Commit Graph
11 Commits
Author SHA1 Message Date
Jacques Le Roux 7d7a441715 Fixed: Any ecommerce user has the ability to reset anothers password
(including admin) via "Forget Your Password"
(OFBIZ-4361)

Currently, any user (via ecommerce "Forget Your Password") has the ability to 
reset another users password, including "admin" without permission.  
By simply entering "admin" and clicking "Email Password", the following is 
displayed:

The following occurred:
A new password has been created and sent to you. Please check your Email.

This now forces the user of the ERP to change their password.  
It is also possible to generate a dictionary attack against ofbiz because there 
is no capta code required.  This is serious security risk.

I have modified the patch following comments I made in the Jira, notably
  Removed unused Java variables
  Removed a check in LoginEvents::forgotPassword which prevented to show error
    messages
  Changed fr and en SecurityExtPasswordSentToYou 
    + SecurityExtThisEmailIsInResponseToYourRequestToHave labels 
    + template PasswordEmail.ftl
    + loginservices.token_incorrect labels
  Added fr and en SecurityExtIgnoreEmail + SecurityExtLinkOnce labels
  Removed changes in general.properties
  I did not remove the 2 GetSecurityQuestion.ftl files (webpos one was still in)

There is still room for improvement. I'll discuss them on the Jira and dev
ML. But this version is already strong enough to not wait that the patch is 
inapplicable!

Thanks: mz4wheeler (Mike Z) for the Jira, Nicolas Malin for the patch, I guess 
with some Gil's help, and all others for comments and ideas

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1866478 13f79535-47bb-0310-9956-ffa450edef68
2019-09-05 15:56:46 +00:00
Jacques Le Roux 2bd8292b90 Improved: Use Labels in themes names
(OFBIZ-9863)

Remove duplicated block that I forgot to remove
This had no effects but I found an XML error in log

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1865891 13f79535-47bb-0310-9956-ffa450edef68
2019-08-25 13:24:10 +00:00
Jacques Le Roux 5ec9d8fb07 Improved: Use Labels in themes names
(OFBIZ-9863)

Adds labels and necessary calls in Theme.xml

While at it, improves other backend themes labels by removing redundancy, at 
least in French and English.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1865370 13f79535-47bb-0310-9956-ffa450edef68
2019-08-17 18:26:42 +00:00
Jacques Le Roux 0459bf6e23 Improved: Clean images, among them logos, in all locations used
(OFBIZ-10128)

Fix my previous commits, there is no themes webapp so no URL at 
/themes/common/webapp/images/ofbiz_logo.png
It's only images/ofbiz_logo.png

Also I previously wrongly changed from
VT_HDR_IMAGE_Url
not
VT_HDR_IMAGE_URL
now fixed


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820982 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 13:49:09 +00:00
Jacques Le Roux e454f2871d Improved: Clean images, among them logos, in all locations used
(OFBIZ-10128)

Fix my previous commits, there is no themes webapp so no URL at 
/themes/common/webapp/images/ofbiz_logo.png
It's only images/ofbiz_logo.png


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820980 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 13:31:38 +00:00
Jacques Le Roux 9247eef6bd Improved: Clean images, among them logos, in all locations used
(OFBIZ-10128)

The ofbiz_logo.png and ofbiz_logo.ico are now in theme but for Tomahawk which
has still it's own version but not really used I'd say. 

So apart for tomahawk/css/style.css which uses a relative path (not sure why)
this replaces the locations for these files in theme files

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820961 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 10:37:28 +00:00
Jacques Le Roux 95b17d4d23 Improved: The main logo in screen upper part shows distorted
(OFBIZ-9990)

Fixes this issue in Tomahawk and Flat Grey themes by using ofbiz_logo.png, 
instead of the old logo deprecated ofbiz_logo.gif 

While at it use the same logo everywhere it's possible. It was needed for links 
to http://ofbiz.apache.org/images/ofbiz_logo.gif which no longer exists 
(actually seems only used for tests so could stay like that but better not refer 
to it anyway)

Also use this logo for Bluelight theme where it fits. 

It could not be used in Rainbow themes because they are using a Scalable Vector 
Graphics file (ofbiz-white.svg) that can't be replaced by the new png logo file
BTW this file still uses a TM symbol instead of a ®

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816897 13f79535-47bb-0310-9956-ffa450edef68
2017-12-01 18:45:50 +00:00
Jacques Le Roux 942cb96b04 No functional change; just a name change
The real English name for saphir (that's French) is sapphire

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1812458 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 05:18:53 +00:00
Deepak Dixit 2379a08cdd Improved: Removed unused theme related data, also fix the ofbiz logo for bluelight theme.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1812160 13f79535-47bb-0310-9956-ffa450edef68
2017-10-13 20:13:29 +00:00
Nicolas Malin 661bf7df0d Fixed: Continue the common-theme upload (OFBIZ-9138 Create a common theme)
Correct all Theme.xml file fo the theme definition with the good xmlns

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806170 13f79535-47bb-0310-9956-ffa450edef68
2017-08-25 13:13:33 +00:00
Nicolas Malin 522333fae2 Implemented: Continue the common-theme upload (OFBIZ-9138 Create a common theme)
Five step these step break all the UI
#6 Migrate the Rainbowstone theme from VisualThemeRessource data definition to be an extends of common-theme

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806145 13f79535-47bb-0310-9956-ffa450edef68
2017-08-25 09:42:41 +00:00