Commit Graph
45 Commits
Author SHA1 Message Date
Nicolas Malin 5229d572df Implemented: Element link can update partial area
(OFBIZ-11810)

   Currently when you want to display an information easily on sub-screen
dynamically (example as related element) is currently not possible without
write specific js code.
   To simplify it, we introduce a new link type: update-area, to indicate
to the theme that we want to refresh  a local area with the call result.

   Example :
       <link target="ListCategoryProductMembers" link-type="update-area" target-window="detail">
           <parameter param-name="productCategoryId"/>
       </link>

For this example we indicate that the display result of target 'ListCategoryProductMembers' is going
on the area identify by 'detail'. Pleasure to the theme to manage it.
2021-02-17 18:11:19 +01:00
James Yong d3801256df Improved: Change inline style to class for wait-spinner (OFBIZ-12095)
Inline style not encouraged by Content Security Policy
2020-12-19 12:42:28 +08:00
holivier e6d77fdaa3 Documented: Help system using asciidoc files (OFBIZ-11693)
now OFBiz uses only help link to asciidoc user-manual (no more using docbook files)
2020-10-26 17:34:04 +01:00
James Yong c3c41b28b4 Improved: multi-block attribute for html-template tag (OFBIZ-11686)
Moved <@scriptTagsFooter/> within the body tag.
2020-08-21 17:59:00 +08:00
holivier d79d7c50b8 Improvement: Help link using asciidoc files via generated html (OFBIZ-11693)
1. Add a general property: userDocUri containing uri for
ofbiz.apache.org html user-documentation generated by Buildbot
2. in each theme, add a test on helpAnchor field, if it's define help
link is now on ${userDocUri}#${helpAnchor}
  * if userDocUri is not defined, the general property is used
2020-06-04 17:42:23 +02:00
Jacques Le Roux 6c6f1e1135 Improved: Rainbow theme: use the United Nations flag ad default flag (OFBIZ-11705)
This follows OFBIZ-9866: where I proposed to use the United Nations flag
as default flag

Pierre noticed that no flag shows when a meta language (like en) is chosen.

I noticed that some meta language have default values (gb, fr, zh, th). So I did
not apply Pierre's GH PR#154 to keep those, because that can be increased.

I added the un.svg flag from https://en.wikipedia.org/wiki/United_Nations
I did not adapt its size. Since it's SVG it should be OK in most cases
I also added the necessary change at the end of in flag-icon.min.css

Thanks: Pierre Smits for the initial patch
2020-05-31 12:36:57 +02:00
James Yong c0e527efb2 Improved: Headerize external script in multi-block html template (OFBIZ-11741)
Allow external scripts within the multi-block html template, to be rendered
within the html head tag, when a new attribute data-import is set to “head”

Thanks: Jacques for review
2020-05-30 12:00:21 +08:00
James Yong 803f7fa060 Improved: <script-template> widget tag (OFBIZ-11686)
The new tag allows us to render a freemarker template containing javascript,
as external script in html instead of inline script.
This helps to reduce CSP errors.
2020-05-13 20:19:05 +08:00
Jacques Le Roux 5c534a9f98 Fixed: POC for CSRF Token
(OFBIZ-11306)

Fixes missing default NoCsrfDefenseStrategy in Header.ftl files
2020-04-06 12:12:39 +02:00
Jacques Le Roux ae3ae26698 Improved: type="text/css" was missing on a call to <<link rel="stylesheet/less>>
This was reported by OWASP ZAP: "The Content-Type header is missing or empty."
Considered a low vulnerability
2020-04-04 15:49:43 +02:00
Michael Brohl d3907529c3 Implemented: Remove the user login security question.
(OFBIZ-11244)

Thanks Wiebke Pätzold for providing the patch.
2020-03-21 11:31:47 +01:00
Jacques Le Roux c34491892a Improved:
Implemented:
Documented:
Completed:
Reverted:
Fixed:
Improved: no functional change
(OFBIZ-)
Explanation
Thanks:
2020-02-27 14:36:26 +01:00
Jacques Le Roux 7d7a441715 Fixed: Any ecommerce user has the ability to reset anothers password
(including admin) via "Forget Your Password"
(OFBIZ-4361)

Currently, any user (via ecommerce "Forget Your Password") has the ability to 
reset another users password, including "admin" without permission.  
By simply entering "admin" and clicking "Email Password", the following is 
displayed:

The following occurred:
A new password has been created and sent to you. Please check your Email.

This now forces the user of the ERP to change their password.  
It is also possible to generate a dictionary attack against ofbiz because there 
is no capta code required.  This is serious security risk.

I have modified the patch following comments I made in the Jira, notably
  Removed unused Java variables
  Removed a check in LoginEvents::forgotPassword which prevented to show error
    messages
  Changed fr and en SecurityExtPasswordSentToYou 
    + SecurityExtThisEmailIsInResponseToYourRequestToHave labels 
    + template PasswordEmail.ftl
    + loginservices.token_incorrect labels
  Added fr and en SecurityExtIgnoreEmail + SecurityExtLinkOnce labels
  Removed changes in general.properties
  I did not remove the 2 GetSecurityQuestion.ftl files (webpos one was still in)

There is still room for improvement. I'll discuss them on the Jira and dev
ML. But this version is already strong enough to not wait that the patch is 
inapplicable!

Thanks: mz4wheeler (Mike Z) for the Jira, Nicolas Malin for the patch, I guess 
with some Gil's help, and all others for comments and ideas

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1866478 13f79535-47bb-0310-9956-ffa450edef68
2019-09-05 15:56:46 +00:00
Jacques Le Roux 8db877625c Fixed: Logo image not showing on party profile
(OFBIZ-9299)

Logo image not displayed until we press in content component

Logo image was not showing on party profile page because we were using Ajax 
request to add party content on the party profile screen. 
So due to ajax request screen was not getting refreshed. 

To display logo image we did the following changes:
1) Removed ajax request and rendered profile view screen after submit
2) Used ofbizUrl macro to show an image instead of /content/control/stream URL


Thanks: Moatasim Al Masri for reporting, Mohammed Rehan Khan for fixing

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1861869 13f79535-47bb-0310-9956-ffa450edef68
2019-06-22 14:19:09 +00:00
Deepak Dixit c30252ec15 Fixed: Html escaping missing for renderLink parameters
(OFBIZ-11090)
Parameters vlaue should be escaped to avoid any kind of corss site scripting issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1860597 13f79535-47bb-0310-9956-ffa450edef68
2019-06-04 10:49:17 +00:00
Mathieu Lirzin 4aa65a5b68 Improved: Add ‘WebAppCache’ (OFBIZ-10606)
This improves the cohesion of the ‘ComponentConfig’ class by
extracting the webapps cache related methods into a separate
‘WebAppCache’ class.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854429 13f79535-47bb-0310-9956-ffa450edef68
2019-02-26 22:47:58 +00:00
Deepak Dixit 66753bbdc2 Fixed: Html escaping missing for portalPageId parameter of Help button
(OFBIZ-10828)
 Thanks, Niels Heinen of the Google security team for reporting the issue. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1852818 13f79535-47bb-0310-9956-ffa450edef68
2019-02-03 09:34:47 +00:00
Gil Portenseigne a61c98775f Implemented : Impersonation of userLogin feature
(OFBIZ-10515)

Introduce a new feature that allow the impersonation of a login by an authorized user.
Add the documentation with all the details in security-impersonation.adoc.
Big thanks to Leila, Nicolas and Jacques for your contribution to this implementation.
Big thanks to Mathieu, Jacques, Pierre and Taher for your remarks and reviews that
improved this contribution quality. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1842110 13f79535-47bb-0310-9956-ffa450edef68
2018-09-27 16:01:35 +00:00
Deepak Dixit 870651efdf Improved: Use of layered-modal with parameter does not work
(OFBIZ-10511)
Thanks Arsalane Arrach for your contribution. Use &quot; to escape the double quotation marks

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1840093 13f79535-47bb-0310-9956-ffa450edef68
2018-09-05 07:16:21 +00:00
Julien Nicolas 9a4bda3f27 Improve: Change the uggly favicon with the new one ! | Using new OFBiz logo
(OFBIZ-10522)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1838074 13f79535-47bb-0310-9956-ffa450edef68
2018-08-15 09:15:13 +00:00
Julien Nicolas 89f390cd54 Improve: Main menu enhancement
(OFBIZ-10521)

The main menu in rainbowstone theme don't display more than 9 items, pending items are included in the + menu.
The problem is that it's not really clear to know where you are or to simply click again on the webapp link to be redirected to the main target.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1838073 13f79535-47bb-0310-9956-ffa450edef68
2018-08-15 08:50:28 +00:00
Gil Portenseigne 0b6acc8feb Fixed: Use of layered-modal with parameter does not work
(OFBIZ-10511)

Thanks Deepak and Aditya for the review and providing a better patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1837806 13f79535-47bb-0310-9956-ffa450edef68
2018-08-10 14:11:22 +00:00
Deepak Dixit ef0c694a46 Improved: Use application/javascript instead of text/javascript
(OFBIZ-10492)
Replace text/javascript with application/javascript in all the script tag

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1836886 13f79535-47bb-0310-9956-ffa450edef68
2018-07-28 10:51:52 +00:00
Deepak Dixit 397628ba7d Improved: Remove use of deprecated language attribute from script tag
(OFBIZ-10491)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1836545 13f79535-47bb-0310-9956-ffa450edef68
2018-07-24 11:26:23 +00:00
Deepak Dixit 66b783ca75 Improved: Improve Order layout.
(OFBIZ-10331)
Applied slightly modified patch from jira ticket, Thanks Dennis Balkir for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835889 13f79535-47bb-0310-9956-ffa450edef68
2018-07-14 09:28:04 +00:00
Michael Brohl 38a90dbefa Improved: Add a VERSION file in root dir.
(OFBIZ-10141)

This adds a VERSION file to store the release version information
and changes the footer of the themes to show the release version.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1833173 13f79535-47bb-0310-9956-ffa450edef68
2018-06-08 14:42:18 +00:00
Jacques Le Roux 5ed72f1e95 Improved: Replace Inline js with External js in renderFormClose macro
(OFBIZ-9846)

Replaced inline js from renderFormClose macro to external js in OfbizUtils.js
Done following:
Used custom data attributes: data-focus-field to define focus field for the form.
Used attribute selector to find elements and set focus on the particular field.

Added "requireValidation" class to all the forms with required fields.

Used the class selector to find such forms & attached Validator plugin to it.

Steps to verify:

At add ProdCatalog page: https://localhost:8443/catalog/control/EditProdCatalog

Dialogs:
New Example dialog on Find Example page 
    Go to Find Example page https://localhost:8443/example/control/FindExample
    Click on New Example button
    Validations should work in dialog on form submit.

Additional Changes:

Link for dialog in HtmlMenuMacroLibrary still had the inline code. 
Replaced the code with external js code.

Validations on forms rendered with renderSubmitField macro from 
HtmlFormMacroLibrary.ftl seems not working 
https://demo-trunk.ofbiz.apache.org/partymgr/control/NewEmployee, will create 
a separate ticket for it.

jleroux: 
I agree about NewEmployee issue
As mentionned Aditya themes/rainbowstone/template/HtmlMenuMacroLibrary.ftl was
redundant, removed
I also removed commented out code in rainbowstone HtmlMenuMacroLibrary.ftl 
(left by Aditya while working on the issue I guess)

Thanks: Aditya 


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832307 13f79535-47bb-0310-9956-ffa450edef68
2018-05-26 12:42:20 +00:00
Jacques Le Roux f6ce9d9b52 Fixed:Access the online help in Rainbow themes
(OFBIZ-10222)

As reported by Dmitriy Tsyganok on GitHub we missed the Help Icon

Thanks: Dmitriy Tsyganok 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1824732 13f79535-47bb-0310-9956-ffa450edef68
2018-02-19 10:49:25 +00:00
Julien Nicolas 44d651dd0a Fixed:Access the online help in Rainbow themes
(OFBIZ-10222)
Thanks to Jacques LEROUX to find this missing button

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1824314 13f79535-47bb-0310-9956-ffa450edef68
2018-02-15 14:31:21 +00:00
Jacques Le Roux f613a8a255 Fixed: Rainbow theme: bug in avatar.ftl when the last name does not exist
(OFBIZ-10177)

Both 1st and last names must be present else it's confusing and better to show 
the username


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821965 13f79535-47bb-0310-9956-ffa450edef68
2018-01-23 08:34:04 +00:00
Jacques Le Roux cfc3a63231 Improved: Make the number of initially visible applications in main menu a
(OFBIZ-10132)

Currently the number of initially visible applications is hardcoded to 8 in 
TopAppBar.ftl

This temporarily do it by putting an appMax properties in a 
common/config/rainbowstone.properties file. 
Putting it in themes/common/config/rainbowstone.properties does not work yet.
I have to find why, WIP in relation with OFBIZ-7073

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819800 13f79535-47bb-0310-9956-ffa450edef68
2018-01-02 10:36:49 +00:00
Deepak Dixit 7e19de9966 Improved: Replace all delegator findByAnd and findOne method calling by EntityQuery methods (OFBIZ-10029)
Applied slightly modified patch, rearrange import properly, 
Thanks Suraj Khurana for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818003 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 12:03:17 +00:00
Deepak Dixit 63258e90f8 Reverted r#1817989, workign fine locally, reverted for now will check and commit again
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817998 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 10:42:32 +00:00
Deepak Dixit d1f85a7e5d Improved: Replace all delegator findByAnd and findOne method calling by EntityQuery methods (OFBIZ-10029)
Applied slightly modified patch, rearrange import properly, 
Thanks Suraj Khurana for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817989 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 09:21:33 +00:00
Deepak Dixit 1620e4e0ca Improved: No functional change, Only added license header
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1812309 13f79535-47bb-0310-9956-ffa450edef68
2017-10-16 18:43:14 +00:00
Nicolas Malin d57d75d71c Implemented: Continue the common-theme upload (OFBIZ-9138 Create a common theme)
Five step these step break all the UI
#6.1 Migrate the Rainbowstone theme from VisualThemeRessource data definition to be an extends of common-theme
Forget to load the HtmlMenuMacroLibrary.ftl dedicate to Rainbowstone

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806149 13f79535-47bb-0310-9956-ffa450edef68
2017-08-25 09:57:42 +00:00
Nicolas Malin 522333fae2 Implemented: Continue the common-theme upload (OFBIZ-9138 Create a common theme)
Five step these step break all the UI
#6 Migrate the Rainbowstone theme from VisualThemeRessource data definition to be an extends of common-theme

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806145 13f79535-47bb-0310-9956-ffa450edef68
2017-08-25 09:42:41 +00:00
Arun Patidar 44c0caa799 Improved: Set autocomplete to off for all the password fields.(OFBIZ-9471)
Thanks Ritesh Kumar for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801324 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 21:07:51 +00:00
Arun Patidar 370903e59b Improved: Inconsistent String Comparisons. (OFBIZ-9254).
Thanks Devanshu Vyas for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801278 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 11:03:07 +00:00
Jacques Le Roux d7d1202f3a Improves: Use ignore_missing option of the <#include Freemarker directive when fixed
(OFBIZ-8292)

This is a no functional change except for the flatgrey and blueligth themes where svn and git info are added

Working on OFBIZ-8250 and after Deepak at OFBIZ-7942 (too bad I missed that :/)  I found that the ignore_missing option of the <#include Freemarker directive does not work. I reported to the Freemarker incubating project.
Hopefully this will be fixed. It will then remove the need of creating empty files for the svn and git info footers when building. 

In the meantime this provides the change in the themes footers.
I have also added the svn and git info to the flatgrey footer. The result is barely legible there but is also used (include) by the bluelight theme where it's OK
I have also formatted the related div where it was barely legible (too large)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761392 13f79535-47bb-0310-9956-ffa450edef68
2016-09-19 07:19:23 +00:00
Jacques Le Roux 5b002a5953 Fixes: jquery.jgrowl.min.css is linked twice in html page
(OFBIZ-7758)

I am running on trunk rev 1751489 on tomahawk theme. 
In the browser, right-click and view the page source. 
There is duplicate linking of jquery.jgrowl.min.css i.e.

<link rel="stylesheet" href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css" type="text/css"/>

The solution is to remove a hack for JPublish in fex Java classes 
and related changes (mostly "page." in ftl and xml files)

Thanks: Rohit Koushal for the path and James Yong the report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761235 13f79535-47bb-0310-9956-ffa450edef68
2016-09-17 13:43:16 +00:00
Deepak Dixit 834691742b (OFBIZ-6274) Renamed OFBiz artefacts from org.ofbiz.* to org.apache.ofbiz.*.Thanks to Taher for working on it.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1752920 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 10:30:49 +00:00
Deepak Dixit c52b8ebedc (OFBIZ-7021) Corrected svninfo and gitinfo file name after renaming file I missed it to updated at some places.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1745303 13f79535-47bb-0310-9956-ffa450edef68
2016-05-24 06:01:25 +00:00
Deepak Dixit a03db877f8 (OFBIZ-7021) Renamed theme component ftl file name from lower case to upper camel case pattern.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1744777 13f79535-47bb-0310-9956-ffa450edef68
2016-05-20 17:36:41 +00:00
Deepak Dixit deb3df7a5e (OFBIZ-7022) relocate .ftl files for all the theme component.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1740682 13f79535-47bb-0310-9956-ffa450edef68
2016-04-24 08:45:28 +00:00