Commit Graph
119 Commits
Author SHA1 Message Date
Jacques Le Roux 36380d198d Improved: Enlarge the "more-app" menu in Rainbow Stome theme (OFBIZ-12181)
Enlarges #more-app in rainbowstone-main-theme.less from 40 to 200px
2021-02-21 12:17:24 +01:00
Nicolas Malin 5229d572df Implemented: Element link can update partial area
(OFBIZ-11810)

   Currently when you want to display an information easily on sub-screen
dynamically (example as related element) is currently not possible without
write specific js code.
   To simplify it, we introduce a new link type: update-area, to indicate
to the theme that we want to refresh  a local area with the call result.

   Example :
       <link target="ListCategoryProductMembers" link-type="update-area" target-window="detail">
           <parameter param-name="productCategoryId"/>
       </link>

For this example we indicate that the display result of target 'ListCategoryProductMembers' is going
on the area identify by 'detail'. Pleasure to the theme to manage it.
2021-02-17 18:11:19 +01:00
James Yong d3801256df Improved: Change inline style to class for wait-spinner (OFBIZ-12095)
Inline style not encouraged by Content Security Policy
2020-12-19 12:42:28 +08:00
holivier e6d77fdaa3 Documented: Help system using asciidoc files (OFBIZ-11693)
now OFBiz uses only help link to asciidoc user-manual (no more using docbook files)
2020-10-26 17:34:04 +01:00
Jacques Le Roux c8c5895707 Reverted: "Improved: Have a readme in every component (OFBIZ-6243)"
This reverts commit f281fe290a.

An Apache URL is much easier to have (NO bad idea)
2020-08-29 13:52:27 +02:00
Jacques Le Roux f281fe290a Improved: Have a readme in every component (OFBIZ-6243)
An Apache URL is much easier to have
2020-08-29 13:49:41 +02:00
Jacques Le Roux ee0968440e Improved: Have a readme in every component (OFBIZ-6243)
Not sure why we have this problem (according to
https://docs.github.com/en/github/authenticating-to-github/about-anonymized-image-urls
could be to missing cache control in our site server)

As I was fed up not viewing the OFBIz logo anywhere, and mostly in GH,
but just in browser at https://ofbiz.apache.org/images/ofbiz_logo.png
and I noticed I was viewing it well locally at
https://github.com/apache/ofbiz-framework/tree/trunk/themes/rainbowstone
so decided to use this URL everywhere rather!
2020-08-29 13:35:14 +02:00
Jacques Le Roux d15cc57bf0 Improved: Have a readme in every component (OFBIZ-6243)
This preludes the move of content of README.md files into the asciidoc
documentation

Updates the link to OFBiz-logo.png
Removes deprecated information related to Svn, Jira and Confluence
We will move the wiki pages to wiki attic with OFBIZ-11619
2020-08-29 11:52:51 +02:00
James Yong c3c41b28b4 Improved: multi-block attribute for html-template tag (OFBIZ-11686)
Moved <@scriptTagsFooter/> within the body tag.
2020-08-21 17:59:00 +08:00
Jacques Le Roux db4ee8f9e6 Fixed: With Rainbow theme, a scrollbar appears at bottom where it's not needed
(OFBIZ-10174)

With Rainbow theme, even in large screens, a scrollbar appears at bottom where
it's useless.

The CSS which is adding a border-right on the application bar is adding extra
1px width causing this issue. Attached the patch to remove extra width for the
same.

Thanks: Nameet Jain for the patch
2020-06-27 16:20:41 +02:00
holivier d79d7c50b8 Improvement: Help link using asciidoc files via generated html (OFBIZ-11693)
1. Add a general property: userDocUri containing uri for
ofbiz.apache.org html user-documentation generated by Buildbot
2. in each theme, add a test on helpAnchor field, if it's define help
link is now on ${userDocUri}#${helpAnchor}
  * if userDocUri is not defined, the general property is used
2020-06-04 17:42:23 +02:00
Jacques Le Roux 51d91619ea Improved: Rainbow theme: use the United Nations flag ad default flag (OFBIZ-11705)
Oops, I missed to add the un flag files
2020-05-31 12:39:20 +02:00
Jacques Le Roux 6c6f1e1135 Improved: Rainbow theme: use the United Nations flag ad default flag (OFBIZ-11705)
This follows OFBIZ-9866: where I proposed to use the United Nations flag
as default flag

Pierre noticed that no flag shows when a meta language (like en) is chosen.

I noticed that some meta language have default values (gb, fr, zh, th). So I did
not apply Pierre's GH PR#154 to keep those, because that can be increased.

I added the un.svg flag from https://en.wikipedia.org/wiki/United_Nations
I did not adapt its size. Since it's SVG it should be OK in most cases
I also added the necessary change at the end of in flag-icon.min.css

Thanks: Pierre Smits for the initial patch
2020-05-31 12:36:57 +02:00
James Yong c0e527efb2 Improved: Headerize external script in multi-block html template (OFBIZ-11741)
Allow external scripts within the multi-block html template, to be rendered
within the html head tag, when a new attribute data-import is set to “head”

Thanks: Jacques for review
2020-05-30 12:00:21 +08:00
James Yong 803f7fa060 Improved: <script-template> widget tag (OFBIZ-11686)
The new tag allows us to render a freemarker template containing javascript,
as external script in html instead of inline script.
This helps to reduce CSP errors.
2020-05-13 20:19:05 +08:00
Jacques Le Roux 5c534a9f98 Fixed: POC for CSRF Token
(OFBIZ-11306)

Fixes missing default NoCsrfDefenseStrategy in Header.ftl files
2020-04-06 12:12:39 +02:00
Jacques Le Roux ae3ae26698 Improved: type="text/css" was missing on a call to <<link rel="stylesheet/less>>
This was reported by OWASP ZAP: "The Content-Type header is missing or empty."
Considered a low vulnerability
2020-04-04 15:49:43 +02:00
Pierre Smits c89e9346ba Improved: unify style application
(OFBIZ-11458)

remove unused property 'align-float'
2020-04-04 15:49:42 +02:00
Pierre Smits 48e81c48db Improved: style alignment properties
(OFBIZ-11458)

Adding alignment properties (creating consistency across themes.
2020-04-04 15:49:41 +02:00
Jacques Le Roux 062fc40579 Fixed: CommonTheme has a dependency on Flatgrey application.js
(OFBIZ-11466)

In theme.xml of common-theme there is a reference to application.js residing in
the Flatgrey theme. This should not be. The file should be in common-theme.

Thanks: Pierre Smits for report and fix. I have just also removed
rainbowstone/js/application.js since it's now in common-theme
2020-03-21 11:31:55 +01:00
Michael Brohl d3907529c3 Implemented: Remove the user login security question.
(OFBIZ-11244)

Thanks Wiebke Pätzold for providing the patch.
2020-03-21 11:31:47 +01:00
Jacques Le Roux c34491892a Improved:
Implemented:
Documented:
Completed:
Reverted:
Fixed:
Improved: no functional change
(OFBIZ-)
Explanation
Thanks:
2020-02-27 14:36:26 +01:00
Samuel Trégouët 62c617eeec Fixed: Add XML declaration in “web.xml” files
(OFBIZ-6993)

These declarations avoid SAXParseException traceback when parsing web.xml
the first time in WebappUtil.parseWebXmlFile
2019-12-07 22:58:29 +01:00
Mathieu Lirzin 3b14e7afa9 Reverted: "Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)"
This reverts commit a93b1fcb78.
2019-11-27 21:42:33 +01:00
Mathieu Lirzin b006b8c7cb Revert "Improved: Update “web.xml” files version 3.0 → 4.0 (OFBIZ-6993)"
This reverts commit 226e901981.
2019-11-27 21:40:10 +01:00
Samuel Trégouët 226e901981 Improved: Update “web.xml” files version 3.0 → 4.0 (OFBIZ-6993) 2019-11-27 17:29:41 +01:00
Samuel Trégouët a93b1fcb78 Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)
these declarations avoid SAXParseException traceback when parsing web.xml
the first time in WebappUtil.parseWebXmlFile
2019-11-27 17:28:44 +01:00
Jacques Le Roux 7d7a441715 Fixed: Any ecommerce user has the ability to reset anothers password
(including admin) via "Forget Your Password"
(OFBIZ-4361)

Currently, any user (via ecommerce "Forget Your Password") has the ability to 
reset another users password, including "admin" without permission.  
By simply entering "admin" and clicking "Email Password", the following is 
displayed:

The following occurred:
A new password has been created and sent to you. Please check your Email.

This now forces the user of the ERP to change their password.  
It is also possible to generate a dictionary attack against ofbiz because there 
is no capta code required.  This is serious security risk.

I have modified the patch following comments I made in the Jira, notably
  Removed unused Java variables
  Removed a check in LoginEvents::forgotPassword which prevented to show error
    messages
  Changed fr and en SecurityExtPasswordSentToYou 
    + SecurityExtThisEmailIsInResponseToYourRequestToHave labels 
    + template PasswordEmail.ftl
    + loginservices.token_incorrect labels
  Added fr and en SecurityExtIgnoreEmail + SecurityExtLinkOnce labels
  Removed changes in general.properties
  I did not remove the 2 GetSecurityQuestion.ftl files (webpos one was still in)

There is still room for improvement. I'll discuss them on the Jira and dev
ML. But this version is already strong enough to not wait that the patch is 
inapplicable!

Thanks: mz4wheeler (Mike Z) for the Jira, Nicolas Malin for the patch, I guess 
with some Gil's help, and all others for comments and ideas

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1866478 13f79535-47bb-0310-9956-ffa450edef68
2019-09-05 15:56:46 +00:00
Jacques Le Roux 2bd8292b90 Improved: Use Labels in themes names
(OFBIZ-9863)

Remove duplicated block that I forgot to remove
This had no effects but I found an XML error in log

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1865891 13f79535-47bb-0310-9956-ffa450edef68
2019-08-25 13:24:10 +00:00
Jacques Le Roux 5ec9d8fb07 Improved: Use Labels in themes names
(OFBIZ-9863)

Adds labels and necessary calls in Theme.xml

While at it, improves other backend themes labels by removing redundancy, at 
least in French and English.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1865370 13f79535-47bb-0310-9956-ffa450edef68
2019-08-17 18:26:42 +00:00
Aditya Sharma efc1ae1303 Fixed: Check embedded Javascript libs vulnerabilities using retire.js
(OFBIZ-10678)
1. For solving CVE-2019-11358, upgraded jQuery to 3.4.1
2. Replaced library Fancybox with Featherlight. Added custom css so that cursor for links becomes pointer
Thanks Jacques Le Roux for the reviews

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863838 13f79535-47bb-0310-9956-ffa450edef68
2019-07-27 06:43:12 +00:00
Jacques Le Roux 8db877625c Fixed: Logo image not showing on party profile
(OFBIZ-9299)

Logo image not displayed until we press in content component

Logo image was not showing on party profile page because we were using Ajax 
request to add party content on the party profile screen. 
So due to ajax request screen was not getting refreshed. 

To display logo image we did the following changes:
1) Removed ajax request and rendered profile view screen after submit
2) Used ofbizUrl macro to show an image instead of /content/control/stream URL


Thanks: Moatasim Al Masri for reporting, Mohammed Rehan Khan for fixing

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1861869 13f79535-47bb-0310-9956-ffa450edef68
2019-06-22 14:19:09 +00:00
Deepak Dixit c30252ec15 Fixed: Html escaping missing for renderLink parameters
(OFBIZ-11090)
Parameters vlaue should be escaped to avoid any kind of corss site scripting issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1860597 13f79535-47bb-0310-9956-ffa450edef68
2019-06-04 10:49:17 +00:00
Jacques Le Roux c80528518b Fixed: Unknown request [images]; this request does not exist or cannot be
called directly.
(OFBIZ-10895)

I was wrong doing massive changes w/o close control. 
I decided to revert the r1859576 and r1859807 commits and to backport the revert

The only safe way to go is to not only check the error log for 
"Unknown request [...."
but also to look for 404 in access log, not all request show erroneously in
error log/

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1860526 13f79535-47bb-0310-9956-ffa450edef68
2019-06-02 13:10:36 +00:00
Suraj Khurana 5ec02486b0 Fixed: CSS Styling for Party Content progress bar is wrong in multiple theme.
(OFBIZ-10797)
Thanks Ayushi Rathod for reporting the issue and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1860082 13f79535-47bb-0310-9956-ffa450edef68
2019-05-26 16:09:40 +00:00
Jacques Le Roux 323f5ffdec Fixed: Unknown request [images]; this request does not exist or cannot be called
directly.
(OFBIZ-10895)

This should be the last commit, but I can't be sure. So I'll continue to 
monitor the demos logs...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859807 13f79535-47bb-0310-9956-ffa450edef68
2019-05-23 16:41:59 +00:00
Jacques Le Roux 0f7e524334 Fixed: Unknown request [images]; this request does not exist or cannot be
called directly.
(OFBIZ-10895)

This error happens in many occasions.
It shows only in log and have no effect on UI.
It happens in all supported releases. 
So it's not very bad since it's has no side effects.

As said Deepak Dixit:
I think we need to fix the image url in css file, it should start with /images, 
else browser append this in request info. There is nothing related to java or 
tomcat code. 

I finally decided to do a whole change, here it is

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859576 13f79535-47bb-0310-9956-ffa450edef68
2019-05-20 18:02:09 +00:00
Jacques Le Roux 282270d9ad Fixed: Unknown request [images]; this request does not exist or cannot be
called directly.
(OFBIZ-10895)

This error happens in many occasions:
Inside another request (eg LookupProduct)
Of after a request (eg login)

It shows only in log and have no effect on UI. Notably the new feature normally 
showing an error message in trunk (OFBIZ-10753) does not shows

It happens in all supported releases. IIRW it always happened, only URLs like 
https://demo-trunk.ofbiz.apache.org/images/defaultImage.jpg work. 
But here it's different because we don't need to call 
https://demo-trunk.ofbiz.apache.org/images by hand to get the issue in log.

So it's not very bad since it's has no side effects, just weird and annoying. 
Because it might hide something undetected yet...

This issue does not appear in R15, a good place to test is for instance 
ordermgr/control/request. 
There cal.gif is called by /images/cal.gif and it works (the images appears) 
but in more recent versions the call is also done to 
/ordermgr/control/images/cal.gif where it fails. 
This 1st appears in ControlFilter in the stack trace.

As said Deepak Dixit:
I think we need to fix the image url in css file, it should start with /images, 
else browser append this in request info. There is nothing related to java or 
tomcat code. 

This is a 1st commit for the errors I already reported and I'm sure about

Thanks: Deepak 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1858444 13f79535-47bb-0310-9956-ffa450edef68
2019-04-30 16:23:56 +00:00
Mathieu Lirzin 4aa65a5b68 Improved: Add ‘WebAppCache’ (OFBIZ-10606)
This improves the cohesion of the ‘ComponentConfig’ class by
extracting the webapps cache related methods into a separate
‘WebAppCache’ class.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1854429 13f79535-47bb-0310-9956-ffa450edef68
2019-02-26 22:47:58 +00:00
Deepak Dixit 66753bbdc2 Fixed: Html escaping missing for portalPageId parameter of Help button
(OFBIZ-10828)
 Thanks, Niels Heinen of the Google security team for reporting the issue. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1852818 13f79535-47bb-0310-9956-ffa450edef68
2019-02-03 09:34:47 +00:00
Aditya Sharma 3cbf90302c Improved: Replace Inline js with External js in renderFieldGroupOpen macro
(OFBIZ-9853)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1851433 13f79535-47bb-0310-9956-ffa450edef68
2019-01-16 11:49:11 +00:00
Aditya Sharma 08fc69e679 Improved: Replace jQuery.bind() with jQuery.on()
(OFBIZ-10758)
As of jQuery 3.0, .bind() has been deprecated. It was superseded by the .on() method for attaching event handlers to a document.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1850711 13f79535-47bb-0310-9956-ffa450edef68
2019-01-08 05:06:43 +00:00
Gil Portenseigne a61c98775f Implemented : Impersonation of userLogin feature
(OFBIZ-10515)

Introduce a new feature that allow the impersonation of a login by an authorized user.
Add the documentation with all the details in security-impersonation.adoc.
Big thanks to Leila, Nicolas and Jacques for your contribution to this implementation.
Big thanks to Mathieu, Jacques, Pierre and Taher for your remarks and reviews that
improved this contribution quality. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1842110 13f79535-47bb-0310-9956-ffa450edef68
2018-09-27 16:01:35 +00:00
Deepak Dixit 870651efdf Improved: Use of layered-modal with parameter does not work
(OFBIZ-10511)
Thanks Arsalane Arrach for your contribution. Use &quot; to escape the double quotation marks

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1840093 13f79535-47bb-0310-9956-ffa450edef68
2018-09-05 07:16:21 +00:00
Julien Nicolas 9a4bda3f27 Improve: Change the uggly favicon with the new one ! | Using new OFBiz logo
(OFBIZ-10522)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1838074 13f79535-47bb-0310-9956-ffa450edef68
2018-08-15 09:15:13 +00:00
Julien Nicolas 89f390cd54 Improve: Main menu enhancement
(OFBIZ-10521)

The main menu in rainbowstone theme don't display more than 9 items, pending items are included in the + menu.
The problem is that it's not really clear to know where you are or to simply click again on the webapp link to be redirected to the main target.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1838073 13f79535-47bb-0310-9956-ffa450edef68
2018-08-15 08:50:28 +00:00
Julien Nicolas 35677822a1 Improved: Change font Title|to match with the initial implementation
(OFBIZ-10513)

Tanks: Marine DESMARCHELIER for her help to understand the reason that it wasn't work

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1838072 13f79535-47bb-0310-9956-ffa450edef68
2018-08-15 08:42:00 +00:00
Julien Nicolas 28a8f7b053 fixed: code duplication in main rainbowstone less file
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1837981 13f79535-47bb-0310-9956-ffa450edef68
2018-08-13 21:05:54 +00:00
Gil Portenseigne 0b6acc8feb Fixed: Use of layered-modal with parameter does not work
(OFBIZ-10511)

Thanks Deepak and Aditya for the review and providing a better patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1837806 13f79535-47bb-0310-9956-ffa450edef68
2018-08-10 14:11:22 +00:00
Deepak Dixit ef0c694a46 Improved: Use application/javascript instead of text/javascript
(OFBIZ-10492)
Replace text/javascript with application/javascript in all the script tag

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1836886 13f79535-47bb-0310-9956-ffa450edef68
2018-07-28 10:51:52 +00:00