Commit Graph
217 Commits
Author SHA1 Message Date
James Yong d3801256df Improved: Change inline style to class for wait-spinner (OFBIZ-12095)
Inline style not encouraged by Content Security Policy
2020-12-19 12:42:28 +08:00
Jacques Le Roux 333b896eef Fixed: Error wIth Flat Grey theme related to rest component (OFBIZ-12093)
When you use the Flat Grey theme (useful for RTL languages) you see an error in
the main menu (component choise). It's related to the rest component not using a
controller.

Fixes is simple and has not side effect: instead of throwing an exception simply
log a warning and return an empty string
2020-12-18 10:38:26 +01:00
holivier e6d77fdaa3 Documented: Help system using asciidoc files (OFBIZ-11693)
now OFBiz uses only help link to asciidoc user-manual (no more using docbook files)
2020-10-26 17:34:04 +01:00
James Yong c3c41b28b4 Improved: multi-block attribute for html-template tag (OFBIZ-11686)
Moved <@scriptTagsFooter/> within the body tag.
2020-08-21 17:59:00 +08:00
holivier d79d7c50b8 Improvement: Help link using asciidoc files via generated html (OFBIZ-11693)
1. Add a general property: userDocUri containing uri for
ofbiz.apache.org html user-documentation generated by Buildbot
2. in each theme, add a test on helpAnchor field, if it's define help
link is now on ${userDocUri}#${helpAnchor}
  * if userDocUri is not defined, the general property is used
2020-06-04 17:42:23 +02:00
James Yong c0e527efb2 Improved: Headerize external script in multi-block html template (OFBIZ-11741)
Allow external scripts within the multi-block html template, to be rendered
within the html head tag, when a new attribute data-import is set to “head”

Thanks: Jacques for review
2020-05-30 12:00:21 +08:00
James Yong 803f7fa060 Improved: <script-template> widget tag (OFBIZ-11686)
The new tag allows us to render a freemarker template containing javascript,
as external script in html instead of inline script.
This helps to reduce CSP errors.
2020-05-13 20:19:05 +08:00
Jacques Le Roux 5c534a9f98 Fixed: POC for CSRF Token
(OFBIZ-11306)

Fixes missing default NoCsrfDefenseStrategy in Header.ftl files
2020-04-06 12:12:39 +02:00
Pierre Smits c89e9346ba Improved: unify style application
(OFBIZ-11458)

remove unused property 'align-float'
2020-04-04 15:49:42 +02:00
Pierre Smits 48e81c48db Improved: style alignment properties
(OFBIZ-11458)

Adding alignment properties (creating consistency across themes.
2020-04-04 15:49:41 +02:00
Jacques Le Roux 062fc40579 Fixed: CommonTheme has a dependency on Flatgrey application.js
(OFBIZ-11466)

In theme.xml of common-theme there is a reference to application.js residing in
the Flatgrey theme. This should not be. The file should be in common-theme.

Thanks: Pierre Smits for report and fix. I have just also removed
rainbowstone/js/application.js since it's now in common-theme
2020-03-21 11:31:55 +01:00
Jacques Le Roux c34491892a Improved:
Implemented:
Documented:
Completed:
Reverted:
Fixed:
Improved: no functional change
(OFBIZ-)
Explanation
Thanks:
2020-02-27 14:36:26 +01:00
Samuel Trégouët 62c617eeec Fixed: Add XML declaration in “web.xml” files
(OFBIZ-6993)

These declarations avoid SAXParseException traceback when parsing web.xml
the first time in WebappUtil.parseWebXmlFile
2019-12-07 22:58:29 +01:00
Mathieu Lirzin 3b14e7afa9 Reverted: "Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)"
This reverts commit a93b1fcb78.
2019-11-27 21:42:33 +01:00
Mathieu Lirzin b006b8c7cb Revert "Improved: Update “web.xml” files version 3.0 → 4.0 (OFBIZ-6993)"
This reverts commit 226e901981.
2019-11-27 21:40:10 +01:00
Samuel Trégouët 226e901981 Improved: Update “web.xml” files version 3.0 → 4.0 (OFBIZ-6993) 2019-11-27 17:29:41 +01:00
Samuel Trégouët a93b1fcb78 Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)
these declarations avoid SAXParseException traceback when parsing web.xml
the first time in WebappUtil.parseWebXmlFile
2019-11-27 17:28:44 +01:00
Jacques Le Roux 3d2fb1c228 Fixed: <description> of <visual-theme> in Theme.xml does not work
(OFBIZ-9867)

There is no str:label in UelFunctions class but util:label

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1865367 13f79535-47bb-0310-9956-ffa450edef68
2019-08-17 18:08:14 +00:00
Aditya Sharma 9e8061ab7c Improved: Change the uggly favicon with the new one ! | Using new OFBiz logo
(OFBIZ-10522)
Fixed issues with logo size for flatgrey theme with some custom css to fix its height and width
Replaced old logo with the new one in tomahawk theme along with some custom css to fix its height and width

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1865103 13f79535-47bb-0310-9956-ffa450edef68
2019-08-14 09:47:44 +00:00
Aditya Sharma 34311f84a0 Fixed: favicon.ico missing for LookupDecorator
(OFBIZ-11146)
The ListVisualTheme page uses LookupDecorator and in the absence of any shortcut icon the browser hits favicon.ico file by default. 
Additional change: Fixed path for title.gif specific to Flatgrey theme

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1864216 13f79535-47bb-0310-9956-ffa450edef68
2019-08-02 11:13:43 +00:00
Aditya Sharma efc1ae1303 Fixed: Check embedded Javascript libs vulnerabilities using retire.js
(OFBIZ-10678)
1. For solving CVE-2019-11358, upgraded jQuery to 3.4.1
2. Replaced library Fancybox with Featherlight. Added custom css so that cursor for links becomes pointer
Thanks Jacques Le Roux for the reviews

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863838 13f79535-47bb-0310-9956-ffa450edef68
2019-07-27 06:43:12 +00:00
Jacques Le Roux c80528518b Fixed: Unknown request [images]; this request does not exist or cannot be
called directly.
(OFBIZ-10895)

I was wrong doing massive changes w/o close control. 
I decided to revert the r1859576 and r1859807 commits and to backport the revert

The only safe way to go is to not only check the error log for 
"Unknown request [...."
but also to look for 404 in access log, not all request show erroneously in
error log/

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1860526 13f79535-47bb-0310-9956-ffa450edef68
2019-06-02 13:10:36 +00:00
Suraj Khurana 5ec02486b0 Fixed: CSS Styling for Party Content progress bar is wrong in multiple theme.
(OFBIZ-10797)
Thanks Ayushi Rathod for reporting the issue and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1860082 13f79535-47bb-0310-9956-ffa450edef68
2019-05-26 16:09:40 +00:00
Jacques Le Roux 323f5ffdec Fixed: Unknown request [images]; this request does not exist or cannot be called
directly.
(OFBIZ-10895)

This should be the last commit, but I can't be sure. So I'll continue to 
monitor the demos logs...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859807 13f79535-47bb-0310-9956-ffa450edef68
2019-05-23 16:41:59 +00:00
Jacques Le Roux 0f7e524334 Fixed: Unknown request [images]; this request does not exist or cannot be
called directly.
(OFBIZ-10895)

This error happens in many occasions.
It shows only in log and have no effect on UI.
It happens in all supported releases. 
So it's not very bad since it's has no side effects.

As said Deepak Dixit:
I think we need to fix the image url in css file, it should start with /images, 
else browser append this in request info. There is nothing related to java or 
tomcat code. 

I finally decided to do a whole change, here it is

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859576 13f79535-47bb-0310-9956-ffa450edef68
2019-05-20 18:02:09 +00:00
Jacques Le Roux 282270d9ad Fixed: Unknown request [images]; this request does not exist or cannot be
called directly.
(OFBIZ-10895)

This error happens in many occasions:
Inside another request (eg LookupProduct)
Of after a request (eg login)

It shows only in log and have no effect on UI. Notably the new feature normally 
showing an error message in trunk (OFBIZ-10753) does not shows

It happens in all supported releases. IIRW it always happened, only URLs like 
https://demo-trunk.ofbiz.apache.org/images/defaultImage.jpg work. 
But here it's different because we don't need to call 
https://demo-trunk.ofbiz.apache.org/images by hand to get the issue in log.

So it's not very bad since it's has no side effects, just weird and annoying. 
Because it might hide something undetected yet...

This issue does not appear in R15, a good place to test is for instance 
ordermgr/control/request. 
There cal.gif is called by /images/cal.gif and it works (the images appears) 
but in more recent versions the call is also done to 
/ordermgr/control/images/cal.gif where it fails. 
This 1st appears in ControlFilter in the stack trace.

As said Deepak Dixit:
I think we need to fix the image url in css file, it should start with /images, 
else browser append this in request info. There is nothing related to java or 
tomcat code. 

This is a 1st commit for the errors I already reported and I'm sure about

Thanks: Deepak 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1858444 13f79535-47bb-0310-9956-ffa450edef68
2019-04-30 16:23:56 +00:00
Deepak Dixit 66753bbdc2 Fixed: Html escaping missing for portalPageId parameter of Help button
(OFBIZ-10828)
 Thanks, Niels Heinen of the Google security team for reporting the issue. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1852818 13f79535-47bb-0310-9956-ffa450edef68
2019-02-03 09:34:47 +00:00
Aditya Sharma 3cbf90302c Improved: Replace Inline js with External js in renderFieldGroupOpen macro
(OFBIZ-9853)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1851433 13f79535-47bb-0310-9956-ffa450edef68
2019-01-16 11:49:11 +00:00
Aditya Sharma 08fc69e679 Improved: Replace jQuery.bind() with jQuery.on()
(OFBIZ-10758)
As of jQuery 3.0, .bind() has been deprecated. It was superseded by the .on() method for attaching event handlers to a document.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1850711 13f79535-47bb-0310-9956-ffa450edef68
2019-01-08 05:06:43 +00:00
Gil Portenseigne a61c98775f Implemented : Impersonation of userLogin feature
(OFBIZ-10515)

Introduce a new feature that allow the impersonation of a login by an authorized user.
Add the documentation with all the details in security-impersonation.adoc.
Big thanks to Leila, Nicolas and Jacques for your contribution to this implementation.
Big thanks to Mathieu, Jacques, Pierre and Taher for your remarks and reviews that
improved this contribution quality. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1842110 13f79535-47bb-0310-9956-ffa450edef68
2018-09-27 16:01:35 +00:00
Julien Nicolas 9a4bda3f27 Improve: Change the uggly favicon with the new one ! | Using new OFBiz logo
(OFBIZ-10522)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1838074 13f79535-47bb-0310-9956-ffa450edef68
2018-08-15 09:15:13 +00:00
Deepak Dixit ef0c694a46 Improved: Use application/javascript instead of text/javascript
(OFBIZ-10492)
Replace text/javascript with application/javascript in all the script tag

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1836886 13f79535-47bb-0310-9956-ffa450edef68
2018-07-28 10:51:52 +00:00
Deepak Dixit 397628ba7d Improved: Remove use of deprecated language attribute from script tag
(OFBIZ-10491)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1836545 13f79535-47bb-0310-9956-ffa450edef68
2018-07-24 11:26:23 +00:00
Michael Brohl 38a90dbefa Improved: Add a VERSION file in root dir.
(OFBIZ-10141)

This adds a VERSION file to store the release version information
and changes the footer of the themes to show the release version.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1833173 13f79535-47bb-0310-9956-ffa450edef68
2018-06-08 14:42:18 +00:00
Deepak Dixit 23e4b72f17 Fixed: Alert message : Developer: for lookups to work you must provide a form name! appears when try to select contentId from Lookup.
(OFBIZ-10012)
Applied slightly modified patch 
Thanks  Sonal for reporting and Aditya Sharma for providing patch for the issue


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1825205 13f79535-47bb-0310-9956-ffa450edef68
2018-02-24 10:22:18 +00:00
Jacques Le Roux 19d9b3ca30 Improved: Replace Asm select plugin with Select2.
(OFBIZ-10113)

Current Asm Select Plugin 
http://www.ryancramer.com/journal/entries/asmselect_v104/
can be replaced with Select2 (https://select2.org/).

* Select2 has much better community support on GitHub with 386 contributors 
  while Asm Select Plugin is handled by Ryan Cramer on http://www.ryancramer.com/.
* Select2 has 37 releases while Asm select has very few releases yet.
* Both the plugin has MIT license.

Refer https://select2.org/ and  
https://github.com/select2/select2 for more features and other information.

Added i18n support so added logic in JsLanguageFileMappingCreator and 
JsLanguageFilesMapping accordingly.
Added some custom CSS as the Select2 seems to be too fancy in accordance 
with the current OFBiz themes

Verify:
Multiple drop-downs field in FormWidgetExamples.
https://localhost:8443/example/control/FormWidgetExamples

Find Request page with StatusId , CustRequestId
https://localhost:8443/ordermgr/control/FindRequest

I have replaced the plugins though I feel the implementation of select multiple 
js code is to be reviewed & refactored. I will pick when I am done with all my 
current tasks if I get some consensus.

Thanks: Aditya 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821001 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 15:47:47 +00:00
Jacques Le Roux 0459bf6e23 Improved: Clean images, among them logos, in all locations used
(OFBIZ-10128)

Fix my previous commits, there is no themes webapp so no URL at 
/themes/common/webapp/images/ofbiz_logo.png
It's only images/ofbiz_logo.png

Also I previously wrongly changed from
VT_HDR_IMAGE_Url
not
VT_HDR_IMAGE_URL
now fixed


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820982 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 13:49:09 +00:00
Jacques Le Roux e454f2871d Improved: Clean images, among them logos, in all locations used
(OFBIZ-10128)

Fix my previous commits, there is no themes webapp so no URL at 
/themes/common/webapp/images/ofbiz_logo.png
It's only images/ofbiz_logo.png


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820980 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 13:31:38 +00:00
Jacques Le Roux 9247eef6bd Improved: Clean images, among them logos, in all locations used
(OFBIZ-10128)

The ofbiz_logo.png and ofbiz_logo.ico are now in theme but for Tomahawk which
has still it's own version but not really used I'd say. 

So apart for tomahawk/css/style.css which uses a relative path (not sure why)
this replaces the locations for these files in theme files

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820961 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 10:37:28 +00:00
Taher A. Alkhateeb 0a34f341d1 Fixed: apply correct RTL on tab bar items in flatgrey and rainbowstone themes
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819499 13f79535-47bb-0310-9956-ffa450edef68
2017-12-29 17:29:52 +00:00
Deepak Dixit dc8180b333 Improved: Removed empty css attribute
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818611 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 19:06:40 +00:00
Jacques Le Roux 95b17d4d23 Improved: The main logo in screen upper part shows distorted
(OFBIZ-9990)

Fixes this issue in Tomahawk and Flat Grey themes by using ofbiz_logo.png, 
instead of the old logo deprecated ofbiz_logo.gif 

While at it use the same logo everywhere it's possible. It was needed for links 
to http://ofbiz.apache.org/images/ofbiz_logo.gif which no longer exists 
(actually seems only used for tests so could stay like that but better not refer 
to it anyway)

Also use this logo for Bluelight theme where it fits. 

It could not be used in Rainbow themes because they are using a Scalable Vector 
Graphics file (ofbiz-white.svg) that can't be replaced by the new png logo file
BTW this file still uses a TM symbol instead of a ®

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816897 13f79535-47bb-0310-9956-ffa450edef68
2017-12-01 18:45:50 +00:00
Deepak Dixit 2379a08cdd Improved: Removed unused theme related data, also fix the ofbiz logo for bluelight theme.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1812160 13f79535-47bb-0310-9956-ffa450edef68
2017-10-13 20:13:29 +00:00
Deepak Dixit 0b5cce399a Improved: Moved some utility js files from images to common-theme/js/util
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1812158 13f79535-47bb-0310-9956-ffa450edef68
2017-10-13 18:50:43 +00:00
Jacques Le Roux 456ad70aca Improved: Add session tracking mode and make cookie secure
(OFBIZ-6655)

Programmatically replaces the web.xml <session-config> declarations and uses 
the @WebListener annotation to start the process. This avoid to duplicates 
things everywhere in web.xml files. Since the web.xml files have precedence 
on annotations, the setting can be easily overridden when necessary.

Now that we also use HTTPS in ecommerce the ecommerce session cookie is 
also secured.

I also noted that we had 8 weird <session-timeout> declarations:
    in solr component: <session-timeout>2</session-timeout>
    in themes: <session-timeout>1</session-timeout>

Also in Rainbowstone we lacked the <cookie-config> and <tracking-mode> 
declarations. I think it's not good.

I resolve these points by simply removing the <session-config> in web.xml files 
of themes and Solr.

Thanks: Pradhan Yash Sharma  for review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811041 13f79535-47bb-0310-9956-ffa450edef68
2017-10-04 07:12:57 +00:00
Deepak Dixit 69a3268067 Improved: Moved OfbizUtil.js and fieldlookup.js from images to common-theme and made changes accordingly. (OFBIZ-5776)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809391 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 11:01:24 +00:00
Deepak Dixit 88493836bc Improved: Moved jquery related js/plugins from images to common-theme webapp and made changes accordinlgy. (OFBIZ-5776)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809389 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 10:41:28 +00:00
Nicolas Malin 661bf7df0d Fixed: Continue the common-theme upload (OFBIZ-9138 Create a common theme)
Correct all Theme.xml file fo the theme definition with the good xmlns

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806170 13f79535-47bb-0310-9956-ffa450edef68
2017-08-25 13:13:33 +00:00
Nicolas Malin e6e12f6407 Implemented: Continue the common-theme upload (OFBIZ-9138 Create a common theme)
Five step these step break all the UI
#4 Migrate the FlatGrey theme from VisualThemeRessource data definition to be an extends of common-theme

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806143 13f79535-47bb-0310-9956-ffa450edef68
2017-08-25 09:40:40 +00:00
Nicolas Malin aec57b51c5 Implemented: Continue the common-theme upload (OFBIZ-9138 Create a common theme)
Third step, move macro ftl libraries and ftl template present on framework common to common theme
At this step, the common-theme is forced like the common component previously.

Main common screens present on CommonScreens.xml, LookupScreens.xml and HelpScreens.xml are moved to common screen with a forced rewrite to common-theme 
Warning this commit is going to follow with a other commit for CommonScreens.xml because LookupScreens.xml and HelpScreens.xml are recreated on common-theme, but to keep the history of CommonScreens.xml it was moved entirely, the second commit restore it with redirect call.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806091 13f79535-47bb-0310-9956-ffa450edef68
2017-08-24 21:55:06 +00:00