Commit Graph
37 Commits
Author SHA1 Message Date
James Yong 483e77ea83 Fixed: Date picker not initialised in ajax-called form (OFBIZ-12097)
Use inline script when request is ajax
2020-12-20 08:46:52 +08:00
James Yong e405d35c08 Improved: Move page-specific script links to html template (OFBIZ-11799)
Use importLibrary js function to load locale-specific datepicker js.
Corrected locale naming in macro to use '.locale'.
Tested page at /ordermgr/control/findreturn and /ordermgr/control/orderentry.
2020-12-05 23:23:04 +08:00
James Yong a3fbb66479 Improved: Move page-specific script links to html template (OFBIZ-11799)
Use importLibrary js function to load time-related js and css for date time picker.
Tested page at /ordermgr/control/findreturn and /ordermgr/control/orderentry
2020-11-30 10:29:08 +08:00
James Yong bc5b0d595c Improved: Load language js for date.js only when required (OFBIZ-12064)
Tested on
1) date time field at /ordermgr/control/orderentry and
2) date find field at /ordermgr/control/findreturn
2020-11-27 21:51:35 +08:00
James Yong 2eb3282988 Reverted: Error when rendering renderSubmitField macro (OFBIZ-11968)
No issue after new checkout.

Thanks Jacques and Dennis for the check
2020-08-22 14:43:00 +08:00
James Yong 796e0d94ee Fixed: Error when rendering renderSubmitField macro (OFBIZ-11968)
Fixed error rendering renderSubmitField when accessing /humanres/control/FindPartySkills page
2020-08-21 15:44:39 +08:00
Jacques Le Roux 3c687a757c Improved: Form-Fields of certain types won't render IDs (OFBIZ-11957)
While implementing some OFBiz-Forms, I noticed, that certain types of
form-fields will not render the set ID.

Field-Types that won't work for sure are {{submit}} and {{hyperlink}} where the
set name for the parameter {{id-name}} simply will not be rendered in the
HTML-Code that is generated by OFBiz.

Thanks: Dennis Balkir
2020-08-20 15:17:21 +02:00
James Yong eb4f082fef Fixed: Error in log when running renderDropDownField macro (OFBIZ-11959)
Fixed unable to render the disable attribute.
2020-08-15 20:01:29 +08:00
Pawan Verma bc0afa36ee Fixed: Entering manually date in date-time field become unworkable
(OFBIZ-10432)

Thanks, Olivier for the report.
2020-05-20 14:26:52 +05:30
Pawan Verma 3b7e63744c Improved: Expansion of form widget field disabled atrribute with xsd improvement (#141)
(OFBIZ-10432)

1. Added disabled attribute support in ModelFormField with xs:boolean type
2. Removed specific field level disabled attribute support for CheckField and TextField
3. Modified existing usage of disabled attribute as per new implementation.

Thanks: Rishi for the report and Taher, Gil and Jacques for the feedback
2020-05-19 17:37:24 +05:30
Jacques Le Roux c34491892a Improved:
Implemented:
Documented:
Completed:
Reverted:
Fixed:
Improved: no functional change
(OFBIZ-)
Explanation
Thanks:
2020-02-27 14:36:26 +01:00
Deepak Dixit c30252ec15 Fixed: Html escaping missing for renderLink parameters
(OFBIZ-11090)
Parameters vlaue should be escaped to avoid any kind of corss site scripting issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1860597 13f79535-47bb-0310-9956-ffa450edef68
2019-06-04 10:49:17 +00:00
Aditya Sharma b112049a5d Improved: Replace Inline js with External js in renderDropDownField macro.
(OFBIZ-9849)
Silghtly modified patch as Specify-other Dropdown field were not working. Refactored code in combobox.js file
Thanks Dhaval Wagela for the initial patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1856610 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 07:12:36 +00:00
Jacques Le Roux ee75d89772 Improved: Browser Unresponsive when Loading Entity with Large Results
(OFBIZ-10716)

I came across a situation where an entity was taking too much of a time 
(browser asked me to either wait or kill) while loading/searching results in the 
Webtools application. The entity had close to 5M records, and I checked the 
server responded timely but the rendering of the screen was taking time.

When I explored the issue I came across a macro which renders the pagination on the screen, and it had a code block which was causing the screen rendering delay.

<#assign x=(listSize/viewSize)?ceiling>
  <#list 1..x as i>
    <#if i == (viewIndex+1)><option selected="selected" value="<#else><option value="</#if>${i-1}">${i}</option>
  </#list>

This code seems logical enough to me, and what I gather from this is that the 
list will render a select box with 250,000 options.

I like propose a change in this UI/UX from select box to an input text box so an 
user can navigate to any page, similar to a navigation input box in a PDF 
document reader application.

Thanks: Devanshu Vyas for the patch, Nicolas for discussion and Kumar Rahul for
testing

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1856145 13f79535-47bb-0310-9956-ffa450edef68
2019-03-24 13:12:12 +00:00
Aditya Sharma 5c3e72c517 Improved: Replace Inline js with External js in renderTextField macro
(OFBIZ-9844)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1851500 13f79535-47bb-0310-9956-ffa450edef68
2019-01-17 08:32:56 +00:00
Aditya Sharma 3cbf90302c Improved: Replace Inline js with External js in renderFieldGroupOpen macro
(OFBIZ-9853)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1851433 13f79535-47bb-0310-9956-ffa450edef68
2019-01-16 11:49:11 +00:00
Aditya Sharma 9cc82517de Improved: Replace Inline js with External js in renderDateFindField macro
(OFBIZ-9850)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1851315 13f79535-47bb-0310-9956-ffa450edef68
2019-01-15 04:55:27 +00:00
Aditya Sharma b0dcf2929e Improved: Replace Inline js with External js in renderDateTimeField macro
(OFBIZ-9848)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1851224 13f79535-47bb-0310-9956-ffa450edef68
2019-01-14 05:20:37 +00:00
Jacques Le Roux 2a96d29cbe Fixed: Date-find error when used in two forms of a same screen
(OFBIZ-10722)

When we have more than one form, in a screen, that use a date-find field, 
the second date-find picker is not working.

To reproduce, you can add a new form with a date-find and call it below 
FindInvoices in FindInvoices screen

Then load page [https://localhost:8443/accounting/control/findInvoices] . 
You should see  that there is no picker on the second date-find

The patch adds an id that allow renderDateFindField macro script to work for 
both fields

Thanks: Leila Mekika

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1849165 13f79535-47bb-0310-9956-ffa450edef68
2018-12-18 11:20:28 +00:00
Deepak Dixit 870651efdf Improved: Use of layered-modal with parameter does not work
(OFBIZ-10511)
Thanks Arsalane Arrach for your contribution. Use &quot; to escape the double quotation marks

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1840093 13f79535-47bb-0310-9956-ffa450edef68
2018-09-05 07:16:21 +00:00
Suraj Khurana 2d2aba0a4c Improved: Empty header row should not render if list to render in file is empty.
(OFBIZ-7598)
Thanks everyone for your inputs and suggestions.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1839729 13f79535-47bb-0310-9956-ffa450edef68
2018-08-31 06:33:07 +00:00
Suraj Khurana 5d317c08de Reverted: Empty header row should not render if list to render in file is empty.
(OFBIZ-7598)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1838823 13f79535-47bb-0310-9956-ffa450edef68
2018-08-24 11:37:16 +00:00
Deepak Dixit 5f8f3bfa65 Improved: Replace #assign with #local in all the themes ftl macros
(OFBIZ-10516)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1837829 13f79535-47bb-0310-9956-ffa450edef68
2018-08-10 18:47:58 +00:00
Gil Portenseigne 0b6acc8feb Fixed: Use of layered-modal with parameter does not work
(OFBIZ-10511)

Thanks Deepak and Aditya for the review and providing a better patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1837806 13f79535-47bb-0310-9956-ffa450edef68
2018-08-10 14:11:22 +00:00
Deepak Dixit 252828d8b0 Improved: Improved: Use application/javascript instead of text/javascript
(OFBIZ-10492)
Added missing file in last commit

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1836893 13f79535-47bb-0310-9956-ffa450edef68
2018-07-28 12:21:52 +00:00
Deepak Dixit ef0c694a46 Improved: Use application/javascript instead of text/javascript
(OFBIZ-10492)
Replace text/javascript with application/javascript in all the script tag

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1836886 13f79535-47bb-0310-9956-ffa450edef68
2018-07-28 10:51:52 +00:00
Deepak Dixit 397628ba7d Improved: Remove use of deprecated language attribute from script tag
(OFBIZ-10491)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1836545 13f79535-47bb-0310-9956-ffa450edef68
2018-07-24 11:26:23 +00:00
Suraj Khurana 65b5b117f7 Improved: Empty header row should not render if list to render in file is empty.
(OFBIZ-7598)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835869 13f79535-47bb-0310-9956-ffa450edef68
2018-07-14 05:10:00 +00:00
Suraj Khurana 920050d685 Reverted: Empty header row should not render if list to render in file is empty because after this, search Result tables won't show first search result.
{OFBIZ-10438}

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835042 13f79535-47bb-0310-9956-ffa450edef68
2018-07-04 05:24:41 +00:00
Aditya Sharma fcc31d5ba6 Fixed: <#if containerId?has_content> id=''</#if> is missed in renderFormOpen
(OFBIZ-10437)

With r1832307, the code that adds the id attribute to form was missing and the attribute autocomplete was repeated twice. 

Thanks: Wei and Jacques for discovering the issue.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1834816 13f79535-47bb-0310-9956-ffa450edef68
2018-07-02 05:28:22 +00:00
Rishi Solanki b9cf8a5d55 Improved: Add Support for Disable attribute in CheckBox Form Widget. Disabled attrivute can be used as
<field><check disabled=true/></field>

and default value for attribute will be false.
(OFBIZ-10367)
Thanks Pawan Verma for reporting the improvement and providing patch for that.
Thanks James Yong for testing the work.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1833231 13f79535-47bb-0310-9956-ffa450edef68
2018-06-09 12:34:49 +00:00
Jacques Le Roux 22b6c33e88 Improved: Empty header row should not render if list to render in file is empty
(OFBIZ-7598)

If list inside form doesn't contain data, then header row should not render from
better UI perspective and proper message should be shown to user.

Get to catalog/control/EditProductGoodIdentifications with eg 
productId=ID:GZ-1006 for a test 

Thanks: Suraj 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832401 13f79535-47bb-0310-9956-ffa450edef68
2018-05-28 14:37:44 +00:00
Jacques Le Roux 5ed72f1e95 Improved: Replace Inline js with External js in renderFormClose macro
(OFBIZ-9846)

Replaced inline js from renderFormClose macro to external js in OfbizUtils.js
Done following:
Used custom data attributes: data-focus-field to define focus field for the form.
Used attribute selector to find elements and set focus on the particular field.

Added "requireValidation" class to all the forms with required fields.

Used the class selector to find such forms & attached Validator plugin to it.

Steps to verify:

At add ProdCatalog page: https://localhost:8443/catalog/control/EditProdCatalog

Dialogs:
New Example dialog on Find Example page 
    Go to Find Example page https://localhost:8443/example/control/FindExample
    Click on New Example button
    Validations should work in dialog on form submit.

Additional Changes:

Link for dialog in HtmlMenuMacroLibrary still had the inline code. 
Replaced the code with external js code.

Validations on forms rendered with renderSubmitField macro from 
HtmlFormMacroLibrary.ftl seems not working 
https://demo-trunk.ofbiz.apache.org/partymgr/control/NewEmployee, will create 
a separate ticket for it.

jleroux: 
I agree about NewEmployee issue
As mentionned Aditya themes/rainbowstone/template/HtmlMenuMacroLibrary.ftl was
redundant, removed
I also removed commented out code in rainbowstone HtmlMenuMacroLibrary.ftl 
(left by Aditya while working on the issue I guess)

Thanks: Aditya 


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832307 13f79535-47bb-0310-9956-ffa450edef68
2018-05-26 12:42:20 +00:00
Deepak Dixit 40f25899a1 Fixed: Lookup rendering broken due changes done at r#1825350, conditionGroup is optional paramerter for lookup or related macros, so set empty default parameter value for conditionGroup parameter
(OFBIZ-10195)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1825430 13f79535-47bb-0310-9956-ffa450edef68
2018-02-27 08:23:43 +00:00
Gil Portenseigne 65fe235f51 Implemented: Add the ability in performFind service to set OR search criteria
(OFBIZ-10195)

This improvement add a way to specify a condition-group attribute on search fields, for performFind service usage.
The same group conditions are gathered with AND operator, and each group is added with a OR
The resulting condition is added to the other with AND operator.
Thanks Taher for your reviews and ideas

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1825350 13f79535-47bb-0310-9956-ffa450edef68
2018-02-26 09:57:36 +00:00
Deepak Dixit 23e4b72f17 Fixed: Alert message : Developer: for lookups to work you must provide a form name! appears when try to select contentId from Lookup.
(OFBIZ-10012)
Applied slightly modified patch 
Thanks  Sonal for reporting and Aditya Sharma for providing patch for the issue


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1825205 13f79535-47bb-0310-9956-ffa450edef68
2018-02-24 10:22:18 +00:00
Taher A. Alkhateeb bf25f54b0f Implemented: renamed the common theme directory from "common" to "common-theme"
(OFBIZ-10175)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821789 13f79535-47bb-0310-9956-ffa450edef68
2018-01-21 12:40:46 +00:00