Commit Graph
10472 Commits
Author SHA1 Message Date
Erwan de Ferrieres 791bbded63 More improvements on help, adding more descriptions and a French page
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1075324 13f79535-47bb-0310-9956-ffa450edef68
2011-02-28 13:45:02 +00:00
Sascha Rodekamp 40f52ad764 Improvement - if-regexp conditions in Minilang and Screens not thread safe (https://issues.apache.org/jira/browse/OFBIZ-4107). I added another getTestPattern Method to support case insensitive tests. The case insensitive testPattern is needed from the UtilHttp.checkURLforSpiders.
Thanks Martin & Dimitri for your effort.

Orig. Msg.:

The Perl5Matcher Perl5Compiler are not thread safe, as mentioned in their documentation: http://jakarta.apache.org/oro/api/org/apache/oro/text/regex/Perl5Compiler.html
A separate instance should be used per thread.

The concrete issue occurred in our system in the createCommContentDataResource service. The service tries to save emails to the database after they have been sent. It failed because of the described issue. This caused the whole email service (sendMailFromScreen) to be rescheduled. So customers got emails twice.

The Perl5Matcher and Perl5Compiler instances are assigned to static fields in the org.ofbiz.minilang.method.ifops.IfRegexp class. So every thread will use the same instance. No synchronization is done currently. Changing the fields to be non-static will not work either, as SimpleMethods are cached. So all calls to the same simple method use the same IfRegexp instance.

We fixed the problem by moving the instantiation of the Perl5Matcher and Perl5Compiler to the exec() method in IfRegexp.

Other classes are most likely affected, too: org.ofbiz.entity.condition.EntityComparisonOperator, org.ofbiz.minilang.method.conditional.RegexpCondition, org.ofbiz.minilang.operation.Regexp, org.ofbiz.widget.menu.ModelMenuCondition$IfRegexp, org.ofbiz.widget.screen.ModelScreenCondition$IfRegexp, org.ofbiz.widget.tree.ModelTreeCondition$IfRegexp


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1075322 13f79535-47bb-0310-9956-ffa450edef68
2011-02-28 13:43:23 +00:00
Erwan de Ferrieres af56c858e8 Using the right syntax for caution, important, note, tip and warning in docbook documentation
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1075125 13f79535-47bb-0310-9956-ffa450edef68
2011-02-27 19:49:39 +00:00
Jacques Le Roux f9661643f7 Fixes some errors in UiLabels
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1073801 13f79535-47bb-0310-9956-ffa450edef68
2011-02-23 16:09:50 +00:00
Jacques Le Roux faefe05b41 Helps to find errors in UiLabels files
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1073785 13f79535-47bb-0310-9956-ffa450edef68
2011-02-23 15:31:11 +00:00
Christian Geisert a89af7668e Adding Germany (de_DE) Labels for "Quote" (!= "Offerte") and a few more translations
Submitted by Carsten Schinzer
See OFBIZ-2862



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1073716 13f79535-47bb-0310-9956-ffa450edef68
2011-02-23 12:07:24 +00:00
Jacques Le Roux be618c46fc * Fixes some issues related to anchors syntax in some docbook help files
* Adds TheMarketingApplication anchor for https://cwiki.apache.org/confluence/display/OFBENDUSER/Apache+OFBiz+Business+Setup+Guide

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1073502 13f79535-47bb-0310-9956-ffa450edef68
2011-02-22 21:06:54 +00:00
Erwan de Ferrieres 57eefd55cd Misc. French translations
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1073485 13f79535-47bb-0310-9956-ffa450edef68
2011-02-22 20:18:48 +00:00
Erwan de Ferrieres cc97cd53cc Make collapsibleAreaId unique so the right screenlet is collapsed when more than one screenlet in a portalPage
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1073398 13f79535-47bb-0310-9956-ffa450edef68
2011-02-22 16:44:30 +00:00
David E. Jones bcae85b5f4 Reduced logging of an exception that is just rethrown, still logs error but not full stack trace
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1073196 13f79535-47bb-0310-9956-ffa450edef68
2011-02-22 01:18:55 +00:00
Jacques Le Roux 5a4b5561a7 Provides defaultMinLength default value (=2)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1073163 13f79535-47bb-0310-9956-ffa450edef68
2011-02-21 21:55:49 +00:00
Sascha Rodekamp a3cfb8c9e4 Feature - Improve UtilProperties.java with a new Method getPropertyNumber which returns an Object of the Number or a default Object - (https://issues.apache.org/jira/browse/OFBIZ-3418) - I submitted a less modified patch from Mirko Vogelsmeier. The patch was outdated but doesn't matter I merged by hand and removed the tabs. Thanks Mirko for the improvement. And thanks Adrian for the first review.
Orig. Msg.:
Improvement of UtilProperties.java with a new method which returns the Number as an Object of the specified property name from the specified resource/properties file.
If the specified property name or properties file is not found, the defaultObject is returned.

i did update my method "getPropertyNumber" a bit and
as requested i added "getPropertyAsInteger / asLong / AsFloat / AsDouble / AsBigInteger / AsBigDecimal".
In addition i added a "getPropertyAsBoolean".


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1073113 13f79535-47bb-0310-9956-ffa450edef68
2011-02-21 19:01:36 +00:00
Jacques Le Roux 2d35500cf5 Introduces widget.autocompleter.defaultMinLength in widget.properties and set it to 2: Default minimum number of characters an user has to type before the ajax autocompleter activates (jQuery default is 1).
Note: not to be confused with the the minChars option of the old plugin (not in jQuery UI but the  external plugin from bassistance.de) which allowed this so this page is wrong: http://docs.jquery.com/Plugins/Autocomplete/autocomplete#url_or_dataoptions. Now replaced by minLength, the right page is http://docs.jquery.com/UI/API/1.8/Autocomplete#options

Also adds a css trick (from http://jqueryui.com/demos/autocomplete/maxheight.html) to have a vertical scroolbar when having dozens of items in autocomplete (using widget.autocompleter.defaultViewSize=100 for instance) 



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1072784 13f79535-47bb-0310-9956-ffa450edef68
2011-02-20 22:43:59 +00:00
Erwan de Ferrieres 3f737c4cf6 Better consistency for French CommonItems translation
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1072600 13f79535-47bb-0310-9956-ffa450edef68
2011-02-20 14:13:03 +00:00
Erwan de Ferrieres 2fa06cc44c Adding missing DTD attributes for link element when calling an ajax-window
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1072599 13f79535-47bb-0310-9956-ffa450edef68
2011-02-20 14:11:02 +00:00
Jacques Le Roux 6d47543fe3 Fix ports numbers
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1072395 13f79535-47bb-0310-9956-ffa450edef68
2011-02-19 17:08:08 +00:00
Jacques Le Roux e3711d2369 * Replaces the old testRemoteSoap service now invalid with our own dog food: testSoapSimple from http://demo-trunk.ofbiz.apache.org:8080/webtools/control/SOAPService
* Adds a bunch of external SOAP services, none of them work so far, not sure why, a good exercise for the future...

I have tried to backport to R9.04 the testRemoteSoap change but it does not work there:

2011-02-19 17:26:02,500 (http-0.0.0.0-8443-1) [               Call.java:2469:ERROR] Exception:
org.xml.sax.SAXException: Deserializing parameter 'map-Map':  could not find deserializer for type {http://www.w3.org/2001/XMLSchema}anyType
        at org.apache.axis.message.RPCHandler.onStartChild(RPCHandler.java:277)
        at org.apache.axis.encoding.DeserializationContext.startElement(DeserializationContext.java:1035)
        at org.apache.axis.message.SAX2EventRecorder.replay(SAX2EventRecorder.java:165)
        at org.apache.axis.message.MessageElement.publishToHandler(MessageElement.java:1141)
        at org.apache.axis.message.RPCElement.deserialize(RPCElement.java:236)
        at org.apache.axis.message.RPCElement.getParams(RPCElement.java:384)
        at org.apache.axis.client.Call.invoke(Call.java:2467)
        at org.apache.axis.client.Call.invoke(Call.java:2366)
        at org.apache.axis.client.Call.invoke(Call.java:1812)
        at org.ofbiz.service.engine.SOAPClientEngine.serviceInvoker(SOAPClientEngine.java:137)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1072378 13f79535-47bb-0310-9956-ffa450edef68
2011-02-19 16:32:19 +00:00
Sascha Rodekamp 007a92695b Bug - Screen Link Ajax Windows (https://issues.apache.org/jira/browse/OFBIZ-4183) - Erwan found a bug regarding the layered links in the example screens, it's fixed, i created a seperated screen for the layered link. Thanks Erwan for reporting.
Orig. Msg.:
now there is a problem when you click on an example to edit it, the decorator is no more present on the form.

to reproduce
In example component, search all examples the click on an id.
    


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1072303 13f79535-47bb-0310-9956-ffa450edef68
2011-02-19 10:47:53 +00:00
David E. Jones 3b20b9c06f Reversing accidental commit in rev 1072292
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1072301 13f79535-47bb-0310-9956-ffa450edef68
2011-02-19 10:38:13 +00:00
David E. Jones 2d28cc3d66 VUA-429 full implementation to add a path through the screens for creating a sales order for a contact and add a customer for the contact in the process
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1072292 13f79535-47bb-0310-9956-ffa450edef68
2011-02-19 10:13:50 +00:00
Jacques Le Roux a8841a71da This was preventing to show "(show WSDL)" in other languages than English
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1072017 13f79535-47bb-0310-9956-ffa450edef68
2011-02-18 15:06:44 +00:00
Erwan de Ferrieres 747137b741 Adding default empty values to step and timeValues, resolving OFBIZ-4188
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1071967 13f79535-47bb-0310-9956-ffa450edef68
2011-02-18 11:25:05 +00:00
Erwan de Ferrieres 51f8bdc022 Adding caution, important, note, tip, warning to docbook formatting possibilities. Those can be used inside a para element.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1071917 13f79535-47bb-0310-9956-ffa450edef68
2011-02-18 08:31:52 +00:00
Sascha Rodekamp f51f4fdff2 Feature - Screen Link Ajax Windows (https://issues.apache.org/jira/browse/OFBIZ-4183)
I created a new Screen <link feature. Similar to the Form Lookups a link can be opened in a layered JS Box (see Screenshot in Jira Task). It looks nice and is helpful in some cases.

You can add any screen u want. It's expected that you create a certain screen for the layered link which only contains the information you need.

The layered box doesn't contain any logic it's just a container for the screen which should be opened. So the screen it self can decide what to show. i.e  if you load a form, the form itself implement the way how it react on a submit (either reload the site or perform the submit as Ajax request in the background).

There is also an example in the example section. Try to create a new Example on the mainpage.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1071698 13f79535-47bb-0310-9956-ffa450edef68
2011-02-17 17:01:07 +00:00
Sascha Rodekamp 0203cb9f0b Feature - "LoginWorker should use expandedEntites von the checkLogin-query" (https://issues.apache.org/jira/browse/OFBIZ-3453) - The parameters in the query String are separated by an &. The Code is more clean (and XHTML strict) when the separator is encoded. Thanks Dimitri for the patch.
Orig. Msg.:
I guess that the makeLoginUrl-method in the LoginWorker should return a string with expandedEntites.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1071362 13f79535-47bb-0310-9956-ffa450edef68
2011-02-16 19:06:10 +00:00
Sascha Rodekamp a33a59873b Bug Fix "DateTimePicker shows wrong current time" (https://issues.apache.org/jira/browse/OFBIZ-4169) - When changing the plugin configuration the dtp shows the correct time - Thanks Nikkel K for reporting.
Orig. Msg:
The DateTimePicker calculates nearly always in 5m steps and rounds up or down, depending on the nearest result. This means, that you have at 14:11:10 and at 14:12:10 a time of 14:10:10 in the DTP and at 14:13:10 and 14:14:10 already 14:15:10 (so on the one hand you have a "current" time that shows in the future and on the other hand the same time 5 times in the DTP (while the mins. dont increase, the seconds do).

comment to the nearly always: i had exactly one case, where i had xx:01:xx, and i cant recreate it...


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1071328 13f79535-47bb-0310-9956-ffa450edef68
2011-02-16 17:55:52 +00:00
Bruno Busco 41dcc9b67a Better Italian labels
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1071327 13f79535-47bb-0310-9956-ffa450edef68
2011-02-16 17:49:31 +00:00
Erwan de Ferrieres 28cda607e3 Missing geoAssoc for Corse FR-20
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1070911 13f79535-47bb-0310-9956-ffa450edef68
2011-02-15 14:12:04 +00:00
Erwan de Ferrieres 80d2dc710d Adding a new feature for date-time fields: step, which will format the minutes drop-down with or a 1, 5, 10, 15 or 30 step-size
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1070570 13f79535-47bb-0310-9956-ffa450edef68
2011-02-14 16:57:31 +00:00
Erwan de Ferrieres 530e8847da Migration to Tomcat 6.0.32 due to a security issue in previous revisions
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1070455 13f79535-47bb-0310-9956-ffa450edef68
2011-02-14 12:04:29 +00:00
Erwan de Ferrieres ee15828aee Back to evolution for the French Tomahawk description
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1070425 13f79535-47bb-0310-9956-ffa450edef68
2011-02-14 10:09:31 +00:00
Erwan de Ferrieres 7575802207 Better French descriptions for visual themes
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1070295 13f79535-47bb-0310-9956-ffa450edef68
2011-02-13 20:49:03 +00:00
Erwan de Ferrieres d6be0a8959 Adding a help message on how to choose a theme and how to use it
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1070287 13f79535-47bb-0310-9956-ffa450edef68
2011-02-13 20:12:37 +00:00
Jacques Le Roux 13f879435f Revert r1070230, was a patch from Stephen Rufle "Blank year in UtilValidate.isYear should return false" (https://issues.apache.org/jira/browse/OFBIZ-4171) - OFBIZ-4171
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1070282 13f79535-47bb-0310-9956-ffa450edef68
2011-02-13 19:43:13 +00:00
Jacques Le Roux a259699bd7 A patch from Stephen Rufle "Blank year in UtilValidate.isYear should return false" (https://issues.apache.org/jira/browse/OFBIZ-4171) - OFBIZ-4171
UtilValidate.isYear returns true for a blank year which the calling function UtilValidate.isDate(String, String, String) tries to parse. This causes an exception to be thrown
ValidateMethod.java:96 :ERROR] [ValidateMethod.exec] Error in validation method isDateAfterToday of class org.ofbiz.base.util.UtilValidate: null
I found this error when trying to add a new credit card in the eCommerce checkout flow.
   1. Add a product to the cart
   2. login as any user I used "admin"
   3. Checkout Step "Shipping Address" (Step 1: Where shall we ship it?)
          * Click Next
   4. Checkout Step "Shipping Options" (Step 2: How shall we ship it?)
          * Choose "UPS Air"
          * Click Next
   5. Checkout Step "Payment Options" (Step 3: How shall you pay?)
   6. Create "Credit Card"
          * Fill Name
          * Card Type "Visa"
          * Card Number "4111111111111111"
          * Expiration Date Month drop-down 01
          * Expiration Date Year drop-down leave blank
          * Choose billing address
          * Click "Save" button

Should see "Error in validation method isDateAfterToday of class org.ofbiz.base.util.UtilValidate: null"

My fix is to change isYear, isMonth, and isDay to return false when a blank value is entered.
After I make my change the message is "The expiration date is before today"


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1070230 13f79535-47bb-0310-9956-ffa450edef68
2011-02-13 12:55:45 +00:00
Jacques Le Roux 170d362368 A modified patch from BJ Freeman "Add anchor to SingleSignOn.xml" (https://issues.apache.org/jira/browse/OFBIZ-4174) - OFBIZ-4174
A cleaner solution for the anchor /cmssite/cms/APACHE_OFBIZ_HTML#CASLDAP: only in chapter


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069565 13f79535-47bb-0310-9956-ffa450edef68
2011-02-10 20:56:21 +00:00
Erwan de Ferrieres d23662467b OFBIZ-4170 : a bug was present in the timepicker plugin and values under 01:05:10 couldn't be selected
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069542 13f79535-47bb-0310-9956-ffa450edef68
2011-02-10 19:45:22 +00:00
Jacques Le Roux c7c6b5377e Better place for anchor
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069372 13f79535-47bb-0310-9956-ffa450edef68
2011-02-10 12:57:22 +00:00
Jacques Le Roux 0b92565dc0 Fix some blocking issues reported at "add anchor to SingleSignOn.xml" (https://issues.apache.org/jira/browse/OFBIZ-4174) - OFBIZ-4174
there are still some (not blocking, minor?) issues to fix

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069368 13f79535-47bb-0310-9956-ffa450edef68
2011-02-10 12:44:33 +00:00
Jacques Le Roux 6ca4414f03 A patch from BJ Freeman "Add anchor to SingleSignOn.xml" (https://issues.apache.org/jira/browse/OFBIZ-4174) - OFBIZ-4174
Adds anchor /cmssite/cms/APACHE_OFBIZ_HTML#CASLDAP so it can use permanent link. (CTR mode: Still to be tested)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069229 13f79535-47bb-0310-9956-ffa450edef68
2011-02-10 05:03:15 +00:00
Marco Risaliti 78dcf847bd Add a @SuppressWarning("serial") in ViewHandlerException (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069122 13f79535-47bb-0310-9956-ffa450edef68
2011-02-09 21:31:19 +00:00
Marco Risaliti e5b0485aba Add a @SuppressWarning("serial") of classes of package org.ofbiz.webapp.taglib (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069121 13f79535-47bb-0310-9956-ffa450edef68
2011-02-09 21:30:31 +00:00
Marco Risaliti ecc24d9115 Add a @SuppressWarning("serial") of classes of package org.ofbiz.webapp.region (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069118 13f79535-47bb-0310-9956-ffa450edef68
2011-02-09 21:21:50 +00:00
Marco Risaliti fc188f9f06 Add a @SuppressWarning("serial") in EventHandlerException/FileUploadProgressListener (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069117 13f79535-47bb-0310-9956-ffa450edef68
2011-02-09 21:19:57 +00:00
Marco Risaliti 3b77f392b7 Add a @SuppressWarning("serial") in RequestHandlerException (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069115 13f79535-47bb-0310-9956-ffa450edef68
2011-02-09 21:18:24 +00:00
Marco Risaliti 2ce589d6dd Add a @SuppressWarning("serial") in StartupException (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069113 13f79535-47bb-0310-9956-ffa450edef68
2011-02-09 21:17:33 +00:00
Marco Risaliti 52345a05f7 Remove an unused variable in Classpath (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069112 13f79535-47bb-0310-9956-ffa450edef68
2011-02-09 21:17:00 +00:00
Marco Risaliti 7f178509c0 Remove a unused import in SQLSelect (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069111 13f79535-47bb-0310-9956-ffa450edef68
2011-02-09 21:13:20 +00:00
Marco Risaliti 1bae5e4464 Remove a unused import in SQLIndex (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069109 13f79535-47bb-0310-9956-ffa450edef68
2011-02-09 21:12:36 +00:00
Marco Risaliti 8c5cd799ea Add a @SuppressWarning("serial") in ParameterizedConditionException (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069108 13f79535-47bb-0310-9956-ffa450edef68
2011-02-09 21:11:33 +00:00