Test mode rollback doesn't work right in GenericDelegator for calls to removeByPrimary() key and removeByValue() when the row to be deleted didn't exist in the first place. It creates a TestOperation with a null value and subsequently fails to create that during rollback.
First, the TestOperation shouldn't be created at all. Second, if null is passed to GenericDelegator.create() it tries to handle this, but fails with a NullPointerException.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1104423 13f79535-47bb-0310-9956-ffa450edef68
XmlFileLoader: File file:.....framework/entity/config/entityengine.xml process fatal error. Line: 686. Error message: Invalid byte 2 of 2-byte UTF-8 sequence.
After having manually put back the line modified by an automatically applied patch, I got this mis-representation. Not sure why, and anyway had no chances to think about it (certainly due to a difference on how UTF-8 was represented on these servers and on my machine - XP with Putty and SSH)
So I remove this weirdness to prevent future possible nervous crises ;o)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1104173 13f79535-47bb-0310-9956-ffa450edef68
e.g. in lookup dialog (in layer mode), one href value of a link is "javascript:set_value('123/ABC');", then the ofbiz framework will parse it to "javascript:lookupAjaxRequest('ABC'');&presentation=layer')". It's wrong. Correct one should be given href itself.
to fix:
judge whether the link contains "javascript:set_" before split it by slash '/'.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1103714 13f79535-47bb-0310-9956-ffa450edef68
If the session is timed out the request handler checks weather it is an ajax request or not (The information comes from the request header if the X-Requested-With contains XMLHttpRequest we haven an ajax request.).
If it is an ajax request it don't return the normal "checkLogin" request, i return a a special ajaxCheckLogin request. This request can point to an site which shows the "Please Login Hint".
Orig Msg:
Take the following page (for example) https://localhost/content/control/findContent
field "Data Resource Id" has an icon beside it that creates an ajax dialog pop up. If the session has already timed out. The dialog box would show the login screen.
I suspect that all pages containing this functionality would exhibit the same symptom.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1102615 13f79535-47bb-0310-9956-ffa450edef68
Replaces the <if> task (used javascript in a file with .py suffix :/ ). I kept it commented out for now, in case someone is using it (not used OOTB)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1100795 13f79535-47bb-0310-9956-ffa450edef68
I wondered if I should not remove the event from the common-controller since I guess this is rarely used. But, as the functionality is available OOTB, I preferred to keep it as is. So I simply remove the never-cache from UserLoginAndProtectedView view-entity. Since it will almost always be empty, no memory issues and better performance are expected. If I remember well, at the moment I committed this, I checked: the performance impact was already not noticeable (most of the time only one check in the event).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1100197 13f79535-47bb-0310-9956-ffa450edef68
Actually in R10.04 the problem is reported as a warning but the service is not rolled back. Not sure if it's a desired change (then how to use Integer as field type in an entity also used by a service?)
GenericEntity.java:426:WARN ]
---- exception report ----------------------------------------------------------
=-=-=-=-=-=-=-=-= Database type warning GenericEntity.set =-=-=-=-=-=-=-=-= In entity field [ProtectedView.maxHits] set the value passed in [java.lang.Integer] is not compatible with the Java type of the fiel
d [Long]
Exception: java.lang.Exception
Message: Location of database type warning
---- stack trace ---------------------------------------------------------------
java.lang.Exception: Location of database type warning
org.ofbiz.entity.GenericEntity.set(GenericEntity.java:426)
org.ofbiz.entity.GenericEntity.set(GenericEntity.java:372)
org.ofbiz.entity.GenericEntity.setAllFields(GenericEntity.java:906)
org.ofbiz.entity.GenericEntity.setNonPKFields(GenericEntity.java:862)
org.ofbiz.service.engine.EntityAutoEngine.runSync(EntityAutoEngine.java:235)
org.ofbiz.service.ModelServiceReader$GenericInvokerImpl.runSync(ModelServiceReader.java:832)
_$gen.file_58$.D_58$.workspace.ofbizDev.framework.common.servicedef.services_95$security_46$xml_35$addProtectedViewToSecurityGroup.runSync(file:/D:/workspace/ofbizDev/framework/common/servicedef/services_secu
rity.xml#addProtectedViewToSecurityGroup:95)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1099388 13f79535-47bb-0310-9956-ffa450edef68
Screenlet title bars and H1 titles have been removed when they simply duplicate the tab menu.
Fixed some missing tab menu highlighting.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1098406 13f79535-47bb-0310-9956-ffa450edef68
[javac16] Compiling 20 source files to /home/ofbiz/trunk/framework/testtools/build/classes
[javac16] /home/ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/ModelTestSuite.java💯 addTestSuite(java.lang.Class<? extends junit.framework.TestCase>) in junit.framework.TestSuite cannot be applied to (java.lang.Class<capture#618 of ?>)
[javac16] suite.addTestSuite(clz);
This change allows to compile on trunk demo server
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1098245 13f79535-47bb-0310-9956-ffa450edef68
Lookup tag has a attribute "disabled" that is used to set disabled="disabled" property for lookup input element and it create also a clear button just after lookup field to clear the field value.
But if we set disabled="disabled" for any input field then that field does not passes as parameter and we can't accesses it from parameters or request parameters , so it should be "readonly".
If we set readonly-"readonly" then user can't change the field value directly, and this field passes as parameters.
Only difference between readonly and disabled is that in case of disabled field does not passes as parameter buy in case of readonly field passes as a parameter.
Thanks Deepak for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1098082 13f79535-47bb-0310-9956-ffa450edef68
<<Slight improvement to prevent false error messages when putting spaces in readers names, eg after commas for instance>>
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1097712 13f79535-47bb-0310-9956-ffa450edef68
- move remove and rename function to manage page
- create UI label and error UI label
- improve remove function
- improve rejected function
- improve share image function
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1097674 13f79535-47bb-0310-9956-ffa450edef68
Orig. Msg.
When I open an layer mode lookup window and click the 'Next' button above the search result list, nothing happend but exception occures in backend.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1096344 13f79535-47bb-0310-9956-ffa450edef68
Initial demand by Michael Pätzold
At the moment we concentrate on increasing the usability of the backend application. One thing we recognized is the way form errors are reported to the users. Now it's done by showing a list of entity fields, that are required. A more common approach would be to highlight the form controls, that were not/wrongly filled. Was/Is there any task related to that or something similar?
Nicolas's solution
With integration of JQuery and validate function integrate by Sascha, I extend the Form renderer to apply required class and alert the form when she submitted to pass by JQuery validate function.
JLR: I have added a required field to InternalName field in Edit Product Form. There are maybe other cases like that which should be improved...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1096293 13f79535-47bb-0310-9956-ffa450edef68
To test :
* apply patch
* apply patch from OFBiz-4262
* load seed
* Go to example and add examplePortlet2 to an example pagePortal
* Edit examplePortlet2
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1096290 13f79535-47bb-0310-9956-ffa450edef68
When you use auto-field-entity on a form , you get a nullPointer :
java.lang.NullPointerException
org.ofbiz.widget.form.ModelFormField$DisplayField.getImageLocation(ModelFormField.java:2122)
org.ofbiz.widget.form.MacroFormRenderer.renderDisplayField(MacroFormRenderer.java:193)
org.ofbiz.widget.form.ModelFormField$DisplayField.renderFieldString(ModelFormField.java:2104)
org.ofbiz.widget.form.ModelFormField.renderFieldString(ModelFormField.java:600)
org.ofbiz.widget.form.ModelForm.renderItemRow(ModelForm.java:1707)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1096140 13f79535-47bb-0310-9956-ffa450edef68
Adds the possibility to use famfamfam icons contained in framework/images/webapp/images/famfamfam/icons.
If you want use a specific icon, it's possible to define an attribute VT_ICONS_LOC that contains the location to themes icons directory to use
It improves form rendering to pass a flexible string on image-location attribute and screen and form renderer to display an image with a text.
JLR: I just added à before menus texts
After Erwan's remark I wondered If I should remove the CSS on buttons. But I finally found that it was complementary. Because when no image is used on a specific button you still have the default CSS style applied (typical for Add buttons as Erwan outlined). And when no default CSS style is applied you can have an image like now shown OTTB on print button when editing an Example. So I see these 2 features as complementary for now. Maybe one day, one will replace the other, but at this stage both are welcome IMO.
BTW the famfamfam (strange name ;o) icons lib is well done and really full of possibilities...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1095984 13f79535-47bb-0310-9956-ffa450edef68