This commit also removes the demonstration widgetVerbose setting in the Example component's web.xml file - which caused some confusion, and it comments out the setting in the web.xml file that is used for creating new components.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1172954 13f79535-47bb-0310-9956-ffa450edef68
In the createJsLanguageFileMapping service, the catch blocks have assigns to a local variable in a return statement.
Simplified further on Adrian's advice.
jleroux: I have also organized imports
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1172342 13f79535-47bb-0310-9956-ffa450edef68
Some Background : In our customization we have configured MCA to process incoming emails which is basically a custom service this service in turn calls service storeIncomingEmail, and rest of the custom code follows.
Now though we are able to receive emails (which can be seen in the communications in party manager), we have noticed that system does not some process the attachments and creates the link between communication event and content.
Analysis shows, MimeMessageWrapper.getAttachmentIndexes() while checking for content disposition, does a case sensitive comparison, which should rather be case insensitive.
This small change fixes the issue.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1172213 13f79535-47bb-0310-9956-ffa450edef68
Some value assignments to local variables without reading or using it.
jleroux: indeed I don't see any reasons to set the size of a byte array before feeding it with String.getBytes(), since NPE is handled above. I have even simplified it more using function composition style.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1172015 13f79535-47bb-0310-9956-ffa450edef68
Orig Msg:
Here is a step-by-step how the error occures:
1) Request a new password by entering your userlogin
2) Login and you will get to the "requirePasswordChange"-Page (depending on properties)
3) If you enter a wrong current password on this page the exception is thrown.
OFBiz tries to call the service "updatePassword" with a bad userLogin and an Exception is thrown:
org.ofbiz.service.ServiceAuthException: User authorization is required for this service: updatePassword [updatePassword::file:/C:/Workspace/apache_ofbiz/framework/common/servicedef/services.xml::Update a UserLogin ...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1170473 13f79535-47bb-0310-9956-ffa450edef68
* UtilValidate.is(Not)Empty wherever possible
* Remove useless boiler plate code which makes things harder to read
* if on one line w/out {}, it avoid future errors: you can't miss the block if you need to add a line
* else on one line w/out {}, it avoid future errors: you can't miss the block if you need to add a line
* no else when return in previous if
The result is a much easier code to read. I'd recommend to use this style everywhere in OFBiz. Of course this suppose a screen with larger width than in 2000 years...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1170442 13f79535-47bb-0310-9956-ffa450edef68
I also refactored, I prefer if/else with only one short expression to be on the same line, notably when return is used (then else is useless)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1169917 13f79535-47bb-0310-9956-ffa450edef68
ShoppingCart.java: a tabs has been automatically replaced by 8 spaces, fixes it
UtilValidate.java: removes useless parentheses
GeneriDao.java: fixes a wrong UtilValidate.isNotEmpty
ModelFormField.java: revert all UtilValidate.is(Not)Empty() changes though I ddid not find an error there, it must be one because https://localhost:8443/humanres/control/EditResponsibilityTypes is not rendered correctly. I will check again
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1169754 13f79535-47bb-0310-9956-ffa450edef68
Changes implementation of UtilValidate.isEmpty() for Collection and Map by using isEmpty() instead of c.size() == 0). It's more clear and as efficient. Removes also useless parentheses there.
Makes use of UtilValidate.is(Not)Empty() everywhere it makes senses. This for 2 reasons:
* Make the code more readable by replacing the (!)null/isEmpty pattern.
* Avoid possible NPEs when only isEmpty() was used (after Entity.find... for instance). I found a lot of cases (242 today) where isEmpty() could perhaps be replaced in Framework. But I guess no NPE checks were missing there and anyway it was too much for me to check them all... So I only did the relevant changes in Applications...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1169478 13f79535-47bb-0310-9956-ffa450edef68
If we setup the custom uom conversion method which is called by convertUom service, and then invoke convertUom service, the exception raised:
Could not complete the Convert UOM values...blahblah...Unknown parameter found: [convertUomCustom.asOfDate]Unknown parameter found: [convertUomCustom.defaultDecimalScale]Unknown parameter found: [convertUomCustom.defaultRoundingMode]Unknown parameter found: [convertUomCustom.purposeEnumId].
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1167480 13f79535-47bb-0310-9956-ffa450edef68
I have kept tomcat-6.0.32-tomcat-juli-adapters.jar & tomcat-6.0.32-tomcat-juli.jar and renamed them to 33, did not find any issues...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1165125 13f79535-47bb-0310-9956-ffa450edef68
Actually I hastily did it bad using static instead of caching. Anyway, I checked there are no real needs to change current code in OFBiz for perf.: one instance is in an exception and the other not called OOTB...
Was: Closes https://issues.apache.org/jira/browse/OFBIZ-4201
"DateFormat.getDateTimeInstance() is very expensive, we can cache it to improve performance"
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1165084 13f79535-47bb-0310-9956-ffa450edef68
"DateFormat.getDateTimeInstance() is very expensive, we can cache it to improve performance"
jlr: It's not really cache but a static class constant
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1165076 13f79535-47bb-0310-9956-ffa450edef68
It uses "locale" (e.g. zh_TW) to form the jquery.ui.datepicker file name in method JsLanguageFileMappingCreator.createJsLanguageFileMapping, but jquery uses dash ("-") instead of underscore ("_") to concat the language code and country code, such as zh-TW vs. zh_TW.
A very trivial update to JsLanguageFileMappingCreator.java, and after that, update the JsLanguageFileMapping.java file by running service "createJsLanguageFileMapping". In attached, contains both of patches to these two files.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1163533 13f79535-47bb-0310-9956-ffa450edef68
Nested lookup dialogs: in one lookup dialog, it opens another lookup dialog.
trivial improvements:
1. "enter" event only occurs to lookup dialog itself
2. if mouse click out side the lookup dialog, only current activated dialog closes
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1163093 13f79535-47bb-0310-9956-ffa450edef68