Summary: The purpose of this patch is to address the following:
1. Provide a standardized set of image width and height specs for page layout in ofbiz. This gives ofbiz a uniform look throughout as it applies to image display.
2. Preserve the aspect ratio of the image when using these standardized image sizes.
3. One place to make styling modifications (eg. css file).
4. Decouple styling from code (eg. java,ftl,xml,html,jsp,etc).
Regarding including the real image size, the width/height attributes in <img> specifies the boundary of the image when shown on the page. If you need to specify the real size of the image, the server code would have to perform the determination. Afterwards, you can include the actual dimensions of the image in the title attribute of <img>
Details:
Manually specifying the image width and height does help with preserving the layout of a page regardless of the image size to be shown. The challenge with this method is that the image shown on the page in question may be distorted if the aspect ratio of the image differed from that of the width and height attributes of <img>. This basically forces the person uploading the image to be more vigilant about image aspect ratios.
The purpose is to harmonize on the display size of images with a standardized set of width/height constraints in which an image must fit and preserve the aspect ratio of images.
Currently the source files (eg. ftl, xml) either manually specifies the width or height of a displayed image (ie widget <image> and html <img> tag). The problem with specifying only one constraint is that an image can affect the layout of the page if the user uploads an image where the aspect ratio could be large.
Some ftl and xml files specify both the width and the height. The problem with this is that if the aspect ratio of the image in question does not match that of the width and height of the <img> tag, the image would be displayed distorted.
The solution was to create a standardized set of CSS styles that both configure the displayed image size and preserve the image aspect ratio (eg. thumbnail size, medium size and large size). Of course, the developers can further define or modify the styles to suit their need.
By using CSS, one can change the size of displayed images without having to tamper with the ftl and/or xml files. This helps to reduce potential bugs that come with modifying the ftl and xml files. The existing way of doing things is to go through each ftl or xml file in question and manually modify the width and/or height of the <image> and/or <img> tag.
The question about the "border" around images. If you do not wish to have a border around the image, just remove it from the CSS style. It's that easy No need to change anything else. Ie. configuration to the image is done on the CSS style and not on the <image>, <img> tag.
NB: The current patch does not apply to all displayed images. I have only made appropriate modifications to widget <image> and html <img> tags that have either specified the width and/or height. There are numerous <image> and <img> tags spread all over the project that do not specify dimensions. I would have to modify them as I encountered them when I could see where and how they are displayed on the screen. Note that these images would not be affect by this patch.
jleroux: despite my efforts I was not able to check all screens. But I think it's ok
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1296782 13f79535-47bb-0310-9956-ffa450edef68
In particular these chenges should make it easier to implement JSR-223 (even if I think that we should still treat Groovy in a special way).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1296762 13f79535-47bb-0310-9956-ffa450edef68
- Addresses BIRT engine with a new POJO based runtime
- Add more content types
* Post Script
* Open Document Text
* Open Document Spreadsheet
* Open Document Presentation
- Remove warning messages at compile time
- Set an override content type in the view handler
A contribution of Chattree
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1293999 13f79535-47bb-0310-9956-ffa450edef68
I'd like to have a review of this slighly modified patch (no labels changes) by a German speaking committer or contributor.
Because some labels are replaced and my German is not good enough (it's not good at all) to be able to take a decision by myself
Here are the points I'm unsure about
- <value xml:lang="de">Forderungen</value>
+ <value xml:lang="de">Debitoren</value>
- <value xml:lang="de">Klicken Sie hier</value>
+ <value xml:lang="de">Hier klicken</value>
- <value xml:lang="de">Ansehen</value>
+ <value xml:lang="de">Suchen</value>
- <value xml:lang="de">Neues Passwort (zur Überprüfung)</value>
+ <value xml:lang="de">Neues Passwort (Wiederholung)</value>
- <value xml:lang="de">Erstellt von Benutzeranmeldung</value>
+ <value xml:lang="de">Erstellt von Benutzer</value>
- <value xml:lang="de">Zuletzt geändert von Benutzeranmeldung</value>
+ <value xml:lang="de">Zuletzt geändert von Benutzer</value>
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1293232 13f79535-47bb-0310-9956-ffa450edef68
In htmlFormMacrolLibrary.ftl, renderFormClose has containerId, hasRequiredField.
But csv, fo, text, xml FormMacroLibary.ftl don't have these fields for this macro.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1245778 13f79535-47bb-0310-9956-ffa450edef68
The return value of currentDelegatorTenantId.trim() is not assigned in org.ofbiz.webapp.control.LoginWorker.login() so trim() has no effect.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1244139 13f79535-47bb-0310-9956-ffa450edef68
* null values in Map
* BigDecimal
* correctly TimeStamp format (we use xsd:dateTime in ModelService.getTypes())
So CXF was not able to unmarshall a List of Maps with those types in them.
It does not introduce any regressions:
* A new specific SOAP null type is introduced using ("nillable","true") and ("xsi:nil","true) attributes. I had also to set the http://www.w3.org/2001/XMLSchema-instance schema on the null node. Because it was impossible to add it in the envelope header, not a big deal anyway.
* I introduced a 'T' in the TimeStamp format. It's is OK, the deserialisation handles it well (we use xsd:dateTime, see http://www.w3.org/TR/xmlschema-2/#dateTime)/. We don't handle TimeZone...
* BigDecimal was missing and is now correctly handled. I used 10 decimals and half up rounding (ROUND_HALF_UP)
Also improves the SOAPEventHandler.sendError() method by passing the serviceName in the message
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1243026 13f79535-47bb-0310-9956-ffa450edef68
- by default leave the values in the entity null
- use findOne method to get SystemProperty by primary key
- add check whether system property's value empty before using properties file
This change to make sure current users of a non tenant installation are not affected.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1239451 13f79535-47bb-0310-9956-ffa450edef68