Commit Graph
10472 Commits
Author SHA1 Message Date
Adam Heath 1aa422773b DEPRECATION: framework: getRelatedOne variants replaced with a getRelatedOne variant that takes a boolean useCache parameter.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343478 13f79535-47bb-0310-9956-ffa450edef68
2012-05-29 04:11:19 +00:00
Adam Heath 9e8ddebcac FEATURE: Add GenericValue.getRelatedOne that takes a boolean useCache parameter.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343477 13f79535-47bb-0310-9956-ffa450edef68
2012-05-29 04:10:58 +00:00
Adam Heath 7cf7538567 Deprecate all Delegator.getRelatedOne/getRelatedOneCache, and add a
version that takes a cache parameter.

This commit finishes the Delegator.getRelatedOne set of changes; the
previous methods are now deprecated, and the new ones should be used
going forward.

Delegator.getRelatedOne(String, GenericValue) is replaced by
Delegator.getRelatedOne(String, GenericValue, boolean).

Delegator.getRelatedOneCache(String, GenericValue) is replaced by
Delegator.getRelatedOne(String, GenericValue, boolean).

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343476 13f79535-47bb-0310-9956-ffa450edef68
2012-05-29 04:10:52 +00:00
Adam Heath 221b2c0312 FEATURE: Add Delegator.getRelatedOne variant that takes a boolean useCache parameter.
Rework internal GenericDelegator methods to call the new method, but no
other external classes directly call this new one yet.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343475 13f79535-47bb-0310-9956-ffa450edef68
2012-05-29 04:10:44 +00:00
Adam Heath 3482d929e7 OPTIMIZE: Replace Delegator.getRelatedOne calls with
GenericValue.getRelatedOne.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343474 13f79535-47bb-0310-9956-ffa450edef68
2012-05-29 04:10:37 +00:00
Adam Heath ce8e0a2c24 FIX: Found a local case of findByPrimaryKey usage.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343471 13f79535-47bb-0310-9956-ffa450edef68
2012-05-29 04:09:53 +00:00
Adam Heath 1ba97a3210 FIX: This is the correct fix for 1343088;
TransactionUtil.doNewTransaction was starting a new transaction, then
immediately suspending it.  This caused confusion in calling code that
tried to use doNewTransaction.  Fortunately, this was not used very
much,

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343469 13f79535-47bb-0310-9956-ffa450edef68
2012-05-29 03:55:05 +00:00
Adam Heath a2d4b1b5e3 OPTIMIZE: Change return type of noTransaction(Callable) to
NoTransaction; it used to be Callable.  NoTransaction implements
Callable.  This change requires a recompile, but is otherwise
compatible with calling code.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343468 13f79535-47bb-0310-9956-ffa450edef68
2012-05-29 03:54:58 +00:00
Adam Heath b829aa5d60 FEATURE: Change NoTransaction.call() to throw GenericEntityException
instead of Exception.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343467 13f79535-47bb-0310-9956-ffa450edef68
2012-05-29 03:54:51 +00:00
Jacopo Cappellato aa62961e63 Corrected param name in javadoc.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343303 13f79535-47bb-0310-9956-ffa450edef68
2012-05-28 15:53:41 +00:00
Jacopo Cappellato 3eecd00954 Enhanced unit test for UtilCache.putIfAbsentAndGet method to better explain its behaviour: it returns the reference to the same object passed as argument only if the key was not already found in cache.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343291 13f79535-47bb-0310-9956-ffa450edef68
2012-05-28 15:39:02 +00:00
Jacopo Cappellato 247c205188 Improved code that manages the cache:
* replaced putIfAbsent + get with putIfAbsentAndGet to avoid the risk of a NPE if the cache entry is removed (or expired) between the two calls



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343287 13f79535-47bb-0310-9956-ffa450edef68
2012-05-28 15:32:28 +00:00
Jacopo Cappellato 074c282c0c Improved code that manages the cache:
* protected the UtilCache object (static field) by making it private and final
* instead of using the "put" method, use the "putIfAbsentAndGet" method to prevent the risk of adding the new value if another concurrent thread added it in the meantime



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343278 13f79535-47bb-0310-9956-ffa450edef68
2012-05-28 15:25:46 +00:00
Jacopo Cappellato 733bb64592 Improved code that manages the cache:
* removed unnecessary synchronization  
 * protected the UtilCache object (static field) by making it private and final


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343277 13f79535-47bb-0310-9956-ffa450edef68
2012-05-28 15:02:39 +00:00
Jacopo Cappellato ed9474669c Removed an unused UtilCache static field.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343273 13f79535-47bb-0310-9956-ffa450edef68
2012-05-28 14:51:32 +00:00
Jacopo Cappellato ee53c9452b Some cleanups and changes to logging configuration:
* some misc formatting and changes to comments
* removed the old and unused configuration for minerva
* added a new file appender for Tomcat where all Tomcat internal logging is now redirected 
* changed internal logging for FOP from info to warn to be consistent with the settings of other external components (Tomcat, Geronimo Transaction Manager, Freemarker)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343269 13f79535-47bb-0310-9956-ffa450edef68
2012-05-28 14:41:50 +00:00
Jacopo Cappellato 0fb93cc33b Removed a bunch of unused jars imported from the Tomcat distribution and replaced with the ones in the "Embedded" distribution.
For details about the upgrade process for future Tomcat releases see my notes:
  https://cwiki.apache.org/confluence/display/OFBTECH/How+to+upgrade+the+embedded+Tomcat


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343263 13f79535-47bb-0310-9956-ffa450edef68
2012-05-28 14:22:15 +00:00
Jacopo Cappellato 7c91aaa74f OFBIZ-4901 Upgraded icu4j from version 4.4 to version 49.1; thanks to Deepak Dixit for the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343261 13f79535-47bb-0310-9956-ffa450edef68
2012-05-28 14:05:29 +00:00
Adrian Crum 1002cfb510 Mini-language JavaDocs. No functional change.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343174 13f79535-47bb-0310-9956-ffa450edef68
2012-05-28 09:30:49 +00:00
Jacques Le Roux 6075bed667 Missed this because I had some other changes pending
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343154 13f79535-47bb-0310-9956-ffa450edef68
2012-05-28 07:15:42 +00:00
Jacques Le Roux b48ff3a62c Closes "Move SHARK to Attic" https://issues.apache.org/jira/browse/OFBIZ-4795
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343064 13f79535-47bb-0310-9956-ffa450edef68
2012-05-27 15:47:32 +00:00
Jacques Le Roux 7730a12e22 Renames nekohtml.jar to nekohtml-1.9.7.jar (found in MANIFEST) see http://nekohtml.sourceforge.net/index.html
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343038 13f79535-47bb-0310-9956-ffa450edef68
2012-05-27 12:33:17 +00:00
Adrian Crum 28c894cd6f Overhauled Mini-language <find-by-and> element.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343035 13f79535-47bb-0310-9956-ffa450edef68
2012-05-27 12:06:41 +00:00
Jacques Le Roux baa73733d2 Where it shows that maintaining help is not that easy. Unlike Javadoc you don't have under eyes when changing things
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343030 13f79535-47bb-0310-9956-ffa450edef68
2012-05-27 10:41:13 +00:00
Jacques Le Roux 720578ecf3 Replaces all remaining title="${uiLabelMap.CommonEmptyHeader}" by title=" ", and specific case in ListPartyCommEvents
This closes the CommonEmptyHeader chapter

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343016 13f79535-47bb-0310-9956-ffa450edef68
2012-05-27 08:41:47 +00:00
Jacques Le Roux 621a487c35 Closes "Logs not generating on linux" https://issues.apache.org/jira/browse/OFBIZ-4877
I removed log4j-over-slf4j from trunk at in order to have logs in official Trunk demo. THis is part of the JCR effort which should be removed from trunk anyway since Sascha recreated a new JCR branch. I let him handle the rest...

I guess [Bridging legacy APIs|http://www.slf4j.org/legacy.html] has not been followed in details 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1342893 13f79535-47bb-0310-9956-ffa450edef68
2012-05-26 13:05:35 +00:00
Jacques Le Roux e3e7491611 I just learned today that now for regions to be associated with a state a country needs a CountryAddressFormat. I guess this is related Sascha's changes for GBR (he introduced the GROUP_MEMBER notion), but I could be wrong
This fixes Swiss cantons wich now appears at https://localhost:8443/example/control/FormWidgetExamples#DropDownFieldsExampleForm_stateProvinceGeoId_title

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1342874 13f79535-47bb-0310-9956-ffa450edef68
2012-05-26 10:03:04 +00:00
Jacques Le Roux 5f732182bd Forgot to save pending change in Eclipse, thanks to Adrian who noticed it
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1342871 13f79535-47bb-0310-9956-ffa450edef68
2012-05-26 09:35:02 +00:00
Adrian Crum 2bab33d7aa Overhauled Mini-language <filter-list-by-date> element.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1342854 13f79535-47bb-0310-9956-ffa450edef68
2012-05-26 05:01:00 +00:00
Adrian Crum 19870304f9 Added a missing license header.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1342850 13f79535-47bb-0310-9956-ffa450edef68
2012-05-26 04:11:41 +00:00
Jacques Le Roux 463be6851d Thanks to Martin Kaiser report on dev ML, cleans geo data a bit
Use Swiss geo data. To be consistent I have also renamed GeoData_CHE.xml to GeoData_CH.xml. 

While at it I also renamed GeoData_IRL.xml to GeoData_IE.xml , renamed things internally, and extracted the  North Ireland geo data from it to GeoData_UK.xml where it actually belongs


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1342846 13f79535-47bb-0310-9956-ffa450edef68
2012-05-26 03:56:52 +00:00
Jacques Le Roux c62a93044a Forget to document the value option for redirect-parameter (not a big deal, pretty obvious, so I don't backport)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1342567 13f79535-47bb-0310-9956-ffa450edef68
2012-05-25 10:47:00 +00:00
Jacopo Cappellato 8de34f3f44 Upgraded Ant from 1.8.3 to 1.8.4 and "Commons Compress" from 1.4 to 1.4.1 in order to protect the system from vulnerability reported in CVE-2012-2098: Apache Commons Compress and Apache Ant denial of service vulnerability.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1342326 13f79535-47bb-0310-9956-ffa450edef68
2012-05-24 16:36:09 +00:00
Jacopo Cappellato 8c28b9751b Modified validation query (executed by DBCP to verify that a connection is valid before borrowing it) to remove dependency on the the "example" component; thanks to Adam Heath and Jacques Le Roux for the suggestions and tests to find out a proper SQL statement (db independent and efficient).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1342310 13f79535-47bb-0310-9956-ffa450edef68
2012-05-24 16:12:05 +00:00
Jacopo Cappellato c42b1ffb2e Removed the definition of the FreeMarkerViewHandler handler from common-controller and added to the only controller that still uses it (the one of the "webtools" component, and only for one test page).
The main motivation for this is that FreeMarkerViewHandler creates (via OfbizCacheStorage) an unused static instance of UtilCache per object (i.e. for each webapp at init time), wasting system resources and cluttering the list of cache objects in Webtools.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1342308 13f79535-47bb-0310-9956-ffa450edef68
2012-05-24 16:03:29 +00:00
Ashish Vijaywargiya 6cba6c06b4 Fixing important bug that we have observed in one of the production system. This error comes when production system generates lot of JobSandbox records. And sometime it happens that purgeOldJobs service tries to remove RuntimeData from the system but runtimeDataId is still referred in JobSandbox records. To fix this bug we have separated out the code for deleting RuntimeData. We have also tested this fix on production system for about two weeks and now things are better over there. Thanks Jacopo for the discussion.
Here I am sharing console log for everyones reference: 
f9cb9ec37f8ed14 Apr 28, 2012 10:47:46 PM org.apache.jk.common.ChannelSocket processConnection
f9cb9ec37f8f0fc WARNING: processCallbacks status 2
f9cbcd4388830dc 2012-04-28 23:00:10,947 (default-invoker-Thread-781938) [ GenericDelegator.java:1163:ERROR] 
f9cbcd4388834c4 ---- exception report ----------------------------------------------------------
f9cbcd4388838ac Failure in removeByCondition operation for entity [RuntimeData]: org.ofbiz.entity.GenericDataSourceException: Generic Entity Exception occured in deleteByCondition (SQL Exception while executing the following:DELETE FROM public.RUNTIME_DATA WHERE (RUNTIME_DATA_ID = '45794') (ERROR: update or delete on table "runtime_data" violates foreign key constraint "job_sndbx_rntmdta" on table "job_sandbox"
f9cbcd43888d4ec Detail: Key (runtime_data_id)=(45794) is still referenced from table "job_sandbox".)). Rolling back transaction.
f9cbcd43888e48c Exception: org.ofbiz.entity.GenericDataSourceException
f9cbcd43888e874 Message: Generic Entity Exception occured in deleteByCondition (SQL Exception while executing the following:DELETE FROM public.RUNTIME_DATA WHERE (RUNTIME_DATA_ID = '45794') (ERROR: update or delete on table "runtime_data" violates foreign key constraint "job_sndbx_rntmdta" on table "job_sandbox"
f9cbcd43888ffe4 Detail: Key (runtime_data_id)=(45794) is still referenced from table "job_sandbox".))
f9cbcd4388903cc ---- cause ---------------------------------------------------------------------
f9cbcd438890b9c Exception: org.ofbiz.entity.GenericDataSourceException
f9cbcd438890f84 Message: SQL Exception while executing the following:DELETE FROM public.RUNTIME_DATA WHERE (RUNTIME_DATA_ID = '45794') (ERROR: update or delete on table "runtime_data" violates foreign key constraint "job_sndbx_rntmdta" on table "job_sandbox"
f9cbcd43889136c Detail: Key (runtime_data_id)=(45794) is still referenced from table "job_sandbox".)
f9cbcd438895da4 ---- cause ---------------------------------------------------------------------
f9cbcd43889618c Exception: org.postgresql.util.PSQLException
f9cbcd43889618c Message: ERROR: update or delete on table "runtime_data" violates foreign key constraint "job_sndbx_rntmdta" on table "job_sandbox"
f9cbcd438896574 Detail: Key (runtime_data_id)=(45794) is still referenced from table "job_sandbox".
f9cbcd43889712c ---- stack trace ---------------------------------------------------------------
f9cbcd43889712c org.postgresql.util.PSQLException: ERROR: update or delete on table "runtime_data" violates foreign key constraint "job_sndbx_rntmdta" on table "job_sandbox"
f9cbcd43889889c Detail: Key (runtime_data_id)=(45794) is still referenced from table "job_sandbox".
f9cbcd43889889c org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2103)
f9cbcd438898c84 org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1836)
f9cbcd438899454 org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:257)
f9cbcd43889983c org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:512)
f9cbcd43889983c org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:388)
f9cbcd438899c24 org.postgresql.jdbc2.AbstractJdbc2Statement.executeUpdate(AbstractJdbc2Statement.java:334)
f9cbcd43889a3f4 org.apache.commons.dbcp.DelegatingPreparedStatement.executeUpdate(DelegatingPreparedStatement.java:105)
f9cbcd43889a7dc org.apache.commons.dbcp.DelegatingPreparedStatement.executeUpdate(DelegatingPreparedStatement.java:105)
f9cbcd43889abc4 org.ofbiz.entity.jdbc.SQLProcessor.executeUpdate(SQLProcessor.java:420)
f9cbcd43889abc4 org.ofbiz.entity.datasource.GenericDAO.deleteByCondition(GenericDAO.java:1158)
f9cbcd43889bb64 org.ofbiz.entity.datasource.GenericDAO.deleteByCondition(GenericDAO.java:1132)
f9cbcd43889bf4c org.ofbiz.entity.datasource.GenericHelperDAO.removeByCondition(GenericHelperDAO.java:160)
f9cbcd43889c334 org.ofbiz.entity.GenericDelegator.removeByCondition(GenericDelegator.java:1152)
f9cbcd43889c334 org.ofbiz.entity.GenericDelegator.removeByAnd(GenericDelegator.java:1120)
f9cbcd43889cb04 org.ofbiz.entity.GenericDelegator.removeByAnd(GenericDelegator.java:1105)
f9cbcd43889ceec org.ofbiz.entity.GenericDelegator.removeByAnd(GenericDelegator.java:1098)
f9cbcd43889ceec org.ofbiz.service.ServiceUtil.purgeOldJobs(ServiceUtil.java:476)
f9cbcd43889d2d4 sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
f9cbcd43889d2d4 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
f9cbcd43889de8c sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
f9cbcd43889de8c java.lang.reflect.Method.invoke(Method.java:597)
f9cbcd43889e274 org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
f9cbcd43889e274 org.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
f9cbcd43889f5fc org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:396)
f9cbcd43889f9e4 org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:224)
f9cbcd43889f9e4 org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
f9cbcd43889fdcc org.ofbiz.service.job.GenericServiceJob.exec(GenericServiceJob.java:71)
f9cbcd43889fdcc org.ofbiz.service.job.JobInvoker.run(JobInvoker.java:242)
f9cbcd4388a3c4c java.lang.Thread.run(Thread.java:662)
f9cbcd4388a3c4c --------------------------------------------------------------------------------
f9cbcd4388a4034 
 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1341770 13f79535-47bb-0310-9956-ffa450edef68
2012-05-23 07:57:31 +00:00
Adrian Crum 3da5a8a129 Oops, forgot to add validation to the <filter-list-by-and> element.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1341408 13f79535-47bb-0310-9956-ffa450edef68
2012-05-22 11:13:26 +00:00
Jacques Le Roux 0157ddcbda 2 missing ASL2 headers, while at it...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1341399 13f79535-47bb-0310-9956-ffa450edef68
2012-05-22 10:57:13 +00:00
Adrian Crum 75fe3886a4 Overhauled Mini-language <filter-list-by-and> element.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1341397 13f79535-47bb-0310-9956-ffa450edef68
2012-05-22 10:44:31 +00:00
Adrian Crum 6a6ad86bc3 Overhauled Mini-language <entity-one> element.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1341348 13f79535-47bb-0310-9956-ffa450edef68
2012-05-22 08:28:02 +00:00
Adam Heath 0f2788d388 FIX: Remove "null" from the context, so that the real 'null' token can
be used.  What was occuring previously, was that any use of "null" would
actually end up using GenericEntity.NullField, which has a string value
of "[null-field]".

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1341094 13f79535-47bb-0310-9956-ffa450edef68
2012-05-21 16:22:57 +00:00
Adam Heath 0b90e34124 FEATURE: SimpleMethod was putting a "nullField" =
GenericEntity.NullField into each context, but ModelScreen wasn't.  Now
they are the same.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1341093 13f79535-47bb-0310-9956-ffa450edef68
2012-05-21 16:22:49 +00:00
Adrian Crum 273010c771 Temporarily disable Mini-language validation until the overhaul is finished and the invalid/deprecated code is fixed.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1341075 13f79535-47bb-0310-9956-ffa450edef68
2012-05-21 15:35:02 +00:00
Adam Heath 49c0e405a9 FEATURE: Upgrade freemarker to a custom version that contains an
upcoming fix, filed in bug upstream at:
https://sourceforge.net/tracker/?func=detail&atid=100794&aid=3527625&group_id=794

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1341056 13f79535-47bb-0310-9956-ffa450edef68
2012-05-21 14:40:23 +00:00
Adam Heath 7c59f9068e OPTIMIZE: Add a static method that configures a BeansWrapper instance
for ofbiz use.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1341055 13f79535-47bb-0310-9956-ffa450edef68
2012-05-21 14:40:13 +00:00
Adam Heath 410079c235 OPTIMIZE: Move the getDefaultOfbizWrapper to earlier in the class; this
reflects the notion that BeansWrapper needs to be accessed/configured
earlier than Configuration, so ideally should come earlier in the list
of methods.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1341054 13f79535-47bb-0310-9956-ffa450edef68
2012-05-21 14:40:05 +00:00
Adam Heath 2e5e25fdce OPTIMIZE: In v1340631, the new FreeMarkerImport was placed in the wrong
block of imports, this change fixes it.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1341052 13f79535-47bb-0310-9956-ffa450edef68
2012-05-21 14:39:51 +00:00
Adam Heath a76bc2e73b FIX: In v1340631, a change was introduced in a comment; however, that
referenced a public static variable, it really should have called the
public static method introduced in that same commit.  This happened
because the change wasn't reviewed before it was committed.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1341051 13f79535-47bb-0310-9956-ffa450edef68
2012-05-21 14:39:44 +00:00
Jacques Le Roux db3f521441 Typo
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1340944 13f79535-47bb-0310-9956-ffa450edef68
2012-05-21 09:21:41 +00:00
Jacques Le Roux ec604e54eb Forgot this trick, thanks to Si Chen cookbook...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1340943 13f79535-47bb-0310-9956-ffa450edef68
2012-05-21 09:20:58 +00:00