Commit Graph
10472 Commits
Author SHA1 Message Date
Jacques Le Roux ae5d3b4045 Fixed: NotSerializableException using uploadPartyContentFile service (OFBIZ-12050)
This error appears after trying to upload a file to party content:

2020-11-06 07:48:22,488 |jsse-nio-8443-exec-7 |RequestHandler                |I|
Sending redirect to:
[https://localhost:8443/partymgr/control/viewprofile?partyId=admin].
2020-11-06 07:48:29,288 |jsse-nio-8443-exec-7 |UtilObject                    |E|
null
java.io.NotSerializableException: org.apache.commons.fileupload.disk.DiskFileItem
2020-11-06 10:59:58 +01:00
Jacques Le Roux 21e5f215f1 Fixed: Sorting of lists generates undesired results (OFBIZ-8302)
Workaround for an issue reported by
MacroFormRendererTest::renderSortFieldUsesQueryString
Put in with "MacroFormRenderer refactoring" (OFBIZ-11456)

I put a FIXME as I'm not sure how to handle it in a reasonable time :/
2020-11-01 17:43:07 +01:00
Jacques Le Roux f2632b90c5 Fixed: Sorting of lists generates undesired results (OFBIZ-8302)
Fixes an issue reported by UtilHttpTest::emptyParameterMap

More to come for MacroFormRendererTest::renderSortFieldUsesQueryString

Both put in with "MacroFormRenderer refactoring" (OFBIZ-11456)
2020-11-01 10:47:31 +01:00
Jacques Le Roux cd242ea34c Fixed: Sorting of lists generates undesired results (OFBIZ-8302)
For this issue (OFBIZ-8302) I reverted the point 1 of
http://svn.apache.org/viewvc?view=revision&revision=1759555

As reported by Alvaro Munoz from GH security team it's not sufficient:
<<the second part of the fix was not effective, since the attacker can close the
raw string context with a double quote and write a new attribute or even close
the macro tag and write arbitrary FreeMarker code.>>

So this removes the 2nd part and add better solution to fix the OFBIZ-8302 issue
The solution is to encode only the QueryString and to handle it correctly in
UtilHttp::getParameterMap. I must say it was not a sinecure!
2020-10-31 20:21:32 +01:00
holivier 37c075b1f5 Documented: migration to help system using asciidoc files (OFBIZ-11587)
remove in plugin creation gradle task, files related to docbook help
2020-10-26 17:34:04 +01:00
holivier 302bc0eb15 Documented: migration to help system using asciidoc files (OFBIZ-11587)
Remove all related help docbook files
2020-10-26 17:34:03 +01:00
James Yong 127cd86da7 Improved: Open Screen file from browser (OFBIZ-12038)
Refactoring
2020-10-11 09:18:58 +08:00
James Yong a983c7741c Improved: Open Form Widget (Single Type) source file from browser (OFBIZ-12041)
Add function to open the corresponding Form Widget file with IDE
when the named border is clicked from browser.
Dependent on widget.dev.namedBorder and widget.dev.cmd.openSourceFile properties.

Thanks Jacques for review
2020-10-11 08:37:39 +08:00
James Yong cbbcb14119 Improved: Open Screen file from browser (OFBIZ-12038)
Refactoring
2020-10-10 18:06:14 +08:00
James Yong 0088af8b90 Fixed: Open Screen file from browser (OFBIZ-12038)
Fix regresssions in integration tests
2020-10-10 16:29:41 +08:00
James Yong 5fca2ed58d Improved: Open Screen file from browser (OFBIZ-12038)
Refactoring
2020-10-10 12:39:43 +08:00
James Yong 0e40d9f091 Improved: Open Screen file from browser (OFBIZ-12038)
Allow the opening of screen definition that contributed to the web page from the browser. Command to open the file is set at widget.dev.cmd.openSourceFile.

Thanks Jacques for review.
2020-10-08 15:28:43 +08:00
Jacques Le Roux a8b252f7dd Reverted: "description" and "comment" datatypes unnecessarily limited to 255 char (OFBIZ-12021)
This reverts commit 8736162c74.

We have test integration issues to fix

Due to TortoiseGIt, something weird happened, confused me to revert the revert :/
2020-10-03 13:41:41 +02:00
Jacques Le Roux 8736162c74 Reverted: "description" and "comment" datatypes unnecessarily limited to 255 char (OFBIZ-12021)
This reverts commit 686f01c8cf.

We have test integration issues to fix
2020-10-03 13:30:15 +02:00
Jacques Le Roux 8ef3b54c22 Reverted: "description" and "comment" datatypes unnecessarily limited to 255 char (OFBIZ-12021)
This reverts commit 686f01c8cf.

We have test integration issues to fix
2020-10-03 13:28:10 +02:00
Jacques Le Roux 686f01c8cf Improved: "description" and "comment" datatypes unnecessarily limited to 255 char (OFBIZ-12021)
"Description" and "comment" fields are restricted to 255 char.

However after some research I found that all the supported databases support
longer then 255 char
I would expect users to want to write more then 255 char in a comment
(I know I personally can).

A discussion has been started on dev ML:
https://markmail.org/message/7utrgejc2c44i37u

Also adds a note in DATAMODEL_CHANGES.adoc

Thanks: ddev
2020-10-03 11:26:27 +02:00
James Yong 582e6c6ac9 Improved: Open FTL File from browser (OFBIZ-12018)
Comment + Rename method
2020-10-03 11:08:14 +08:00
holivier 7c7eae2f84 Improved: Error messages when generating HTML and PDF file from AsciiDoc files (OFBIZ-11893)
sy-impersonation.adoc minor correction,
* imagesDir cannot be out of asciidoc directory because content of it s copied in build directory when document is generated
* internal link to go to sub-section security was wrong because securty automatic anchor is generate for general security chapter
2020-10-02 18:23:14 +02:00
James Yong aa8ae4b01e Improved: Move SeoConfigUtil.java from Product to Widget component (OFBIZ-12031)
Help to remove dependency of product component from widget component
An afterthought: webapp component seems better for SeoConfigUtil.java than widget component.

Thanks Jacques for review
2020-10-02 22:57:15 +08:00
James Yong 10fbedbce0 Fixed: Open FTL File from browser (OFBIZ-12018)
Not able to open source file when clicking on named border in ecomseo landing page

Thanks Jacques for reporting
2020-10-02 20:33:44 +08:00
James Yong f15c037e07 Fixed: Open FTL File from browser (OFBIZ-12018)
Some named borders were hidden in ecomseo landing page
2020-09-30 19:16:53 +08:00
James Yong 91d8a2f02a Improved: multi-block attribute for html-template tag (OFBIZ-11686)
Form getJs link according to SEO Config setting
2020-09-28 21:54:25 +08:00
James Yong c911019856 Improved: Open FTL File from browser (OFBIZ-12018)
Better usability when clicking on named border
2020-09-28 21:50:01 +08:00
holivier 9eaf180a4b Documented: migration to help system using asciidoc files
(OFBIZ-11587)

Add <set field=helpAnchor... in CommonScreens for application where it's
not present. With this commit all OFBiz application help go to the html
generated from asciidoc files
2020-09-28 15:15:04 +02:00
Suraj Khurana acdddaf85c Improved: Corrected some spacing issues in code, where there are extra white spaces, this will fix some checkstyle issues in framework component.
(OFBIZ-12022)
2020-09-26 14:01:43 +05:30
James Yong 4b8dd2a06b Fixed: Open FTL File from browser (OFBIZ-12018)
Unable to open file in Windows

Thanks Jacques for reporting.
2020-09-25 22:44:46 +08:00
James Yong d7a5d601bd Fixed: Open FTL File from browser (OFBIZ-12018)
StringIndexOutOfBoundsException error in Windows

Thanks Jacques for reporting.
2020-09-25 13:00:34 +08:00
James Yong ad2e8de7c2 Improved: Open FTL File from browser (OFBIZ-12018)
Add function to open the corresponding FTL file with IDE
when the named border is clicked from browser.

Thanks Rishi and Jacques for review
2020-09-24 21:36:24 +08:00
Jacques Le Roux ee8bd3f5d4 Fixes a JavaDoc issue 2020-09-24 10:32:06 +02:00
Jacques Le Roux f1b88bd84b Improved: Checkstyle: Variable name must match pattern (OFBIZ-11926)
Better use Debug.logVerbose in place where I replaced missing expression with
another varation of Debug.log. We mainly don't need these information, it's only
for Checkstyle.

I thought did not replace cases where using another variation makes sense
2020-09-21 10:45:03 +02:00
James Yong 2cc3ab0f66 Fixed: Show border and file name for content rendered from ftl (OFBIZ-12002)
Error in testIntegration

Thanks Jacques for reporting
2020-09-19 23:34:53 +08:00
James Yong 17e2ded1cc Improved: multi-block attribute for html-template tag (OFBIZ-11686)
Move getJs and js request mapping out of "AJAX events" comments block
2020-09-19 10:04:18 +08:00
Girish Vasmatkar 31a6171c0b Fixed: Issue in OpenAPI generation due to duplicate ModelParam in the IN model param list. Added a BinaryOperarion function
to account for duplicates(OFBIZ-11328)
2020-09-18 16:26:18 +05:30
James Yong 347c905674 Improved: Show border and file name for content rendered from ftl (OFBIZ-12002)
New property “widget.dev.namedBorder” to control the display of the named border

Thanks Michael for review
2020-09-18 14:37:36 +08:00
James Yong d4713fa647 Improved: Remove formatBoundaryComment function in HtmlWidgetRenderer class (OFBIZ-12015)
Use buildBoundaryComment function instead of formatBoundaryComment function. Both functions do the same thing.

Thanks: Jacques for review
2020-09-17 21:11:07 +08:00
Jacques Le Roux ae8b2d89b0 Improved: Checkstyle: Variable name must match pattern (OFBIZ-11926)
Removes last remaining "Must have at least one statement" issues by using
Debug.logVerbose

Decreases tasks.checkstyleMain.maxErrors from 543 to 535

Thanks: Suraj for report
2020-09-16 10:30:37 +02:00
Jacques Le Roux 231f97f030 Improved: Demo Data in conflict with Entity Unique Index when loading data during creation (OFBIZ-11998)
This is a known issue with MsSQL since
http://ofbiz.135035.n4.nabble.com/Unique-constraint-on-Person-cardId-breaks-ofbiz-on-SQL-Server-td4656840.html
The problem does not exist with Derby, nor with the mostly open source DBMS
used with OFBiz: Postres, MySQL, MariaDB, etc.
So we will not change the current OOTB setting and suggest to simply change
your own configuration

Thanks: Schumann Ye for report
2020-09-16 09:09:06 +02:00
Jacques Le Roux 346c63bfdf Improved: Checkstyle: Variable name must match pattern (OFBIZ-11926)
We have a lot of "do nothing" in Java code. In case of catch we should at least
have Debug.logError(e, MODULE); and maybe an explanation in the comment.
2020-09-15 15:24:45 +02:00
Jacques Le Roux 71e027d3a1 Documented: Error while decoding url parameters with percent character (OFBIZ-12014)
Just a comment to clarify
2020-09-14 11:53:02 +02:00
Jacques Le Roux 748e6c3452 Fixed: Error while decoding url parameters with percent character (OFBIZ-12014)
This has been already fixed (an clearly explained) in OFBIZ-10275 and broken
again in OFBIZ-11822

Thanks: Pradeep Choudhary
2020-09-14 11:18:28 +02:00
Suraj Khurana 02bb30ec61 Merge branch 'trunk' of https://gitbox.apache.org/repos/asf/ofbiz-framework into trunk 2020-09-13 11:29:46 +05:30
Suraj Khurana a5619831eb Improved: Added missing Javadocs for remaining methods in framework component, this is required for all classes which looks like designed for extension (can be subclassed).
(OFBIZ-11947)
Thanks Jacques for review.
2020-09-13 11:28:00 +05:30
James Yong b18dd6a9ce Improved: Show border and file name for content rendered from ftl (OFBIZ-12002)
To reduce the need to view the page source from the browser.
Activated when print.verbose=true and widget.verbose=true.

Thanks: Jacques for review
2020-09-12 20:10:08 +08:00
Suraj Khurana 97b1688b0d Improved: Make data members of class as private and added accessor methods for the same, also corrected occurences of the same in framework component.
(OFBIZ-11963)
Also made some related checkstyle code enhancements. Thanks Jacques for review.
2020-09-12 12:05:16 +05:30
James Yong 8c4a19118d Refactor ThemeFactory.java 2020-09-11 20:14:58 +08:00
holivier 93eb9c65a2 Documented: Framework, migration all docbook files to asciidoc
(OFBIZ-11587)

- Correction on tag added in README.adoc, wrong comment characters,
- and correction in included:: in unit-tests.adoc to have correct
paragraph level
2020-09-10 15:27:40 +02:00
Jacques Le Roux a74eac0060 Fixed: Well-formed html in ftl template (OFBIZ-11996)
Fixes Java method names issues

Thanks: Girish
2020-09-10 12:31:22 +02:00
James Yong 161c0c0c05 Improved: Well-formed html in ftl template (OFBIZ-11996)
refactoring + add test case
2020-09-10 17:12:36 +08:00
James Yong aab02b5142 Improved: Well-formed html in ftl template (OFBIZ-11996)
Add code to check closing tags and refactoring
2020-09-10 13:10:32 +08:00
James Yong cac8c27477 Improved: Allow <html-template> to accept CDATA (OFBIZ-7004)
Fix cvc-complex-type.2.1 error
2020-09-10 10:13:28 +08:00