This error appears after trying to upload a file to party content:
2020-11-06 07:48:22,488 |jsse-nio-8443-exec-7 |RequestHandler |I|
Sending redirect to:
[https://localhost:8443/partymgr/control/viewprofile?partyId=admin].
2020-11-06 07:48:29,288 |jsse-nio-8443-exec-7 |UtilObject |E|
null
java.io.NotSerializableException: org.apache.commons.fileupload.disk.DiskFileItem
Workaround for an issue reported by
MacroFormRendererTest::renderSortFieldUsesQueryString
Put in with "MacroFormRenderer refactoring" (OFBIZ-11456)
I put a FIXME as I'm not sure how to handle it in a reasonable time :/
Fixes an issue reported by UtilHttpTest::emptyParameterMap
More to come for MacroFormRendererTest::renderSortFieldUsesQueryString
Both put in with "MacroFormRenderer refactoring" (OFBIZ-11456)
For this issue (OFBIZ-8302) I reverted the point 1 of
http://svn.apache.org/viewvc?view=revision&revision=1759555
As reported by Alvaro Munoz from GH security team it's not sufficient:
<<the second part of the fix was not effective, since the attacker can close the
raw string context with a double quote and write a new attribute or even close
the macro tag and write arbitrary FreeMarker code.>>
So this removes the 2nd part and add better solution to fix the OFBIZ-8302 issue
The solution is to encode only the QueryString and to handle it correctly in
UtilHttp::getParameterMap. I must say it was not a sinecure!
Add function to open the corresponding Form Widget file with IDE
when the named border is clicked from browser.
Dependent on widget.dev.namedBorder and widget.dev.cmd.openSourceFile properties.
Thanks Jacques for review
Allow the opening of screen definition that contributed to the web page from the browser. Command to open the file is set at widget.dev.cmd.openSourceFile.
Thanks Jacques for review.
This reverts commit 8736162c74.
We have test integration issues to fix
Due to TortoiseGIt, something weird happened, confused me to revert the revert :/
"Description" and "comment" fields are restricted to 255 char.
However after some research I found that all the supported databases support
longer then 255 char
I would expect users to want to write more then 255 char in a comment
(I know I personally can).
A discussion has been started on dev ML:
https://markmail.org/message/7utrgejc2c44i37u
Also adds a note in DATAMODEL_CHANGES.adoc
Thanks: ddev
sy-impersonation.adoc minor correction,
* imagesDir cannot be out of asciidoc directory because content of it s copied in build directory when document is generated
* internal link to go to sub-section security was wrong because securty automatic anchor is generate for general security chapter
Help to remove dependency of product component from widget component
An afterthought: webapp component seems better for SeoConfigUtil.java than widget component.
Thanks Jacques for review
(OFBIZ-11587)
Add <set field=helpAnchor... in CommonScreens for application where it's
not present. With this commit all OFBiz application help go to the html
generated from asciidoc files
Better use Debug.logVerbose in place where I replaced missing expression with
another varation of Debug.log. We mainly don't need these information, it's only
for Checkstyle.
I thought did not replace cases where using another variation makes sense
Removes last remaining "Must have at least one statement" issues by using
Debug.logVerbose
Decreases tasks.checkstyleMain.maxErrors from 543 to 535
Thanks: Suraj for report
We have a lot of "do nothing" in Java code. In case of catch we should at least
have Debug.logError(e, MODULE); and maybe an explanation in the comment.
(OFBIZ-11587)
- Correction on tag added in README.adoc, wrong comment characters,
- and correction in included:: in unit-tests.adoc to have correct
paragraph level