Jacques Le Roux
e07ab48fb4
Some cleaning related to is(Not)Empty
...
* remove duplicate ()
* remove casts no longer needed
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@885103 13f79535-47bb-0310-9956-ffa450edef68
2009-11-28 15:46:52 +00:00
Jacques Le Roux
569a4afeea
Some cleaning related to isEmpty
...
* remove duplicate ()
* remove casts no longer needed
I'm doing these last tasks around isEmpty and isNotEmpty mostly to be sure that nothing has slipped in. Despite I have been very careful, I prefer double check.
+ one typo in ofbizSelenium help (not sure this file is used yet though, seems to be missing some parts which are commented out, for now I guess)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@885093 13f79535-47bb-0310-9956-ffa450edef68
2009-11-28 14:08:16 +00:00
Jacques Le Roux
2777b83223
Fix r885091 where isNotEmpty has been used by error instead of isEmpty
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@885092 13f79535-47bb-0310-9956-ffa450edef68
2009-11-28 13:59:45 +00:00
Jacques Le Roux
5d4b9b5982
More uses of isEmpty(expr) instead of (expr == null) || (expr.size() == 0
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@885091 13f79535-47bb-0310-9956-ffa450edef68
2009-11-28 13:31:52 +00:00
Adam Heath
d68d9fb287
None of the stats values were protected with any kind of locking. The
...
The jvm doesn't guarantee anything about ++ operations; they are *not*
single commands. This is even more of a problem with 64 bit longs on a
32 bit jvm, where even a read or a write to/from a long may be multiple
commands. It is entirely possible that a write to a long might be
partially read by another thread.
The fix is either to protected all the stats with a synchronized block,
either a single one, or one per stat, or to use the new java 1.5 atomic
variables. The latter is much better, because most of the time no one
is reading the stats, so there is hardly ever any contention.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884984 13f79535-47bb-0310-9956-ffa450edef68
2009-11-27 20:26:06 +00:00
Bruno Busco
884d5c0397
An additional patch from Sascha Rodekamp "Drag'n'Drop update - add directly in the my portal application"
...
(https://issues.apache.org/jira/browse/OFBIZ-3227 ) - OFBIZ-3227
I found a bug while using the IE
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884891 13f79535-47bb-0310-9956-ffa450edef68
2009-11-27 15:04:45 +00:00
Bruno Busco
683f95cee3
A patch from Sascha Rodekamp "Drag'n'Drop update - add directly in the my portal application"
...
(https://issues.apache.org/jira/browse/OFBIZ-3227 ) - OFBIZ-3227
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884864 13f79535-47bb-0310-9956-ffa450edef68
2009-11-27 12:52:11 +00:00
Jacques Le Roux
fbae8a234f
A patch from Patrick Antivackis "In owasp-esapi-java, htmlCodec.decode is broken for all entities where entity.substr(0, x) exists ." ( https://issues.apache.org/jira/browse/OFBIZ-3135 ) - OFBIZ-3135
...
I checked the diff Patrick provided against http://code.google.com/p/owasp-esapi-java/source/detail?r=755 and found no differences (except test classes no present of course)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884781 13f79535-47bb-0310-9956-ffa450edef68
2009-11-27 08:26:54 +00:00
Jacques Le Roux
e26e66c8c3
Oops, I forgot to commit this file in r884545
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884598 13f79535-47bb-0310-9956-ffa450edef68
2009-11-26 15:42:46 +00:00
Jacques Le Roux
c0ccc25289
No duplicates, alphabetical order (at least in English, hopefully more to come regardind this aspect)
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884573 13f79535-47bb-0310-9956-ffa450edef68
2009-11-26 14:59:11 +00:00
Jacques Le Roux
2c51efbc09
Better version of isEmpty() with comments from Scott and Adam on dev ML.
...
I used one line, please feel free to comment if needed
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884545 13f79535-47bb-0310-9956-ffa450edef68
2009-11-26 13:09:40 +00:00
Adam Heath
e650de55f1
Fix build error, caused by bad merge from an old branch.
...
GenericDelegator was used instead of Delegator.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884373 13f79535-47bb-0310-9956-ffa450edef68
2009-11-26 02:30:10 +00:00
Adam Heath
1d148ce235
Helper method to fetch all rows/values from a query.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884363 13f79535-47bb-0310-9956-ffa450edef68
2009-11-26 01:33:38 +00:00
Adam Heath
586bedfa70
for all doTransaction helpers, change Throwable to
...
GenericEntityException.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884362 13f79535-47bb-0310-9956-ffa450edef68
2009-11-26 01:33:03 +00:00
Adam Heath
3a6becca71
For unimplemented values, show the class name as well.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884361 13f79535-47bb-0310-9956-ffa450edef68
2009-11-26 01:32:25 +00:00
Adam Heath
1599de6d2c
Handle null values during planning of conditions.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884360 13f79535-47bb-0310-9956-ffa450edef68
2009-11-26 01:31:38 +00:00
Adam Heath
e75c3d12e2
Implements proper null support, and fix operators that have '=' in them.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884359 13f79535-47bb-0310-9956-ffa450edef68
2009-11-26 01:30:35 +00:00
Adam Heath
4e31701beb
Override appendTo.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884358 13f79535-47bb-0310-9956-ffa450edef68
2009-11-26 01:29:52 +00:00
Jacques Le Roux
ba29f3ee12
Improve getCountryList: following Scott's remarks on dev ML.
...
Though now we don't check errors in the countries property list
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884317 13f79535-47bb-0310-9956-ffa450edef68
2009-11-25 22:44:01 +00:00
Jacques Le Roux
207ce8cb79
Sort countries data by GeoName
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884298 13f79535-47bb-0310-9956-ffa450edef68
2009-11-25 22:17:16 +00:00
Adam Heath
cd446f9c3c
Fix getOrCreateUtilCache, so that it doesn't always create new caches; mea culpa.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884262 13f79535-47bb-0310-9956-ffa450edef68
2009-11-25 20:47:51 +00:00
Jacques Le Roux
ebf6dc2efa
Fix a typo in JavaDoc found by Eclipse
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884251 13f79535-47bb-0310-9956-ffa450edef68
2009-11-25 20:31:38 +00:00
Adam Heath
683479438b
size() needs to be synchronized as well.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884239 13f79535-47bb-0310-9956-ffa450edef68
2009-11-25 19:47:31 +00:00
Adam Heath
8ad14aae64
Remove synchronization for listeners, switching to CopyOnWriteArraySet.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884238 13f79535-47bb-0310-9956-ffa450edef68
2009-11-25 19:46:49 +00:00
Adam Heath
126a045cda
Remove all remaining synchronized protection against utilCacheTable.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884237 13f79535-47bb-0310-9956-ffa450edef68
2009-11-25 19:46:05 +00:00
Jacques Le Roux
13ab0a310b
Use log verbose as suggested by Scott in https://issues.apache.org/jira/browse/OFBIZ-3107
...
+ SuppressWarnings("serial")
+ a typo
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884047 13f79535-47bb-0310-9956-ffa450edef68
2009-11-25 11:15:16 +00:00
Jacques Le Roux
70d7a15dfb
Partially fix an issue I discussed with Akash on dev ML on how to format decimals in prices
...
* Mostly parameterize UtilFormatOut.formatPrice() from general.properties
* I removed unused currency.decimal.format calls in CheckOutEvents class
* Also removed unused priceNumberFormat in UtilFormatOut class
Still have to fix 11 harcoded "##0.00" in ftl files using ofbizCurrency
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884023 13f79535-47bb-0310-9956-ffa450edef68
2009-11-25 10:43:09 +00:00
Jacques Le Roux
5661bad7fa
I forgot to improve Angelo Matarazzo's patch I committed for "view-last-noparam" ( https://issues.apache.org/jira/browse/OFBIZ-3027 ) - OFBIZ-3027 in r829727
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883914 13f79535-47bb-0310-9956-ffa450edef68
2009-11-24 22:54:47 +00:00
Scott Gray
d55301de85
Switched back to using main-decorator in ManagePortalPages, wrapped the body section in no-clear container since that was the reason why the CommonPartyDecorator was being used
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883900 13f79535-47bb-0310-9956-ffa450edef68
2009-11-24 22:25:17 +00:00
Adrian Crum
0b269f4296
Improved entity engine Blob test.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883882 13f79535-47bb-0310-9956-ffa450edef68
2009-11-24 21:24:10 +00:00
Adrian Crum
07f3abc276
Eliminated unnecessary casts.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883827 13f79535-47bb-0310-9956-ffa450edef68
2009-11-24 19:26:20 +00:00
Adrian Crum
036cc7b2c4
Converter framework bug fixes. This commit fixes the out of memory errors the demo servers have been having lately.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883807 13f79535-47bb-0310-9956-ffa450edef68
2009-11-24 18:37:09 +00:00
Hans Bakker
029dee7381
added the warehouse processing for the ordersales entities. Contribution by our Antwebsystems employee Tom
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883699 13f79535-47bb-0310-9956-ffa450edef68
2009-11-24 14:07:47 +00:00
Jacques Le Roux
3bc058cef7
Replaces a not needed call to isEmpty()
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883682 13f79535-47bb-0310-9956-ffa450edef68
2009-11-24 13:10:38 +00:00
Jacques Le Roux
8620399660
Complete r883634 : allows to check isEmpty() on a CharSequence
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883647 13f79535-47bb-0310-9956-ffa450edef68
2009-11-24 10:29:30 +00:00
Jacques Le Roux
e25f58f02d
Scott detected that UtilValidate.is(Not)Empty did not exist for CharSequence and reverted changes I did in EntitySaxReader.java
...
This commit adds UtilValidate.is(Not)Empty for CharSequence; and uses it in EntitySaxReader.java and everywhere else it might still be used (because of my changes)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883634 13f79535-47bb-0310-9956-ffa450edef68
2009-11-24 09:24:32 +00:00
Scott Gray
01ca7f002b
Revert Jacques changes to EntitySaxReader.java from r883549 and 883507, the UtilValidate.is(Not)Empty methods are not setup to test CharSequence instances. Hopefully there aren't too many more out there.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883613 13f79535-47bb-0310-9956-ffa450edef68
2009-11-24 07:43:18 +00:00
Adrian Crum
0206592d18
JavaDoc updates in the conversion framework. No functional changes.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883589 13f79535-47bb-0310-9956-ffa450edef68
2009-11-24 05:35:18 +00:00
Jacques Le Roux
c72b29cb1f
Use UtilValidate.isNotEmpty methods instead of (obj != null) || (obj.length > 0) and (obj != null) || (obj.size > 0)
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883549 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 23:41:34 +00:00
Adrian Crum
df86f46af2
Added Blob<->byte[] converters.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883529 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 22:49:06 +00:00
Hans Bakker
d0293a5f16
fix for using equals operator with null field in performFind service: OFBIZ-3151
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883525 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 22:24:59 +00:00
Jacques Le Roux
d5d543b178
Fix r883508
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883517 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 22:02:49 +00:00
Jacques Le Roux
5518e9baf8
Use UtilValidate.isEmpty methods instead of (obj == null) || (obj.size == 0)
...
Complete r883492
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883516 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 22:02:05 +00:00
Jacques Le Roux
e839974fe7
Use UtilValidate.isEmpty methods instead of (obj == null) || (obj.length == 0)
...
Complete r883507
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883508 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 21:48:18 +00:00
Jacques Le Roux
4e0d303e06
Use UtilValidate.isEmpty methods instead of (obj == null) || (obj.length == 0)
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883507 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 21:42:18 +00:00
Jacques Le Roux
8ae9319710
Use UtilValidate.isEmpty methods instead of (obj == null) || (obj.size == 0)
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883492 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 20:34:27 +00:00
Bilgin Ismet Ibryam
803f423dc6
- Fixed wrong style used.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883444 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 18:16:46 +00:00
Jacques Le Roux
7c92156d1c
Some other fixes in help files
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883333 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 13:15:09 +00:00
Jacques Le Roux
49b2961e9c
Fix few things in help files
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883329 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 13:02:53 +00:00
Scott Gray
b94f973c30
Allow a target and additional parameters to be specified when defining a portal page menu item, for example:
...
<menu-item name="main" parent-portal-page-value="${parameters.parentPortalPageId}"/>
can now be customized to point to a specific target rather than the default "showPortalPage":
<menu-item name="main" parent-portal-page-value="${parameters.parentPortalPageId}">
<link target="MyCustomRequest">
<parameter param-name="myCustomParam" from-field="parameters.myCustomParam"/>
</link>
</menu-item>
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883239 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 04:06:27 +00:00