Commit Graph
10472 Commits
Author SHA1 Message Date
Adrian Crum 5aee9e3b82 Deleted orphaned JavaDoc comment.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923591 13f79535-47bb-0310-9956-ffa450edef68
2010-03-16 06:45:23 +00:00
Adam Heath 2eb1768f1d Fix lots of bad xhtml tags, need to have a space before the ending /.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923545 13f79535-47bb-0310-9956-ffa450edef68
2010-03-16 01:56:41 +00:00
Adam Heath a98e688899 Move ObjectWrapper to the lang package.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923358 13f79535-47bb-0310-9956-ffa450edef68
2010-03-15 17:33:24 +00:00
Adam Heath ac7090a129 This doesn't need to import ObjectWrapper.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923356 13f79535-47bb-0310-9956-ffa450edef68
2010-03-15 17:32:06 +00:00
Adam Heath 2f7ee6b1d3 Move Factory to lang package.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923354 13f79535-47bb-0310-9956-ffa450edef68
2010-03-15 17:31:34 +00:00
Adam Heath 6d6205e192 Test the ability of loadContainedConverters to skip thrown exceptions.
This leaves 2 lines unconvered, and 1 branch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923103 13f79535-47bb-0310-9956-ffa450edef68
2010-03-15 07:27:33 +00:00
Adam Heath 1e042ce64d In PassThruConverterCreator, only use ObjectType.instanceOf, so that
there are no longer any unconvered branches on that line.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923102 13f79535-47bb-0310-9956-ffa450edef68
2010-03-15 07:26:58 +00:00
Adam Heath 84e8e45b16 Turn off verbosity of Converters, and no longer explicitly call
Debug.verboseOn; it's not a fast path that needs to have it protected,
as this code is only called once at startup.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923101 13f79535-47bb-0310-9956-ffa450edef68
2010-03-15 07:26:10 +00:00
Adam Heath 572679cabf Remove unused null check against targetClass in registerConverter.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923100 13f79535-47bb-0310-9956-ffa450edef68
2010-03-15 07:25:25 +00:00
Adam Heath 857d0b81a0 Test that public objects in a class are skipped over, if they aren't a
ConverterLoader.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923099 13f79535-47bb-0310-9956-ffa450edef68
2010-03-15 07:24:51 +00:00
Adam Heath 8a614758af Converters is a static helper class, so test for that.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923097 13f79535-47bb-0310-9956-ffa450edef68
2010-03-15 07:24:14 +00:00
Adam Heath 9aa9857b95 Remove not-needed NullConverter.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923096 13f79535-47bb-0310-9956-ffa450edef68
2010-03-15 07:23:35 +00:00
Adam Heath c7af9fddd6 Moved call to future.run to inside the main loop; as a side effect, this
causes us to finally reach full branch coverage.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923095 13f79535-47bb-0310-9956-ffa450edef68
2010-03-15 07:22:47 +00:00
Adam Heath f50dfd69d2 Reworked setObject to delay the actual setting until the next getObject
call.  Removes one hard to test branch.  Just a single branch left to
test.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923094 13f79535-47bb-0310-9956-ffa450edef68
2010-03-15 07:21:59 +00:00
Adam Heath 5f97749e45 100% line coverage, 2 branches left.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923093 13f79535-47bb-0310-9956-ffa450edef68
2010-03-15 07:21:10 +00:00
Adam Heath ab880ae454 Remove unneeded cast.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923092 13f79535-47bb-0310-9956-ffa450edef68
2010-03-15 07:20:34 +00:00
Adam Heath 176b409413 Full branch coverage now.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923091 13f79535-47bb-0310-9956-ffa450edef68
2010-03-15 07:19:57 +00:00
Adam Heath 89c1bec653 Some major tweeking to get better coverage.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923054 13f79535-47bb-0310-9956-ffa450edef68
2010-03-15 04:37:31 +00:00
Adam Heath c807dcea6f 100% coverage during testing now.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923053 13f79535-47bb-0310-9956-ffa450edef68
2010-03-15 04:37:01 +00:00
Adam Heath d8553a3cef Add new helper method to make constructing simpler.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923052 13f79535-47bb-0310-9956-ffa450edef68
2010-03-15 04:36:22 +00:00
Adam Heath 6466fae298 More coverage on ObjectType.simpleTypeConvert.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@923051 13f79535-47bb-0310-9956-ffa450edef68
2010-03-15 04:35:44 +00:00
Hans Bakker 4381785ac5 add a common 'accept' label
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@922850 13f79535-47bb-0310-9956-ffa450edef68
2010-03-14 14:00:58 +00:00
Adam Heath 4577e3afa4 Helper wrapper to protect against objects that have some kind of timestamp
checking.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@922758 13f79535-47bb-0310-9956-ffa450edef68
2010-03-14 03:57:12 +00:00
Adam Heath bef43eedb4 Since getTTL throws ConfigurationException, which is now a
RuntimeException, there's no need to declare it in the throws clause.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@922757 13f79535-47bb-0310-9956-ffa450edef68
2010-03-14 03:55:52 +00:00
Adam Heath 45d2d66c02 ConfigurationException is now a RuntimeException.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@922756 13f79535-47bb-0310-9956-ffa450edef68
2010-03-14 03:55:23 +00:00
Adam Heath 809fdb9e88 Fixed coverage of the test cases.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@922755 13f79535-47bb-0310-9956-ffa450edef68
2010-03-14 03:54:53 +00:00
Adam Heath 37f62c89e9 Follow junit best practices.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@922735 13f79535-47bb-0310-9956-ffa450edef68
2010-03-14 02:22:10 +00:00
Adam Heath 4ba13c9699 Fix formatting; some lines had a leading indent of 2 spaces.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@922734 13f79535-47bb-0310-9956-ffa450edef68
2010-03-14 02:21:42 +00:00
Adam Heath 2d40b49aff Thread.sleep takes a long, not an int, so convert the wait time to long calculations. Also, remove the use of new Double().
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@922733 13f79535-47bb-0310-9956-ffa450edef68
2010-03-14 02:21:14 +00:00
Adam Heath 641b22e58c Change visibility of purely internal methods to private, and make several instance variables final.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@922731 13f79535-47bb-0310-9956-ffa450edef68
2010-03-14 02:20:45 +00:00
Adam Heath 579ff51707 SequenceBank no longer stores the bankSize.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@922730 13f79535-47bb-0310-9956-ffa450edef68
2010-03-14 02:20:17 +00:00
Adam Heath 1647601757 SequenceBank no longer maintains a duplicate reference to SequenceUtil.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@922729 13f79535-47bb-0310-9956-ffa450edef68
2010-03-14 02:19:44 +00:00
Adam Heath 23abe54e4e SequenceUtil no longer stores a reference to the ModelEntity at all.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@922728 13f79535-47bb-0310-9956-ffa450edef68
2010-03-14 02:19:16 +00:00
Adam Heath be1f4c329c SequenceBank no longer uses ModelEntity at all.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@922725 13f79535-47bb-0310-9956-ffa450edef68
2010-03-14 02:18:42 +00:00
Adam Heath 795b0cdbab Remove use of ModelEntity from fillBank.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@922724 13f79535-47bb-0310-9956-ffa450edef68
2010-03-14 02:18:10 +00:00
Adam Heath 8ccf42e1dd Fix bad caching. Previously, any call to getDelegator() would *always*
walk the entire classpath, trying to find all implementations of
DelegatorFactory.  This was fixed by moving the cache higher up.

In detail, the entity caching system only stored a String delegator
name.  It would then try to find the appropriate delegator to match that
name.  However, during a custom importer, the caching system was being
exercised very heavily, so DelegatorFactory.getDelegator() was being
called in a very tight loop.  Since the delegator instances were not
being cached at the high level, this caused a *big* slowdown; basically,
a 15 minute importer was taking over 2 hours, and was no near finishing.
This was because UtilObject.getObjectFromFactory would end up walking
the entire classpath, finding every jar, looking at every zip entry, to
try and find the appropriate file in META-INF/services.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@921990 13f79535-47bb-0310-9956-ffa450edef68
2010-03-11 18:59:34 +00:00
Adam Heath a68617c9ad Pass the delegator into any create/init methods that end up setting any
field data.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@921989 13f79535-47bb-0310-9956-ffa450edef68
2010-03-11 18:58:13 +00:00
Adam Heath b4651644c8 Don't fetch the delegator with UtilObject, instead using
DelegatorFactory.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@921987 13f79535-47bb-0310-9956-ffa450edef68
2010-03-11 18:57:33 +00:00
Adam Heath 9bcda83ad7 Remove runtime/logs/cobertura-report.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@921984 13f79535-47bb-0310-9956-ffa450edef68
2010-03-11 18:55:50 +00:00
Jacques Le Roux 9652e69f8f Allow double quote in title. This is possible because, at least OOTB, all title should be localized. Hence from a label in an XML file, and nothing prevent to use double quotes there
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@921773 13f79535-47bb-0310-9956-ffa450edef68
2010-03-11 10:17:15 +00:00
Jacques Le Roux a7a09a0817 As suggested by Adam and Scott move the encodeQuotes static method (actually renamed encodeDoubleQuotes) from UtilHttp to FreeMarkerWorker
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@921714 13f79535-47bb-0310-9956-ffa450edef68
2010-03-11 07:57:27 +00:00
Jacques Le Roux ca38a526fa Following r921421, here is the right and simplest solution (KISS way).
Simply encoding the tooltip (why I did not think about that before, really sometimes I wonder how my brain is working, I need to stop working for it to begin to work)
There are no needs to encode char like >, but of course < is needed (in he XML file) since else there is a problem in the XML labels file (always the same issue: around vs inside)
So yes, it's only a matter of encoding at the right place, ie before the "around vs inside" issue arises
Good night ;)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@921643 13f79535-47bb-0310-9956-ffa450edef68
2010-03-11 00:20:57 +00:00
Adrian Crum 615c3d83d1 Revert rev 902341 - which seemed to cause problems with the Derby database.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@921455 13f79535-47bb-0310-9956-ffa450edef68
2010-03-10 17:11:18 +00:00
Jacques Le Roux 248b851c03 Better explanation of lookup fields
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@921432 13f79535-47bb-0310-9956-ffa450edef68
2010-03-10 16:23:29 +00:00
Jacques Le Roux be7c45c096 You can't use double quote in tooltips. I tried to find a quick way to allow this in MacroFormRenderer.appendTooltip() but gave up, too narrow need.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@921421 13f79535-47bb-0310-9956-ffa450edef68
2010-03-10 16:12:30 +00:00
Jacques Le Roux 9fbb7f392c Fix a small encoding bug found in Example Widget form
Set default values for fields 4&5 (time dropdowns)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@921401 13f79535-47bb-0310-9956-ffa450edef68
2010-03-10 15:29:44 +00:00
Jacopo Cappellato 0e57369c97 Reverted rev. 920359 (by erwan) and reimplemented in a cleaner way by refactoring the renderHyperlinkTitle code.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@921397 13f79535-47bb-0310-9956-ffa450edef68
2010-03-10 15:21:23 +00:00
Jacopo Cappellato 32aa30cfcb Minor code simplification: no functional changes.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@921305 13f79535-47bb-0310-9956-ffa450edef68
2010-03-10 11:15:30 +00:00
Erwan de Ferrieres dbc53a2fb8 html string encoding for alternate and description tags on image field
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@921287 13f79535-47bb-0310-9956-ffa450edef68
2010-03-10 10:24:33 +00:00
Erwan de Ferrieres 80b67af4e4 Correcting a wrong macro name (missing letter)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@921109 13f79535-47bb-0310-9956-ffa450edef68
2010-03-09 20:32:47 +00:00