Commit Graph
1568 Commits
Author SHA1 Message Date
Jacques Le Roux e7905f2c8c Fix the anti-pattern
if (* != null && *.size() > 0) { 
where * is a variable name (String or Collection). Rewritten to
    if (UtilValidate.isNotEmpty(*)) {

Done with Eclipse regex replace feature with
search = if \((\w+) *!= *null *&& *(\w+)\.size\(\) *> *0\) *\{
replace = if (UtilValidate.isNotEmpty($1)) {

And of course some hand-work for imports and cleaning. I compiled and tested with ant run-tests

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@686591 13f79535-47bb-0310-9956-ffa450edef68
2008-08-17 07:47:18 +00:00
Adam Heath e410552cc9 No longer *copy* the extra support files into the classes dir;
instead, just add them straight to the final jar.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@685934 13f79535-47bb-0310-9956-ffa450edef68
2008-08-14 15:08:14 +00:00
Adam Heath 2617681b51 Remove svn:executable on a bunch of stuff.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@684389 13f79535-47bb-0310-9956-ffa450edef68
2008-08-10 00:53:43 +00:00
Adam Heath 7f61d043c1 Few more generics things.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@684378 13f79535-47bb-0310-9956-ffa450edef68
2008-08-09 23:54:33 +00:00
Scott Gray ab7f3fb5e3 Fixed a problem with list widgets not being able to make use of *EntityLabels.xml localization, I'm not sure if I've taken the best possible approach but the problem is solved without causing any harm as far as I can see. Reported by Bruno Busco on the dev list.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@684244 13f79535-47bb-0310-9956-ffa450edef68
2008-08-09 12:45:52 +00:00
Adrian Crum ab5fac7dba Small fix for HtmlScreenRenderer.java - don't render an img element if there is no image to display.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@684051 13f79535-47bb-0310-9956-ffa450edef68
2008-08-08 18:49:33 +00:00
Adam Heath 06029fe7e1 One last update.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@682104 13f79535-47bb-0310-9956-ffa450edef68
2008-08-03 05:19:45 +00:00
Adam Heath 2527b104a9 More FlexibleMapAccessor fallout.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@682103 13f79535-47bb-0310-9956-ffa450edef68
2008-08-03 05:17:15 +00:00
Adam Heath eb18028c42 More generics work; a bit of fallout from the recent
FlexibleMapAccessor generification.  Plus a few additional changes.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@682102 13f79535-47bb-0310-9956-ffa450edef68
2008-08-03 05:10:30 +00:00
Adam Heath abbb639e21 Remove duplicate ListOptions.listAscr initialization.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@682099 13f79535-47bb-0310-9956-ffa450edef68
2008-08-03 04:04:58 +00:00
Adam Heath b6a1ae5e5e Another minor optimization; no longer need to specify classpathref in
all the build.xml files.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@681935 13f79535-47bb-0310-9956-ffa450edef68
2008-08-02 03:41:46 +00:00
Jacques Le Roux bb4aa64f7a A fixing patch from Mridul Pathak "Implement Ajax.InPlaceEditor for display field in Form Widget" (https://issues.apache.org/jira/browse/OFBIZ-1859) - OFBIZ-1859
Some work still needed (strange behaviour at least reproductible on Opera 9.02)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@679980 13f79535-47bb-0310-9956-ffa450edef68
2008-07-26 11:55:14 +00:00
Jacques Le Roux 46d33fe5c0 A fixing patch from Mridul Pathak "Implement Ajax.InPlaceEditor for display field in Form Widget" (https://issues.apache.org/jira/browse/OFBIZ-1859) - OFBIZ-1859
Some work still needed it seems


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@679975 13f79535-47bb-0310-9956-ffa450edef68
2008-07-26 09:47:13 +00:00
Jacopo Cappellato 2f0cf9ef44 Layout enhancements for tree widgets.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@679828 13f79535-47bb-0310-9956-ffa450edef68
2008-07-25 15:04:52 +00:00
Jacopo Cappellato e4609c411a Misc cleanups to the widget tree code, still a lot to do to improve the readability of the code but this is hopefully a small step in that direction.
Most of all, I have fixed a small issue that was preventing to work the first click (after visiting the page) for the expansion of a node.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@679798 13f79535-47bb-0310-9956-ffa450edef68
2008-07-25 13:22:46 +00:00
Jacopo Cappellato eff5b1e697 Formatting fixes.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@679127 13f79535-47bb-0310-9956-ffa450edef68
2008-07-23 16:48:00 +00:00
Jacopo Cappellato bfcdd9cd47 Misc code cleanups: formatting fixes, renamed some variables, removed useless code.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@679126 13f79535-47bb-0310-9956-ffa450edef68
2008-07-23 16:42:32 +00:00
Jacopo Cappellato 8e1390b872 Formatting fixes and misc cleanups (removed unused entries from the context).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@679078 13f79535-47bb-0310-9956-ffa450edef68
2008-07-23 11:48:03 +00:00
Jacopo Cappellato b38c79185b Formatting cleanup
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@679057 13f79535-47bb-0310-9956-ffa450edef68
2008-07-23 10:22:12 +00:00
Jacopo Cappellato a21b39dc1c Small fix to prevent NPE under certain circumstances; still the code should be improved, but for now I am trying to change as less code as possible.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@679056 13f79535-47bb-0310-9956-ffa450edef68
2008-07-23 10:16:02 +00:00
Jacopo Cappellato 26d94fc5b0 Formatting cleanups.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@679018 13f79535-47bb-0310-9956-ffa450edef68
2008-07-23 08:27:17 +00:00
Anil Patel 73f15bf2bd Enhancements contributed by Mridul Pathal for Ajax InPlaceEditor for form widget Display field. Mridul, Thanks for your effort.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@678979 13f79535-47bb-0310-9956-ffa450edef68
2008-07-23 02:20:39 +00:00
Scott Gray 0312a4f80f Changed where the nowTimestamp variable is declared so that it is more widely available
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@676837 13f79535-47bb-0310-9956-ffa450edef68
2008-07-15 09:05:13 +00:00
Anil Patel 58d361213f Initial implementation of Ajax InPlaceEditor for form widget Display field. Mridul, Thanks for your effort.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@675688 13f79535-47bb-0310-9956-ffa450edef68
2008-07-10 19:17:36 +00:00
Anil Patel 8e653379d3 enhancements to the Autocompleter integration with form widget dropdown.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@675103 13f79535-47bb-0310-9956-ffa450edef68
2008-07-09 06:15:23 +00:00
Adrian Crum 1f39a762bc Improved screen widget UI label rendering - now expands expressions contained in UI labels (${...}).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@674387 13f79535-47bb-0310-9956-ffa450edef68
2008-07-07 03:21:18 +00:00
Scott Gray 093b675bd7 0.4 is not an integer
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@673040 13f79535-47bb-0310-9956-ffa450edef68
2008-07-01 09:45:52 +00:00
Adam Heath ffe732728c Fix the last 3 generics warnings; haven't verified that other java1.5
features are being used, tho.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672901 13f79535-47bb-0310-9956-ffa450edef68
2008-06-30 20:29:06 +00:00
Adam Heath 1dc13f6105 Number.valueOf changes.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672898 13f79535-47bb-0310-9956-ffa450edef68
2008-06-30 20:20:37 +00:00
Adam Heath 18391f98a9 The build.xml files are now much smaller and simpler; they reuse a
few global definitions.  1585 lines removed.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672657 13f79535-47bb-0310-9956-ffa450edef68
2008-06-29 18:39:36 +00:00
Anil Patel 265e7b46a1 Adding Autocompleter options to form widget dropdown. More improvements to come.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@671723 13f79535-47bb-0310-9956-ffa450edef68
2008-06-26 04:23:57 +00:00
David E. Jones 907fba975c Small cleanups, no change in functionality
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@671561 13f79535-47bb-0310-9956-ffa450edef68
2008-06-25 14:30:37 +00:00
Anil Patel 3feb26b6d8 Removed Prototype.js specific code from HtmlFormRenderer.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@671393 13f79535-47bb-0310-9956-ffa450edef68
2008-06-25 01:40:44 +00:00
Anil Patel dba109d02d Now rendering Id attribute of span displaying data in form.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@671029 13f79535-47bb-0310-9956-ffa450edef68
2008-06-24 05:19:45 +00:00
Adrian Crum 4c57b7d203 Oops, forgot to reset the property after testing.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@670705 13f79535-47bb-0310-9956-ffa450edef68
2008-06-23 18:39:53 +00:00
Adrian Crum 13be6d006d Better implementation of last commit, based on a suggestion by David Jones.
No additional screen widget code is needed to implement the Find screen search results default behavior.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@670704 13f79535-47bb-0310-9956-ffa450edef68
2008-06-23 18:38:04 +00:00
Adrian Crum 06493a32aa Added a widget.properties property to control the display of the search result list in the Find screen. Also added an example in the Asset Maintenance component.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@670676 13f79535-47bb-0310-9956-ffa450edef68
2008-06-23 17:17:09 +00:00
Jacopo Cappellato 4cac01d534 Added ability to define the default operator for from/thru fields in date-find and range-find fields (similar to the one existing for the text find field).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@670502 13f79535-47bb-0310-9956-ffa450edef68
2008-06-23 09:51:45 +00:00
Adrian Crum 906dbc553b Fixed bug in form widget rendering. Request parameters were being dropped while rendering the pagination links.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@670248 13f79535-47bb-0310-9956-ffa450edef68
2008-06-21 18:38:33 +00:00
Adrian Crum 55516877e2 Page select dropdown bug fix - reported by Jacopo on the dev mailing list.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@668696 13f79535-47bb-0310-9956-ffa450edef68
2008-06-17 14:54:06 +00:00
Adrian Crum c2156ce895 Bug fix for collapsible screenlet in JavaScript mode. It now updates pagination links so the collapsible state change is carried across pagination screen refreshes.
IE has a problem with the page select dropdown after a screenlet collapsible state change. I'm still working on that.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@668342 13f79535-47bb-0310-9956-ffa450edef68
2008-06-16 23:11:14 +00:00
Adrian Crum e2e5268f42 Improved Lookup decorator, submitted by Bruno Busco - https://issues.apache.org/jira/browse/OFBIZ-1841, with modifications by me.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@667965 13f79535-47bb-0310-9956-ffa450edef68
2008-06-15 15:20:10 +00:00
Jacopo Cappellato b2ac94a266 Added support for the skip-end attribute to form widgets of type "multi": now it is easier to add "global" form parameters to multi forms by concatenating a single form to a multi form with skip-end set to true.
Modified the way submitted multi form rows are counted: now the hidden _rowCount field in the form is no more needed because rows are counted in the ServiceMultiEventHandler (using the util methods that I have implemented in the UtilHttp class).


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@667930 13f79535-47bb-0310-9956-ffa450edef68
2008-06-15 06:27:15 +00:00
Adrian Crum d37351838c Screenlet initially-collapsed bug fix provided by Bruno Busco - https://issues.apache.org/jira/browse/OFBIZ-1840.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@667837 13f79535-47bb-0310-9956-ffa450edef68
2008-06-14 16:34:25 +00:00
Adrian Crum 58845f4c48 Screen widget improvements:
1. Better screenlet collapsible implementation.
2. New widget: horizontal-separator.

The id attribute is no longer required for collapsible screenlets. Just use collapsible="true".

The horizontal-separator widget can be used to divide complicated screens - as an alternative to using screenlets.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@667723 13f79535-47bb-0310-9956-ffa450edef68
2008-06-14 03:01:33 +00:00
Adrian Crum 887e99df1d Fix for form widget renderer - it wasn't rendering the field-group id.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@664355 13f79535-47bb-0310-9956-ffa450edef68
2008-06-07 15:33:24 +00:00
Scott Gray 16742b636a Corrected the field lookup's img tag width and height
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@664255 13f79535-47bb-0310-9956-ffa450edef68
2008-06-07 03:23:49 +00:00
Adrian Crum 800b1c0e56 Fixed bug I introduced in a previous commit.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@663743 13f79535-47bb-0310-9956-ffa450edef68
2008-06-05 21:22:02 +00:00
Adrian Crum 399d67552b Small fix for HtmlMenuRenderer.java - tooltip and style attributes were being ignored.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@663376 13f79535-47bb-0310-9956-ffa450edef68
2008-06-04 21:30:13 +00:00
Adrian Crum bbd26287a1 Fixed thread-safe issues in the tree widget. Eliminated compiler warnings.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@662847 13f79535-47bb-0310-9956-ffa450edef68
2008-06-03 17:32:07 +00:00