Commit Graph
1143 Commits
Author SHA1 Message Date
Marco Risaliti aaa6f94573 Remove a warning from RequestHandler (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1076340 13f79535-47bb-0310-9956-ffa450edef68
2011-03-02 19:21:48 +00:00
Jacques Le Roux 8f96fd0b65 A fix suggested by Michael Reichenbach at "Multiple responses send by SOAPEventHandler when ServiceValidationException occurs" https://issues.apache.org/jira/browse/OFBIZ-4207
Problem
=======

When calling a service that was defined as "export=true" and a non-optional parameter is missing, then the SOAP-Response is not a valid XML.

Cause
=====

The cause is, that in SOAPEventHandler.invoke() the dispatcher.runSync() throws a ServiceValidationException ("The following required parameter is missing..."). This will be catched by the GenericServiceException-block, a error response will be written to the output stream (via sendError()) and an EventHandlerException will be thrown. This exception will again be catched (this time by the Exception-block and another error response will be written to the output stream.

Solution
========

I think the best solution is simply not to call sendError in the GenericServiceException-block.

JLR: I simply commented out the faulty line (with a reference to OFBIZ-4207) in case someone would want to improve the error message.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1075952 13f79535-47bb-0310-9956-ffa450edef68
2011-03-01 18:03:14 +00:00
Jacques Le Roux c0716dd0db Removes an useless unchecked annotation
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1075875 13f79535-47bb-0310-9956-ffa450edef68
2011-03-01 16:16:26 +00:00
Marco Risaliti 822f6d1820 Remove some warning in IteratorTag (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1075540 13f79535-47bb-0310-9956-ffa450edef68
2011-02-28 21:27:49 +00:00
Marco Risaliti ca6ca40950 Remove some warning in IfTag (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1075539 13f79535-47bb-0310-9956-ffa450edef68
2011-02-28 21:26:51 +00:00
Marco Risaliti f52bef96d0 Remove some warning in RenderTag (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1075538 13f79535-47bb-0310-9956-ffa450edef68
2011-02-28 21:24:34 +00:00
Marco Risaliti 4f9a3aa386 Remove some warning in InputValue (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1075535 13f79535-47bb-0310-9956-ffa450edef68
2011-02-28 21:20:03 +00:00
Marco Risaliti c78d6dba39 Remove some warning in EntityField (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1075534 13f79535-47bb-0310-9956-ffa450edef68
2011-02-28 21:19:34 +00:00
Jacques Le Roux 141bb6827f I should have used cache in 1st place here. It's never too late...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1075350 13f79535-47bb-0310-9956-ffa450edef68
2011-02-28 14:35:02 +00:00
Sascha Rodekamp 0203cb9f0b Feature - "LoginWorker should use expandedEntites von the checkLogin-query" (https://issues.apache.org/jira/browse/OFBIZ-3453) - The parameters in the query String are separated by an &. The Code is more clean (and XHTML strict) when the separator is encoded. Thanks Dimitri for the patch.
Orig. Msg.:
I guess that the makeLoginUrl-method in the LoginWorker should return a string with expandedEntites.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1071362 13f79535-47bb-0310-9956-ffa450edef68
2011-02-16 19:06:10 +00:00
Marco Risaliti 78dcf847bd Add a @SuppressWarning("serial") in ViewHandlerException (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069122 13f79535-47bb-0310-9956-ffa450edef68
2011-02-09 21:31:19 +00:00
Marco Risaliti e5b0485aba Add a @SuppressWarning("serial") of classes of package org.ofbiz.webapp.taglib (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069121 13f79535-47bb-0310-9956-ffa450edef68
2011-02-09 21:30:31 +00:00
Marco Risaliti ecc24d9115 Add a @SuppressWarning("serial") of classes of package org.ofbiz.webapp.region (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069118 13f79535-47bb-0310-9956-ffa450edef68
2011-02-09 21:21:50 +00:00
Marco Risaliti fc188f9f06 Add a @SuppressWarning("serial") in EventHandlerException/FileUploadProgressListener (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069117 13f79535-47bb-0310-9956-ffa450edef68
2011-02-09 21:19:57 +00:00
Marco Risaliti 3b77f392b7 Add a @SuppressWarning("serial") in RequestHandlerException (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069115 13f79535-47bb-0310-9956-ffa450edef68
2011-02-09 21:18:24 +00:00
David E. Jones 3d970a834b Soften exception log on error saving ServerHit, happens often with MySQL and no need for such a bug chunk of text in the log
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1068668 13f79535-47bb-0310-9956-ffa450edef68
2011-02-08 22:57:30 +00:00
David E. Jones 58c2d96cb0 Changed to not use hard-coded dispatcher name to avoid issues when using multiple delegators
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1068665 13f79535-47bb-0310-9956-ffa450edef68
2011-02-08 22:56:18 +00:00
Marco Risaliti f7e858af65 Remove an unused import in FreeMarkerViewHandler (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1068567 13f79535-47bb-0310-9956-ffa450edef68
2011-02-08 20:42:28 +00:00
Marco Risaliti ac07860c5a Remove some unused import in ControlServlet (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1068565 13f79535-47bb-0310-9956-ffa450edef68
2011-02-08 20:39:40 +00:00
Jacques Le Roux a9a3d4bdeb Fix "Ajax requests prevent externalLoginKey parameters from working correctly" (https://issues.apache.org/jira/browse/OFBIZ-3862) - OFBIZ-3862
Scott reported: To clarify, the problem only occurs if the Ajax call results in a screen being rendered since it is the ScreenRenderer that causes a new key to be generated.

Bilgin suggested: I think a solution would be to skip generating of new external login key for Ajax requests.
Ajax requests can be identified by presence of 'X-Requested-With': 'XMLHttpRequest', http header. It is set by most of the Javascript libraries we use: prototype, jquery.

I coded it

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1068283 13f79535-47bb-0310-9956-ffa450edef68
2011-02-08 07:47:25 +00:00
David E. Jones 30c0a8cb24 Bug fix to support multiple delegators; these places has a hard-coded dispatcher name that may have been created with a delegator different from the one that is now active and attempted to be used with the same old dispatcher, resulting in undesired database switching; changed to the convention of using the delegator name for the dispatcher name, which is the normal default and should be used everywhere a special dispatcher name specific to a context, like a webapp, is not used
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1066356 13f79535-47bb-0310-9956-ffa450edef68
2011-02-02 07:31:21 +00:00
Jacques Le Roux 51a2ceb54f A patch from Chatree Srichart "Fix using TagLib in Freemarker." (https://issues.apache.org/jira/browse/OFBIZ-2703) - OFBIZ-2703
Fix using TagLib in freemarker follow this.
1. In ControlServlet.java, create ServletContextHashModel instance and set to request's attritube
2. In ScreenRenderer.java, set ServletContextHashModel instance from request's attribute to context name Application and set HttpRequestHashModel instance from requestAttributes in context to context name Request

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1061310 13f79535-47bb-0310-9956-ffa450edef68
2011-01-20 14:23:29 +00:00
Hans Bakker d696e3547b When a load balancer is in front of the ofbiz system and takes care of the ssl certificate, ofbiz is now reading the Header[X-Forwarded-Proto] parameters to check if the request was secure or not. It still works the old way if these request parameters are not present
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1057115 13f79535-47bb-0310-9956-ffa450edef68
2011-01-10 08:26:04 +00:00
Scott Gray 47f43a302a Remove unnecessary casts
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1044931 13f79535-47bb-0310-9956-ffa450edef68
2010-12-12 21:31:27 +00:00
David E. Jones f2dff15007 Undo part of the changes from Hans in rev 1037624 which caused the system to reset the delegator to the base delegator and ignore the user's specified tenant
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1040651 13f79535-47bb-0310-9956-ffa450edef68
2010-11-30 17:35:05 +00:00
Jacques Le Roux 600bac5ad9 A patch from Sascha Rodekamp "Redirect from Http to Https causes double service call" (https://issues.apache.org/jira/browse/OFBIZ-3988) - OFBIZ-3988
The problem is, when you call a request over http, but the controller wants an https request, the RequestHandler make an redirect to https (which is indeed pretty cool). But this redirect causes that Events/ Services will be called twice. This can be avoided when we return from the Service/ Event directly after doing the redirect.
Example: http://localhost:8080/ecommerce/control/setdistributor?distributor=4711

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1040044 13f79535-47bb-0310-9956-ffa450edef68
2010-11-29 09:33:39 +00:00
Jacques Le Roux 66c5dd10a0 A patch from Dukian "Add Traditional Chinese translation for applications, ecommerce, and ofbizsetup" (https://issues.apache.org/jira/browse/OFBIZ-4031) - OFBIZ-4031
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1039574 13f79535-47bb-0310-9956-ffa450edef68
2010-11-26 21:56:14 +00:00
Hans Bakker 350dc3c0ed add root condition for initial path and add multi tenant condition in the login screen of myportal
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1038543 13f79535-47bb-0310-9956-ffa450edef68
2010-11-24 09:55:16 +00:00
Hans Bakker ef76d5387d small adjustment fo multitenant, redirecting url in jsp did not work properly
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1037624 13f79535-47bb-0310-9956-ffa450edef68
2010-11-22 07:55:56 +00:00
Hans Bakker 1a7456f191 Correction because of Scott's comment that it should not expected that the root path is /control/main. So now the root path is checked by looking at the 'requestPath' and 'contextUri' variables having the same value. If it is the same value then it is the root path
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1034278 13f79535-47bb-0310-9956-ffa450edef68
2010-11-12 06:25:10 +00:00
Jacques Le Roux 4bf70deef8 Fixes "Changing the locale (language) from the 1st screen of Order Entry is faulty" (https://issues.apache.org/jira/browse/OFBIZ-4016) - OFBIZ-4016
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1034179 13f79535-47bb-0310-9956-ffa450edef68
2010-11-11 22:19:54 +00:00
Hans Bakker 3b172e8c72 removing the tenant servlet because that gave a problem with the root mountpoint defined twice in systems which already use the root mount point
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1032896 13f79535-47bb-0310-9956-ffa450edef68
2010-11-09 09:14:33 +00:00
Hans Bakker eaa8f6b5d4 next to setting of the tenent id, now also the initial mountpoint if entered also refactoring:
- set delegator, dispatcher and security from session, servlet context or request's attribute to app context of birt engine before render and send email
- add the initialPath field to Tenant entity
- create the tenant context which as a default servlet using org.ofbiz.webapp.control.TenantServlet in the catalina container and check the multitenant property for initial the tenant context with root mount /
- move the changing a multi tenant delegator statement from ControlServlet to ContextFilter that could apply to every servlets
(implementation by Chattree Richard)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1032472 13f79535-47bb-0310-9956-ffa450edef68
2010-11-08 06:54:17 +00:00
Hans Bakker 6abf950e9d Optionally alow the setting of the multitenant id from the incoming domainname which is also stored in the tenant entity
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1032444 13f79535-47bb-0310-9956-ffa450edef68
2010-11-08 02:04:27 +00:00
Jacques Le Roux 1a5cc0bffa A patch from Sascha Rodekamp "NPE in Control Event listener when visits are disabled" (https://issues.apache.org/jira/browse/OFBIZ-3998) - OFBIZ-3998
When the visits are disabled the ControlEventListener throws a NPE. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1030597 13f79535-47bb-0310-9956-ffa450edef68
2010-11-03 18:30:33 +00:00
David E. Jones af7a120fcd Fixed bug where if the only redirect-parameter elements only had value attributes they would be ignored (for request-redirect responses in requests)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1028499 13f79535-47bb-0310-9956-ffa450edef68
2010-10-28 21:32:56 +00:00
Jacques Le Roux 1610fce6df A patch from Sascah Rodekamp "Server Hit Bin, counterHit receive delegator" (https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/OFBIZ-3984) - OFBIZ-3984
Patch to improve the delegator call in the countHit method.
The method got the delegator name from the session and got, with this delegator name over the delegator factory, the delegator.
But when the delegator name was not available in the session the method crashes.
I try to get the delegator from the request, and if their is no delegator object I go the factory way.

I think it's a little bit saver to get a delegator object this way

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1021344 13f79535-47bb-0310-9956-ffa450edef68
2010-10-11 13:43:38 +00:00
Jacques Le Roux 52bc5a3dbd A patch from Weizhan Guo "multi-tenant function do not work correctly if switch from one app to another by click the menu" (https://issues.apache.org/jira/browse/OFBIZ-3956) - OFBIZ-3956
I found a problem when I switched from one app to another. The multi-tenant did not work if the username and password were the same in the main database and tenants (or different tenants). For example, the password of admin is ofbiz in main database and in DEMO1 tenant, first log in to catalog as admin of tenant DEMO1, and then switch to the content app, the data of content app is from the main database instead of DEMO1.

I debugged this problem, and the code was missing to check the userlogin tenant in checkExternalLoginKey.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1001099 13f79535-47bb-0310-9956-ffa450edef68
2010-09-24 22:45:12 +00:00
Adam Heath 202204c9de Use setServletContextForTemplateLoading instead of
setDirectoryForTemplateLoading, so that raw File access is no longer
used.  This is to support webslinger, which uses an overlay filesystem
to merge multiple modules, and doesn't really have a single File view of
the webapp.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@997422 13f79535-47bb-0310-9956-ffa450edef68
2010-09-15 17:56:52 +00:00
David E. Jones d5ef229814 For response -> redirect-parameter element added value attribute so you can specify a static value to include in the redirected URL
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@993489 13f79535-47bb-0310-9956-ffa450edef68
2010-09-07 19:27:07 +00:00
Scott Gray 58e89dd716 Set the response content type to what was provided in the view-map definition instead of hard-coding application/pdf, allows for any type of document supported by fop to be rendered by the view handler.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@990335 13f79535-47bb-0310-9956-ffa450edef68
2010-08-28 09:47:15 +00:00
Scott Gray b4b155de17 Commented test-suite declaration in webapp's ofbiz-component.xml because the contents of the test suite file are themselves commented out
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981174 13f79535-47bb-0310-9956-ffa450edef68
2010-08-01 08:51:36 +00:00
Scott Gray 4448c4a866 No functional changes, just removing a whole bunch of unused imports and reorganizing them along the way.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981019 13f79535-47bb-0310-9956-ffa450edef68
2010-07-31 08:28:34 +00:00
Scott Gray 640ebde077 Fix for OFBIZ-3786 reported by Sascha Rodekamp, first-visit controller events were not being executed. Fix based on a simplified version of the patch provided by Sascha.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@980747 13f79535-47bb-0310-9956-ffa450edef68
2010-07-30 12:18:12 +00:00
Erwan de Ferrieres c39c604127 Manage compositeTypes in multi handler
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@967012 13f79535-47bb-0310-9956-ffa450edef68
2010-07-23 09:27:59 +00:00
Joseph Eckard d265053740 base font url will always be null
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@966719 13f79535-47bb-0310-9956-ffa450edef68
2010-07-22 16:01:22 +00:00
Joseph Eckard ea05e29713 replacing calls to deprecated FopFactory methods getFontBaseURL / setFontBaseURL
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@966718 13f79535-47bb-0310-9956-ffa450edef68
2010-07-22 16:01:14 +00:00
Joseph Eckard 18f557fe42 reverting previous change, BaseURL is not the same as FontBaseURL
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@966717 13f79535-47bb-0310-9956-ffa450edef68
2010-07-22 16:01:06 +00:00
Erwan de Ferrieres 124f19b1b4 Finally adding Apache FOP 1.0, barcode generation is now working
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@966662 13f79535-47bb-0310-9956-ffa450edef68
2010-07-22 14:02:39 +00:00
Scott Gray 114c8ae6a3 Setting the request-map/security element's direct-request attribute to false was only working if a default-request was present. Reported by Wai in OFBIZ-3861 and fixed using a variation of the patch that he supplied.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@965163 13f79535-47bb-0310-9956-ffa450edef68
2010-07-18 05:55:35 +00:00