Commit Graph
33 Commits
Author SHA1 Message Date
Jacques Le Roux fde21d0b10 reverted: CLONE - Use only HTTPS in OFBiz
(OFBIZ-11643)

Reverted, this needs more work
2020-05-04 13:21:03 +02:00
Jacques Le Roux a8c5c84cec Fixed: CLONE - Use only HTTPS in OFBiz
(OFBIZ-11643)

When doing OFBIZ-6849 I forgot to take care of the https attribute of the
security element used in controllers.

It's not used anymore since we used HTTPS everywhere but in request listed in
http.request-map.list property of url.properties. It's even enforced by HSTS for
requests that are not listed in this property.

This removes the https attribute and removes its usage in in controllers.
2020-05-04 13:10:17 +02:00
Jacques Le Roux 308fa20e81 Improved: Remove unused ‘UtilHttp#checkURLforSpiders’
(OFBIZ-11138)

The "link.remove_lsessionid.user_agent_list" properties was forgotten
2020-03-12 15:13:42 +01:00
Samuel Trégouët 889769593e Improved: Remove ‘ServiceEventHandler#checkSecureParameter’
(OFBIZ-11260)

There is no security reason justifying to prevent the invocation of
service event handlers with URI parameters if we accept request body
parameters.  As a consequence it is preferable to unconditionally
accept URI parameters and remove the
‘service.http.parameters.require.encrypted’ configuration property.
2019-11-04 22:52:16 +01:00
Deepak Dixit 471198e9eb Fixed: Shipping Label printing not working (OFBIZ-10153)
Added viewShipmentLabel in http-request map so that pdf will be able to print the shipping lable.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820823 13f79535-47bb-0310-9956-ffa450edef68
2018-01-11 05:49:53 +00:00
Deepak Dixit 4577532666 Reverted: Unwanted changes from url.properties done at r#1345849, this commit was reverted in r#1446913, but url.properties changes missed during revert.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814703 13f79535-47bb-0310-9956-ffa450edef68
2017-11-09 05:18:26 +00:00
Jacques Le Roux d34001a9d4 Fixed: "Login and logout process in demos shows a certificate issue"
(OFBIZ-9206)

After my conclusions at OFBIZ-9240 I decided to reapply the changes and will 
test on demos.

Because WebSiteProperties reuse the port initially found in the 1st login URL
I tried to replace locally
port.https=8443
by
port.https=
in url.properties (w/o SystemProperty) and did not face any issue but with 
portOffset. This is due to how the WebSiteProperties class works and there is also 
an easy fix: don't add twice the portOffset when it's build from the request, 
and only then. Keep it as is when it's build from a WebSite GenericValue. 
We then trust the user and don't rely on the request.

I also removed the deprecated RequestHandler.getDefaultServerRootUrl()
I think it was time...

Thanks: Pierre Smits for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1784930 13f79535-47bb-0310-9956-ffa450edef68
2017-03-01 13:36:05 +00:00
Jacques Le Roux 1a6d7b307d Reverts revisions 1784558, 1784555, 1784549
No functional change, cleaner code
........
No functional change, fixes a typo
........
Fixed: "Login and logout process in demos shows a certificate issue"
(OFBIZ-9206)

Also fixes "16.11 ofbizUrl include host+port and break some reverse-proxy/docker
 setups"
(OFBIZ-9224)

It was an easy fix, I just imported
<SystemProperty systemPropertyId="port.https" systemResourceId="url" 
systemPropertyValue=""/>
in trunk demo and all work perfectly.

I also tried to replace locally
port.https=8443
by
port.https=
in url.properties (w/o SystemProperty) and did not face any issue but with 
portOffset. This is due to the WebSiteProperties class works and there is also 
an easy fix: don't add twice the portOffset when it's build from the request, 
and only then. Keep it as is when it's build from a WebSite GenericValue. 
We then trust the user and don't rely on the request.

I also removed the deprecated RequestHandler.getDefaultServerRootUrl() 
I think it was time...

Thanks: Pierre Smits and Leonard Lin for reports
........


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1784760 13f79535-47bb-0310-9956-ffa450edef68
2017-02-28 15:36:42 +00:00
Jacques Le Roux 761a9e8069 No functional change, fixes a typo
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1784555 13f79535-47bb-0310-9956-ffa450edef68
2017-02-27 12:48:39 +00:00
Jacques Le Roux 31080df097 Fixed: "Login and logout process in demos shows a certificate issue"
(OFBIZ-9206)

Also fixes "16.11 ofbizUrl include host+port and break some reverse-proxy/docker
 setups"
(OFBIZ-9224)

It was an easy fix, I just imported
<SystemProperty systemPropertyId="port.https" systemResourceId="url" 
systemPropertyValue=""/>
in trunk demo and all work perfectly.

I also tried to replace locally
port.https=8443
by
port.https=
in url.properties (w/o SystemProperty) and did not face any issue but with 
portOffset. This is due to the WebSiteProperties class works and there is also 
an easy fix: don't add twice the portOffset when it's build from the request, 
and only then. Keep it as is when it's build from a WebSite GenericValue. 
We then trust the user and don't rely on the request.

I also removed the deprecated RequestHandler.getDefaultServerRootUrl() 
I think it was time...

Thanks: Pierre Smits and Leonard Lin for reports

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1784549 13f79535-47bb-0310-9956-ffa450edef68
2017-02-27 12:33:42 +00:00
Divesh Dutta 6955ceb0c3 Fix: Reverting unwanted changes from my last commits.
(OFBIZ-8744)



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768274 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 19:29:02 +00:00
Divesh Dutta 738a12bec1 Improvement: Miniland code readability and consistency improvements
(OFBIZ-8744) (OFBIZ-8745) (OFBIZ-8746) (OFBIZ-8748) (OFBIZ-8829) (OFBIZ-8830) (OFBIZ-8907) (OFBIZ-8908) (OFBIZ-8924) (OFBIZ-8925) 

Thanks: Ankush Upadhyay , Sega patidar , Abhijeet Ashapure for your patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768219 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:14:04 +00:00
Jacques Le Roux 06245c53ae A fix for "Use only HTTPS in OFBiz" - https://issues.apache.org/jira/browse/OFBIZ-6849
The tests did not pass because of xmlrpc. Simply adding it in http.request-map.list in url.properties and like for SOAPService request setting <security https="false"/> does it.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1746254 13f79535-47bb-0310-9956-ffa450edef68
2016-05-31 08:39:07 +00:00
Jacques Le Roux e7cdb8a30d Implements "Use only HTTPS in OFBiz" - https://issues.apache.org/jira/browse/OFBIZ-6849
All tests passes and the normal use of OFBiz seems to work

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1745525 13f79535-47bb-0310-9956-ffa450edef68
2016-05-25 18:02:23 +00:00
Jacques Le Roux 6d5dd1c5ba Things got totally wrong with r1742196 which contained much more than expected.
This reverts things which should not have been committed

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1742197 13f79535-47bb-0310-9956-ffa450edef68
2016-05-03 21:03:11 +00:00
Jacques Le Roux 31ef1f9186 "Continue the work on the form widget grid element" - https://issues.apache.org/jira/browse/OFBIZ-7029
Completes in screens the changes done in forms at r1741873. I then replaced few form lists by grids, where it was possible to do it with regexp.
Also complete StatsForms.xml to use only grids and "searchList" form in ecommerce ContentForms to NOT use grid (not called in screen)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1742196 13f79535-47bb-0310-9956-ffa450edef68
2016-05-03 20:50:10 +00:00
Ashish Vijaywargiya 0dff62e4e9 Reverting the changes that I mistakenly committed in trunk r1618325.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1618368 13f79535-47bb-0310-9956-ffa450edef68
2014-08-16 14:43:05 +00:00
Ashish Vijaywargiya e4d68ed2f7 Applied the patch OFBIZ-4902_framework.patch from OFBIZ-4902 - Replace in Freemarker templates the deprecated built-ins: default, exists, if_exists.
Thanks http://ofbiz.us team for providing the patch work.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1618325 13f79535-47bb-0310-9956-ffa450edef68
2014-08-16 10:58:51 +00:00
Hans Bakker 8f0c926dbb allow the fop configuration to be different between tenants
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1345849 13f79535-47bb-0310-9956-ffa450edef68
2012-06-04 07:33:24 +00:00
Scott Gray ab7580e1d9 Add an additional google bot user agent
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@952145 13f79535-47bb-0310-9956-ffa450edef68
2010-06-07 08:52:23 +00:00
Hans Bakker fbaad86261 unwanted change
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@804075 13f79535-47bb-0310-9956-ffa450edef68
2009-08-14 04:24:25 +00:00
Hans Bakker 2d51096b6d Excellent contribution from Brett G. Palmer in issue: OFBIZ-2116
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@804074 13f79535-47bb-0310-9956-ffa450edef68
2009-08-14 04:22:27 +00:00
Jacques Le Roux 46038493c4 Revert r766443 commited by accident
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@766446 13f79535-47bb-0310-9956-ffa450edef68
2009-04-19 11:06:54 +00:00
Jacques Le Roux 59dcd48d1b This was a commit error
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@766443 13f79535-47bb-0310-9956-ffa450edef68
2009-04-19 10:27:47 +00:00
David E. Jones 78d8c7cdc0 Consolidated code to check for non-encrypted parameters sent to service calls, enhanced to support a new url.properties property (service.http.parameters.require.encrypted) that controls whether or not this will throw an exception
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@764286 13f79535-47bb-0310-9956-ffa450edef68
2009-04-12 07:30:29 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Jacques Le Roux 4f4b4e5e43 Revert previous change done unintentionnaly while testing Subclipse 1.4 new interface (so far I preferred the old one...)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@676279 13f79535-47bb-0310-9956-ffa450edef68
2008-07-13 08:45:11 +00:00
Jacques Le Roux 80c57126a0 New French labels
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@676274 13f79535-47bb-0310-9956-ffa450edef68
2008-07-13 08:21:54 +00:00
Jacopo Cappellato 82e557da6c http and https ports should not be changed; I think this change has been committed by accident.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@550701 13f79535-47bb-0310-9956-ffa450edef68
2007-06-26 05:42:42 +00:00
Jacques Le Roux b67954e73a A patch from Dimitri Unruh "Remove sessionid for Googlebot & Co." (https://issues.apache.org/jira/browse/OFBIZ-857).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@550673 13f79535-47bb-0310-9956-ffa450edef68
2007-06-26 03:56:42 +00:00
Jacques Le Roux 64cea174fc This is the change of ASL2 headers in properties files only. Please see comments in another post in dev ML.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@497074 13f79535-47bb-0310-9956-ffa450edef68
2007-01-17 16:49:01 +00:00
Jacopo Cappellato bf65daa750 License change from MIT to ASL2.0 for the files of the webapp component.
Thanks to Scott Gray for the patch (Apache OFBIZ-87).

git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@423844 13f79535-47bb-0310-9956-ffa450edef68
2006-07-20 09:08:06 +00:00
David E. Jones 94fe6d1cda Initial OFBiz import from revision 7923 of the old svn.ofbiz.org SVN repository.
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@418498 13f79535-47bb-0310-9956-ffa450edef68
2006-07-01 19:05:20 +00:00