Commit Graph
7 Commits
Author SHA1 Message Date
Nicolas Malin f4aab777a5 Improved: Refactoring permission model call
(OFBIZ-7113)
With the problem to have a permission service not on the same transaction that the related service [1]

I realized the following improvement to
 * unified call evalPermission
 * move all related field for permission service on ModelService to ModelPermission
 * Remove deprecated code
 * add labelized error message  
 * call as same transaction the permission service by defautl with possibility to overide this rule 
 * add new attributes on permission model: require-new-transaction and return-error-on-failure

Thanks to Jacques Leroux for the review


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1866137 13f79535-47bb-0310-9956-ffa450edef68
2019-08-30 08:47:48 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
David E. Jones 1aeaa42a42 Added test of global-commit and global-rollback, also commented out the failing tests so that these will all succeed, as solutions are found for these other tests they should be added back in, those are the lock wait timeout tests
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@576730 13f79535-47bb-0310-9956-ffa450edef68
2007-09-18 06:46:04 +00:00
David E. Jones 20d6259e82 Added some tougher variations on the deadlock retry test case to make sure both threads succeed in the end; note that this appears to be failure for the non-retry thread so the retry code and/or the test cases need a little more work
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@573973 13f79535-47bb-0310-9956-ffa450edef68
2007-09-09 09:39:13 +00:00
David E. Jones 3249854cee A few refinements to the deadlock retry test case, but the main part of this is the actual implementation of the deadlock retry in the service engine, and the implementation of that makes the deadlock test case pass now; this is a bit of rework in some low level code so this needs some good testing beyond the few general tests already done
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@573956 13f79535-47bb-0310-9956-ffa450edef68
2007-09-09 08:13:25 +00:00
David E. Jones afefce6020 These failure cases are now running properly, though for the first lock wait timeout I still don't like the error results because it is hard to identify for retry purposes; whatever the case, here they are; NOTE these WILL all fail right now and that is expected, these are in anticipation of new Service Engine features to automatically recover from these errors
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@573813 13f79535-47bb-0310-9956-ffa450edef68
2007-09-08 10:32:18 +00:00
David E. Jones c5e71667f6 Added some test cases for deadlock and lock wait timeout errors to be used when developing auto retry feature in service engine; note that this isn't implemented yet so these (usually not used) test cases will fail, if that becommes a problem we can comment them out in the test def xml file
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@572280 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 10:45:24 +00:00