(OFBIZ-11200)
Before this commit, to purge old job we use the thread job manager to check
if some job need to be run and if the pool is empty, check the old job to purge.
I detected a problem when you have many job's server and more than one pool.
When you have a first pool that run regular job and a second that receive
huge asynchrone services (by persist call), the server who manage the second pool
have rarely the possibility to purge their jobs that, by the way, increase JobSandbox table.
The Server who manage the first pool, call often the purge process, but the table size
generate a long query time to purge few element. Long query time, run often,
this purge process load uselessly the database.
After analyze, I refactoring these following items :
* When you call JobSandbox table for a purge, use a limit on the query
with the max thread pool because when you have the database return,
you purge only with this limit so this help the database to not scan
the whole table. Other small improvement, do not sort the result
(no functional gain).
* Purge by the pool thread is nice, each server can only purge their
own job (filtered on run_by_instance_id), to help an overloaded server,
I was rehability purgeOldJobs service that it can run with specific
parameter to make assistance.
* Last, all job services are historical on class org.apache.ofbiz.service.ServiceUtil,
I moved them all in a new dedicate class org.apache.ofbiz.service.job.JobServices
(including admin) via "Forget Your Password"
(OFBIZ-4361)
Currently, any user (via ecommerce "Forget Your Password") has the ability to
reset another users password, including "admin" without permission.
By simply entering "admin" and clicking "Email Password", the following is
displayed:
The following occurred:
A new password has been created and sent to you. Please check your Email.
This now forces the user of the ERP to change their password.
It is also possible to generate a dictionary attack against ofbiz because there
is no capta code required. This is serious security risk.
I have modified the patch following comments I made in the Jira, notably
Removed unused Java variables
Removed a check in LoginEvents::forgotPassword which prevented to show error
messages
Changed fr and en SecurityExtPasswordSentToYou
+ SecurityExtThisEmailIsInResponseToYourRequestToHave labels
+ template PasswordEmail.ftl
+ loginservices.token_incorrect labels
Added fr and en SecurityExtIgnoreEmail + SecurityExtLinkOnce labels
Removed changes in general.properties
I did not remove the 2 GetSecurityQuestion.ftl files (webpos one was still in)
There is still room for improvement. I'll discuss them on the Jira and dev
ML. But this version is already strong enough to not wait that the patch is
inapplicable!
Thanks: mz4wheeler (Mike Z) for the Jira, Nicolas Malin for the patch, I guess
with some Gil's help, and all others for comments and ideas
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1866478 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-7113)
With the problem to have a permission service not on the same transaction that the related service [1]
I realized the following improvement to
* unified call evalPermission
* move all related field for permission service on ModelService to ModelPermission
* Remove deprecated code
* add labelized error message
* call as same transaction the permission service by defautl with possibility to overide this rule
* add new attributes on permission model: require-new-transaction and return-error-on-failure
Thanks to Jacques Leroux for the review
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1866137 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9161)
At OFBIZ-9159 I added the entity-auto CRUD services for JobSandbox but
w/o permission check.
While working on this issue I decided it's better to have them and decided to
also put them for JobSandbox CRUD services.
So here are the entity-auto CRUD services for RuntimeData and permission check
for JobSandbox CRUD services
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1776558 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8289) (OFBIZ-8307)(OFBIZ-8440)(OFBIZ-8728)(OFBIZ-8775)(OFBIZ-8776)(OFBIZ-8777)(OFBIZ-8778)(OFBIZ-8779)(OFBIZ-8780)(OFBIZ-8781)(OFBIZ-8782)(OFBIZ-8783)(OFBIZ-8784)(OFBIZ-8787)(OFBIZ-8964)
Thanks: Rahul Singh, Chinmay Patidar, Amit Gadaley and Rishi Solanki for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768184 13f79535-47bb-0310-9956-ffa450edef68
This improvement add a control to not update or delete an EntityStatus by entity-auto (for help developer) and complete unit test
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751530 13f79535-47bb-0310-9956-ffa450edef68
When you call expire on a entity :
* if a date field is present on service attribute, OFBiz try to expire it with the given value or with now date
* else try to expire thruDate field
* else try to expire *ThruDate or thru*Date field
With the new action I refactoring the code to separate each action on dedicate function.
the unit test associate to expire action was updated.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1735737 13f79535-47bb-0310-9956-ffa450edef68
This improvement add a entity JobManagerLock, a new screen to add/edit job manager lock and an information for end user on FindJob and ScheduleJob screen.
See more information on issue OFBIZ-6790. Thanks to Jacques for sharing on this improvement.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1727570 13f79535-47bb-0310-9956-ffa450edef68
Add the possibility to the entity-auto engine on the create action to manage entities with more than 2 primary keys which one is under sub sequence or fromDate, like PerfReview (employeePartyId, employeeRoleTypeId, perfReviewId) or PartyQual (partyId, partyQualTypeId, fromDate).
Improve return message for the create action if the entity value exist and the delete action if the entity value not exist instead of the database message error.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1637596 13f79535-47bb-0310-9956-ffa450edef68
A patch from Nicolas Malin - adding a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@959071 13f79535-47bb-0310-9956-ffa450edef68
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)
Of course this effort to remove trailing spaces has no functional implications.
Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {
So these changes are also in this commit, should not be a problem anyway.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
I put also some svn:ignore for shark build and lib diretories and assetmaint/build
I did some by hand lately, too much to remember. They were files with old header but without copyright. A 1st attempt I suppose, will have to check this after this commit.
I add some problems to commit this patch in one piece because it's so huge (specially with Eclipse I had to turn to Tortoise) !
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@499486 13f79535-47bb-0310-9956-ffa450edef68