Commit Graph
1462 Commits
Author SHA1 Message Date
Jacques Le Roux 3fedb9e5ed Some ASL2 headers
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@811870 13f79535-47bb-0310-9956-ffa450edef68
2009-09-06 19:54:25 +00:00
Scott Gray 00e1d034ea Fix a problem where empty Collections fail the field type check
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@811581 13f79535-47bb-0310-9956-ffa450edef68
2009-09-05 00:56:07 +00:00
Jacques Le Roux 372d9ce14e Fix an issue reported by André Herbst at http://markmail.org/thread/wgqhbyr5qo6j44yq. Related to r810438
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@810465 13f79535-47bb-0310-9956-ffa450edef68
2009-09-02 11:55:44 +00:00
Scott Gray 044d8d6090 Fix some code that seems to cause problems for some non-Sun JDKs
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@810438 13f79535-47bb-0310-9956-ffa450edef68
2009-09-02 09:55:20 +00:00
Scott Gray 49fe2b05ce Switched back to using scroll insensitive cursors, fixes problem reported by Jacques and Jacopo
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@809425 13f79535-47bb-0310-9956-ffa450edef68
2009-08-30 22:15:01 +00:00
Scott Gray 9df4db06bd Fix problem reported by Jacques, the ResultSet API doesn't allow FORWARD_ONLY result sets to call the first() method even
if the current position is beforeFirst or first, worked around it by having the EntityListIterator handle the
situation

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@809324 13f79535-47bb-0310-9956-ffa450edef68
2009-08-30 12:36:49 +00:00
Scott Gray d185774026 Fix to make sure the ELI count handles distinct queries
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@808824 13f79535-47bb-0310-9956-ffa450edef68
2009-08-28 09:13:01 +00:00
Scott Gray 12566c26b9 Wherever possible changed ELI queries to limit the result set to the actual rows required of the query, should improve time
and memory performance if a cursor isn't being used on large result sets quite a bit.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@808820 13f79535-47bb-0310-9956-ffa450edef68
2009-08-28 08:58:10 +00:00
Scott Gray 712364816b Changes to the EntityListIterator to use a separate COUNT query to determine the result size plus a few other changes to help the ELI deal with TYPE_FORWARD_ONLY resultsets.
The changes to SQLProcessor are unrelated and contains no functional changes.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@808812 13f79535-47bb-0310-9956-ffa450edef68
2009-08-28 08:35:45 +00:00
Jacques Le Roux 7befd1d25e no tabs but 4 spaces in code files (*.ftl, *.gro*, *.java, *.xml)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@804935 13f79535-47bb-0310-9956-ffa450edef68
2009-08-17 11:01:25 +00:00
Jacques Le Roux 4c442ee379 Some fusiness
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@804895 13f79535-47bb-0310-9956-ffa450edef68
2009-08-17 08:20:38 +00:00
Jacopo Cappellato d073d1db07 "admin" user is only in demo data.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@804131 13f79535-47bb-0310-9956-ffa450edef68
2009-08-14 08:54:01 +00:00
Hans Bakker 31a5a0c5f4 reverted 804104 because of compile error
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@804130 13f79535-47bb-0310-9956-ffa450edef68
2009-08-14 08:48:06 +00:00
Hans Bakker e40f03e356 adjustment of storing/retrieving timestamp in the proper timezone. In the database the time zone is always GMT
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@804104 13f79535-47bb-0310-9956-ffa450edef68
2009-08-14 07:42:30 +00:00
Adrian Crum 38f8588dea Small code cleanup in DelegatorData.java.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@802881 13f79535-47bb-0310-9956-ffa450edef68
2009-08-10 18:22:40 +00:00
Adrian Crum 22dc76f12f Fixed a bug in DelegatorData.java.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@802877 13f79535-47bb-0310-9956-ffa450edef68
2009-08-10 18:09:07 +00:00
Adrian Crum 6786aa4dbc Refactored GenericDelegator:
1. Converted GenericDelegator to an interface. We already have DelegatorInterface, but it isn't being used anywhere. Removed DelegatorInterface.java.

2. Extracted the static, cached data from the GenericDelegator implementation and put it in its own class - DelegatorData. The GenericDelegator implementation holds a reference to the DelegatorData instance. This makes it possible to have per-thread instances of GenericDelegator.

3. Replaced the ThreadLocal variables with regular variables. ThreadLocal variables are no longer needed. Client code doesn't need to be concerned with pushing and popping the GenericDelegator state.

This commit paves the way for the forthcoming ExecutionContext.

User modifications will have to replace GenericDelegator.getGenericDelegator(...) with DelegatorFactory.getGenericDelegator(...). Also, replace the push code with the new setXxx methods, and remove the pop code. If modifications used DelegatorInterface, replace that with GenericDelegator.

Aside from those changes, this commit is backwards compatible.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@802567 13f79535-47bb-0310-9956-ffa450edef68
2009-08-09 18:04:26 +00:00
David E. Jones 3f8f20e601 Added example of nested view-entity with entity-condition on a view member entity; adjusted view-entity entity-condition to handle naming consistent to other places for nested views, other small cleanups
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@792836 13f79535-47bb-0310-9956-ffa450edef68
2009-07-10 08:47:16 +00:00
David E. Jones e550fc35ca Removed comments so that queries won't always show in the log; thanks to Adam for the reminder
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@792546 13f79535-47bb-0310-9956-ffa450edef68
2009-07-09 13:17:08 +00:00
David E. Jones f8471fc20d Refactored implementation of view-entity entity-condition implementation to support the changes to the XSD and support the various new options; tested to work with the various cases in the entitymodel_view.xml file in the example component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@792420 13f79535-47bb-0310-9956-ffa450edef68
2009-07-09 06:48:05 +00:00
David E. Jones d83da9a32a Added some notes on additional things to add
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@792394 13f79535-47bb-0310-9956-ffa450edef68
2009-07-09 04:28:27 +00:00
David E. Jones bc8b260f8d Some cleanups of the design for the entity-condition stuff; I should have reviewed and cleaned up this XSD more before doing the last commit as there are a number of things that did not work and are not useful in this context from the entity-condition patterns used in the widgets and simple-methods; the implementation is not updated yet for these changes but will be soon; while not all of the changes here are supported yet the ones that are removed were things that did not work anyway; in the mean time feedback on the design is welcome
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@792116 13f79535-47bb-0310-9956-ffa450edef68
2009-07-08 12:41:04 +00:00
Scott Gray dec24b29f2 Sorry for the big commit, got a bit carried away.
Added override and deprecated annotations wherever they were missing
Removed the use of any deprecated classes/methods (except OutputFormat in UtilXml)
A few other random generics and misc. cleanups

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@791212 13f79535-47bb-0310-9956-ffa450edef68
2009-07-05 10:01:19 +00:00
David E. Jones 9add252033 Added Override annotations as suggested by Adam Heath to avoid missing these again in the future and causing problems
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@791054 13f79535-47bb-0310-9956-ffa450edef68
2009-07-04 03:21:18 +00:00
David E. Jones 1bba575471 Small refactoring, changed so select count uses new entity-condition stuff under the view-entity
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@790793 13f79535-47bb-0310-9956-ffa450edef68
2009-07-03 05:30:18 +00:00
David E. Jones d429bad707 Fixed bug reported by Hans and Adrian that broke the ByAndFinder class where string because method that overrides one on ListFinder wasn't doing that any more because the ListFinder method signature had changed; also did a few little cleanups related to this
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@790791 13f79535-47bb-0310-9956-ffa450edef68
2009-07-03 05:14:00 +00:00
David E. Jones 7e981d3cb3 Added ability to specify an entity-condition as part of a view-entity in order to encapsulate a full query definition in a view-entity
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@790472 13f79535-47bb-0310-9956-ffa450edef68
2009-07-02 06:43:50 +00:00
Jacques Le Roux e60a3fa0d1 Info about max_connections in postgresql.conf (related to pool-maxsize)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@782927 13f79535-47bb-0310-9956-ffa450edef68
2009-06-09 09:25:52 +00:00
Hans Bakker 59830ab104 instead of a NPE show an error message
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@778984 13f79535-47bb-0310-9956-ffa450edef68
2009-05-27 03:46:26 +00:00
Scott Gray 6aa97d6adb Typos
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@775821 13f79535-47bb-0310-9956-ffa450edef68
2009-05-18 05:55:45 +00:00
Jacques Le Roux 058d6aed57 A patch from Ashish Vijaywargiya "Change Copyright Year" (https://issues.apache.org/jira/browse/OFBIZ-2346) - OFBIZ-2346
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@772936 13f79535-47bb-0310-9956-ffa450edef68
2009-05-08 10:56:14 +00:00
David E. Jones daebb63942 Small improvement in error message for location parsing
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@771195 13f79535-47bb-0310-9956-ffa450edef68
2009-05-04 06:29:36 +00:00
David E. Jones 5f2671153d Changed to support component:// URLs, should fix issue reported by Hans in OFBIZ-2418
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@771193 13f79535-47bb-0310-9956-ffa450edef68
2009-05-04 06:24:54 +00:00
Adam Heath 2f59201bbd Make this a bit nicer for generics users.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@771123 13f79535-47bb-0310-9956-ffa450edef68
2009-05-03 20:35:00 +00:00
Adam Heath a2fb671036 Remove unused EnumMap import.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@771121 13f79535-47bb-0310-9956-ffa450edef68
2009-05-03 20:17:37 +00:00
Adam Heath 812b0e50d4 No more generics warnings.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@771120 13f79535-47bb-0310-9956-ffa450edef68
2009-05-03 20:16:24 +00:00
Adam Heath 37a3734593 Some tightening of generics.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@770034 13f79535-47bb-0310-9956-ffa450edef68
2009-04-30 01:59:21 +00:00
Adam Heath 9840b7cc1c Fix some StringBuffer usage that has crept in.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@770030 13f79535-47bb-0310-9956-ffa450edef68
2009-04-30 01:22:44 +00:00
Scott Gray 0444b960a2 Wrap EntityListIterator usage in a transaction
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@768999 13f79535-47bb-0310-9956-ffa450edef68
2009-04-27 14:19:33 +00:00
Scott Gray 50380d2301 Allow GenericEntity.NULL values through without warnings
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@768984 13f79535-47bb-0310-9956-ffa450edef68
2009-04-27 13:52:31 +00:00
Jacques Le Roux 0594f35d91 A patch from Tamer Sezgin "ij.ofbiz does not work" https://issues.apache.org/jira/browse/OFBIZ-2355 - OFBIZ-2355
+ update of Derby to 10.4.2.0

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@768608 13f79535-47bb-0310-9956-ffa450edef68
2009-04-25 21:43:34 +00:00
Jacques Le Roux 46038493c4 Revert r766443 commited by accident
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@766446 13f79535-47bb-0310-9956-ffa450edef68
2009-04-19 11:06:54 +00:00
Jacques Le Roux 59dcd48d1b This was a commit error
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@766443 13f79535-47bb-0310-9956-ffa450edef68
2009-04-19 10:27:47 +00:00
David E. Jones a415efaaa3 Based on feedback from Philippe Mouawad in Jira issue #OFBIZ-2315 changed the non-ThreadLocal maps to be synchronized
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@766429 13f79535-47bb-0310-9956-ffa450edef68
2009-04-19 06:49:58 +00:00
David E. Jones ba72c5edf8 Reverted change to prefix all sequenced IDs; new change to ofbiz extensions of UEL from Adrian should fix issues there, and this isn't needed in general
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@765067 13f79535-47bb-0310-9956-ffa450edef68
2009-04-15 07:15:45 +00:00
Scott Gray 7531687fdd OFBIZ-2259: Implemented test data rollback per test-suite using the GenericDelegator
Provides the following benefits:
1. Test data independence per component suite
2. Ability to run tests repeatedly without reloading the database
3. Continued database independence for the testing tools
4. The possibility of future improvements for controlling when data is rolled back (per unit test, group of unit tests within a suite or
even tree structured tests where data is partially rolled back before continuing)
5. The future possibility to export data changes resulting from a test run
6. The future possibility to verify a test result automatically based on the output of #4

The rollback currently doesn't catch changes resulting from async service calls and also doesn't rollback changes to SequenceValueItem

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@765057 13f79535-47bb-0310-9956-ffa450edef68
2009-04-15 06:01:36 +00:00
David E. Jones b502c14948 Small change to have a prefix for all sequenced IDs by default
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@764947 13f79535-47bb-0310-9956-ffa450edef68
2009-04-14 20:50:23 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Jacques Le Roux a5042291f7 1st part of an effort to remove trailing spaces
" +/> => "/>
Should be easier when dealing with Eclipse S/R regexp

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@762648 13f79535-47bb-0310-9956-ffa450edef68
2009-04-07 08:27:15 +00:00
Adam Heath 722aca2618 Fix lines that *only* have whitespace.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759234 13f79535-47bb-0310-9956-ffa450edef68
2009-03-27 16:56:58 +00:00