Deepak Dixit
574bf8fa31
Fixed: Corrected property name as defined in general.properties
...
(OFBIZ-10008)
2021-02-17 12:43:06 +05:30
Wiebke Pätzold
82a15c70e3
Improved: Removed inner assignments (OFBIZ-12169)
2021-02-10 11:38:04 +01:00
Wiebke Pätzold
3cd7cf1cea
Improved: Changed modifier order (OFBIZ-12169)
2021-02-10 11:31:12 +01:00
Wiebke Pätzold
03960053a8
Improved: Replaced '.*' import form (OFBIZ-12169)
2021-02-09 11:30:18 +01:00
Wiebke Pätzold
c1c0813da2
Improved: Removes illegal character as shown by checkstyle (OFBIZ-12169)
2021-02-09 10:19:49 +01:00
Wiebke Pätzold
95d37d2189
Removes and adds whitespaces as suggested by checkstyle (OFBIZ-12169)
2021-02-09 08:46:20 +01:00
Michael Brohl
bae3628501
Declare classes final as suggested by checkstyle (OFBIZ-12169)
...
Helper and Worker classes which are likely to be extended by custom
projects where left as is.
2021-02-08 17:09:56 +01:00
Jacques Le Roux
a234f8e201
Improved: fixes a Java doc issue reported by checkstyle
...
Also removes unused ModelEntity::toXmlElement and ModelEntity::toGroupXmlElement
tasks.checkstyleMain.maxErrors from 278 to 277
2021-02-05 11:26:34 +01:00
Benjamin Jugl
8fac07ad0a
Improved: Replaces ModelInduceFromDb with widgets (OFBIZ-6510)
2021-02-03 12:39:15 +01:00
Benjamin Jugl
17864a11e9
Fixed: Possible NPE in DatabaseUtil.getColumnInfo(...) (OFBIZ-11385)
2021-01-25 18:11:54 +01:00
Daniel Watford
7830328bb4
Improved: Removed deprecated ExpectedException.none from tests
...
(OFBIZ-12137)
Prevents logging of deprecation warnings during the build.
2021-01-14 17:07:40 +00:00
Nicolas Malin
816068335c
Improved: Improve makeRangeCondition in file EntityDateFilterCondition.java
...
(OFBIZ-12051)
When we have a value with both from and thrudate greater than given range
Thanks to Leila Mekika for this improvement
2020-11-29 19:21:23 +01:00
Jacques Le Roux
a8b252f7dd
Reverted: "description" and "comment" datatypes unnecessarily limited to 255 char (OFBIZ-12021)
...
This reverts commit 8736162c74 .
We have test integration issues to fix
Due to TortoiseGIt, something weird happened, confused me to revert the revert :/
2020-10-03 13:41:41 +02:00
Jacques Le Roux
8736162c74
Reverted: "description" and "comment" datatypes unnecessarily limited to 255 char (OFBIZ-12021)
...
This reverts commit 686f01c8cf .
We have test integration issues to fix
2020-10-03 13:30:15 +02:00
Jacques Le Roux
8ef3b54c22
Reverted: "description" and "comment" datatypes unnecessarily limited to 255 char (OFBIZ-12021)
...
This reverts commit 686f01c8cf .
We have test integration issues to fix
2020-10-03 13:28:10 +02:00
Jacques Le Roux
686f01c8cf
Improved: "description" and "comment" datatypes unnecessarily limited to 255 char (OFBIZ-12021)
...
"Description" and "comment" fields are restricted to 255 char.
However after some research I found that all the supported databases support
longer then 255 char
I would expect users to want to write more then 255 char in a comment
(I know I personally can).
A discussion has been started on dev ML:
https://markmail.org/message/7utrgejc2c44i37u
Also adds a note in DATAMODEL_CHANGES.adoc
Thanks: ddev
2020-10-03 11:26:27 +02:00
Jacques Le Roux
ae8b2d89b0
Improved: Checkstyle: Variable name must match pattern (OFBIZ-11926)
...
Removes last remaining "Must have at least one statement" issues by using
Debug.logVerbose
Decreases tasks.checkstyleMain.maxErrors from 543 to 535
Thanks: Suraj for report
2020-09-16 10:30:37 +02:00
Jacques Le Roux
231f97f030
Improved: Demo Data in conflict with Entity Unique Index when loading data during creation (OFBIZ-11998)
...
This is a known issue with MsSQL since
http://ofbiz.135035.n4.nabble.com/Unique-constraint-on-Person-cardId-breaks-ofbiz-on-SQL-Server-td4656840.html
The problem does not exist with Derby, nor with the mostly open source DBMS
used with OFBiz: Postres, MySQL, MariaDB, etc.
So we will not change the current OOTB setting and suggest to simply change
your own configuration
Thanks: Schumann Ye for report
2020-09-16 09:09:06 +02:00
Jacques Le Roux
346c63bfdf
Improved: Checkstyle: Variable name must match pattern (OFBIZ-11926)
...
We have a lot of "do nothing" in Java code. In case of catch we should at least
have Debug.logError(e, MODULE); and maybe an explanation in the comment.
2020-09-15 15:24:45 +02:00
Suraj Khurana
a5619831eb
Improved: Added missing Javadocs for remaining methods in framework component, this is required for all classes which looks like designed for extension (can be subclassed).
...
(OFBIZ-11947)
Thanks Jacques for review.
2020-09-13 11:28:00 +05:30
Suraj Khurana
97b1688b0d
Improved: Make data members of class as private and added accessor methods for the same, also corrected occurences of the same in framework component.
...
(OFBIZ-11963)
Also made some related checkstyle code enhancements. Thanks Jacques for review.
2020-09-12 12:05:16 +05:30
Suraj Khurana
bc5e945ded
Improved: Corrected line is longer than 150 characters checkstyle issues in framework component.
...
(OFBIZ-11921)
Also fixed some other extra space and naming related checkstyle issues observed.
Thanks Jacques for review.
2020-09-04 12:25:12 +05:30
Suraj Khurana
ca9fa4fba4
Improved: Corrected line is longer than 150 characters checkstyle issues in framework and applications component.
...
(OFBIZ-11921)
Also fixed some extra spaces and naming conventions related checkstyle issues.
Thanks Jacques for review.
2020-08-31 19:54:54 +05:30
Akash Jain
66a76ffd5a
Improved: Fix Literals comparisons with variable to avoid NPE (OFBIZ-11929)
...
Thanks, Devanshu Vyas for your contribution.
2020-08-30 17:20:23 +05:30
Suraj Khurana
f98f5ebb86
Improved: Added missing Javadocs for some methods, this is required for all classes which looks like designed for extension (can be subclassed).
...
(OFBIZ-11947)
Also fixed some other checkstyle issues that requires re-factoring.
Thanks Jacques for review.
2020-08-28 16:54:15 +05:30
Suraj Khurana
f357b997c0
Improved: Corrected class names, method names, data members of class and variables names in framework component.
...
(OFBIZ-11926)
Also corrected some formatting and line length related checkstyle issues.
2020-08-26 21:40:40 +05:30
Pawan Verma
6cb67c1a40
Improved: Replace .size() == 0 with isEmpty() in Java files(OFBIZ-11944)
...
Thanks, priya for the report and patch and jacques for the review.
2020-08-22 19:17:10 +05:30
Suraj Khurana
9689201b84
Improved: Make data members of class as private and added accessor methods for the same, also corrected occurences of the same in framework component.
...
(OFBIZ-11963)
Also made some related checkstyle code enhancements.
Thanks jacques for finalizing Javadoc pattern during this effort.
2020-08-22 13:20:39 +05:30
Suraj Khurana
8c10d4ae72
Improved: Added missing Javadocs for some methods, this is required for all classes which looks like designed for extension (can be subclassed).
...
(OFBIZ-11947)
This is done for framework component. Also corrected some variables as per naming convention best practices.
Thanks Jacques for review.
2020-08-17 12:30:26 +05:30
Priya Sharma
3fe72d440f
Improved: Remove unused imports from Java files (OFBIZ-11930) ( #222 )
...
Improved: Remove unused imports from Java files
(OFBIZ-11930)
Thanks: Priya Sharma
2020-08-06 19:51:09 +05:30
Suraj Khurana
33f05c1684
Improved: Corrected all redundant modifiers occurences in framework component. Also, fixed some other checkstyle line formatting and spacing issues.
...
(OFBIZ-11925)
2020-08-06 18:53:13 +05:30
Suraj Khurana
7d82b17c72
Improved: Corrected some line is longer than 150 characters checkstyle issues in framework component. Also fixed some extra spaces and naming conventions related checkstyle issues.
...
(OFBIZ-11921)
2020-08-03 10:11:40 +05:30
Suraj Khurana
d374019465
Improved: Corrected all incorrect indentation level issues in framework component, also fixed some case indentation checkstyle issues.
...
(OFBIZ-11922)
2020-07-26 21:04:41 +05:30
Suraj Khurana
f4f2722d36
Improved: Updated case indentation to 0 for all switch statements in framework component. Also done formatting changes as per checkstyle best practices.
...
(OFBIZ-11904)
2020-07-25 13:50:37 +05:30
Suraj Khurana
7b251e43d9
Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in framework component.
...
(OFBIZ-11886)
2020-07-21 12:25:20 +05:30
Suraj Khurana
8b1e0dbd85
Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in framework component.
...
(OFBIZ-11887)
2020-07-18 12:26:42 +05:30
holivier
91fe7bf4cc
Documented: Framework, delete all docbook files related to migration to
...
asciidoc
(OFBIZ-11587)
- common-sending-email: include in email
- datafile: move as a include at the end of entity-engine section
- entity-engine: list of link to OFBiz wiki about entity configuration
- service-engine: a link to OFBiz wiki Service Engine Guide
- webtools: help for main screen
- mini-lang: include a link to OFBiz wiki mini-lang-reference at the
beginning of minilang-to-groovy-manual
move minilang-to-groovy-manual to Development environment
section
- unit-test: include as Junit test, and use README to list gradle
command available (so add a tag in REAME.adoc)
- base: add a link to OFBiz wiki Configuration Guide, in deployment
section
- SingleSignOn with LDAP: move to plugin LDAP and include in deployment
section
2020-07-14 17:04:36 +02:00
holivier
b0f445b123
Documented: Framework, migration all docbook files to asciidoc
...
(OFBIZ-11587)
- common-sending-email: include in email
- datafile: move as a include at the end of entity-engine section
- entity-engine: list of link to OFBiz wiki about entity configuration
- service-engine: a link to OFBiz wiki Service Engine Guide
- webtools: help for main screen
- mini-lang: include a link to OFBiz wiki mini-lang-reference at the
beginning of minilang-to-groovy-manual
move minilang-to-groovy-manual to Development environment
section
- unit-test: include as Junit test, and use README to list gradle
command available (so add a tag in REAME.adoc)
- base: add a link to OFBiz wiki Configuration Guide, in deployment
section
- SingleSignOn with LDAP: move to plugin LDAP and include in deployment
section
developer-manual is updated with some include lines or with directly a
sentence.
2020-07-14 16:56:05 +02:00
Suraj Khurana
0c37e80036
Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in framework component.
...
(OFBIZ-11880)
Thanks Jacques for review.
2020-07-13 14:18:24 +05:30
Suraj Khurana
dd4da77d76
Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for framework component.
...
(OFBIZ-11874)
This fixes following checkstyle issues:
'{' is not preceded with whitespace.
'{' is not followed by whitespace.
'}' is not followed by whitespace.
'}' is not preceded with whitespace.
'typecast' is not followed by whitespace.
'try' is not followed by whitespace.
';' is preceded with whitespace.
2020-07-11 14:33:47 +05:30
Pawan Verma
5c27d7ad5b
Improved: Introduce support for having condition in EntityQuery#queryList method(OFBIZ-11846)
...
Thanks, Nitish and Suraj for review.
2020-07-11 09:36:13 +05:30
Suraj Khurana
3bb22302c7
Improved: Corrected all checkstyle issues related to succeeding space for comma in framework directory.
...
(OFBIZ-11805)
Thanks Jacques and Ritesh Kumar for review.
2020-07-09 12:07:29 +05:30
Suraj Khurana
fc6b8a6ca3
Improved: Corrected remaining ', is not followed by whitespace' checkstyle errors in framework component.
...
(OFBIZ-11805)
2020-07-07 15:08:17 +05:30
Suraj Khurana
bbfb390fb8
Merge branch 'trunk' of https://gitbox.apache.org/repos/asf/ofbiz-framework into trunk
2020-07-06 15:31:59 +05:30
Suraj Khurana
4f53828bea
Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors in framework component.
...
(OFBIZ-11805)
Thanks Jacques Le Roux and Ritesh Kumar for review.
2020-07-06 15:29:58 +05:30
Pawan Verma
71ac32c89b
Implemented: EntityBatchIterator which pages through large resultsets (500 at a time by default) and added support for EntityBatchIterator to EntityQuery via 'queryBatchIterator'(OFBIZ-11789) ( #191 )
...
Modified GenericDao#makeOffsetString to have OFFSET/FETCH style by default
Modified entityengine's mysql and postgres datasources to have LIMIT/OFFSET style, rest can work with default OFFSET/FETCH style
Thanks: Scott for the help.
2020-07-04 23:02:47 +05:30
Pawan Verma
031592cc32
Fixed: EntityQuery queryCount is throwing error with distinct method (OFBIZ-11294)
...
Added missing support for selectFields in queryCount and all the subsequent methods.
Thanks: Deepak Dixit for the review.
2020-06-28 01:40:58 +05:30
Pawan Verma
3da16a182c
Improved: Replace Collection.sort() with List.sort().(OFBIZ-11830)
2020-06-28 01:21:23 +05:30
Pawan Verma
e19b12eae9
Improved: Replace explicit type argument with diamond operator(OFBIZ-11828)
...
Since Java 1.7, when defining generic types it is unnecessary to redefine those types in the constructor when it is already done in the declared type.
2020-06-28 01:04:51 +05:30
Pawan Verma
f0af2894e5
Improved: Merge identical catch blocks in single catch block(OFBIZ-11827)
...
In Java SE 7 and later, a single catch block can handle more than one type of exception. This feature can reduce code duplication and lessen the temptation to catch an overly broad exception.
Thanks: Jacques for the review.
2020-06-27 11:23:12 +05:30