Commit Graph
2222 Commits
Author SHA1 Message Date
Jacques Le Roux 5e1d1f763e Improved: Make xssi prefix configurable
(OFBIZ-9169)

In OFBIZ-5409 a prefix was added for GET ajax requests.
It would be beneficial if the prefix could be configured instead of hard coded

jleroux: at r1777942 I missed the general.properties change

Thanks: Michael Brohl for reporting the issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821386 13f79535-47bb-0310-9956-ffa450edef68
2018-01-17 15:28:51 +00:00
Jacques Le Roux edd922a62f Improved: Update Geo information according to ISO notifications, Mali
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

This is mostly to check WIP at INFRA-15836 and INFRA-15842,
so will be backported

Thanks: Kyra Pritzel-Hentley 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821219 13f79535-47bb-0310-9956-ffa450edef68
2018-01-16 07:58:49 +00:00
Jacques Le Roux 65a24ca17f Improved: Update Geo information according to ISO notifications, Moldova
(the Republic of)/
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

This is mostly to check WIP at INFRA-15836, so will be backported

Thanks: Kyra Pritzel-Hentley 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821186 13f79535-47bb-0310-9956-ffa450edef68
2018-01-15 17:47:05 +00:00
Jacques Le Roux 978360b471 Improved: Update Geo information according to ISO notifications, Lao People's
Democratic Republic (the)
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

This is mostly to check WIP at INFRA-15836, so will be backported

Thanks: Kyra Pritzel-Hentley 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821144 13f79535-47bb-0310-9956-ffa450edef68
2018-01-15 10:45:33 +00:00
Jacques Le Roux 7de1951eee Improved: Update Geo information according to ISO notifications, Korea
(the Democratic People's Republic of)
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

This is mostly to check WIP at INFRA-15836, so will be backported

Thanks: Kyra Pritzel-Hentley 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821112 13f79535-47bb-0310-9956-ffa450edef68
2018-01-14 18:23:57 +00:00
Jacques Le Roux 19d9b3ca30 Improved: Replace Asm select plugin with Select2.
(OFBIZ-10113)

Current Asm Select Plugin 
http://www.ryancramer.com/journal/entries/asmselect_v104/
can be replaced with Select2 (https://select2.org/).

* Select2 has much better community support on GitHub with 386 contributors 
  while Asm Select Plugin is handled by Ryan Cramer on http://www.ryancramer.com/.
* Select2 has 37 releases while Asm select has very few releases yet.
* Both the plugin has MIT license.

Refer https://select2.org/ and  
https://github.com/select2/select2 for more features and other information.

Added i18n support so added logic in JsLanguageFileMappingCreator and 
JsLanguageFilesMapping accordingly.
Added some custom CSS as the Select2 seems to be too fancy in accordance 
with the current OFBiz themes

Verify:
Multiple drop-downs field in FormWidgetExamples.
https://localhost:8443/example/control/FormWidgetExamples

Find Request page with StatusId , CustRequestId
https://localhost:8443/ordermgr/control/FindRequest

I have replaced the plugins though I feel the implementation of select multiple 
js code is to be reviewed & refactored. I will pick when I am done with all my 
current tasks if I get some consensus.

Thanks: Aditya 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821001 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 15:47:47 +00:00
Jacques Le Roux fbba91bbcd Improved: Update Geo information according to ISO notifications
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

Here are China, Germany, Hungary and Indonesia

Thanks: Kyra Pritzel-Hentley 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820644 13f79535-47bb-0310-9956-ffa450edef68
2018-01-09 11:30:39 +00:00
James Yong b2004efd5a Improved: ID should be the abbreviation for identity in English
(OFBIZ-100131)

Cover translations that are missed earlier.
Also cover non-English translations.

Thanks: Jacques for the additional patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820451 13f79535-47bb-0310-9956-ffa450edef68
2018-01-07 12:16:21 +00:00
Jacques Le Roux 883b3f7f1e Improved: Update Geo information according to ISO notifications, Ecuador
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

This is mostly to check WIP at INFRA-15394, INFRA-15785 and OFBIZ-10147

Thanks: Kyra Pritzel-Hentley 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820441 13f79535-47bb-0310-9956-ffa450edef68
2018-01-07 10:51:39 +00:00
Jacques Le Roux aa5ecc3540 Improved: Update Geo information according to ISO notifications, Iceland
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

This is mostly to check WIP at INFRA-15394, INFRA-15785 and OFBIZ-10147

Thanks: Kyra Pritzel-Hentley 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820375 13f79535-47bb-0310-9956-ffa450edef68
2018-01-06 07:13:44 +00:00
Jacques Le Roux 0b91b6e911 Improved: Update Geo information according to ISO notifications, Cyprus
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

Thanks: Kyra Pritzel-Hentley 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820374 13f79535-47bb-0310-9956-ffa450edef68
2018-01-06 06:01:15 +00:00
James Yong 38d0f7455d Fixed: ID should be the abbreviation for identity in English
(OFBIZ-10131)

Replaced the word 'Id' with 'ID' in the *Labels.xml files for "en" locale.
Improved the logic for auto title so that labels generated for variables like productTypeId 
will be 'Product Type ID' instead of 'Product Type Id'.

Thanks: Jacques for the review.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819906 13f79535-47bb-0310-9956-ffa450edef68
2018-01-02 21:58:37 +00:00
James Yong ba2e822f27 Implemented: Tomcat SSO
(OFBIZ-10047)

This allow developers the option to use Tomcat SSO, instead of externalLoginKey, for SSO.

Thanks: Jacques and Michael for the reviews

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819133 13f79535-47bb-0310-9956-ffa450edef68
2017-12-23 10:39:44 +00:00
Deepak Dixit fb77a3c477 Improved: Logging: change all System.out/.err/.. println to Debug.log... in the code base (OFBIZ-10045)
Thanks Michael Brohl and Kyra Pritzel-Hentley for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819124 13f79535-47bb-0310-9956-ffa450edef68
2017-12-23 09:08:04 +00:00
Jacques Le Roux 35ee954560 Completed: Remove applet concept in OFBiz
(OFBIZ-10094)

Following discussion at http://markmail.org/message/dlp4zoo3xxuiefpn :

While reviewing http://svn.apache.org/viewvc?view=revision&revision=1811438 
I stumbled upon the usage of Java Applets

It's still possible to use Java Applets in browsers but most of the time it's 
not OOTB https://www.digitalcitizen.life/how-enable-java-all-major-web-browsers

And Java 9 deprecates it https://www.java.com/en/download/faq/jdk9_plugin.xml


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818646 13f79535-47bb-0310-9956-ffa450edef68
2017-12-19 10:33:15 +00:00
Deepak Dixit d24c956bf9 Improved: Moved plugins js from images to common/js (OFBIZ-5776)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818600 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 18:16:09 +00:00
Michael Brohl b932ce362a Improved: General refactoring and code improvements, package
org.apache.ofbiz.common.login.
(OFBIZ-9880)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818567 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 13:45:13 +00:00
Michael Brohl 6329196e14 Improved: General refactoring and code improvements, package
org.apache.ofbiz.common.email.
(OFBIZ-9876)

Thanks Julian Leichert for reporting and providing the patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818557 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 12:21:16 +00:00
Michael Brohl dcf4ab8ef6 Improved: General refactoring and code improvements, package
org.apache.ofbiz.common.image.
(OFBIZ-9878)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818556 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 12:01:53 +00:00
Michael Brohl 5bfe284067 Improved: General refactoring and code improvements, package
org.apache.ofbiz.common.qrcode.
(OFBIZ-9883)

Thanks Julian Leichert for reporting and providing the patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818551 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 10:52:13 +00:00
Michael Brohl 1d75c7f50c Improved: General refactoring and code improvements, package
org.apache.ofbiz.common.preferences.
(OFBIZ-9927)

Thanks Dennis Balkir for reporting and providing the patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818548 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 10:16:05 +00:00
Michael Brohl 4f85d01d72 Improved: General refactoring and code improvements, package
org.apache.ofbiz.common.
(OFBIZ-9930)

Thanks Dennis Balkir for reporting and providing the patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818544 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 09:51:44 +00:00
Michael Brohl fe66233dc4 Improved: No functional change, removed obsolete import.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818466 13f79535-47bb-0310-9956-ffa450edef68
2017-12-17 09:41:58 +00:00
Jacques Le Roux e0d2057456 Improved: Always check if debug verbose is on when using Debug.logVerbose()
(OFBIZ-10052)

We discussed on this point: http://markmail.org/message/mplvusuqn7oshl4v 
and we agreed about better doing a check when using Debug.logVerbose().

I checked there are 300+ cases like that. Since it's an easy S/R 
This implements it

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818005 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 12:43:05 +00:00
Deepak Dixit 7e19de9966 Improved: Replace all delegator findByAnd and findOne method calling by EntityQuery methods (OFBIZ-10029)
Applied slightly modified patch, rearrange import properly, 
Thanks Suraj Khurana for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818003 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 12:03:17 +00:00
Deepak Dixit 63258e90f8 Reverted r#1817989, workign fine locally, reverted for now will check and commit again
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817998 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 10:42:32 +00:00
Deepak Dixit d1f85a7e5d Improved: Replace all delegator findByAnd and findOne method calling by EntityQuery methods (OFBIZ-10029)
Applied slightly modified patch, rearrange import properly, 
Thanks Suraj Khurana for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817989 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 09:21:33 +00:00
Michael Brohl bf6310c5e4 Improved: General refactoring and code improvements, package
org.apache.ofbiz.common.authentication.
(OFBIZ-9875)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817751 13f79535-47bb-0310-9956-ffa450edef68
2017-12-11 08:10:16 +00:00
Jacques Le Roux 48a2f6dc8b Fixed: Fix Default or Empty Catch block in Java and Groovy files
(OFBIZ-8341)

While reviewing recent Michael's FB commits I spotted a bunch of (unrelated) 
swallowed exceptions. This fixes them

Also few formatting and use of multi catches



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817703 13f79535-47bb-0310-9956-ffa450edef68
2017-12-10 12:00:07 +00:00
Jacques Le Roux cac7d76cba Implemented: Handle service response effectively
(OFBIZ-9981)
Included Debug.logError in ServiceUtil.returnProblem so that in case of any 
error occurred and handled, it will always be logged on the console.
jleroux: I put a toString() there, Debug.logError() does not work with maps

Also no functional change (better code) in QRCodeEvents
jleroux: I also replaced tabs by spaces there 
            and put debug info in exceptions

Thanks: Suraj Khurana

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817455 13f79535-47bb-0310-9956-ffa450edef68
2017-12-08 05:04:23 +00:00
Jacques Le Roux 8021fd3717 Improved: Upgrade Jquery 1.11.0 to JQuery 3.2.1
(OFBIZ-9978)

Includes following changes
jQuery UI upgraded to 1.12.1
Included CSS files to theme properties and screens.

Manually added datepicker-en.js and datepicker-it-CH.js a new candidate added 
it to jsLanguageFilesMapping
Updated defaultDateTime path of dateTime picker it was having path of 
timepicker files.

I18n files for datepicker renamed from jquery.ui.datepicker- to datepicker- 
as comes with the JQuery ui package so that we don’t have to rename files 
manually everytime we upgrade.
https://github.com/jquery/jquery-ui/tree/master/ui/i18n
Can’t get jquery-ui-i18n.js file though it was not used either.

I have not updated jQuery.cookie-1.4.0.js as it is related to jstree and we will 
update & move it when we will update jstree.

Jeditable 1.7.2 upgraded to 1.7.3

I feel JQuery ui should also be in plugins folder with other JQuery plugin

Thanks: Aditya

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817026 13f79535-47bb-0310-9956-ffa450edef68
2017-12-03 10:15:55 +00:00
Jacques Le Roux 04f84bac79 Improved: Make the general.SystemPropertyValue same than the related property
in general properties
(OFBIZ-9924)

only VISUAL_THEME value was concerned

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816899 13f79535-47bb-0310-9956-ffa450edef68
2017-12-01 19:10:00 +00:00
Jacques Le Roux b7127e1ed2 Improved: Upgrade Jquery 1.11.0 to JQuery 3.2.1
(OFBIZ-9978)

Upgrades jQuery Timepicker Addon to 1.6.3 
https://github.com/trentrichardson/jQuery-Timepicker-Addon/
 jQuery UI Slider Access comes with JQuery Timepicker addon package.
 Moved localization to i18n (as comes with package) & made changes accordingly
 Working well with even jQuery UI 1.10.

Steps to verify:
https://localhost:8443/ordermgr/control/ListQuoteRoles?quoteId=CQ0001
https://localhost:8443/example/control/FormWidgetExamples
https://localhost:8443/catalog/control/EditProduct

Interestingly it supports Millisecond, Microsecond and Time Zone too.

jleroux: as required with such changes I ran the createJsLanguageFileMapping 
service to create or update the JsLanguageFilesMapping class content (this is
documented in JsLanguageFileMappingCreator class
We got some new ones:
-fa.js
-lv.js
-mk.js
-sl.js
-sq.js
but lost CZ (not quite sure about that one, I vaguely remember something we
discussed with Aditya )

Thanks: Aditya 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816377 13f79535-47bb-0310-9956-ffa450edef68
2017-11-26 10:18:36 +00:00
Jacques Le Roux ffa5438ff8 Improved: Replace request-redirect w/ no redirect-param attribute by
request-redirect-no-param
(OFBIZ-9997)

Not sure why this one missed in r1816183 (looks like it was reverted)



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816188 13f79535-47bb-0310-9956-ffa450edef68
2017-11-23 19:41:01 +00:00
Jacques Le Roux 17d7246e06 Improved: Replace request-redirect w/ no redirect-param attribute by
request-redirect-no-param
(OFBIZ-9997)

There was a typo in r1816180 , this fixes it and adds plugins part



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816183 13f79535-47bb-0310-9956-ffa450edef68
2017-11-23 18:42:23 +00:00
Jacques Le Roux dfc7fb084a Improved: Replace request-redirect w/ no redirect-param attribute by
request-redirect-no-param
(OFBIZ-9997)

This follows the discussion at http://markmail.org/message/sbfdlhntdzziqeyz



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816180 13f79535-47bb-0310-9956-ffa450edef68
2017-11-23 18:21:51 +00:00
Jacques Le Roux c1a11e83ae Fixed: Fix Default or Empty Catch block in Java and Groovy files
(OFBIZ-8341)

While reviewing r1812057 I spotted a bunch of swallowed ClassCastExceptions

I then reviewed all ClassCastExceptions and this fixes all of them with a 
minimal logging

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1815797 13f79535-47bb-0310-9956-ffa450edef68
2017-11-20 12:32:44 +00:00
Jacques Le Roux 3933ba15c0 No functional change, fixes typos and formatting
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1815774 13f79535-47bb-0310-9956-ffa450edef68
2017-11-20 07:34:07 +00:00
Jacques Le Roux 0d0badf38e Implemented: Token Based Authentication
(OFBIZ-9833)

I have tested the Token Based Authentication between my local machine and the 
trunk demo. It works as expected.

This completes the previous commit by:
  adding a new externalServerLoginCheck pre processor
  Documenting how to set the ExternalServerJwtMasterSecretKey in production
    using sed and uuidgen
  Adding documenting properties in security.properties, not set to be used OOTB
   but ready to be set in production

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1814363 13f79535-47bb-0310-9956-ffa450edef68
2017-11-05 17:33:30 +00:00
Jacques Le Roux 90a349b441 Implemented: Token Based Authentication
(OFBIZ-9833)

This works the same way than externalLoginKey but between 2 servers, 
not 2 webapps on the same server. 

The Single Sign On (SSO) is ensured by a JWT token, then all is handled as 
normal by a session on the reached server. The servers may or may not share a 
database but the loginUserIds on the 2 servers must be the same.

OOTB the JWT masterSecretKey is not properly initialised and can not be OOTB.
As we sign on on several servers, so have different sessions, we can't use the 
externalLoginKey way to create the JWT masterSecretKey.
The best way to create the JWT masterSecretKey is to use a temporary way to load 
in a static final key when compiling. This is simple and most secure. 
One of the proposed way is to use sed and uuidgen to modify the masterSecretKey 
value. The magic words here are TEMPORARY and FINAL!

I have not tested this between 2 servers yet, only locally where it works well.
I'll do after this commit between my local instance and the trunk demo.

Thanks: Nicolas for the sed ans uuidgen suggestion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1813679 13f79535-47bb-0310-9956-ffa450edef68
2017-10-29 11:02:00 +00:00
Deepak Dixit 2a8a37f308 Improved: Manage life span of SecurityGroupPermission entity.
Applied patch from jira issue(OFBIZ-9801) Thanks Suraj Khurana for your contribution


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1812383 13f79535-47bb-0310-9956-ffa450edef68
2017-10-17 10:47:47 +00:00
Deepak Dixit 1620e4e0ca Improved: No functional change, Only added license header
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1812309 13f79535-47bb-0310-9956-ffa450edef68
2017-10-16 18:43:14 +00:00
Deepak Dixit c2c47188b7 Fixed: Added missing license header in some files.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1812289 13f79535-47bb-0310-9956-ffa450edef68
2017-10-16 12:22:33 +00:00
Jacques Le Roux 15deb25aae No functional change, fixes wrong ASL2 headers I introduced recently
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1812235 13f79535-47bb-0310-9956-ffa450edef68
2017-10-15 21:02:52 +00:00
Jacques Le Roux 2382cd9cbd No functional change, these files were missing the ASL2 header
I stop here, please help at https://ci.apache.org/projects/ofbiz/rat-output.html

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1812225 13f79535-47bb-0310-9956-ffa450edef68
2017-10-15 17:40:59 +00:00
Michael Brohl ee46dbb019 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.common.
(OFBIZ-9681)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811438 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 15:47:59 +00:00
Michael Brohl cf3081a277 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.common.preferences.
(OFBIZ-9640)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811433 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 14:51:43 +00:00
Michael Brohl a7beb48720 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.common.uom.
(OFBIZ-9634)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811428 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 14:12:51 +00:00
Michael Brohl 2a66a06aef Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.common.qrcode.
(OFBIZ-9633)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811427 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 14:10:50 +00:00
Michael Brohl 404139505e Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.common.period.
(OFBIZ-9631)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811426 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 14:08:49 +00:00