Commit Graph
2421 Commits
Author SHA1 Message Date
Marco Risaliti 2249639ac1 Remove some warning in UtilCache (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1076419 13f79535-47bb-0310-9956-ffa450edef68
2011-03-02 21:54:02 +00:00
Marco Risaliti b1266e64b3 Remove some warning in UtilCacheTests (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1076413 13f79535-47bb-0310-9956-ffa450edef68
2011-03-02 21:49:33 +00:00
Marco Risaliti 04f9e16356 Remove some warning in UtilPlist (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1076407 13f79535-47bb-0310-9956-ffa450edef68
2011-03-02 21:46:14 +00:00
Marco Risaliti fe88b86001 Remove a warning in UtilO (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1076397 13f79535-47bb-0310-9956-ffa450edef68
2011-03-02 21:36:14 +00:00
Marco Risaliti 0a733c0896 Remove a warning in FlexibleServletAccessor (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1076396 13f79535-47bb-0310-9956-ffa450edef68
2011-03-02 21:31:49 +00:00
Marco Risaliti 7eea3b7de9 Remove unused variable and suppress serial in FlexibleMapAccessorTests (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1076395 13f79535-47bb-0310-9956-ffa450edef68
2011-03-02 21:30:37 +00:00
Marco Risaliti 01f355463d Remove some warning in UelUtil (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1076392 13f79535-47bb-0310-9956-ffa450edef68
2011-03-02 21:28:56 +00:00
Marco Risaliti d1a6f5f805 Remove some warning in ObjectType (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1076384 13f79535-47bb-0310-9956-ffa450edef68
2011-03-02 21:18:05 +00:00
Sascha Rodekamp 40f52ad764 Improvement - if-regexp conditions in Minilang and Screens not thread safe (https://issues.apache.org/jira/browse/OFBIZ-4107). I added another getTestPattern Method to support case insensitive tests. The case insensitive testPattern is needed from the UtilHttp.checkURLforSpiders.
Thanks Martin & Dimitri for your effort.

Orig. Msg.:

The Perl5Matcher Perl5Compiler are not thread safe, as mentioned in their documentation: http://jakarta.apache.org/oro/api/org/apache/oro/text/regex/Perl5Compiler.html
A separate instance should be used per thread.

The concrete issue occurred in our system in the createCommContentDataResource service. The service tries to save emails to the database after they have been sent. It failed because of the described issue. This caused the whole email service (sendMailFromScreen) to be rescheduled. So customers got emails twice.

The Perl5Matcher and Perl5Compiler instances are assigned to static fields in the org.ofbiz.minilang.method.ifops.IfRegexp class. So every thread will use the same instance. No synchronization is done currently. Changing the fields to be non-static will not work either, as SimpleMethods are cached. So all calls to the same simple method use the same IfRegexp instance.

We fixed the problem by moving the instantiation of the Perl5Matcher and Perl5Compiler to the exec() method in IfRegexp.

Other classes are most likely affected, too: org.ofbiz.entity.condition.EntityComparisonOperator, org.ofbiz.minilang.method.conditional.RegexpCondition, org.ofbiz.minilang.operation.Regexp, org.ofbiz.widget.menu.ModelMenuCondition$IfRegexp, org.ofbiz.widget.screen.ModelScreenCondition$IfRegexp, org.ofbiz.widget.tree.ModelTreeCondition$IfRegexp


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1075322 13f79535-47bb-0310-9956-ffa450edef68
2011-02-28 13:43:23 +00:00
Sascha Rodekamp a3cfb8c9e4 Feature - Improve UtilProperties.java with a new Method getPropertyNumber which returns an Object of the Number or a default Object - (https://issues.apache.org/jira/browse/OFBIZ-3418) - I submitted a less modified patch from Mirko Vogelsmeier. The patch was outdated but doesn't matter I merged by hand and removed the tabs. Thanks Mirko for the improvement. And thanks Adrian for the first review.
Orig. Msg.:
Improvement of UtilProperties.java with a new method which returns the Number as an Object of the specified property name from the specified resource/properties file.
If the specified property name or properties file is not found, the defaultObject is returned.

i did update my method "getPropertyNumber" a bit and
as requested i added "getPropertyAsInteger / asLong / AsFloat / AsDouble / AsBigInteger / AsBigDecimal".
In addition i added a "getPropertyAsBoolean".


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1073113 13f79535-47bb-0310-9956-ffa450edef68
2011-02-21 19:01:36 +00:00
Jacques Le Roux 6d47543fe3 Fix ports numbers
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1072395 13f79535-47bb-0310-9956-ffa450edef68
2011-02-19 17:08:08 +00:00
Jacques Le Roux e3711d2369 * Replaces the old testRemoteSoap service now invalid with our own dog food: testSoapSimple from http://demo-trunk.ofbiz.apache.org:8080/webtools/control/SOAPService
* Adds a bunch of external SOAP services, none of them work so far, not sure why, a good exercise for the future...

I have tried to backport to R9.04 the testRemoteSoap change but it does not work there:

2011-02-19 17:26:02,500 (http-0.0.0.0-8443-1) [               Call.java:2469:ERROR] Exception:
org.xml.sax.SAXException: Deserializing parameter 'map-Map':  could not find deserializer for type {http://www.w3.org/2001/XMLSchema}anyType
        at org.apache.axis.message.RPCHandler.onStartChild(RPCHandler.java:277)
        at org.apache.axis.encoding.DeserializationContext.startElement(DeserializationContext.java:1035)
        at org.apache.axis.message.SAX2EventRecorder.replay(SAX2EventRecorder.java:165)
        at org.apache.axis.message.MessageElement.publishToHandler(MessageElement.java:1141)
        at org.apache.axis.message.RPCElement.deserialize(RPCElement.java:236)
        at org.apache.axis.message.RPCElement.getParams(RPCElement.java:384)
        at org.apache.axis.client.Call.invoke(Call.java:2467)
        at org.apache.axis.client.Call.invoke(Call.java:2366)
        at org.apache.axis.client.Call.invoke(Call.java:1812)
        at org.ofbiz.service.engine.SOAPClientEngine.serviceInvoker(SOAPClientEngine.java:137)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1072378 13f79535-47bb-0310-9956-ffa450edef68
2011-02-19 16:32:19 +00:00
Erwan de Ferrieres 530e8847da Migration to Tomcat 6.0.32 due to a security issue in previous revisions
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1070455 13f79535-47bb-0310-9956-ffa450edef68
2011-02-14 12:04:29 +00:00
Jacques Le Roux 13f879435f Revert r1070230, was a patch from Stephen Rufle "Blank year in UtilValidate.isYear should return false" (https://issues.apache.org/jira/browse/OFBIZ-4171) - OFBIZ-4171
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1070282 13f79535-47bb-0310-9956-ffa450edef68
2011-02-13 19:43:13 +00:00
Jacques Le Roux a259699bd7 A patch from Stephen Rufle "Blank year in UtilValidate.isYear should return false" (https://issues.apache.org/jira/browse/OFBIZ-4171) - OFBIZ-4171
UtilValidate.isYear returns true for a blank year which the calling function UtilValidate.isDate(String, String, String) tries to parse. This causes an exception to be thrown
ValidateMethod.java:96 :ERROR] [ValidateMethod.exec] Error in validation method isDateAfterToday of class org.ofbiz.base.util.UtilValidate: null
I found this error when trying to add a new credit card in the eCommerce checkout flow.
   1. Add a product to the cart
   2. login as any user I used "admin"
   3. Checkout Step "Shipping Address" (Step 1: Where shall we ship it?)
          * Click Next
   4. Checkout Step "Shipping Options" (Step 2: How shall we ship it?)
          * Choose "UPS Air"
          * Click Next
   5. Checkout Step "Payment Options" (Step 3: How shall you pay?)
   6. Create "Credit Card"
          * Fill Name
          * Card Type "Visa"
          * Card Number "4111111111111111"
          * Expiration Date Month drop-down 01
          * Expiration Date Year drop-down leave blank
          * Choose billing address
          * Click "Save" button

Should see "Error in validation method isDateAfterToday of class org.ofbiz.base.util.UtilValidate: null"

My fix is to change isYear, isMonth, and isDay to return false when a blank value is entered.
After I make my change the message is "The expiration date is before today"


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1070230 13f79535-47bb-0310-9956-ffa450edef68
2011-02-13 12:55:45 +00:00
Marco Risaliti 5680ef42bf Add a @SuppressWarning("serial") in GenericMapTest (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069069 13f79535-47bb-0310-9956-ffa450edef68
2011-02-09 20:25:03 +00:00
Marco Risaliti 56664b11a9 Remove unused variable in SyncTTLObjectTest (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069067 13f79535-47bb-0310-9956-ffa450edef68
2011-02-09 20:13:36 +00:00
Marco Risaliti 26009a9ca6 Remove unused variable in AsyncTTLObjectTest (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1069065 13f79535-47bb-0310-9956-ffa450edef68
2011-02-09 20:11:56 +00:00
Jacques Le Roux 3f6d0167f0 Update Groovy from 1.7.4 to 1.7.7
This version is required for Groovy++: http://code.google.com/p/groovypptest/wiki/HowDoesItWork

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1068830 13f79535-47bb-0310-9956-ffa450edef68
2011-02-09 10:17:21 +00:00
Marco Risaliti 860d0537b2 Add a @SuppressWarning("serial") in FlexibleStringExpanderTests (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1068616 13f79535-47bb-0310-9956-ffa450edef68
2011-02-08 22:19:01 +00:00
Marco Risaliti d5d75bda27 Add a @SuppressWarning("serial") from ObjectWrapper (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1068580 13f79535-47bb-0310-9956-ffa450edef68
2011-02-08 21:07:37 +00:00
Marco Risaliti 8cd85c7a4c Remove an unused import in StringUtil (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1068577 13f79535-47bb-0310-9956-ffa450edef68
2011-02-08 20:57:58 +00:00
Marco Risaliti a919ba2003 Remove some unnecessary suppress warning serial in UtilProperties (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1068576 13f79535-47bb-0310-9956-ffa450edef68
2011-02-08 20:56:34 +00:00
Marco Risaliti 60d44422ef Remove an unused private variable of method containsAll in GenericMapCollection instead of suppress it as unused (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1068507 13f79535-47bb-0310-9956-ffa450edef68
2011-02-08 18:29:35 +00:00
Marco Risaliti b18225f7b1 Remove an unused private method of JNDIConfigUtil instead of suppress it as unused (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1068505 13f79535-47bb-0310-9956-ffa450edef68
2011-02-08 18:25:52 +00:00
Marco Risaliti c9099db25b Remove compilation warnings of an unused variable in GenericMapCollection (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1068128 13f79535-47bb-0310-9956-ffa450edef68
2011-02-07 20:56:02 +00:00
Marco Risaliti d9a9fd2179 Remove unnecessary warning suppress into HardRefCacheLine (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1068127 13f79535-47bb-0310-9956-ffa450edef68
2011-02-07 20:53:06 +00:00
Marco Risaliti e386c63015 Remove compilation warnings of an unused variable in ComparableRangeTests (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1068125 13f79535-47bb-0310-9956-ffa450edef68
2011-02-07 20:50:33 +00:00
Marco Risaliti 4ea2300f38 Remove compilation warnings of an unused private method in JNDIConfigUtil (OFBIZ-4102)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1068120 13f79535-47bb-0310-9956-ffa450edef68
2011-02-07 20:46:53 +00:00
Jacques Le Roux f2d7b941f7 As discussed on dev ML, by default comment out Beanshell and Groovy containers for security reasons
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1063235 13f79535-47bb-0310-9956-ffa450edef68
2011-01-25 11:35:04 +00:00
Jacques Le Roux 357eda99e0 Revert file commited by error at r1063228
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1063234 13f79535-47bb-0310-9956-ffa450edef68
2011-01-25 11:33:23 +00:00
Jacques Le Roux 41f04cefbb As discussed on dev ML, by default comment out Beanshell and Groovy containers for security reasons
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1063228 13f79535-47bb-0310-9956-ffa450edef68
2011-01-25 11:25:23 +00:00
Jacques Le Roux d42aaef2b8 A patch from René Scheibe "Groovy shell." (https://issues.apache.org/jira/browse/OFBIZ-3954) - OFBIZ-3954
A Groovysh container to connect to. Just do a 'telnet localhost 9991' and you have a fully fledged groovysh.
This is a Groovy equivalent to the already existing BeanShell container.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1062476 13f79535-47bb-0310-9956-ffa450edef68
2011-01-23 17:58:43 +00:00
Erwan de Ferrieres ec5adee63b Displaying help was in error in the big topics, buffer.flip() was misplaced
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1061189 13f79535-47bb-0310-9956-ffa450edef68
2011-01-20 10:10:52 +00:00
Erwan de Ferrieres 1dedf4711c Upgrading to tomcat 6.0.30 - Changelog is here: http://tomcat.apache.org/tomcat-6.0-doc/changelog.html
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1061169 13f79535-47bb-0310-9956-ffa450edef68
2011-01-20 09:14:24 +00:00
Jacopo Cappellato 0ed73fe64c Added a bunch of missing license headers.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1058580 13f79535-47bb-0310-9956-ffa450edef68
2011-01-13 14:25:38 +00:00
Jacopo Cappellato a6922893a3 hot-deploy component are now always loaded in alphanumeric order; before this change they were loaded randomly (in a platform dependedent way).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1055411 13f79535-47bb-0310-9956-ffa450edef68
2011-01-05 11:05:13 +00:00
Adrian Crum 35da2271fa Added two new UEL functions to make date/time display more user friendly. Form widget example:
<field name="someTimeStamp">
  <display description="${date:localizedDateTimeStr(someTimeStamp, timeZone, locale)}"/>
</field>

will display the date/time according to the user's locale, instead of yyyy-mm-dd hh:mm:ss.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1054211 13f79535-47bb-0310-9956-ffa450edef68
2011-01-01 09:05:44 +00:00
Hans Bakker 50b24e3ee5 the first version of a product image management system to upload/approve and manupulate product images, see catalog -> image management
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1052521 13f79535-47bb-0310-9956-ffa450edef68
2010-12-24 15:22:49 +00:00
Jacques Le Roux 1221defad7 Better solution for "Bug In Jquery Integration - js File Not Found" (https://issues.apache.org/jira/browse/OFBIZ-4060) - OFBIZ-4060
A jquery.ui.datepicker i18n file is missing for the language.country couple you want. Simply add it there: [" + baseLocation + "]. Else anyway the 'en' default will be used", module)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1052494 13f79535-47bb-0310-9956-ffa450edef68
2010-12-24 12:12:05 +00:00
Jacques Le Roux 52c7d137e8 Fix "Bug In Jquery Integration - js File Not Found" (https://issues.apache.org/jira/browse/OFBIZ-4060) - OFBIZ-4060
We don't care for missing jquery.ui.datepicker i18n files, since "en" as default is handled internally. If people want a missing translation they have to add the file 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1052492 13f79535-47bb-0310-9956-ffa450edef68
2010-12-24 11:59:54 +00:00
Erwan de Ferrieres adbf783134 Adding ivy to OFBiz and make an example with cobertura. No more errors when running tests.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1050915 13f79535-47bb-0310-9956-ffa450edef68
2010-12-19 17:38:57 +00:00
Jacques Le Roux 26fcb9eb4c I think this is the correct solution for the problem I temporarily fixed some hours ago (r1050364+r1050367: was for a blocking deadlock issue, see https://issues.apache.org/jira/browse/OFBIZ-4065 - OFBIZ-4065 for details)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1050452 13f79535-47bb-0310-9956-ffa450edef68
2010-12-17 17:04:27 +00:00
Jacques Le Roux 159aaa42e9 Temporary(?) fix, follows r1050364
(r1050364 was for a blocking deadlock issue, see https://issues.apache.org/jira/browse/OFBIZ-4065 - OFBIZ-4065)



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1050367 13f79535-47bb-0310-9956-ffa450edef68
2010-12-17 12:51:55 +00:00
Jacques Le Roux 95ec1c0d52 Temporary(?) fix for a blocking deadlock issue, see https://issues.apache.org/jira/browse/OFBIZ-4065 - OFBIZ-4065
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1050364 13f79535-47bb-0310-9956-ffa450edef68
2010-12-17 12:28:27 +00:00
Christian Geisert 2d501d0876 Log if there's a problem (i.e. invalid XML) when loading XML-Properties
see OFBIZ-4045
submitted by Georg Koester

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1050186 13f79535-47bb-0310-9956-ffa450edef68
2010-12-16 21:56:14 +00:00
Scott Gray 2ecc4b2494 Removed unnecessary SuppressWarnings annotations
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1044932 13f79535-47bb-0310-9956-ffa450edef68
2010-12-12 21:31:51 +00:00
Scott Gray 47f43a302a Remove unnecessary casts
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1044931 13f79535-47bb-0310-9956-ffa450edef68
2010-12-12 21:31:27 +00:00
Scott Gray 75b0b1c1e3 Remove unnecessary semicolons
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1044917 13f79535-47bb-0310-9956-ffa450edef68
2010-12-12 20:43:03 +00:00
Scott Gray bdd23c22d5 Add missing override annotations
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1044913 13f79535-47bb-0310-9956-ffa450edef68
2010-12-12 20:41:27 +00:00