Commit Graph
2421 Commits
Author SHA1 Message Date
Gil Portenseigne 3130f0eb95 OFBIZ-7763 :
Remove all bsh libraries and bsh remaining fonctionnalities.
Bsh interpreter is replaced by GroovyShell evaluation.

To avoid groovyShell undefined var exception, the evaluated expression is analysed, detecting variables used and setting its to null if undefined in context.
Today only alphabetic variable with '_' are detected (i.e. my_variable==null).
Add in example a test replacement of " syntax to simple quote.
Remove all found bsh references

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1752231 13f79535-47bb-0310-9956-ffa450edef68
2016-07-11 23:04:54 +00:00
Jacques Le Roux 2dbfbea9f9 Temporarily comments because the "high-ascii" test is failing on BuildBot (only) when switching to Gradle
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1752043 13f79535-47bb-0310-9956-ffa450edef68
2016-07-09 19:56:35 +00:00
Taher A. Alkhateeb 4d2b415a91 Another major patch for OFBIZ-7534 replacing Ant with Gradle
This is the first patch that takes OFBiz to the point of no return
in terms of switching from Ant to Gradle build system. Specifically
this patch applies the following items:

- Delete all old Ant and Maven build scripts
- Delete 169 Jar libraries and replace them with remote ones in the
  gradle build script
- update the gradle build scripts for the dependencies and other minor
  changes needed for the script work correctly

All tests pass with the command ./gradlew cleanAll loadDefault testIntegration

Again, thank you for everyone who contributed valueble time and effort in this
process.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1752033 13f79535-47bb-0310-9956-ffa450edef68
2016-07-09 18:10:19 +00:00
Jacopo Cappellato 6d3f6d1ceb Removed two unused jars.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751951 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 18:05:44 +00:00
Jacopo Cappellato 539084a511 OFBIZ-7763 Removed a series of artifacts dependent on the old Beanshell jar that is going to be removed from the project; specifically:
* removed the code that implemented the deprecated "call-bsh" operation in Minilang
* removed the BeanShellContainer (it has been disabled a long time ago)
* removed the BeanShell service engine, no more used


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751947 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 17:53:59 +00:00
Jacopo Cappellato e0da901504 OFBIZ-7760 Removed from UtilCache the ability to persist entries in the file system.
This feature has been contributed a long time ago as an experimental feature but never really matured into a production ready artifact: since it was contributed, no users asked about how to use it, or tested it, or reported bugs or enhancement requests.
More importantly, the feature has always been disabled in the OFBiz framework (i.e. the widget code and the entity engine code were not using it).
This removal should not impact our user base; however, after the removal, an entry to the Attic will be created to keep track of it and to make it easier, to interested users, to get this code, improve it (e.g. by making it dependent on a live external jar, for example MapDB instead of JDBM) and possibly contribute it back to the project.
The most compelling reason for its removal is that the feature was based on a snapshot, unreleased version of JDBM, which is now a mostly dead project: for licensing reasons we are no more allowed to bundle jars in our releases. Additionally, having code that relies an old jar from a no more active project represents a maintenance issue for the community.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751817 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 17:00:05 +00:00
Arun Patidar 64b8f07724 Applied patch from jira issue - OFBIZ-7541 - Enforce noninstantiability to KeyStoreUtil class. Thanks Rishi Solanki and Pratik Kulshreshth for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751322 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 15:44:12 +00:00
Arun Patidar 19e96ab827 Applied patch from jira issue - OFBIZ-7593 - Enforce noninstantiability to UtilNumber class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751307 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 15:19:07 +00:00
Arun Patidar 54a13d732f Applied patch from jira issue - OFBIZ-7600 - Enforce noninstantiability to UtilPlist class. Thanks Rishi Solanki for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751304 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 14:57:02 +00:00
Arun Patidar 96eb92df15 Applied patch from jira issue - OFBIZ-7590 - Enforce noninstantiability to UtilIO class. Thanks Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751300 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 14:51:45 +00:00
Arun Patidar e7f41ad116 Applied patch from jira issue - OFBIZ-7551 - Enforce noninstantiability to SSLUtil class. Thanks Rishi solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751040 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 08:50:31 +00:00
Arun Patidar f3ce2f02ec Applied patch from jira issue - OFBIZ-7562 - Enforce noninstantiability to UtilDateTime class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751028 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 06:16:52 +00:00
Arun Patidar 542db954a5 Applied patch from jira issue - OFBIZ-7588 - Enforce noninstantiability to UtilGenerics class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751027 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 06:06:43 +00:00
Arun Patidar bd0472e263 Applied patch from jira issue - OFBIZ-7589 - Enforce noninstantiability to UtilHttp class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751026 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 05:56:47 +00:00
Arun Patidar 63308fd046 Applied patch from jira issue - OFBIZ-7601 - Enforce noninstantiability to UtilURL class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751025 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 05:46:56 +00:00
Arun Patidar 3fb5c91e11 Applied patch from jira issue - OFBIZ-7591 - Enforce noninstantiability to UtilJavaParse class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750969 13f79535-47bb-0310-9956-ffa450edef68
2016-07-01 15:53:19 +00:00
Arun Patidar 76df6b013f Applied patch from jira issue - OFBIZ-7587 - Enforce noninstantiability to UtilFormatOut class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750968 13f79535-47bb-0310-9956-ffa450edef68
2016-07-01 15:47:16 +00:00
Arun Patidar 593f996d60 Applied patch from jira issue - OFBIZ-7540 - Enforce noninstantiability to FileUtil class. Thanks Rishi Solanki and Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750663 13f79535-47bb-0310-9956-ffa450edef68
2016-06-29 15:20:09 +00:00
Arun Patidar 7f6a53c91f Applied patch from jira issue - OFBIZ-7479 - Enforce noninstantiability to BshUtil class. Thanks Rishi Solanki and Rahul Singh for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750662 13f79535-47bb-0310-9956-ffa450edef68
2016-06-29 15:16:20 +00:00
Jacques Le Roux b43b62bef2 Updates Shiro to 1.2.5 (CVE-2016-4437) - https://issues.apache.org/jira/browse/OFBIZ-7373
Apache Shiro before 1.2.5, when a cipher key has not been configured for the "remember me" feature, allows remote attackers to execute arbitrary code or bypass intended access restrictions via an unspecified request parameter.

Details at https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2016-4437

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749220 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:30:06 +00:00
Jacques Le Roux 27b736e3ed No functional changes. While reviewing Wai's patch for OFBIZ-7112 I noticed that he (re)used this pattern introduced earlier:
(resource == null || resource.length() <= 0)
From Java spec. a String, Collection, Map or CharSequence can't have a negative length, so the pattern above can be reduced to 
  (resource == null || resource.length() == 0)
which can be replaced using 
  UtilValidate.isEmpty()
I checked, there are several other occurrences of this pattern (some very old, I guess most were routinely copied from an initial occurrence). I decided to replace all of them, here they are.

I did that already long ago for the 
  (resource == null || resource.length() == 0)
pattern. It remains 4 of them. Three are justified (because of the dependency on base component or because using isEmpty() on Object is disputable for performance reasons). I took care of the remaining one right aways (in SplashScreen.java)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747976 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 10:43:58 +00:00
Jacques Le Roux 0029608c28 This has slipped in inadvertently in a previous commit, removes!
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747783 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 19:25:25 +00:00
Jacques Le Roux ec66e361e1 A big but straightforward commit for "Move minilang scripts from component://componentname/script/org/ofbiz to component://componentname/minilang" - https://issues.apache.org/jira/browse/OFBIZ-7267
I removed duplicate paths were componentname was uselessly repeated after component://componentname/script/org/ofbiz (projectmngr was the only one using there project instead)

I had few typos, easily fixed thanks to the tests. There could be still typos but they are unexpected and anyway no-brainer to fix 

I'm still wondering about specialpurpose/example/minilang/README.txt.
I changed its content to 
  "The minilang directory is for static resources that are interpreted at run time rather than being compiled. This goes on the classpath, but does not get built or put into a JAR file."
not sure it makes any sense, I don't see how this relates to the classpath. 


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747712 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 14:04:30 +00:00
Jacques Le Roux 3aadf4e8da A slightly modified patch from James Yong for "Autocompletion for Compound Widget" https://issues.apache.org/jira/browse/OFBIZ-7061
1. The following xsd are duplicated to use namespaces
  site-conf.xsd     ->  site-conf-ns.xsd
  widget-form.xsd   ->  widget-form-ns.xsd
  widget-screen.xsd ->  widget-screen-ns.xsd
  widget-menu.xsd   ->  widget-menu-ns.xsd
  simple-methods.xsd->  simple-methods-ns.xsd
For example, in site-conf-ns.xsd, we have the following document level attribute
  <xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema" elementFormDefault="qualified" xmlns="http://ofbiz.apache.org/Site-Conf" targetNamespace="http://ofbiz.apache.org/Site-Conf">
instead of 
  <xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema" elementFormDefault="qualified">

2. The above schema are used into compound-widgets.xsd so that compound widgets use only one consolidated schema. 

3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For example
<compound-widgets xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xmlns:sc="http://ofbiz.apache.org/Site-Conf"
        xmlns:sm="http://ofbiz.apache.org/Simple-Method"
        xmlns:wf="http://ofbiz.apache.org/Widget-Form"
        xmlns:wt="http://ofbiz.apache.org/Widget-Tree"
        xmlns:wm="http://ofbiz.apache.org/Widget-Menu"
        xmlns:ws="http://ofbiz.apache.org/Widget-Screen"
        xsi:noNamespaceSchemaLocation="../../../../framework/widget/dtd/compound-widgets.xsd">
    
    <sc:site-conf>
        <sc:request-map uri="CompoundWidgets1">
            <sc:security https="true" auth="true"/>
            <sc:event type="simple" invoke="CompoundWidgetsFunc" path="component://example/widget/example/ExampleCompoundWidgets.xml"/>
            <sc:response name="success" type="view" value="CompoundWidgets1"/>
        </sc:request-map>
        <sc:request-map uri="CompoundWidgets2"><sc:security https="true" auth="true"/><sc:response name="success" type="view" value="CompoundWidgets2"/></sc:request-map>

        <sc:view-map name="CompoundWidgets1" type="screen" page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/>
        <sc:view-map name="CompoundWidgets2" type="screen" page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/>
    </sc:site-conf>
...... the rest

4. Change java code to support reading xml with namespace (i.e. xml for compound widgets)

jleroux: I simply replaced tabs by spaces in Java files and removed this commented out line 
  <compound-widgets xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd">
in ExampleCompoundWidgets.xml

We decided to duplicate the simple-methods.xsd rather than updating all concerned files. Else we would have to update the attributes at document level for rest of the controllers, menus, forms, simple methods and screens. For example, in controller.xml, we would have to change 
  xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd”
to 
  xmlns="http://ofbiz.apache.org/sc” xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”>
But especially we would have to use the same syntax with namespaces prefixes than in ExampleCompoundWidgets.xml (see example above). This can be discussed because with auto-completion it's not a big deal, but could be overwhelming for existing custom projects...

James mentionned that "the schema location at compound-widgets.xsd is relative to the project...". I don't see any problems with that. We can keep as is as long as we maintain the relation (ie if the main XSDs are moved). Moreover with the previous addition of compound-widgets.xsd in widget-catalog.xml it seems all things work correctly (eg w/o the new *-ns.xsd yet committed, the auto-completion works well in ExampleCompoundWidgets.xml




git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1746302 13f79535-47bb-0310-9956-ffa450edef68
2016-05-31 16:48:09 +00:00
Deepak Dixit 64d804e2e1 (OFBIZ-7141) Updated apache fop to 2.1 and also updated xmlgraphics-commons to 2.1.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1746270 13f79535-47bb-0310-9956-ffa450edef68
2016-05-31 12:49:12 +00:00
Taher A. Alkhateeb ca819dda9d Remove cobertura and sonar completely. Ref OFBIZ-6783
After getting consensus from the community in the email thread below
we agreed to remove these two items because they make the startup
logic more complex and also because many things are broken and 
unmaintained for years.

It is a good idea to reintroduce cobertura in the future on a cleaner
implementation, hopefully completely away from the start component and
perhaps as a container implementation.

The email thread:
http://ofbiz.markmail.org/message/b4jovfhurczunbam?q=remove+cobertura

The related JIRA:
https://issues.apache.org/jira/browse/OFBIZ-6783


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1746236 13f79535-47bb-0310-9956-ffa450edef68
2016-05-31 06:43:11 +00:00
Jacques Le Roux c048e9c85a Ugrades PDFBox to 1.8.12 (or 2.0.1?) due to vulnerability - https://issues.apache.org/jira/browse/OFBIZ-7136
See CVE-2016-2175: Apache PDFBox XML External Entity vulnerability

I did not try to update to version 2.0.1. 
I only tested by using https://localhost:8443/example/control/ExampleReportPdfOptions?exampleId=EX01 but I got nothing, so I tried with R15.12 before backporting with the same issue so I guess it's unrelated with this update moreover with both branches I get an error in log for the barcode PDF I will open a Jira

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1745751 13f79535-47bb-0310-9956-ffa450edef68
2016-05-27 13:12:55 +00:00
Jacques Le Roux 0d40ddae13 No functional change, removes an useless private String, found by chance
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1744508 13f79535-47bb-0310-9956-ffa450edef68
2016-05-19 05:13:57 +00:00
Deepak Dixit 6d8f4053fc (OFBIZ-7041) Forgot to update freemarker version from 2.3.22 to 2.3.24 in FreemarkerWroker.java
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1743132 13f79535-47bb-0310-9956-ffa450edef68
2016-05-10 09:01:54 +00:00
Deepak Dixit aa4a15049c (OFBIZ-7041) Removed freemarker2.3.22.jar.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1742686 13f79535-47bb-0310-9956-ffa450edef68
2016-05-07 06:51:34 +00:00
Deepak Dixit da58d4da97 (OFBIZ-7041) Upgraded freemarker jar to 2.3.24
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1742685 13f79535-47bb-0310-9956-ffa450edef68
2016-05-07 06:35:55 +00:00
Jacques Le Roux 9d6072b3d8 Changes for "Use SecureRandom instead of Random where appropriate, and randomUUID for externalKey" - https://issues.apache.org/jira/browse/OFBIZ-7028
Because using SecureRandom comes with a cost, I have identified the places where it's reasonable to keep the non secured Random (like tests, internal sequences, etc.).
Ant to use UUID.randomUUID to generate the external link id

Also, though there are no real proven vulnerabilities, I decided to backport as much as possible since it's now public.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1741684 13f79535-47bb-0310-9956-ffa450edef68
2016-04-29 18:54:49 +00:00
Jacques Le Roux 4f243ac529 No functional changes, removes duplicate ";"
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1741674 13f79535-47bb-0310-9956-ffa450edef68
2016-04-29 17:36:31 +00:00
Jacques Le Roux a26666f7bc Updates ICU4J from version 52 to 57, no functional changes
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1740229 13f79535-47bb-0310-9956-ffa450edef68
2016-04-21 05:18:07 +00:00
Jacques Le Roux 7316ee4818 A patch from Pierre Smits for "Remove limitation regarding menu-name in ofbiz-component.xsd" https://issues.apache.org/jira/browse/OFBIZ-6667
Currently the following is in the ofbiz-component.xsd:
        <xs:attribute name="menu-name" default="main">
            <xs:simpleType>
                <xs:restriction base="xs:token">
                    <xs:enumeration value="main"/>
                    <xs:enumeration value="secondary"/>
                </xs:restriction>
            </xs:simpleType>
        </xs:attribute>

However, this is limiting the options that can be applied generates unnecessary errors when developers opt for another methodology.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1739968 13f79535-47bb-0310-9956-ffa450edef68
2016-04-19 17:56:07 +00:00
Nicolas Malin ab000418de Uprade the Apache Tika Library :
tika-parsers-1.7.jar -> tika-parsers-1.12.jar
    tika-core-1.7.jar -> tika-core-1.12.jar

This update induce updating of :

    pdfbox-1.8.5.jar -> pdfbox-1.8.11.jar
    jempbox-1.8.5.jar -> jempbox-1.8.11.jar
    fontbox-1.8.5.jar -> fontbox-1.8.11.jar
    commons-compress-1.9.jar -> commons-compress-1.11.jar

And pdfbox-1.8.11.jar need the introduction of :

    jce-jdk13-154.jar under MIT licence (www.bouncycastle.org)

Apache Tika is needed to test the screenfop on issue OFBIZ-6497. So I move all library from applications/content/lib/ to framework/base/lib/ to didn't create a dependency between widget and content 
Related issue OFBIZ-7015

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1739551 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 08:26:45 +00:00
Jacques Le Roux c64517519b A slightly modified patch from Chatree Srichart for "Upgrade Tomcat to 8.0.32" https://issues.apache.org/jira/browse/OFBIZ-6915
jleroux: I simply changed the doc link in catalina ofbiz-component.xml


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1738902 13f79535-47bb-0310-9956-ffa450edef68
2016-04-13 07:40:25 +00:00
Jacques Le Roux 92e56e4078 A patch from Gareth Carter for "some files set viewIndex to 1 by default rather than 0" https://issues.apache.org/jira/browse/OFBIZ-6705
Implements a PagedList object (stores list of data items, resultset size, viewSize, viewIndex, lowIndex (called startIndex) and highIndex (called endIndex), also a utils class that returns the PagedList object based on a EntityListIterator, viewSize and viewIndex. 
And implements a queryPagedList method in EntityQuery, used as an example in findOrders service Java implementation

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1738900 13f79535-47bb-0310-9956-ffa450edef68
2016-04-13 07:29:11 +00:00
Jacques Le Roux 2001f1091a For "Replace OFBiz HttpClient by org.apache.commons.httpclient.HttpClient" - https://issues.apache.org/jira/browse/OFBIZ-4430
Since commons.httpclient.HttpClient is now deprecated/not-maintained an vulnerable I prefer to simply put a warning at the top of the class. So people can pick what they prefer and is handy for their problem at than

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1737695 13f79535-47bb-0310-9956-ffa450edef68
2016-04-04 14:49:44 +00:00
Jacques Le Roux a725bd4db7 Fixes "Update XStream lib to prevent XML External Entity (XXE) Processing" - https://issues.apache.org/jira/browse/OFBIZ-6959
The XStream team has released the 1.4.9 stable version in March 15, 2016
This version fixes the XML External Entity (XXE) Processing security issue https://www.owasp.org/index.php/XML_External_Entity_%28XXE%29_Processing
Since OFBiz uses the DomDriver, with Java 6 at least in supported releases, OFBiz seems not really vulnerable https://x-stream.github.io/faq.html#Security_XXEVulnerability, but better to be safe than sorry, notably for not OOTB uses...



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1736434 13f79535-47bb-0310-9956-ffa450edef68
2016-03-24 12:12:11 +00:00
Jacques Le Roux e38ec39dfe This partially reverts r1735569 to simplify and have less commented out parts.
Fixes "Comment out RMI related code because of the Java deserialization issue" - https://issues.apache.org/jira/browse/OFBIZ-6942

We decided to comment out as less as possible because once, in the start and both properties; the rmi part is off and the related test services are off there is no RMI related danger left (test services are not a danger but would fail during tests run). 
It's then easier for users who need RMI in their projects to have only to uncomment those and not digg everywhere.

[CVE-2016-2170] The infamous Java serialization vulnerability

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1736083 13f79535-47bb-0310-9956-ffa450edef68
2016-03-21 20:17:59 +00:00
Jacques Le Roux b021268fa7 Fixes "Comment out RMI related code because of the Java deserialization issue" - https://issues.apache.org/jira/browse/OFBIZ-6942
I decided to comment out as less as possible because once the RMI loaders, the RMI dispatcher and the related test services are off there is no RMI related danger left (test services are not a danger but would fail during tests run). It's then easier for users who need RMI in their projects to have only to uncomment those and not digg everywhere. Because the naming (JNDI) server relies on the rmi loader it will also be commented out.

[CVE-2016-2170] The infamous Java serialization vulnerability

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1735569 13f79535-47bb-0310-9956-ffa450edef68
2016-03-18 10:38:04 +00:00
Shi Jinghai 6910aacd54 OFBIZ-6755 Update the passport component to use httpclient/core-4.4.1 instead of commons-httpclient-3.1
1. Remove commons-httpclient-3.1.jar from passport component.
2. Use httpclient 4.4.1 in base/lib instead.
3. Remove randomString methods, use RandomStringUtils.randomAlphanumeric instead.
4. Move getAllowAllHttpClient to UtilHttp.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1735021 13f79535-47bb-0310-9956-ffa450edef68
2016-03-15 06:06:33 +00:00
Deepak Dixit 94eefdcb72 OFBIZ-6278: Merged changes done at 1675464, 1675465 and 1675466 from OFBIZ-6275 branch to trunk.
Log:
==========================================================
- Make use of ResourceLoader.readXmlRootElement, which is
non-caching; this fixes a deprecation warning.
- Use ResourceLoader.readXmlRootElement, which is a
non-caching version.  This fixes a deprecation warning.
- Provide method variants (readXml{Document,RootElement}) that contain the body of the deprecated methods (getXml{Document,RootElement}).
==========================================================


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1731399 13f79535-47bb-0310-9956-ffa450edef68
2016-02-20 13:16:03 +00:00
Deepak Dixit c8add13c70 OFBIZ-6279: Migrated changes from r1675462 to Trunk.
Log:
============================================================
UtilDateTime implements deprecated methods, so add the
@Deprecated tag to stop javac from producing a warning.
============================================================

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1731385 13f79535-47bb-0310-9956-ffa450edef68
2016-02-20 12:11:01 +00:00
Deepak Dixit 51cb141c5e OFBIZ-6277: Merge changes from r1675521 to Trunk:
Log:
============================================================
new Configuration() is deprecated; instead, the desired
freemarker version should be passed in.  To make it easier to control
the version centrally, add a helper method on FreeMarkerWorker that
wraps the instantiation of the Configuration object.
============================================================


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1731380 13f79535-47bb-0310-9956-ffa450edef68
2016-02-20 12:01:23 +00:00
Jacques Le Roux 354260caff In framework/base/lib/ updates Xalan from 2.7.1 to 2.7.2 because of CVE-2014-0107 (was fixed at XALANJ-2435) - https://issues.apache.org/jira/browse/OFBIZ-6905
This implies to update also Xerces from 2.9.1 to 2.11.0 and also xml-apis from 2.9.1 to 1.4.01 (2.9.1 was a wrong version number. It was actually part of the Xerces 2.9.1 package but I was unable to find the real version number then at https://xerces.apache.org/xerces2-j/releases.html)

Also updates Xalan from 27(?) to 2.7.2 in cmssite/template/docbook/extensions. I rendered https://localhost:8443/cmssite/cms/APACHE_OFBIZ_HTML w/o issues
	
Note: According to the DOM Level 3 specification and DOM Level 2 errata the createElementNS and createAttributeNS methods convert empty string namespaceURI to null. 

jleroux: though the tests pass I'm not sure all is covered...



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1730882 13f79535-47bb-0310-9956-ffa450edef68
2016-02-17 17:29:40 +00:00
Jacopo Cappellato f16d1f0717 OFBIZ-6568 With the implementation of @BaseScript annotations (introduced with Groovy 2.3.0) something was broken in the CompilerConfiguration.setScriptBaseClass method and an error is thrown when our scripts are executed; the workaround is to execute at startup a script containing the @BaseScript annotation.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1729809 13f79535-47bb-0310-9956-ffa450edef68
2016-02-11 11:24:51 +00:00
Jacopo Cappellato b0bbe4d430 OFBIZ-6568: upgraded Groovy to the latest version (2.4.5).
[CVE-2016-2170] The infamous Java serialization vulnerability


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1729609 13f79535-47bb-0310-9956-ffa450edef68
2016-02-10 14:38:00 +00:00
Jacques Le Roux e4a0586ff2 Gets rid of the session-cookie-accepted feature - https://issues.apache.org/jira/browse/OFBIZ-6871
Since OFBIZ-6867 is now done, it will no longer be used OOTB and anyway should not be needed because we should preferably always use sessionIds in cookies and newer have sessionsIds in URLs.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1728121 13f79535-47bb-0310-9956-ffa450edef68
2016-02-02 14:10:08 +00:00