Commit Graph
5 Commits
Author SHA1 Message Date
Nicolas Malin c619dd5491 Improved: Use website to generate links on email content
(OFBIZ-4361)
OFBiz contains a nice process to generate link through WebSite entity.
Unfortunately when you send an email, the standard service didn't propage the website 
to the body content email, so we can't use it.

This improvement is needed on forgot password process to resolve the correct uri 
and go back on good OFBiz component: where the user requested for a new password.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1867960 13f79535-47bb-0310-9956-ffa450edef68
2019-10-04 07:32:48 +00:00
Jacques Le Roux 7d7a441715 Fixed: Any ecommerce user has the ability to reset anothers password
(including admin) via "Forget Your Password"
(OFBIZ-4361)

Currently, any user (via ecommerce "Forget Your Password") has the ability to 
reset another users password, including "admin" without permission.  
By simply entering "admin" and clicking "Email Password", the following is 
displayed:

The following occurred:
A new password has been created and sent to you. Please check your Email.

This now forces the user of the ERP to change their password.  
It is also possible to generate a dictionary attack against ofbiz because there 
is no capta code required.  This is serious security risk.

I have modified the patch following comments I made in the Jira, notably
  Removed unused Java variables
  Removed a check in LoginEvents::forgotPassword which prevented to show error
    messages
  Changed fr and en SecurityExtPasswordSentToYou 
    + SecurityExtThisEmailIsInResponseToYourRequestToHave labels 
    + template PasswordEmail.ftl
    + loginservices.token_incorrect labels
  Added fr and en SecurityExtIgnoreEmail + SecurityExtLinkOnce labels
  Removed changes in general.properties
  I did not remove the 2 GetSecurityQuestion.ftl files (webpos one was still in)

There is still room for improvement. I'll discuss them on the Jira and dev
ML. But this version is already strong enough to not wait that the patch is 
inapplicable!

Thanks: mz4wheeler (Mike Z) for the Jira, Nicolas Malin for the patch, I guess 
with some Gil's help, and all others for comments and ideas

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1866478 13f79535-47bb-0310-9956-ffa450edef68
2019-09-05 15:56:46 +00:00
Ashish Vijaywargiya 99271ae91e Applied patch from jira issue - OFBIZ-8023 - Clean up commented out code in Free Marker Template for SecurityExt.
Thanks Aman for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1758004 13f79535-47bb-0310-9956-ffa450edef68
2016-08-27 12:08:03 +00:00
Deepak Dixit c5bd9d0ad8 (OFBIZ-7021) Renamed product and securityext component ftl file name from lower case to upper case pattern.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1743880 13f79535-47bb-0310-9956-ffa450edef68
2016-05-15 05:05:50 +00:00
Deepak Dixit 50ffc15c80 (OFBIZ-6975) Applied patch from jira issue, moves the *.ftl files from webapp to template subfolders for securityext component.
Thanks  Pierre Smits for the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1737781 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 06:28:40 +00:00