Commit Graph
29 Commits
Author SHA1 Message Date
Jacques Le Roux 7d7a441715 Fixed: Any ecommerce user has the ability to reset anothers password
(including admin) via "Forget Your Password"
(OFBIZ-4361)

Currently, any user (via ecommerce "Forget Your Password") has the ability to 
reset another users password, including "admin" without permission.  
By simply entering "admin" and clicking "Email Password", the following is 
displayed:

The following occurred:
A new password has been created and sent to you. Please check your Email.

This now forces the user of the ERP to change their password.  
It is also possible to generate a dictionary attack against ofbiz because there 
is no capta code required.  This is serious security risk.

I have modified the patch following comments I made in the Jira, notably
  Removed unused Java variables
  Removed a check in LoginEvents::forgotPassword which prevented to show error
    messages
  Changed fr and en SecurityExtPasswordSentToYou 
    + SecurityExtThisEmailIsInResponseToYourRequestToHave labels 
    + template PasswordEmail.ftl
    + loginservices.token_incorrect labels
  Added fr and en SecurityExtIgnoreEmail + SecurityExtLinkOnce labels
  Removed changes in general.properties
  I did not remove the 2 GetSecurityQuestion.ftl files (webpos one was still in)

There is still room for improvement. I'll discuss them on the Jira and dev
ML. But this version is already strong enough to not wait that the patch is 
inapplicable!

Thanks: mz4wheeler (Mike Z) for the Jira, Nicolas Malin for the patch, I guess 
with some Gil's help, and all others for comments and ideas

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1866478 13f79535-47bb-0310-9956-ffa450edef68
2019-09-05 15:56:46 +00:00
Jacques Le Roux 7e5a0db5df No functional change, renames files:
conditional.xml to conditionalLabels.xml
DefaultMessages.xml to DefaultMessagesLabels.xml
EmailPassword.xml to EmailPasswordLabels.xml
Found while working on OFBIZ-8321

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1764261 13f79535-47bb-0310-9956-ffa450edef68
2016-10-11 14:56:49 +00:00
Mridul Pathak 3c42c21eb4 [OFBIZ-7529] Part 2 of "Delete stale java files from applications and framework". Deleted following files/directories and references -
applications/securityext/src/main/java/org/apache/ofbiz/securityext/thirdparty
applications/securityext/src/main/java/org/apache/ofbiz/securityext/thirdparty/truition
applications/securityext/src/main/java/org/apache/ofbiz/securityext/thirdparty/truition/TruitionCoReg.java
applications/securityext/config/truition.properties

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1754635 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 06:21:09 +00:00
Jacques Le Roux 0dd553ec96 A modified patch from Harsha Chadhar for "New feature to reclaim a user account - Using Security Questions" https://issues.apache.org/jira/browse/OFBIZ-4983
jleroux: the issue description is quite lengthy so I will summarise it here, please refer to the Jira issue for details.
"When a customer creates an account on eCommerce site, s/he will also need to answer a security question. This security question then can be used by the user to reclaim her/his account in case s/he forgets her/his password. If the user correctly answers the required security question while reclaiming her/his account, her/his password will be sent through email notification. This part would work in the same way as the existing functionality of email password (forget password)."

The description was actually more ambitious (several questions, possibility for users to create own questions) but AFAIK these parts have not been implemented.

Apart updating the patch which did not merge, I got 2 majors issues (and few others I will not report here) I bypassed with workarounds.

Unlike Harsha, and as I reported earlier in the issue, I never got the username (userLoginId) back when using hidden parameters in the request body (not in requestParameters, ie UtilHttp.getParameterMap(request)), nor actually any parameters. This is maybe due to my OS (Windows7 was XP before) or my email client (Outlook Express then, now Thunderbird) or even my SMTP configuration (I used my ISP SMTP server) but most probably because I did it all on my sole machine (localhost). I tried to understand what was happening to request body parameters with http://www.telerik.com/fiddler, but finally gave up because it's even more complicated when https is in the picture. So I decided to rather use parameters in the URL (Query string). It's a bit less safe, though the password is OFBiz encrypted, and should be replaced. But it's safe enough because only the user should receive this message and even if the message is sniffed during its journey it should be hard to decrypt the password!

Harsha used the SecurityExtUiLabels.xml (created by ashish at r1618415) in securityext component but there is already a SecurityextUiLabels.xml in common component. Since I use Windows OFBiz was unable to retrieve the labels from SecurityExtUiLabels.xml since I guess it looked into a SecurityextUiLabels.xml. So I renamed a SecurityExtUiLabels.xml to EmailPassword.xml.










git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1716915 13f79535-47bb-0310-9956-ffa450edef68
2015-11-27 20:37:15 +00:00
Jacques Le Roux b8ca5543c9 Changes in all labels files: <value xml:lang="(.*)_(.*)"> to <value xml:lang="$1-$2">
Changes also listLocales.ftl to show dashes rather than underscores

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1650880 13f79535-47bb-0310-9956-ffa450edef68
2015-01-11 09:59:32 +00:00
Adrian Crum 91feff5f51 Updated the UI label files so they reference a schema.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1649666 13f79535-47bb-0310-9956-ffa450edef68
2015-01-05 21:24:18 +00:00
Jacques Le Roux 3b118d4842 An excerpt of a patch from Nick Ho for "Add/Revise Traditional Chinese (zh-TW) translations" https://issues.apache.org/jira/browse/OFBIZ-5764
added/revised zh-TW translations in the framework, applications and specialpurpose folders to have consistent, commonly-used meaningful terms in Traditional Chinese.

jleroux: from Nick Ho's patch I have extracted only the Chinese changes, w/o the proposed  dash to underscore changes
This contains notably this 14 "zh" (not "sh-TW") changes:
<value xml:lang="zh">人将由电子邮件接受一个临时密码。</value><!-- was 客户将通过电子邮件收到一个临时密码。 -->
<value xml:lang="zh">合计属于公司: </value>
<value xml:lang="zh"> 完整文本:${fullText}</value>
<value xml:lang="zh">供货商佣金百分比</value>
<value xml:lang="zh">文本大小</value>
<value xml:lang="zh">值</value>
<value xml:lang="zh">算子</value>
<value xml:lang="zh">不能转移已序列化的库存。</value>
<value xml:lang="zh">货运收据</value>
<value xml:lang="zh">获取标识为 ${productStoreShipMethId} 的产品店铺送货方法(ProductStoreShipmentMeth)时出错:${errorString}</value>
<value xml:lang="zh">中国人民币元</value>
<value xml:lang="zh">如果选择"specify other",下拉框旁边会出现文本框。参考form的drop-down元素的other-field-size属性说明</value>
<value xml:lang="zh">文本消息</value>
<value xml:lang="zh">能够收到和解析XML消息,但是BSR->NOUN(买卖关系->名词) ${bsrNoun} 和/或 BSR->VERB(买卖关系->动词) ${bsrVerb} 是空的</value>
I have no competency to judge these changes, but from previous Shi Jinghai's feedback I believe there are OK

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1625816 13f79535-47bb-0310-9956-ffa450edef68
2014-09-17 20:44:07 +00:00
Ashish Vijaywargiya 03257ca2a9 Applied patch from jira issue - OFBIZ-3566 - EcommerceUiLabels references in applications/*
Thanks Adam Heath for reporting the issue and team ofbiz.us for providing the fix. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1618415 13f79535-47bb-0310-9956-ffa450edef68
2014-08-16 20:53:55 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Jacopo Cappellato 351b2b2c41 Moved Securityext labels from the applications to the framework to resolve because they are used by the LoginServices in the common component.
We should probably rename the files (and the variables that reference them), but for now I've just moved them.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@590571 13f79535-47bb-0310-9956-ffa450edef68
2007-10-31 06:53:05 +00:00
Andrew Zeneski 6548a71c1e implementation (from Anil Patel) to support restricting changed passwords to not allow the use of a previous password (the length of tracking is configurable in security.properties)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@573458 13f79535-47bb-0310-9956-ffa450edef68
2007-09-07 04:58:35 +00:00
Jacopo Cappellato 77c9e6e6a6 reverted part of 549443 because it is incomplete as is. Thanks to David Jones for the review.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@565617 13f79535-47bb-0310-9956-ffa450edef68
2007-08-14 04:29:46 +00:00
Jacopo Cappellato d2169fd325 When a password is updated, added check to verify that the new password is different from the old one.
Also moved a a few of labels that were in the wrong component.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@549443 13f79535-47bb-0310-9956-ffa450edef68
2007-06-21 10:20:43 +00:00
Jacopo Cappellato 9edc949165 Russian labels from Oleg Andreyev OFBIZ-1039 and OFBIZ-1042
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@545456 13f79535-47bb-0310-9956-ffa450edef68
2007-06-08 08:29:14 +00:00
Hans Bakker 72132f3013 Bunch of NL updates by Perry Smit from morevalue.nl
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@536128 13f79535-47bb-0310-9956-ffa450edef68
2007-05-08 08:57:35 +00:00
Jacopo Cappellato 597766520d Properties files for all OfBiz modules available in romanian language.
Many thanks to Roberto Santori (OFBIZ-845) for this great contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@523091 13f79535-47bb-0310-9956-ffa450edef68
2007-03-27 21:36:11 +00:00
Jacques Le Roux a8d958052f The application part from a Shi Yusen's patch "zh properties in progress" (https://issues.apache.org/jira/browse/OFBIZ-617).
I will create a new patch attached to Jira issue OFBIZ-617 for framework part. A commiter with enough rights will just have to commit it (patch reviewed and OK)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@502130 13f79535-47bb-0310-9956-ffa450edef68
2007-02-01 05:54:40 +00:00
Jacques Le Roux 64cea174fc This is the change of ASL2 headers in properties files only. Please see comments in another post in dev ML.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@497074 13f79535-47bb-0310-9956-ffa450edef68
2007-01-17 16:49:01 +00:00
Jacques Le Roux e76fa9eaa7 Deletion of common french labels not in CommonUILabels_fr.properties.
I will certainly continue in this way with other labels not at their place. 
The most part of the french community is OK about this doing (those that responded at my demand)

git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@469343 13f79535-47bb-0310-9956-ffa450edef68
2006-10-31 02:31:48 +00:00
Jacques Le Roux ec6b7ec5c0 This file was missing. From Jason Wu (http://jira.undersunconsulting.com/browse/OFBIZ-723)
===================================================
I also had a problem of virus(550 Virus detected?) in 
/incubator/ofbiz/trunk/applications  
  manufacturing/config/ 
  party/config/ 
  product/config/ 
  workeffort/config/
Said Postfix program at host eris.apache.org. 

This has worried me a bit
But I'm quitte sure I have no virus on this machine (even if it's a Windows PC ;o). 
And the number (550!) seems strange also.
Not files seems missing according to SVN. 
Even if I can't see the 1st part of one commit (please see revision 442458)

Here is the Postfix message and piece attached
_________________________________________________
This is the Postfix program at host eris.apache.org.

I'm sorry to have to inform you that your message could not
be delivered to one or more recipients. It's attached below.

For further assistance, please send mail to <postmaster>

If you do so, please include this problem report. You can
delete your own text from the attached returned message.

                   The Postfix program

<ofbiz-commits@incubator.apache.org>: host
    idunn.apache.osuosl.org[140.211.166.84] said: 550 Virus detected (in reply
    to end of DATA command)



--------------------------------------------------------------------------------


Received: by eris.apache.org (Postfix, from userid 65534)
id 8A8B01A981A; Mon, 11 Sep 2006 22:40:23 -0700 (PDT)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r442458 [1/2] - in /incubator/ofbiz/trunk/applications:
 manufacturing/config/ party/config/ product/config/ workeffort/config/
Date: Tue, 12 Sep 2006 05:40:23 -0000
To: ofbiz-commits@incubator.apache.org
From: jleroux@apache.org
X-Mailer: svnmailer-1.1.0
Message-Id: <20060912054023.8A8B01A981A@eris.apache.org>
 
Attached message 
Reporting-MTA: dns; eris.apache.org
X-Postfix-Queue-ID: 8A8B01A981A
X-Postfix-Sender: rfc822; jleroux@apache.org
Arrival-Date: Mon, 11 Sep 2006 22:40:23 -0700 (PDT)

Final-Recipient: rfc822; ofbiz-commits@incubator.apache.org
Action: failed
Status: 5.0.0
Remote-MTA: dns; idunn.apache.osuosl.org
Diagnostic-Code: smtp; 550 Virus detected


git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@442476 13f79535-47bb-0310-9956-ffa450edef68
2006-09-12 06:25:09 +00:00
Jacques Le Roux 8b08df2c19 Patch from Rodrigo Aguinaga : OFBiz does speak Spanish now :o)
Thanks for your great work Rodrigo

git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@434047 13f79535-47bb-0310-9956-ffa450edef68
2006-08-23 13:53:14 +00:00
Jacques Le Roux 4132a6e5cd git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@434036 13f79535-47bb-0310-9956-ffa450edef68 2006-08-23 13:19:58 +00:00
Jacques Le Roux d74d2faaec Add *_es.properties from Rodrigo Aguinaga (see Apache Jira OFBIZ-157)
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@432188 13f79535-47bb-0310-9956-ffa450edef68
2006-08-17 09:21:27 +00:00
David E. Jones c84ed3c644 Moved the more core login methods from LoginEvents to LoginWorker as they don't depend on the applications stuff but are used by the framework stuff; also updated various text references to the new locations
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@431021 13f79535-47bb-0310-9956-ffa450edef68
2006-08-12 12:12:18 +00:00
Jacques Le Roux 64d1c5716a The introduction of spaces around = was annoying for synchro of Neogia. I reverse without it.
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@426469 13f79535-47bb-0310-9956-ffa450edef68
2006-07-28 10:13:21 +00:00
Jacques Le Roux ff07abe2c8 Update of french labels
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@426430 13f79535-47bb-0310-9956-ffa450edef68
2006-07-28 08:21:19 +00:00
Jacopo Cappellato 512967892d License change from MIT to ASL2.0 for all the files of the securityext component.
Thanks to Ashish Vijaywargiya for the patch (Apache OFBIZ-87).


git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@422177 13f79535-47bb-0310-9956-ffa450edef68
2006-07-15 08:18:28 +00:00
Hans Bakker b2a2f46cf3 update of dutch security labels
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@419455 13f79535-47bb-0310-9956-ffa450edef68
2006-07-06 06:04:41 +00:00
David E. Jones 94fe6d1cda Initial OFBiz import from revision 7923 of the old svn.ofbiz.org SVN repository.
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@418498 13f79535-47bb-0310-9956-ffa450edef68
2006-07-01 19:05:20 +00:00