Commit Graph
587 Commits
Author SHA1 Message Date
Sebastian Berg 1047003b92 Fixed: Remove CommunicationContent not working as expected (OFBIZ-12172) 2021-02-26 18:49:58 +01:00
Jacques Le Roux 54ab93ff2a Improved: Field 'govAgencyPartyId' shows all parties, not just Government Agencies (OFBIZ-10863)
The field govAgencyPartyId in the AddFixedAssetRegistration form shows all
parties through the lookup target-form-name="LookupPartyName function.

This should be limited to those parties that qualify with the constraint.

Thanks: Pierre Smits for report Priya Sharma for the fix
2021-02-21 14:22:00 +01:00
Michael Brohl 662a3f9d1c Improved: Remove Compdoc functionality from content manager
(OFBIZ-10476)
2021-02-13 17:33:05 +01:00
Benjamin Jugl ce5397dbc6 Fixed: Prevents NPE in Party/My Communications (OFBIZ-12164) 2021-02-11 21:36:04 +01:00
Nicolas Malin 7165768251 Implemented: Add a framework method to get main webapp menu with the webapp name
(OFBIZ-10601)

To improve theme management and provide better tools for new themes, we implement a method to obtain the main menu of a webapp.
Instead of just managing a menu, we extend the functionality by offering a method to expose a summary of the webapp, to simplify the navigation.

For this we add a new attribute on webapp definition app-shortcut-screen :

    <webapp name="mywebapp"
            ...
            app-shortcut-screen="component://mycomponent/widget/CommonScreens.xml#ShortcutApp"
            ...
    />

The idea is to define a new purpose screen *Shortcut* that contains what defines a webapp when an action or navigation has been requested. With this screen you can load a menu, a search, a complex description and use all screen powerfulness to resolve what displaying and support by theming

    <screen name="ShortcutApp">
        <section>
            <actions>
                <property-map resource="CommonUiLabels" map-name="uiLabelMap" global="true"/>
            </actions>
            <widgets>
                <decorator-screen name="ShortcutDecorator" location="component://common/widget/CommonScreens.xml">
                    <decorator-section name="body">
                        <include-menu name="MyShortcutAppBar" location="component://mycomponent/widget/CommonMenus.xml"/>
                    </decorator-section>
                </decorator-screen>
            </widgets>
        </section>
    </screen>

Each component are self-sufficient to define what shortcuts to display without framework change or knowledge about other component.
Each theme can implement and customize the display rendering at will.

To illustrate an example of implementation we set sub menu for each webapp defined on applications and exploit it on bluelight theme.

Thanks for Dennis Balkir, Jacques Leroux, Leila Mekika and Julien Nicolas for their involvement
2021-01-15 08:56:23 +01:00
Jacques Le Roux 66decd89f7 Improved: Create 'New Communication' button should be removed from create new communication screen. (OFBIZ-12027)
Steps to replicate the issue :
Go to Party application.
On the 'find communications' screen clicks on the 'New communications' button.
The system will navigate you to create/edit communications screen.
On create/edit communications screen you will see the 'New communications' button.

Providing the 'New communications' button on the 'create new communication
screen' does not make any sense over so it should be removed from here.

Thanks: Shubham Choudhary
2020-12-29 11:28:16 +01:00
Jacques Le Roux ec2b84341e Reverted: "Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)"
This reverts commit 17eb2e4cf7.

It does not work when using <<target="javascript:........>>
I could change those cases but it's easier and safer to simply revert back to
target-type!

Thanks: James for report
2020-12-18 11:08:32 +01:00
Jacques Le Roux 17eb2e4cf7 Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)
Same for sub-hyperlink
2020-12-11 16:52:04 +01:00
Jacques Le Roux 06e56ed7e9 Improved: Invoice import is not visible from UI and not working (OFBIZ-12089)
While working on OFBIZ-12080 I found an upload feature that allows to import
invoices but it's not visible from UI and not working.
Moreover the export feature was missing a parameters as the import.

It has been introduced by Hans Bakker with
https://svn.apache.org/repos/asf/ofbiz/trunk@1502093
and I'm not sure the integration was completed.

We could remove it, but I think it can be useful and does not seem to miss much
to work fine.

Also use an uploadedFile label in ImportParty and UploadContent forms
2020-12-08 17:22:24 +01:00
Akash Jain 9e006d3732 Fixed: Display/functionality improvement in findParty of OOTB regarding classification group (OFBIZ-10302)
Thanks, Rajesh Kumar Mallah for report.
2020-09-01 15:06:38 +05:30
Jacques Le Roux eb6218b628 Fixed: Make all related Cancel/Done buttons return to backHome ie. party profile page (OFBIZ-11943)
Thanks: Priya for the patch
2020-08-06 12:47:21 +02:00
lodhiravi 32a0cb865e Fixed: Added employee lookup to search/select employee(person) while creating new employment. This will also fixed the issue of party groups being selected as a employee. (OFBIZ-11697) (#210) 2020-07-04 23:11:58 +05:30
holivier ef58d647b6 Documented: migrate help link to asciidoc user manual for Party
(OFBIZ-11581)

All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files

In the global Help Docbook index tree, remove all points about
Party and add a short page with a link to the new help

Remove docbook help files for Party
2020-07-02 12:19:12 +02:00
Aditya Sharma ebd7992dac Fixed: Requesthandler exception is showing after clicking cancel/done button on editPerson screen
(OFBIZ-10890)
Set the value of missing parameter.
Thanks Minal Phalak for reporting and providing the patch
2020-05-23 17:32:16 +05:30
James Yong d94beee1b6 Improved: Apply multi-block attr to each application (OFBIZ-11706)
For Party application.
Also fixed bug where external script tag is incorrectly handled
when extracting internal script tag from freemarker template.
2020-05-15 15:43:31 +08:00
Pawan Verma adb60c2a9e Improved: Purchase Invoice creation should be limited for parties with roleTypeId = SUPPLIER
(OFBIZ-11024)

Added new LookupSupplier and used it.

Thanks: Pierre, Rohit, Jacques, Nicolas for your contribution.
2020-05-05 13:48:54 +05:30
Michael Brohl e4e32a1a64 Improved: Styles some clickable fields of backend tables as buttons.
(OFBIZ-11309)

Thanks Ulrich Heidfeld for reporting and providing the patch, James Yong
for additional review.
2020-03-18 08:05:00 +01:00
Michael Brohl bb698b9b96 Implemented: Remove the user login security question.
(OFBIZ-11244)

Thanks Wiebke Pätzold for providing the patch.
2020-03-13 17:31:49 +01:00
Nicolas Malin 7366da34cc Fixed: Usage of 'include-form' instead of 'include-grid' in PartyScreens.xml for grid elements
(OFBIZ-11286)

In PartyScreens.xml there were 'ListInvoicesApplPayments', 'ListUnAppliedInvoices' and 'ListUnAppliedPayments' include as form instead of grid but in PartyForms.xml they are defined as grids.

Thanks to Ulrich Heidfeld to raise and solve this issue
2019-11-22 15:26:10 +01:00
Jacques Le Roux c98def05a3 Fixed: EditExample always update status, because current Status not shown
(OFBIZ-11230)

In the EditExample Form, the drop-down is populates with the Valid change status 
only. So current status is not in the list and the status print in the drop-down 
is the next authorized. I want to modify exampleName or exampleType, I go to 
editExample and change what I want and validate. The problem is status is also 
changed!

There are 12 other same or similar cases. For the first of them (in FinAccount) 
there is the same bug: when I change FinAccount Name, status change too. If I 
add current="first-in-list" in the tag drop-down it works 

jleroux: Quote is a peculiar case due to OFBIZ-7337 which was a wrong fix
 
Thanks: Oliver for the analysis and the fix 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868545 13f79535-47bb-0310-9956-ffa450edef68
2019-10-17 12:19:33 +00:00
Pawan Verma abebcb6375 'At least one phone number is required below' message should be uneditable while creating new customer using partymgr
(OFBIZ-11113)

Thanks: Arpit Mor for report and Saurabh Dixit for the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1867937 13f79535-47bb-0310-9956-ffa450edef68
2019-10-03 12:36:38 +00:00
Jacques Le Roux 531793820e Improved: Add a discussion feature in order detail view for following
communication about the order (mail, phone etc.)
(OFBIZ-11210)

This is in order detail view for following communication about the order 
(mail, phone etc.) to keep an eye about all com' event linked to the order.

Thanks: Carl Demus

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1867581 13f79535-47bb-0310-9956-ffa450edef68
2019-09-26 15:11:52 +00:00
Jacques Le Roux a86beec96d Fixed: Error in log when looking for parties at partymgr/control/main
(OFBIZ-11201)

There is this a (long stack trace) error in log (only), mostly

java.lang.ClassCastException: java.util.ArrayList cannot be cast to java.util.Map
at org.apache.ofbiz.base.util.string.UelFunctions.getSize(UelFunctions.java:318)

I did not notice any other effect, so the fix only cleans the log.

It's actually an issue in ListParty grid with this line:
<set field="userLoginSize" value="${util:size(logins)}" type="Integer"/>

This fixes it by replacing by 
<set field="userLoginSize" value="${groovy:logins.size()}"/>



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1867099 13f79535-47bb-0310-9956-ffa450edef68
2019-09-18 07:29:18 +00:00
Jacques Le Roux 8db877625c Fixed: Logo image not showing on party profile
(OFBIZ-9299)

Logo image not displayed until we press in content component

Logo image was not showing on party profile page because we were using Ajax 
request to add party content on the party profile screen. 
So due to ajax request screen was not getting refreshed. 

To display logo image we did the following changes:
1) Removed ajax request and rendered profile view screen after submit
2) Used ofbizUrl macro to show an image instead of /content/control/stream URL


Thanks: Moatasim Al Masri for reporting, Mohammed Rehan Khan for fixing

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1861869 13f79535-47bb-0310-9956-ffa450edef68
2019-06-22 14:19:09 +00:00
Jacques Le Roux 4d646ce052 Improved: Use "Create" instead of "Create New" on the various screens of all
components
(OFBIZ-9905)

As the title says + removes now useless labels

Thanks: Aayush Jain for report, Sourabh Jain for the fix, Pierre Smits and 
Rishi Solanki for comments

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1858291 13f79535-47bb-0310-9956-ffa450edef68
2019-04-27 17:56:44 +00:00
Suraj Khurana 8436ca3a25 Improved: Marital Status not managed properly in Person entity.
(OFBIZ-10921)
Thanks Paul, Jacques, Pierre and Nicolas for you suggestions and discussions.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1858261 13f79535-47bb-0310-9956-ffa450edef68
2019-04-27 10:11:09 +00:00
Suraj Khurana f1c283ea98 Fixed: Classification group filter not working on find party screen.
(OFBIZ-10580)
Parties which are under the selected classification group should only be listed, there was code missing on groovy to handle this.
Thanks Anushi Gupta for reporting, Saurabh Dixit for providing the patch and Jacques Le Roux for reviewing it.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1849518 13f79535-47bb-0310-9956-ffa450edef68
2018-12-22 05:40:47 +00:00
Deepak Dixit 13c5258a85 Improved: request map to create party content in controller.xml exists twice
(OFBIZ-10699)
Renamed ambiguous controller request CreatePartyContent to EditPartyContent as per OOTB pattern.
Thanks Pierre Smits for reporting the issue and Jacques Le Roux for the the details and discussion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1849021 13f79535-47bb-0310-9956-ffa450edef68
2018-12-16 11:37:36 +00:00
Jacques Le Roux d89b68face Improved: Splitting CommonRate and CommonProductRating
(OFBIZ-3844)

Simplifies and adds comments for clarity

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1848923 13f79535-47bb-0310-9956-ffa450edef68
2018-12-14 10:38:18 +00:00
Jacques Le Roux 5597b1d65a Improved: Splitting CommonRate and CommonProductRating
(OFBIZ-3844)

The CommonRate label is currently not used coherently throughout the application 
stack. The existing translations suggest that the commonly understood meaning of 
CommonRate is a rate as a tariff or day rate. However, in the product management 
GUI, the CommonRate label is used to demark the section where ProductRating 
setting are made.

The provided fix splits CommonRate into two labels, CommonRatioRate and 
CommonAssessRate (product rating). Also, the application/product/webapp/ form 
definition now references the CommonAssessRate label.

Thanks: Carsten Schinzer for report and patch, Adrian for suggestion and Markus
May for discussion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1848834 13f79535-47bb-0310-9956-ffa450edef68
2018-12-13 09:43:03 +00:00
Suraj Khurana 9ca5823a8a Improved: Consistency and Readability improvements for include-menu tag.
(OFBIZ-8972)
Thanks Ankush Upadhyay for reporting and Devanshu Vyas for providing the updated patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1845088 13f79535-47bb-0310-9956-ffa450edef68
2018-10-29 08:29:43 +00:00
Gil Portenseigne a61c98775f Implemented : Impersonation of userLogin feature
(OFBIZ-10515)

Introduce a new feature that allow the impersonation of a login by an authorized user.
Add the documentation with all the details in security-impersonation.adoc.
Big thanks to Leila, Nicolas and Jacques for your contribution to this implementation.
Big thanks to Mathieu, Jacques, Pierre and Taher for your remarks and reviews that
improved this contribution quality. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1842110 13f79535-47bb-0310-9956-ffa450edef68
2018-09-27 16:01:35 +00:00
Deepak Dixit b13070d7fa Improved: Standardise layout for Party
(OFBIZ-10334)
Thanks Dennis Balkir for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835957 13f79535-47bb-0310-9956-ffa450edef68
2018-07-15 09:10:49 +00:00
Arun Patidar 8345feffab Fixed: Incorrect Party profile view redirection in SFA due to missing roleType.
(OFBIZ-10121)
Thanks Ankit Joshi for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1825233 13f79535-47bb-0310-9956-ffa450edef68
2018-02-24 12:40:32 +00:00
Rishi Solanki 8390f0606a Implemented: Implement and Apply Return Lookup. Added lookup with screen forms and controller entry. Use the same lookup on communication event return screen.
(OFBIZ-10171)
Thanks Ratnesh Upadhyay for reporting and providing fix for the issue.
Thanks Yogesh Noaroliya for verification and details.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1822411 13f79535-47bb-0310-9956-ffa450edef68
2018-01-27 14:21:37 +00:00
Rishi Solanki 7d29cd1888 Implemented: Add ability to record Return Communication. Added support to record communication event against return. Added new entity CommunicationEventReturn, crund and supporting screens. Also added support in the existing email services to handle the return cases.
(OFBIZ-9911)
Thanks to Ratnesh Upadhyay for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821486 13f79535-47bb-0310-9956-ffa450edef68
2018-01-18 11:34:01 +00:00
Jacques Le Roux cf0c677e10 Improved: Clean images, among them logos, in all locations used
(OFBIZ-10128)

Fix my previous commits, there is no themes webapp so no URL at 
/themes/common/webapp/images/ofbiz_logo.png
It's only images/ofbiz_logo.png


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820978 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 12:56:30 +00:00
Jacques Le Roux b964875337 Improved: Clean images, among them logos, in all locations used
(OFBIZ-10128)

The ofbiz_logo.png is now in theme. This is only the framework part. 
I have also made change in theme but I need to review again and perhaps create 
a patch for others to review...
Note: testUpdatePartyGroup is OK

Then I'll also rename the logo in site to use the same name before maybe
referring to svn trunk repo to use only 1 file everywhere, same for the .ico
file

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820862 13f79535-47bb-0310-9956-ffa450edef68
2018-01-11 11:05:26 +00:00
Akash Jain ed4d86630f Fixed: Party Classification Groups are not listing on FindParty screen, applied patch from jira issue (OFBIZ-10007)
Fixed issue in which classification is not listed in the dropdown.
First value is undefined in the list, this is because of asmSelect Jquery which will cover in another ticket.
Thanks, Aman Agrawal and Sonal Patwari for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819136 13f79535-47bb-0310-9956-ffa450edef68
2017-12-23 10:53:58 +00:00
Deepak Dixit 86cb628a38 Fixed: Edit Party Group page does not shows current set values (OFBIZ-9532)
Thansk Aditya Sharma for reporting the issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818269 13f79535-47bb-0310-9956-ffa450edef68
2017-12-15 11:30:48 +00:00
Jacques Le Roux 95b17d4d23 Improved: The main logo in screen upper part shows distorted
(OFBIZ-9990)

Fixes this issue in Tomahawk and Flat Grey themes by using ofbiz_logo.png, 
instead of the old logo deprecated ofbiz_logo.gif 

While at it use the same logo everywhere it's possible. It was needed for links 
to http://ofbiz.apache.org/images/ofbiz_logo.gif which no longer exists 
(actually seems only used for tests so could stay like that but better not refer 
to it anyway)

Also use this logo for Bluelight theme where it fits. 

It could not be used in Rainbow themes because they are using a Scalable Vector 
Graphics file (ofbiz-white.svg) that can't be replaced by the new png logo file
BTW this file still uses a TM symbol instead of a ®

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816897 13f79535-47bb-0310-9956-ffa450edef68
2017-12-01 18:45:50 +00:00
Jacques Le Roux a1aeed0175 Fixed: No option to create the account contacts in SFA component
(OFBIZ-10010)

Steps to regenerate:
1) Open URL https://demo-trunk.ofbiz.apache.org/sfa/control/FindAccounts
2) Select an account from the list or create a new account.
3) In the account profile page, click on "Create New" in the "List Related Contacts" section.
Actual: No option to create the account contacts.
Expected: There should be an option to create account's contact.

Creates new request-map and screen definition to redirect 'Create New' link 
on proper screen. So that user can add contacts to the Account.

Thanks: Rubia Elza Joshep for report and Pradeep Choudhary for patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816373 13f79535-47bb-0310-9956-ffa450edef68
2017-11-26 09:22:59 +00:00
Akash Jain 86f861401c Fixed: Create Related Account from Contact Profile redirect to empty profile screen, applied patch from jira issue (OFBIZ-9697)
Thanks, Ankit Joshi for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816273 13f79535-47bb-0310-9956-ffa450edef68
2017-11-25 09:20:21 +00:00
Jacques Le Roux 32a5949a1d Improved: refactor list related forms in PartyScreen widgets
(OFBIZ-9405)

For an unknown reason yet grid can't be used for ListPartyIdentification form

Thanks: Swapnil M Mane for spotting the issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1815504 13f79535-47bb-0310-9956-ffa450edef68
2017-11-16 19:48:33 +00:00
Jacques Le Roux e438e3f864 Improved: refactor list related forms in PartyScreen widgets
(OFBIZ-9405)

Refactoring various list forms into grids
Refactoring various list form references in screens

jleroux: slightly adapted because of r1799252

Thanks: Pierre Smits

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1815193 13f79535-47bb-0310-9956-ffa450edef68
2017-11-14 09:44:57 +00:00
Akash Jain 7e8b362980 Fixed: Success message also showing before the party identification number is updated, applied patch from jira issue (OFBIZ-9895)
Thanks, Pallavi Goyal for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1813617 13f79535-47bb-0310-9956-ffa450edef68
2017-10-28 12:31:11 +00:00
Deepak Dixit 9715eb8932 Improved: Proper use of if-has-permission, Apply slightly modified patch from jira issue, if if-has-permission uses _ADMIN permission to check condition, so its good to have old pattern instead of using permission/action pattern.
Thanks Suraj Khurana for your contribution(OFBIZ-9740)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1812381 13f79535-47bb-0310-9956-ffa450edef68
2017-10-17 09:58:24 +00:00
Rishi Solanki 3d29d37572 Improved: Extend SecurityGroup entity and add name/groupName field. Added groupName field to entity SecurityGroup and related changes done in the data, services and UI. (OFBIZ-9620)
Thanks Suraj Khurana for your patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809386 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 10:16:17 +00:00
Arun Patidar 1068a929d1 FIXED: UI issue in Lead Lookup on find opportunity. (OFBIZ-9477)
Thanks Jagpreet for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1807890 13f79535-47bb-0310-9956-ffa450edef68
2017-09-09 12:49:46 +00:00
Jacques Le Roux 8cdb6010a1 Fixed: Fix references where Mime type is displayed in HTML encoded pattern
(OFBIZ-9644)

I found various instances where the mimeTypeId is displayed in HTML 
encoded pattern over UI.

jleroux: this also removes 2 duplicated fields in AddLayout form

Thanks: Ankit Joshi

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806951 13f79535-47bb-0310-9956-ffa450edef68
2017-09-01 12:49:04 +00:00