Commit Graph
2213 Commits
Author SHA1 Message Date
Sebastian Berg 1047003b92 Fixed: Remove CommunicationContent not working as expected (OFBIZ-12172) 2021-02-26 18:49:58 +01:00
Jacques Le Roux 54ab93ff2a Improved: Field 'govAgencyPartyId' shows all parties, not just Government Agencies (OFBIZ-10863)
The field govAgencyPartyId in the AddFixedAssetRegistration form shows all
parties through the lookup target-form-name="LookupPartyName function.

This should be limited to those parties that qualify with the constraint.

Thanks: Pierre Smits for report Priya Sharma for the fix
2021-02-21 14:22:00 +01:00
Michael Brohl 69c62f5f00 Merge changes for PR #267 due to conflicting changes in trunk (OFBIZ-12169) 2021-02-15 17:15:18 +01:00
Jacques Le Roux a2dac5482c Improved: Default ordering of webapps titles in main menu (OFBIZ-12166)
[...] having more important apps in 1st places would be better [...]
the feature should be easily changed by custom projects [...]
documentation for that would be enough.

This 1st step sorts the applications and webtools. I believe webtools should not
be secondary but that needs to be discussed with other options.
2021-02-14 21:11:58 +01:00
Michael Brohl 662a3f9d1c Improved: Remove Compdoc functionality from content manager
(OFBIZ-10476)
2021-02-13 17:33:05 +01:00
Michael Brohl 29bf0a040a Merge branch 'trunk' into OFBIZ-12169_Handle_remaining_checkstyle_errors 2021-02-13 11:26:01 +01:00
Benjamin Jugl ce5397dbc6 Fixed: Prevents NPE in Party/My Communications (OFBIZ-12164) 2021-02-11 21:36:04 +01:00
Wiebke Pätzold 95d37d2189 Removes and adds whitespaces as suggested by checkstyle (OFBIZ-12169) 2021-02-09 08:46:20 +01:00
Nicolas Malin 7165768251 Implemented: Add a framework method to get main webapp menu with the webapp name
(OFBIZ-10601)

To improve theme management and provide better tools for new themes, we implement a method to obtain the main menu of a webapp.
Instead of just managing a menu, we extend the functionality by offering a method to expose a summary of the webapp, to simplify the navigation.

For this we add a new attribute on webapp definition app-shortcut-screen :

    <webapp name="mywebapp"
            ...
            app-shortcut-screen="component://mycomponent/widget/CommonScreens.xml#ShortcutApp"
            ...
    />

The idea is to define a new purpose screen *Shortcut* that contains what defines a webapp when an action or navigation has been requested. With this screen you can load a menu, a search, a complex description and use all screen powerfulness to resolve what displaying and support by theming

    <screen name="ShortcutApp">
        <section>
            <actions>
                <property-map resource="CommonUiLabels" map-name="uiLabelMap" global="true"/>
            </actions>
            <widgets>
                <decorator-screen name="ShortcutDecorator" location="component://common/widget/CommonScreens.xml">
                    <decorator-section name="body">
                        <include-menu name="MyShortcutAppBar" location="component://mycomponent/widget/CommonMenus.xml"/>
                    </decorator-section>
                </decorator-screen>
            </widgets>
        </section>
    </screen>

Each component are self-sufficient to define what shortcuts to display without framework change or knowledge about other component.
Each theme can implement and customize the display rendering at will.

To illustrate an example of implementation we set sub menu for each webapp defined on applications and exploit it on bluelight theme.

Thanks for Dennis Balkir, Jacques Leroux, Leila Mekika and Julien Nicolas for their involvement
2021-01-15 08:56:23 +01:00
Jacques Le Roux 66decd89f7 Improved: Create 'New Communication' button should be removed from create new communication screen. (OFBIZ-12027)
Steps to replicate the issue :
Go to Party application.
On the 'find communications' screen clicks on the 'New communications' button.
The system will navigate you to create/edit communications screen.
On create/edit communications screen you will see the 'New communications' button.

Providing the 'New communications' button on the 'create new communication
screen' does not make any sense over so it should be removed from here.

Thanks: Shubham Choudhary
2020-12-29 11:28:16 +01:00
Jacques Le Roux ec2b84341e Reverted: "Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)"
This reverts commit 17eb2e4cf7.

It does not work when using <<target="javascript:........>>
I could change those cases but it's easier and safer to simply revert back to
target-type!

Thanks: James for report
2020-12-18 11:08:32 +01:00
Jacques Le Roux 17eb2e4cf7 Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)
Same for sub-hyperlink
2020-12-11 16:52:04 +01:00
Jacques Le Roux 06e56ed7e9 Improved: Invoice import is not visible from UI and not working (OFBIZ-12089)
While working on OFBIZ-12080 I found an upload feature that allows to import
invoices but it's not visible from UI and not working.
Moreover the export feature was missing a parameters as the import.

It has been introduced by Hans Bakker with
https://svn.apache.org/repos/asf/ofbiz/trunk@1502093
and I'm not sure the integration was completed.

We could remove it, but I think it can be useful and does not seem to miss much
to work fine.

Also use an uploadedFile label in ImportParty and UploadContent forms
2020-12-08 17:22:24 +01:00
holivier 5781f08ff6 Documented:migrated Wiki How to Create the main Company in Party Manager to user-manual (OFBIZ-12065)
Add section Parties Processes and as first process How To Create Main Company
2020-11-30 12:07:57 +01:00
Nicolas Malin 8a51586c63 Fixed: service createCommunicationEventWithoutPermission failed to store a communication
(OFBIZ-12074)

When you call the service createCommunicationEventWithoutPermission to create a anonymous communication or from a user without party permission, the service failed due to missing permission.

With the minilang to groovy conversion the userLogin system it's not loaded before call the main service createCommunicationEvent
2020-11-30 09:40:04 +01:00
holivier c2c1eae612 Documented: migrated Wiki Glossary to glossary asciidoc files (OFBIZ-12060)
- Accounting Glossary,
  - declare it as glossary
  - re-order existing items
  - add a comment at beginning about importance of order items
  - correction for some ID: change space to _
  - add some items coming from wiki glossary
- Facility
  - add glossary directly in facility.adoc
- Human Resource Glossary
  - re-order existing items
  - add a comment at beginning about importance of order items
  - move some items to Party Glossary or global Glossary
- HR appendix: add link to wiki OFBiz related book for Data Model Reference Book
- Add Party Glossary and included it in party.adoc
  - add some items coming from wiki glossary and HR glossary
- General Glossary
  - add a comment at beginning about importance of order items
  - add some items coming from wiki glossary and HR glossary
2020-11-18 17:19:39 +01:00
holivier 98631771aa Documented: Synchronize wiki page End User Documentation (OFBIZ-12059)
- Add facility.adoc with only overview
- Correction for Content Management title
- in General glossary, add link to main components
- Complete Order management overview
- Add a short overview for Party
- Ordered applications in user-manual in alphabetic order
2020-11-16 17:00:48 +01:00
holivier 302bc0eb15 Documented: migration to help system using asciidoc files (OFBIZ-11587)
Remove all related help docbook files
2020-10-26 17:34:03 +01:00
holivier cf7164fc64 fixed: createPartyGroupRoleAndContactMechs service not working (OFBIZ-11986)
Service is used for create employee service, and email address is not mandatory, so emailAddressContext should be empty if parameters.emailAddress is empty.

Correction done is to call createPerson before creating emailAddressContext to be able to put set partyId in the if not empty parameters.emailAddress
2020-10-07 11:45:24 +02:00
Jacques Le Roux 70ff1c5006 Fixed: createPartyGroupRoleAndContactMechs service not working (OFBIZ-11986)
As Akash Jain reported:

<<While researched on ticket OFBIZ-11896 identified that groovy version of
createPartyGroupRoleAndContactMechs service (converted from mini lang at rev
8af7cf8775 ) is not working.
Identify these two reasons,
    resolvePartyGroupMap called incorrectly
    resolvePostalAddressMap and resolveTelecomNumberMap implemented incorrectly
as 'postalAddress' and 'telecomNumber' map processor
not available into PartyMapProcs.xml.

There may be more reasons along with these two reasons.>>

He was so true to say the later!

There are also some intentionally or automated formattings.

Thanks: Akash for report, Sourabh Jain for shy tentative :)
2020-09-30 14:28:31 +02:00
Jacques Le Roux 8675993ac3 Fixed: Geo Location functionality of facility contact information screen is not working (OFBIZ-7343)
Long ago I spotted an issue:

<<In French I got this js error message in console (else nothing apears anywhere)

SyntaxError: missing ) after argument list
...=9000&partyId=Company', 'Adresse d'expédition - Géolocalisation', '450', '550')

It's due to the quote in "Adresse d'expédition"
We could though commit by escaping the popUptitle, but I also think we should
change from the popup (and everywhere the same is used) to a modal layered
window.>>

Turned out that:
<<I had a quick look to see if we could not use a modal layer instead of a popup,
but it's not obvious to use modal layer from Freemarker. This does not mean that
it can't be done... I'll see later...>>

Here is a late workaround :)
2020-09-30 14:28:31 +02:00
Jacques Le Roux 7b01534208 Fixed: createPartyGroupRoleAndContactMechs service not working (OFBIZ-11986)
While researched on ticket OFBIZ-11896 identified that groovy version of
createPartyGroupRoleAndContactMechs service (converted from mini lang at rev
8af7cf8775 ) is not working.

Identify these two reasons,
    resolvePartyGroupMap called incorrectly
    resolvePostalAddressMap and resolveTelecomNumberMap implemented incorrectly
as 'postalAddress' and 'telecomNumber' map processor not available into PartyMapProcs.xml.

There may be more reasons along with these two reasons.

Thanks: Akash Jain for report, Sourabh Jain for incomplete patch (missed 2nd
point from Akash
2020-09-30 14:28:30 +02:00
Suraj Khurana 1ff8957032 Improved: Corrected some spacing issues in code, where there are extra white spaces, this will fix some checkstyle issues in applications component.
(OFBIZ-12022)
2020-09-26 14:18:28 +05:30
Jacques Le Roux 346c63bfdf Improved: Checkstyle: Variable name must match pattern (OFBIZ-11926)
We have a lot of "do nothing" in Java code. In case of catch we should at least
have Debug.logError(e, MODULE); and maybe an explanation in the comment.
2020-09-15 15:24:45 +02:00
Suraj Khurana 5f021ce06b Improved: Corrected line is longer than 150 characters checkstyle issues in applications component.
(OFBIZ-11921)
Also fixed some other extra space and naming related checkstyle issues observed.
Thanks Jacques for review.
2020-09-04 12:24:14 +05:30
Akash Jain 9e006d3732 Fixed: Display/functionality improvement in findParty of OOTB regarding classification group (OFBIZ-10302)
Thanks, Rajesh Kumar Mallah for report.
2020-09-01 15:06:38 +05:30
Suraj Khurana ca9fa4fba4 Improved: Corrected line is longer than 150 characters checkstyle issues in framework and applications component.
(OFBIZ-11921)
Also fixed some extra spaces and naming conventions related checkstyle issues.
Thanks Jacques for review.
2020-08-31 19:54:54 +05:30
James Yong fc44f9ce3b Improved: Move page-specific script links to html template (OFBIZ-11799)
Use importLibrary js function to load fjTimer/jquerytimer-min.js
Tested on /partymgr/control/viewprofile?partyId=DemoEmployee
2020-08-30 21:25:10 +08:00
Suraj Khurana f98f5ebb86 Improved: Added missing Javadocs for some methods, this is required for all classes which looks like designed for extension (can be subclassed).
(OFBIZ-11947)
Also fixed some other checkstyle issues that requires re-factoring.
Thanks Jacques for review.
2020-08-28 16:54:15 +05:30
Pawan Verma 6cb67c1a40 Improved: Replace .size() == 0 with isEmpty() in Java files(OFBIZ-11944)
Thanks, priya for the report and patch and jacques for the review.
2020-08-22 19:17:10 +05:30
Suraj Khurana d74742d730 Improved: Make data members of class as private and added accessor methods for the same, also corrected occurences of the same in applications component.
(OFBIZ-11963)
Also made some related checkstyle code enhancements.
Thanks jacques for finalizing Javadoc pattern during this effort.
2020-08-22 13:00:17 +05:30
Suraj Khurana 413e0ec3ec Improved: Added missing Javadocs for some methods, this is required for all classes which looks like designed for extension (can be subclassed).
(OFBIZ-11947)
This is done for applications component. Also corrected some variables as per naming convention best practices.
Thanks Jacques for review.
2020-08-17 12:25:56 +05:30
Priya Sharma 3fe72d440f Improved: Remove unused imports from Java files (OFBIZ-11930) (#222)
Improved: Remove unused imports from Java files
(OFBIZ-11930)
Thanks: Priya Sharma
2020-08-06 19:51:09 +05:30
Jacques Le Roux eb6218b628 Fixed: Make all related Cancel/Done buttons return to backHome ie. party profile page (OFBIZ-11943)
Thanks: Priya for the patch
2020-08-06 12:47:21 +02:00
Akash Jain b4fbbc4934 Improved: Convert PartyContactMechTests.xml to Groovy (OFBIZ-11854) 2020-08-04 22:35:58 +05:30
Akash Jain 25fc51f961 Improved: Convert PartyStatusChangeTests.xml to Groovy (OFBIZ-11853) 2020-08-04 22:23:10 +05:30
Suraj Khurana c6399ef668 Improved: Corrected some line is longer than 150 characters checkstyle issues in applications component. Also fixed some extra spaces and naming conventions related checkstyle issues.
(OFBIZ-11921)
2020-08-03 10:14:20 +05:30
Pawan Verma 034e03abf4 Improved: Inconsistent String Comparisons(OFBIZ-9254)
There are some inconsistencies in the code for string comparison statusId.equals(PRUN_COMPLETED) whereas it should be written as PRUN_COMPLETED.equals(statusId) cause the former can throw NullPointerException if the variable found to be NULL.

Thanks: Devanshu for your contribution.
2020-07-30 17:01:54 +05:30
Suraj Khurana 3929ff1bd7 Improved: Corrected all incorrect indentation level issues in application component, also fixed some case indentation checkstyle issues.
(OFBIZ-11922)
2020-07-26 20:25:35 +05:30
Aditya Sharma 6804a9dac3 Fixed: Unable to create event in SFA component (OFBIZ-9901)
When creating event for the party other than the loggedin user, the party should be in CAL_OWNER role to be added to event. Added appropriate check in service along with the error message.
Thanks Rubia Elza Joshep for reporting the issue and Aditi Patidar for providing the patch
2020-07-25 18:48:39 +05:30
Suraj Khurana df21972eed Improved: Updated case indentation to 0 for all switch statements in applications component. Also done formatting changes as per checkstyle best practices.
(OFBIZ-11904)
2020-07-25 13:53:10 +05:30
Priya SharmaandPriya Sharma 679b2883e1 Improved : Convert createRoleType service to entity-auto from Java and update its service calls (OFBIZ-11894) (#215)
(OFBIZ-11894)
* Improved: Convert createRoleType service to entity-auto from Java and update its service calls
- Removed the java implementation
- Converted the service to entity-auto
- updated the service call in Party tests where this service was used.
* Improved: Removed the testCreateRoleType test, as the base service is now converted to entity-auto and will be handled in entity-auto tests. (OFBIZ-11984)

Co-authored-by: Priya Sharma <priya.sharma@hotwaxsystems.com>

Thanks: Pawan Verma for review.
2020-07-22 11:21:16 +05:30
Suraj Khurana c20b03eca1 Merge branch 'trunk' of https://gitbox.apache.org/repos/asf/ofbiz-framework into trunk 2020-07-21 12:22:39 +05:30
Suraj Khurana 038d46e51d Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in applications component.
(OFBIZ-11886)
2020-07-21 12:22:02 +05:30
Priya SharmaandPawan Verma 7d024e820f Improved: Convert createPartyRelationshipType service to entity-auto from Java and update its service calls (OFBIZ-11895) (#216)
* Improved: Convert createPartyRelationshipType service to entity-auto from Java and update its service calls(OFBIZ-11895)
- Updated the service definition to convert it into entity-auto
- Removed the java implementation of the services
- Removed the test as the service has been converted to entity-auto and it will be tested using entity-auto tests

Co-authored-by: Pawan Verma
2020-07-21 10:51:44 +05:30
Jacques Le Roux 2d7c533e34 Improved: Use Error.ftl everywhere it's not yet used (OFBIZ-11890)
Removes all error*.jsp reference, no longer used
2020-07-20 19:27:00 +02:00
Suraj Khurana 0524945bda Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in applications component.
(OFBIZ-11887)
2020-07-18 12:15:16 +05:30
Jacques Le Roux 2585cadd33 Improved: Use Error.ftl everywhere it's not yet used (OFBIZ-11890)
Removes ashes in web.xml files
2020-07-17 08:08:19 +02:00
holivier b36943d56f Documented: Check all docbook file in each applications-component
documents directory
(OFBIZ-11587)

remove all files
2020-07-14 16:55:05 +02:00
Suraj Khurana 2d01d722e6 Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in applications component.
(OFBIZ-11880)
Thanks Jacques for review.
2020-07-13 14:15:34 +05:30