The field govAgencyPartyId in the AddFixedAssetRegistration form shows all
parties through the lookup target-form-name="LookupPartyName function.
This should be limited to those parties that qualify with the constraint.
Thanks: Pierre Smits for report Priya Sharma for the fix
[...] having more important apps in 1st places would be better [...]
the feature should be easily changed by custom projects [...]
documentation for that would be enough.
This 1st step sorts the applications and webtools. I believe webtools should not
be secondary but that needs to be discussed with other options.
(OFBIZ-10601)
To improve theme management and provide better tools for new themes, we implement a method to obtain the main menu of a webapp.
Instead of just managing a menu, we extend the functionality by offering a method to expose a summary of the webapp, to simplify the navigation.
For this we add a new attribute on webapp definition app-shortcut-screen :
<webapp name="mywebapp"
...
app-shortcut-screen="component://mycomponent/widget/CommonScreens.xml#ShortcutApp"
...
/>
The idea is to define a new purpose screen *Shortcut* that contains what defines a webapp when an action or navigation has been requested. With this screen you can load a menu, a search, a complex description and use all screen powerfulness to resolve what displaying and support by theming
<screen name="ShortcutApp">
<section>
<actions>
<property-map resource="CommonUiLabels" map-name="uiLabelMap" global="true"/>
</actions>
<widgets>
<decorator-screen name="ShortcutDecorator" location="component://common/widget/CommonScreens.xml">
<decorator-section name="body">
<include-menu name="MyShortcutAppBar" location="component://mycomponent/widget/CommonMenus.xml"/>
</decorator-section>
</decorator-screen>
</widgets>
</section>
</screen>
Each component are self-sufficient to define what shortcuts to display without framework change or knowledge about other component.
Each theme can implement and customize the display rendering at will.
To illustrate an example of implementation we set sub menu for each webapp defined on applications and exploit it on bluelight theme.
Thanks for Dennis Balkir, Jacques Leroux, Leila Mekika and Julien Nicolas for their involvement
Steps to replicate the issue :
Go to Party application.
On the 'find communications' screen clicks on the 'New communications' button.
The system will navigate you to create/edit communications screen.
On create/edit communications screen you will see the 'New communications' button.
Providing the 'New communications' button on the 'create new communication
screen' does not make any sense over so it should be removed from here.
Thanks: Shubham Choudhary
This reverts commit 17eb2e4cf7.
It does not work when using <<target="javascript:........>>
I could change those cases but it's easier and safer to simply revert back to
target-type!
Thanks: James for report
While working on OFBIZ-12080 I found an upload feature that allows to import
invoices but it's not visible from UI and not working.
Moreover the export feature was missing a parameters as the import.
It has been introduced by Hans Bakker with
https://svn.apache.org/repos/asf/ofbiz/trunk@1502093
and I'm not sure the integration was completed.
We could remove it, but I think it can be useful and does not seem to miss much
to work fine.
Also use an uploadedFile label in ImportParty and UploadContent forms
(OFBIZ-12074)
When you call the service createCommunicationEventWithoutPermission to create a anonymous communication or from a user without party permission, the service failed due to missing permission.
With the minilang to groovy conversion the userLogin system it's not loaded before call the main service createCommunicationEvent
- Accounting Glossary,
- declare it as glossary
- re-order existing items
- add a comment at beginning about importance of order items
- correction for some ID: change space to _
- add some items coming from wiki glossary
- Facility
- add glossary directly in facility.adoc
- Human Resource Glossary
- re-order existing items
- add a comment at beginning about importance of order items
- move some items to Party Glossary or global Glossary
- HR appendix: add link to wiki OFBiz related book for Data Model Reference Book
- Add Party Glossary and included it in party.adoc
- add some items coming from wiki glossary and HR glossary
- General Glossary
- add a comment at beginning about importance of order items
- add some items coming from wiki glossary and HR glossary
- Add facility.adoc with only overview
- Correction for Content Management title
- in General glossary, add link to main components
- Complete Order management overview
- Add a short overview for Party
- Ordered applications in user-manual in alphabetic order
Service is used for create employee service, and email address is not mandatory, so emailAddressContext should be empty if parameters.emailAddress is empty.
Correction done is to call createPerson before creating emailAddressContext to be able to put set partyId in the if not empty parameters.emailAddress
As Akash Jain reported:
<<While researched on ticket OFBIZ-11896 identified that groovy version of
createPartyGroupRoleAndContactMechs service (converted from mini lang at rev
8af7cf8775 ) is not working.
Identify these two reasons,
resolvePartyGroupMap called incorrectly
resolvePostalAddressMap and resolveTelecomNumberMap implemented incorrectly
as 'postalAddress' and 'telecomNumber' map processor
not available into PartyMapProcs.xml.
There may be more reasons along with these two reasons.>>
He was so true to say the later!
There are also some intentionally or automated formattings.
Thanks: Akash for report, Sourabh Jain for shy tentative :)
Long ago I spotted an issue:
<<In French I got this js error message in console (else nothing apears anywhere)
SyntaxError: missing ) after argument list
...=9000&partyId=Company', 'Adresse d'expédition - Géolocalisation', '450', '550')
It's due to the quote in "Adresse d'expédition"
We could though commit by escaping the popUptitle, but I also think we should
change from the popup (and everywhere the same is used) to a modal layered
window.>>
Turned out that:
<<I had a quick look to see if we could not use a modal layer instead of a popup,
but it's not obvious to use modal layer from Freemarker. This does not mean that
it can't be done... I'll see later...>>
Here is a late workaround :)
While researched on ticket OFBIZ-11896 identified that groovy version of
createPartyGroupRoleAndContactMechs service (converted from mini lang at rev
8af7cf8775 ) is not working.
Identify these two reasons,
resolvePartyGroupMap called incorrectly
resolvePostalAddressMap and resolveTelecomNumberMap implemented incorrectly
as 'postalAddress' and 'telecomNumber' map processor not available into PartyMapProcs.xml.
There may be more reasons along with these two reasons.
Thanks: Akash Jain for report, Sourabh Jain for incomplete patch (missed 2nd
point from Akash
We have a lot of "do nothing" in Java code. In case of catch we should at least
have Debug.logError(e, MODULE); and maybe an explanation in the comment.
(OFBIZ-11947)
This is done for applications component. Also corrected some variables as per naming convention best practices.
Thanks Jacques for review.
There are some inconsistencies in the code for string comparison statusId.equals(PRUN_COMPLETED) whereas it should be written as PRUN_COMPLETED.equals(statusId) cause the former can throw NullPointerException if the variable found to be NULL.
Thanks: Devanshu for your contribution.
When creating event for the party other than the loggedin user, the party should be in CAL_OWNER role to be added to event. Added appropriate check in service along with the error message.
Thanks Rubia Elza Joshep for reporting the issue and Aditi Patidar for providing the patch
(OFBIZ-11894)
* Improved: Convert createRoleType service to entity-auto from Java and update its service calls
- Removed the java implementation
- Converted the service to entity-auto
- updated the service call in Party tests where this service was used.
* Improved: Removed the testCreateRoleType test, as the base service is now converted to entity-auto and will be handled in entity-auto tests. (OFBIZ-11984)
Co-authored-by: Priya Sharma <priya.sharma@hotwaxsystems.com>
Thanks: Pawan Verma for review.
* Improved: Convert createPartyRelationshipType service to entity-auto from Java and update its service calls(OFBIZ-11895)
- Updated the service definition to convert it into entity-auto
- Removed the java implementation of the services
- Removed the test as the service has been converted to entity-auto and it will be tested using entity-auto tests
Co-authored-by: Pawan Verma