This reverts commit 17eb2e4cf7.
It does not work when using <<target="javascript:........>>
I could change those cases but it's easier and safer to simply revert back to
target-type!
Thanks: James for report
(OFBIZ-9512)
Fixed it at all the places found in SFA where roleTypeId wasn't being passed and creating the issue.
Thanks Jagpreet Kaur for reporting and verifying the issue, thanks Parakh Maheshwari and Devanshu Vyas for reviewing and providing details on their finding and thanks Aditya Sharma for providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806261 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8090)
Change all form names to upper camel case for consistency.
Thanks: Tanmay Muley for reporting and providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761102 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8077)
Change all form names to upper camel case for consistency.
Thanks: Tanmay Muley for reporting and providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761087 13f79535-47bb-0310-9956-ffa450edef68
To resolve this issue we can convert the current use for import/export vcard by an other api ez-vcard (https://github.com/mangstadt/ez-vcard) under bsd licence and present on jcenter.
The refactoring raise some problem on existant code, we will try with Gil to improve the import/export to grow data conversion to functional framework.
Some improve on import :
* check if more than one email is present before check the prefered else take the one
* check if more than one phone is present before check the prefered else take the one
* check if more than one address is present before check the prefered else take the one
* When you load a party by vcard, initialize a reference by fn attribute on PartyIndentification to escape the second loading
Will need continue improve the import like correct Organization loading, update process, add service to detect already party present
I also improve the screen result to display all parties loaded by the import and all already present.
The solution isn't perfect but it's work and compile, first purpose to delete jpim.jar is done :)
Related issue OFBIZ-7961
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1756949 13f79535-47bb-0310-9956-ffa450edef68
This is the 2nd step: puts back the original names, so it will be transparent for remaining references in xml catalogs, Java code, etc.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749489 13f79535-47bb-0310-9956-ffa450edef68
This is a 1st step, in a 2nd I will put back the original names, so it will be transparent for remaining reference in xml catalogs, Java code, etc.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749488 13f79535-47bb-0310-9956-ffa450edef68
Instead of a quiet S/R action, this was an unexpected pain in the ass. A considerable number of forms:
EmployeeForms.xml
EmploymentForms.xml
EmplPositionForms.xml
GlobalHRSettingForms.xml
RecruitmentForms.xml
QuoteForms.xml
PartyForms.xml
StoreForms.xml
ContactForms.xml
FixedAssetForms.xml
TaskForms.xml
scrumForms.xml
TaskForms.xml
contained a large number of fields with
tooltip="${uiLabelMap.CommonRequired}"
but no
required-field="true"
Of course display and display-entity should not be concerned, I spotted a number of them in the lot.
I also removed a bunch of harcoded * at end of labels (those followed by required-field="true"* and spotted a number of others }*" who still need to be carefully reviewed to see if required=true is not missing there :/
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1709882 13f79535-47bb-0310-9956-ffa450edef68
jleroux: after a cursory review, I simply did the chunk related to exampleName by hand, it needed more work. I also removed some trailing blanks.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1709872 13f79535-47bb-0310-9956-ffa450edef68
* clean sfa's from to convert bsh to groovy call and clean unnecessary value declaration
* complete unit test to controle new service ensurePartyRoleFrom and ensurePartyRoleTo
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1649965 13f79535-47bb-0310-9956-ffa450edef68
The label ${uiLabelMap.PartyCountryCode} is used several times in the project but i could not find the definition of PartyCountryCode in label definition files.
I looked further and found CommonCountryCode in label file which is not used and fill the need for PartyCountryCode. To solve this I propose to rename all PartyCountryCode to CommonCountryCode.
jleroux: I also moved CommonCountryCode, CommonCountryCodeMissing and CommonCountryMissing from PartyUiLabels.xml to CommonUiLabels.xml
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1447664 13f79535-47bb-0310-9956-ffa450edef68
Description
In SFA "Create New Account" does not implement dependent drop downs for Country/State.
This is not consistent whith the behavior in the Account update form which uses Country/State dependent drop downs.
To Reproduce:
In SFA select Accounts
Select "Create New Account"
Expect: "State" values to be limited to values valid for the selected country.
Actual: "State" values include all values in stateProvinceGeoId regardless of the selected Country.
After Improvement:
State values will be filtered based on the value selected in "Country Geo Id"
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1325136 13f79535-47bb-0310-9956-ffa450edef68
SFA does not store countryGeoId or stateProvinceGeoId in PostalAddress entity when creating a new account causing postal address display to break in SFA and Party Manager profile screens.
Demo data for "sfa100" does not have values for countryGeoId or stateProvinceGeoId
Values countryGeoId or stateProvinceGeoId are needed to display party profile.
To reproduce:
1. In Party Manager search for Party Id "sfa100"
Open "sfa100" from search results
See error message under "General Correspondence Address"
2. Similar in SFA Account Lookup
3. A New Account created in SFA will produce the same error.
Adding address to an existing account works. For example the demo accounts created by other components.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1310731 13f79535-47bb-0310-9956-ffa450edef68
When rendering "Merge contacts" and "Merge Lead" there are an internal error and the page don't finish rendering.
CONTACTS
log error:
bsh.TokenMgrError: Lexical error at line 1, column 78. Encountered: <EOF> after : "\"${contact.partyId;"
at bsh.ParserTokenManager.getNextToken(Unknown Source)
The problem comes from
/marketing/widget/sfa/forms/ContactForms.xml#MergeContacts
fields: partyIdTo and partyIdFrom
LEADS
log error:
bsh.TokenMgrError: Lexical error at line 1, column 75. Encountered: <EOF> after : "\"${lead.partyId;"
at bsh.ParserTokenManager.getNextToken(Unknown Source)
the problem comes from
/marketing/widget/sfa/forms/LeadForms.xml#MergeLeads
fields: partyIdTo and partyIdFrom
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@941440 13f79535-47bb-0310-9956-ffa450edef68
When rendering "Merge contacts" and "Merge Lead" there are an internal error and the page don't finish rendering.
CONTACTS
log error:
bsh.TokenMgrError: Lexical error at line 1, column 78. Encountered: <EOF> after : "\"${contact.partyId;"
at bsh.ParserTokenManager.getNextToken(Unknown Source)
The problem comes from
/marketing/widget/sfa/forms/ContactForms.xml#MergeContacts
fields: partyIdTo and partyIdFrom
LEADS
log error:
bsh.TokenMgrError: Lexical error at line 1, column 75. Encountered: <EOF> after : "\"${lead.partyId;"
at bsh.ParserTokenManager.getNextToken(Unknown Source)
the problem comes from
/marketing/widget/sfa/forms/LeadForms.xml#MergeLeads
fields: partyIdTo and partyIdFrom
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@941431 13f79535-47bb-0310-9956-ffa450edef68