Commit Graph
24 Commits
Author SHA1 Message Date
Jacques Le Roux e259170b77 Improved: Improvement on Find BOM screen (OFBIZ-12179)
While exploring the manufacturing code I observed on the find screen BOM type is
set hardcoded. We can improve it by using the entity-option tag to allow all
ProductAssocType with parentTypeId equals "PRODUCT_COMPONENT".

Thanks: Nameet Jain
2021-02-18 11:57:35 +01:00
Priya SharmaandPriya Sharma 15aec7e8f7 WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762) (#185)
* [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug
- Replaced the debug.log methods with the respective groovy utility method
- Enhanced the GroovyBaseScript to entertain the fetch the current class name as the module name for logging
- Overloaded the logError method to entertain throwbale object for better logging
- Removed unused import statements and module variables.

(OFBIZ-11762)

* [Removed]: Extra line spaces. (OFBIZ-11762)

* [Revert]: Unwanted changes. (OFBIZ-11762)

* [Added] Same changes to these files. (OFBIZ-11762)

Co-authored-by: Priya Sharma <priya.sharma@example.com>
2020-06-06 10:17:23 +02:00
Nicolas Malin b134c6b72f Improved: Convert ProductionRunServices.xml file from mini-lang to groovy DSL
(OFBIZ-11395)

Thanks to Yashwant Dhakad for this patch
2020-05-19 17:09:34 +02:00
Jacques Le Roux 28e119027c Improved: Use Groovy Truth instead of UtilValidate Class in Groovy
(OFBIZ-11064)

As we all know, Groovy is a powerful language with great built-in functions. 
Groovy Truth[1] is one of them, which is not used properly in our code base. 
We have used UtilValidate Class to validate arguments for Empty or NotEmpty, 
which can easily be done in groovy with built-in functionality[1].
 
Current Code: if (UtilValidate.isNotEmpty(locations)) { ... }
Groovy Built-in Code: if (locations) { ... }
 
[1] - http://groovy-lang.org/semantics.html#Groovy-Truth
 
We need to careful for some points while we change this:
Like:
maxRetry = 0
if (!maxRetry)
{  // Not set, use a default  maxRetry = -1 }

Because groovy evaluates zero to be false, it wouldn't be possible to set
maxRetry to zero.  So it's best not to use groovy truth for null-checks on
numbers in some cases. 
 
Thanks: Pawan Verma

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1860051 13f79535-47bb-0310-9956-ffa450edef68
2019-05-26 10:36:16 +00:00
Jacques Le Roux 9712ec2963 Improved: function parseBigDecimalForEntity is in wrong location
(OFBIZ-10689)

After I changed the method name from  ObjectType::simpleTypeConvert to
ObjectType::simpleTypeOrObjectConvert, Shikha Jaiswal noticed that I missed 
the groovy files.

Checking further I found that I also missed the simple-methods.xsd and 
ObjectTypeTests.java (though this last one was no really a problem)

Thanks: Shikha Jaiswal 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1851156 13f79535-47bb-0310-9956-ffa450edef68
2019-01-12 09:29:29 +00:00
Jacques Le Roux 0af9ffe58e Fixed: Manufacturing BOM search returning duplicate entries in search results
(OFBIZ-10648)

Bill of Materials search returning duplicate entries in search results.

Test Steps:
1. Login to Manufacturing application.
2. Navigate to Bill of Materials tab.
3. Observe the issue in Search results.

Expected Result:
Unique products should be displayed on Bill of Materials search results.
Actual Result:
Bill of Materials search returning duplicate entries in search results. 
The distinct constraint is missing in FindProductBom.groovy find query.

Thanks: Aditya Barve

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1846594 13f79535-47bb-0310-9956-ffa450edef68
2018-11-14 17:31:27 +00:00
Deepak Dixit 7e19de9966 Improved: Replace all delegator findByAnd and findOne method calling by EntityQuery methods (OFBIZ-10029)
Applied slightly modified patch, rearrange import properly, 
Thanks Suraj Khurana for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818003 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 12:03:17 +00:00
Deepak Dixit 63258e90f8 Reverted r#1817989, workign fine locally, reverted for now will check and commit again
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817998 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 10:42:32 +00:00
Deepak Dixit d1f85a7e5d Improved: Replace all delegator findByAnd and findOne method calling by EntityQuery methods (OFBIZ-10029)
Applied slightly modified patch, rearrange import properly, 
Thanks Suraj Khurana for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817989 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 09:21:33 +00:00
Deepak Dixit ccba2a3404 Manufacturing : Remove unused imports from groovy files for code optimization.
Applied slightly modified patch from jira issue (OFBIZ-9510)
Thanks  Suraj Khurana and Pradeep Choudhary for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806323 13f79535-47bb-0310-9956-ffa450edef68
2017-08-26 19:36:42 +00:00
Nicolas Malin 40fdd2ca73 Implemented: Continue the common-theme upload (OFBIZ-9138 Create a common theme)
Five step 
#9 Change all set screen and script that call widget.properties values replaced by call to modelTheme

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806150 13f79535-47bb-0310-9956-ffa450edef68
2017-08-25 10:02:34 +00:00
Deepak Dixit d5bcaaedf8 Improved: Inconsistent String Comparisons, Applied application groovy patch from jira issue. (OFBIZ-9254)
I found an inconsistency in the code for string comparison statusId.equals("PRUN_COMPLETED") whereas it should be written as "PRUN_COMPLETED".equals(statusId) cause the former can throw NullPointerException if the variable found to be NULL.

Thanks Devanshu Vyas for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1795341 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 17:16:05 +00:00
Wei Zhang 7427f9f794 The viewSize should be converted Integer for multiplication
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1792020 13f79535-47bb-0310-9956-ffa450edef68
2017-04-20 07:25:58 +00:00
Arun Patidar 2bfc816e9b Improved: Removed semicolon from all Groovy files of all components.
(OFBIZ-8652)

Thanks: Rohit Koushal, Jacques Le Roux and Rishi Solanki for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767764 13f79535-47bb-0310-9956-ffa450edef68
2016-11-02 19:09:13 +00:00
Ashish Vijaywargiya 6b3717e026 Applied patch from jira issue - OFBIZ-8071 - Clean up commented out code in Groovy for Manufacturing. Thanks Aman for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1759150 13f79535-47bb-0310-9956-ffa450edef68
2016-09-04 06:56:50 +00:00
Deepak Dixit 834691742b (OFBIZ-6274) Renamed OFBiz artefacts from org.ofbiz.* to org.apache.ofbiz.*.Thanks to Taher for working on it.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1752920 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 10:30:49 +00:00
Ashish Vijaywargiya 034acf1d8b Applied patch from jira issue - OFBIZ-7568 - Remove HtmlFormWrapper dependencies from Calendar Exception Day screen.
Thanks Ravi for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750307 13f79535-47bb-0310-9956-ffa450edef68
2016-06-27 08:15:12 +00:00
Ashish Vijaywargiya c296436d2d Applied patch from jira issue -OFBIZ-7573 - Remove unused import related to HtmlFormWrapper and unused file using it.
Thanks Ravi for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750304 13f79535-47bb-0310-9956-ffa450edef68
2016-06-27 08:04:29 +00:00
Ashish Vijaywargiya f7a3a91901 Applied patch from jira issue - OFBIZ-7569 - Remove HtmlFormWrapper dependencies from Calendar Exception Week screen.
Thanks Ravi for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750300 13f79535-47bb-0310-9956-ffa450edef68
2016-06-27 08:00:28 +00:00
Ashish Vijaywargiya 1d71d3c6ba Applied patch from jira issue - OFBIZ-7567 - Remove HtmlFormWrapper dependencies from Production Run Cost screen.
Thanks Ravi for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750299 13f79535-47bb-0310-9956-ffa450edef68
2016-06-27 07:59:17 +00:00
Ashish Vijaywargiya e550ba594a Applied patch from jira issue - OFBIZ-7566 - Remove HtmlFormWrapper dependencies from Production Run Screen.
Thanks Ravi for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750297 13f79535-47bb-0310-9956-ffa450edef68
2016-06-27 07:58:19 +00:00
Arun Patidar a91b9edae9 Applied patch from ticket - OFBIZ-7339 - Replace EntityUtilProperties getPropertyValue method with correct method calls. Thanks Rahul Singh Kushwah and Rishi Solanki for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749882 13f79535-47bb-0310-9956-ffa450edef68
2016-06-23 13:10:51 +00:00
Deepak Dixit d9a8278ae6 (OFBIZ-7245) Renamed groovy file in upper camel case as per best practices
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747850 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 06:12:27 +00:00
Deepak Dixit 8eac4248c9 (OFBIZ-7225) relocate .groovy files in the manufacturing component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747766 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 18:25:48 +00:00