Commit Graph
1030 Commits
Author SHA1 Message Date
Jacques Le Roux 07054fdaf5 Fixed: Error while running MRP (OFBIZ-12187)
I tried running MRP for Sales Forecast option and it returned the following error.

Error running the initMrpEvents service: Service [initMrpEvents] target threw
an unexpected exception (java.sql.Timestamp cannot be cast to java.sql.Date)

Thanks: Nameet Jain
2021-02-23 12:59:46 +01:00
Jacques Le Roux e259170b77 Improved: Improvement on Find BOM screen (OFBIZ-12179)
While exploring the manufacturing code I observed on the find screen BOM type is
set hardcoded. We can improve it by using the entity-option tag to allow all
ProductAssocType with parentTypeId equals "PRODUCT_COMPONENT".

Thanks: Nameet Jain
2021-02-18 11:57:35 +01:00
Michael Brohl 69c62f5f00 Merge changes for PR #267 due to conflicting changes in trunk (OFBIZ-12169) 2021-02-15 17:15:18 +01:00
Jacques Le Roux a2dac5482c Improved: Default ordering of webapps titles in main menu (OFBIZ-12166)
[...] having more important apps in 1st places would be better [...]
the feature should be easily changed by custom projects [...]
documentation for that would be enough.

This 1st step sorts the applications and webtools. I believe webtools should not
be secondary but that needs to be discussed with other options.
2021-02-14 21:11:58 +01:00
Wiebke Pätzold 95d37d2189 Removes and adds whitespaces as suggested by checkstyle (OFBIZ-12169) 2021-02-09 08:46:20 +01:00
Nicolas Malin 7165768251 Implemented: Add a framework method to get main webapp menu with the webapp name
(OFBIZ-10601)

To improve theme management and provide better tools for new themes, we implement a method to obtain the main menu of a webapp.
Instead of just managing a menu, we extend the functionality by offering a method to expose a summary of the webapp, to simplify the navigation.

For this we add a new attribute on webapp definition app-shortcut-screen :

    <webapp name="mywebapp"
            ...
            app-shortcut-screen="component://mycomponent/widget/CommonScreens.xml#ShortcutApp"
            ...
    />

The idea is to define a new purpose screen *Shortcut* that contains what defines a webapp when an action or navigation has been requested. With this screen you can load a menu, a search, a complex description and use all screen powerfulness to resolve what displaying and support by theming

    <screen name="ShortcutApp">
        <section>
            <actions>
                <property-map resource="CommonUiLabels" map-name="uiLabelMap" global="true"/>
            </actions>
            <widgets>
                <decorator-screen name="ShortcutDecorator" location="component://common/widget/CommonScreens.xml">
                    <decorator-section name="body">
                        <include-menu name="MyShortcutAppBar" location="component://mycomponent/widget/CommonMenus.xml"/>
                    </decorator-section>
                </decorator-screen>
            </widgets>
        </section>
    </screen>

Each component are self-sufficient to define what shortcuts to display without framework change or knowledge about other component.
Each theme can implement and customize the display rendering at will.

To illustrate an example of implementation we set sub menu for each webapp defined on applications and exploit it on bluelight theme.

Thanks for Dennis Balkir, Jacques Leroux, Leila Mekika and Julien Nicolas for their involvement
2021-01-15 08:56:23 +01:00
Jacques Le Roux ec2b84341e Reverted: "Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)"
This reverts commit 17eb2e4cf7.

It does not work when using <<target="javascript:........>>
I could change those cases but it's easier and safer to simply revert back to
target-type!

Thanks: James for report
2020-12-18 11:08:32 +01:00
Jacques Le Roux 17eb2e4cf7 Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)
Same for sub-hyperlink
2020-12-11 16:52:04 +01:00
holivier 4a41f0fde5 Documented: migration to help system using asciidoc files (OFBIZ-11587)
commit correction for <Remove all related help docbook files>
* reAdd a contentDocData for main contentId and portletCategory
* remove from ofbiz-component of each application line about helpData which are removed
2020-10-27 11:20:09 +01:00
holivier 302bc0eb15 Documented: migration to help system using asciidoc files (OFBIZ-11587)
Remove all related help docbook files
2020-10-26 17:34:03 +01:00
Suraj Khurana b3fcbeedba Improved: Make data members of class as private and added accessor methods for the same, also corrected occurences of the same in applications component.
(OFBIZ-11963)
Also made some related checkstyle code enhancements. Thanks Jacques for review.
2020-09-12 12:09:03 +05:30
Suraj Khurana 5f021ce06b Improved: Corrected line is longer than 150 characters checkstyle issues in applications component.
(OFBIZ-11921)
Also fixed some other extra space and naming related checkstyle issues observed.
Thanks Jacques for review.
2020-09-04 12:24:14 +05:30
Akash Jain 66a76ffd5a Improved: Fix Literals comparisons with variable to avoid NPE (OFBIZ-11929)
Thanks, Devanshu Vyas for your contribution.
2020-08-30 17:20:23 +05:30
Jacques Le Roux 2d033df446 Improved: Update information in README.md files from removed pages in wiki 2020-08-29 17:37:18 +02:00
Jacques Le Roux c8c5895707 Reverted: "Improved: Have a readme in every component (OFBIZ-6243)"
This reverts commit f281fe290a.

An Apache URL is much easier to have (NO bad idea)
2020-08-29 13:52:27 +02:00
Jacques Le Roux f281fe290a Improved: Have a readme in every component (OFBIZ-6243)
An Apache URL is much easier to have
2020-08-29 13:49:41 +02:00
Jacques Le Roux ee0968440e Improved: Have a readme in every component (OFBIZ-6243)
Not sure why we have this problem (according to
https://docs.github.com/en/github/authenticating-to-github/about-anonymized-image-urls
could be to missing cache control in our site server)

As I was fed up not viewing the OFBIz logo anywhere, and mostly in GH,
but just in browser at https://ofbiz.apache.org/images/ofbiz_logo.png
and I noticed I was viewing it well locally at
https://github.com/apache/ofbiz-framework/tree/trunk/themes/rainbowstone
so decided to use this URL everywhere rather!
2020-08-29 13:35:14 +02:00
Jacques Le Roux d15cc57bf0 Improved: Have a readme in every component (OFBIZ-6243)
This preludes the move of content of README.md files into the asciidoc
documentation

Updates the link to OFBiz-logo.png
Removes deprecated information related to Svn, Jira and Confluence
We will move the wiki pages to wiki attic with OFBIZ-11619
2020-08-29 11:52:51 +02:00
Pawan Verma 6cb67c1a40 Improved: Replace .size() == 0 with isEmpty() in Java files(OFBIZ-11944)
Thanks, priya for the report and patch and jacques for the review.
2020-08-22 19:17:10 +05:30
Suraj Khurana d74742d730 Improved: Make data members of class as private and added accessor methods for the same, also corrected occurences of the same in applications component.
(OFBIZ-11963)
Also made some related checkstyle code enhancements.
Thanks jacques for finalizing Javadoc pattern during this effort.
2020-08-22 13:00:17 +05:30
Suraj Khurana 413e0ec3ec Improved: Added missing Javadocs for some methods, this is required for all classes which looks like designed for extension (can be subclassed).
(OFBIZ-11947)
This is done for applications component. Also corrected some variables as per naming convention best practices.
Thanks Jacques for review.
2020-08-17 12:25:56 +05:30
Priya Sharma 3fe72d440f Improved: Remove unused imports from Java files (OFBIZ-11930) (#222)
Improved: Remove unused imports from Java files
(OFBIZ-11930)
Thanks: Priya Sharma
2020-08-06 19:51:09 +05:30
Akash Jain ea37e0fed3 Improved: Status ID checkbox for FindWorkEffort, FindProductionRun and FindShipment forms (OFBIZ-11939) 2020-08-03 16:22:26 +05:30
Suraj Khurana c6399ef668 Improved: Corrected some line is longer than 150 characters checkstyle issues in applications component. Also fixed some extra spaces and naming conventions related checkstyle issues.
(OFBIZ-11921)
2020-08-03 10:14:20 +05:30
Suraj Khurana 3929ff1bd7 Improved: Corrected all incorrect indentation level issues in application component, also fixed some case indentation checkstyle issues.
(OFBIZ-11922)
2020-07-26 20:25:35 +05:30
Suraj Khurana df21972eed Improved: Updated case indentation to 0 for all switch statements in applications component. Also done formatting changes as per checkstyle best practices.
(OFBIZ-11904)
2020-07-25 13:53:10 +05:30
Suraj Khurana 038d46e51d Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in applications component.
(OFBIZ-11886)
2020-07-21 12:22:02 +05:30
Suraj Khurana 0524945bda Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in applications component.
(OFBIZ-11887)
2020-07-18 12:15:16 +05:30
holivier b36943d56f Documented: Check all docbook file in each applications-component
documents directory
(OFBIZ-11587)

remove all files
2020-07-14 16:55:05 +02:00
Suraj Khurana 2d01d722e6 Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in applications component.
(OFBIZ-11880)
Thanks Jacques for review.
2020-07-13 14:15:34 +05:30
Suraj Khurana bdc8c73fd8 Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for applications component.
(OFBIZ-11874)
This fixes following checkstyle issues:
'{' is not preceded with whitespace.
'{' is not followed by whitespace.
'}' is not followed by whitespace.
'}' is not preceded with whitespace.
'typecast' is not followed by whitespace.
'try' is not followed by whitespace.
';' is preceded with whitespace.
2020-07-11 14:29:35 +05:30
Suraj Khurana 82ce4304ae Improved: Corrected all checkstyle issues related to succeeding space for comma in applications directory.
(OFBIZ-11805)
Thanks Jacques and Ritesh Kumar for review.
2020-07-09 11:59:51 +05:30
Suraj Khurana 749d4d6d94 Improved: Corrected remaining ', is not followed by whitespace' checkstyle errors in framework component.
(OFBIZ-11805)
2020-07-07 15:25:15 +05:30
Suraj Khurana bfe3adeae9 Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors in applications component.
(OFBIZ-11805)
Thanks Jacques Le Roux and Ritesh Kumar for review.
2020-07-06 15:34:00 +05:30
Pawan Verma e19b12eae9 Improved: Replace explicit type argument with diamond operator(OFBIZ-11828)
Since Java 1.7, when defining generic types it is unnecessary to redefine those types in the constructor when it is already done in the declared type.
2020-06-28 01:04:51 +05:30
Pawan Verma f0af2894e5 Improved: Merge identical catch blocks in single catch block(OFBIZ-11827)
In Java SE 7 and later, a single catch block can handle more than one type of exception. This feature can reduce code duplication and lessen the temptation to catch an overly broad exception.

Thanks: Jacques for the review.
2020-06-27 11:23:12 +05:30
Pawan Verma 15c005fa42 Improved: Replace for-loop with forEach loop(OFBIZ-11829)
Also modified some checkstyle issues.

Set checkstyleMain.maxErrors to 26684 (-61)

Thanks: Jacques for the review.
2020-06-22 21:17:49 +05:30
holivier 3a601c90fb Documented: remove docbook help files for manufacturing (OFBIZ-11587)
All files have been migrated to asciidoc format.
2020-06-20 16:04:12 +02:00
holivier 915073ba84 Documented: migrate help link to asciidoc user manual for manufacturing
(OFBIZ-11416)

All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files

In the global Help Docbook index tree, remove all points about
manufacturing and add a short page with a link to the new help
2020-06-20 16:03:58 +02:00
holivier 74a1b73fda Documented: Manufacturing MRP migration to asciidoc
(OFBIZ-11416)

For all of files, content has been directly put in mfg-mrp.adoc
2020-06-20 16:02:46 +02:00
holivier 47a7b30bac Documented: Manufacturing Bill Of Material migration to asciidoc
(OFBIZ-11416)

For all of files, content has been directly put in mfg-bom.adoc
2020-06-20 16:02:46 +02:00
holivier 166d0b33fd Documented: Manufacturing Cost Component Calc migration to asciidoc
(OFBIZ-11416)

The HELP file content has been directly put in manufacturing.adoc
2020-06-20 16:02:46 +02:00
holivier a69ca79ab4 Documented: Manufacturing Calendar migration to asciidoc
(OFBIZ-11416)

For all of files content has been directly put in
mfg-calendar.adoc
2020-06-20 16:02:46 +02:00
holivier b13573a330 Documented: Manufacturing Routing Task migration to asciidoc
(OFBIZ-11416)

For all of files content has been directly put in
mfg-routing-task.adoc
2020-06-20 16:02:46 +02:00
holivier 061cb0dabd Documented: Manufacturing Routing migration to asciidoc
(OFBIZ-11416)

For all of files content has been directly put in
mfg-routing.adoc
2020-06-20 16:02:46 +02:00
holivier 7d1c2c5ed4 Documented: Manufacturing Production Run migration to asciidoc
(OFBIZ-11416)

For most of files content has been directly put in
mfg-production-run.adoc
2020-06-20 16:02:46 +02:00
holivier 8652c3ca04 Documented: Manufacturing migration to asciidoc and new documentation
organization
(OFBIZ-11416)

Main files
2020-06-20 16:02:46 +02:00
Suraj Khurana 575defd088 Improved: Changed decimals, rounding, zero static variables names as per best practices in manufacturing component. (#200)
(OFBIZ-11804)
Also make them private data members of the class.
2020-06-12 16:35:36 +05:30
Priya SharmaandPriya Sharma 15aec7e8f7 WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762) (#185)
* [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug
- Replaced the debug.log methods with the respective groovy utility method
- Enhanced the GroovyBaseScript to entertain the fetch the current class name as the module name for logging
- Overloaded the logError method to entertain throwbale object for better logging
- Removed unused import statements and module variables.

(OFBIZ-11762)

* [Removed]: Extra line spaces. (OFBIZ-11762)

* [Revert]: Unwanted changes. (OFBIZ-11762)

* [Added] Same changes to these files. (OFBIZ-11762)

Co-authored-by: Priya Sharma <priya.sharma@example.com>
2020-06-06 10:17:23 +02:00
Suraj Khurana 5e7193f5a8 Improved: Changed resources with proper naming convention in all application components.
(OFBIZ-11739)
Also, made MODULE as private data member of class instead of public. This will reduce checkstlye issues. Thanks Jacques for review.
2020-05-29 13:19:05 +05:30