Commit Graph
33 Commits
Author SHA1 Message Date
Jacques Le Roux ec2b84341e Reverted: "Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)"
This reverts commit 17eb2e4cf7.

It does not work when using <<target="javascript:........>>
I could change those cases but it's easier and safer to simply revert back to
target-type!

Thanks: James for report
2020-12-18 11:08:32 +01:00
Jacques Le Roux 17eb2e4cf7 Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)
Same for sub-hyperlink
2020-12-11 16:52:04 +01:00
Divesh Dutta 738a12bec1 Improvement: Miniland code readability and consistency improvements
(OFBIZ-8744) (OFBIZ-8745) (OFBIZ-8746) (OFBIZ-8748) (OFBIZ-8829) (OFBIZ-8830) (OFBIZ-8907) (OFBIZ-8908) (OFBIZ-8924) (OFBIZ-8925) 

Thanks: Ankush Upadhyay , Sega patidar , Abhijeet Ashapure for your patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768219 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:14:04 +00:00
Jacques Le Roux c8ba932772 Fixes a "typo" in last commit for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
We used targetNamespace (should only be used in schema) instead of xsi:schemaLocation



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749634 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 05:58:26 +00:00
Jacques Le Roux 89212904bd Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
This is the 2nd step: puts back the original names, so it will be transparent for remaining references in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749489 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:37:47 +00:00
Jacques Le Roux 4931db1ed9 Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061 by replacing xsd files references in xml files by -ns.xsd files and removing the concerned xsd files
This is a 1st step, in a 2nd I will put back the original names, so it will be transparent for remaining reference in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749488 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:14:16 +00:00
Jacques Le Roux ae872ad298 Completes r1709192 for Changes for "SalaryStep entity missing From and Thru dates" https://issues.apache.org/jira/browse/OFBIZ-5758
I also decided that the "Salary StepSeq Id" Lookup needed not only a search on the fromDate but also to display the through date and the amount.
     





git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1709231 13f79535-47bb-0310-9956-ffa450edef68
2015-10-18 04:52:40 +00:00
Nicolas Malin 895c9856b3 Cleaning forms code is needed after setting default-value in list-options and entity-options, patch related to OFBIZ-6524 and follows the resolution of OFBIZ-6490 and OFBIZ-6489. Thanks Gil Portenseigne for this effort
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1686674 13f79535-47bb-0310-9956-ffa450edef68
2015-06-20 21:58:05 +00:00
Anil Patel 5db723cad4 [OFBIZ-5511] Thanks for reporting the issue Christian Carlow and Deepak Dixit for the fix.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1626450 13f79535-47bb-0310-9956-ffa450edef68
2014-09-20 14:58:55 +00:00
Jacques Le Roux 4d9e447e11 Adds the conventional comment <!-- if this isn't there then with all fields empty no query will be done --> to "noConditionFind" fields. It's not quite obvious, so the more there are the better
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1576278 13f79535-47bb-0310-9956-ffa450edef68
2014-03-11 10:53:37 +00:00
Jacques Le Roux 43119ab3dc A Christian Carlow's patch for "EditEmplPositionReportingStructs LookupEmplPosition associated popup and dropdown empty" https://issues.apache.org/jira/browse/OFBIZ-5510
LookupEmplPosition drop-down and popup window show no results on the EditEmplPositionReportingStructs page for the field.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1561305 13f79535-47bb-0310-9956-ffa450edef68
2014-01-25 13:35:32 +00:00
Jacques Le Roux 578662ae4c Now that we have fixed the layered lookup inside layered lookup issue and the recursive call case we can get rid of all the useless remaining presentation="window".
I keep the example and beware LookupTimeDuration is a special case

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@944623 13f79535-47bb-0310-9956-ffa450edef68
2010-05-15 12:13:00 +00:00
Jacques Le Roux e8ebd0a1b2 This lookup does not exist, is there for a long time? (I did not find its date of introduction, the older I found is r615322) and I can't see anything close
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@939988 13f79535-47bb-0310-9956-ffa450edef68
2010-05-01 12:07:08 +00:00
Jacques Le Roux e714f96c66 Closes "Replace popup lookups by layer lookups" (https://issues.apache.org/jira/browse/OFBIZ-3442) - OFBIZ-3442
Not all cases have been resolved but this patch takes this into account and should not introduce any not known issues. These issues are identified at "Layer popup umbrella main task" (https://issues.apache.org/jira/browse/OFBIZ-3445). They will be resolved later and are actually bugs so will be committed later when fixed. They are
* "Allow to open a layer lookup from a layer lookup" (https://issues.apache.org/jira/browse/OFBIZ-3446) and its specific case "Allow to open a layer lookup from a layer lookup recursively" (https://issues.apache.org/jira/browse/OFBIZ-3693)
* "The minimize/enlarge buttons (+ -) blocks the layer" (https://issues.apache.org/jira/browse/OFBIZ-3692)
* "When you get disconnected (time out) from a layered lookup, you then get afterward ugly screens" (https://issues.apache.org/jira/browse/OFBIZ-3450)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@937852 13f79535-47bb-0310-9956-ffa450edef68
2010-04-25 18:49:01 +00:00
Ashish Vijaywargiya 0507a954f6 Part of OFBIZ-3320 - Now you will see "Find" button on Lookup forms.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@889088 13f79535-47bb-0310-9956-ffa450edef68
2009-12-10 04:50:29 +00:00
Hans Bakker 96d54615ca removed default-option='contains' because now set from widget.properties which is the current default
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@834379 13f79535-47bb-0310-9956-ffa450edef68
2009-11-10 08:12:45 +00:00
Jacques Le Roux 835ab9c7c1 Revert r826429, the work at https://issues.apache.org/jira/browse/OFBIZ-2938 was not good enough to be committed. Notably issues with data model changes as noticed by Scott.
See http://markmail.org/thread/vzcj3oaevvxyvek7 for more

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@826964 13f79535-47bb-0310-9956-ffa450edef68
2009-10-20 05:56:47 +00:00
Jacques Le Roux c28b2bf0ca A patch from Pradeep Ruhil "HR Leave Enhancement " (https://issues.apache.org/jira/browse/OFBIZ-2938) - OFBIZ-2938
In this patch we are doing enhancement in HumanResource Leave Module. Initially we can only create new leave application for a partyId. But there was not functionality available for approval of leave. So in this patch we have given functionality for Leave approval as well as leave creation. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@826429 13f79535-47bb-0310-9956-ffa450edef68
2009-10-18 13:15:59 +00:00
Scott Gray 12566c26b9 Wherever possible changed ELI queries to limit the result set to the actual rows required of the query, should improve time
and memory performance if a cursor isn't being used on large result sets quite a bit.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@808820 13f79535-47bb-0310-9956-ffa450edef68
2009-08-28 08:58:10 +00:00
Hans Bakker 8ee21f614a commited patch of OFBIZ-2531 with minor changes, however added initial help screens, initial commit need some more work on the permissions for admin and employee
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@802308 13f79535-47bb-0310-9956-ffa450edef68
2009-08-08 07:20:30 +00:00
Vikas Mayur 02150938b0 Fixed: Relation Enumeration of entity JobRequisition is not unique for that entity, reported by Hans on dev mailing list.
Also changed entity field names as per best practice and fixed wrong attribute names on services found by chance in the logs.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@778587 13f79535-47bb-0310-9956-ffa450edef68
2009-05-26 07:15:43 +00:00
Ashish Vijaywargiya 82e1b52445 Applied patch from jira issue OFBIZ-2205 (Implemented recruitment in HR module).
I am committing the recently uploaded patch.
As it looks lot better from the initial one.

It may happen that I have missed some small things(It was around 5th or 7th review from my side) ... although those can be handled as reported in future.

At the end thanks to Abhinav Vaid for his contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@776961 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 06:02:38 +00:00
Jacques Le Roux 999bd7c577 Fix following Chris Howe's message in dev ML
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@764195 13f79535-47bb-0310-9956-ffa450edef68
2009-04-11 13:00:24 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Marco Risaliti 244eea12bb A lot of hardcoded labels cleaning and changes some wrong references
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@752268 13f79535-47bb-0310-9956-ffa450edef68
2009-03-10 21:16:58 +00:00
Marco Risaliti 8a3e5a7f52 A lot of hardcoded labels cleaning and changes some wrong references into humanres and marketing components
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@744509 13f79535-47bb-0310-9956-ffa450edef68
2009-02-14 15:54:35 +00:00
Marco Risaliti eeb2b0c785 Artifact cleaning on humanres component after recent changes on xsd files (OFBIZ-2137)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@738249 13f79535-47bb-0310-9956-ffa450edef68
2009-01-27 21:25:52 +00:00
Jacques Le Roux 66ffa47fd6 This does not hurt and help
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@732677 13f79535-47bb-0310-9956-ffa450edef68
2009-01-08 10:36:01 +00:00
Ashish Vijaywargiya 4e1f4e636e Applied patch from JIRA issue OFBIZ-1659.
Following things are covered in this patch :-

Included LookUps at the required places and done improvements.
Added Employee Leave tab,Create Entity EmplLeave and crud operations by Parimal.

Thanks Harsha Chadhar and Parimal Gain for your work.




git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@661359 13f79535-47bb-0310-9956-ffa450edef68
2008-05-29 15:30:53 +00:00
Vikas Mayur 061d746e70 A bunch of clean ups in HR module - still more to go ... Patch from Harsha Chadhar
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@655072 13f79535-47bb-0310-9956-ffa450edef68
2008-05-10 12:48:22 +00:00
Marco Risaliti 1957932f96 Lookup forms (ftl/widgets screen) has now the same look and feel (Part of issue OFBIZ-1595)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@615338 13f79535-47bb-0310-9956-ffa450edef68
2008-01-25 20:54:43 +00:00
Marco Risaliti c881b9f056 All the human resources forms (ftl/widgets screen) has now the same look and feel (Part of issue OFBIZ-1595)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@615322 13f79535-47bb-0310-9956-ffa450edef68
2008-01-25 20:12:10 +00:00
Anil Patel 61f40b4456 Patch from Abhijit with some improvements. Feeback from community will help in improvements.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@543391 13f79535-47bb-0310-9956-ffa450edef68
2007-06-01 05:02:45 +00:00