Commit Graph
29 Commits
Author SHA1 Message Date
Akash Jain da0f52d005 Improved: Status ID checkbox for FindEmploymentApps, FindPartyQuals and FindEmplLeaves forms (OFBIZ-11937) 2020-08-04 15:41:53 +05:30
Aditya Sharma 1451943617 Fixed: Broken page renders while click on Submit button
(OFBIZ-7535)
Submit button on ListEmploymentApps form has no check to hide when no record in List due to which button always appears and shows broken screen when submitting empty list.
Thanks Ankush Upadhyay for reporting the issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1841662 13f79535-47bb-0310-9956-ffa450edef68
2018-09-22 08:44:42 +00:00
Divesh Dutta 738a12bec1 Improvement: Miniland code readability and consistency improvements
(OFBIZ-8744) (OFBIZ-8745) (OFBIZ-8746) (OFBIZ-8748) (OFBIZ-8829) (OFBIZ-8830) (OFBIZ-8907) (OFBIZ-8908) (OFBIZ-8924) (OFBIZ-8925) 

Thanks: Ankush Upadhyay , Sega patidar , Abhijeet Ashapure for your patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768219 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:14:04 +00:00
Divesh Dutta ef0805ffb0 Improved:Convert search criteria on status into multi select pattern for project and HR component.
(OFBIZ-7549) (OFBIZ-7550)

Added Check box for status fields on Find Qualifications, Find Employment Applications, Find Leave in HR and in Find Tasks, Find TimeSheet in Project components.

Thanks: Mohammad Kathawala for the patch and Swapnil Shah for reporting the issues. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761186 13f79535-47bb-0310-9956-ffa450edef68
2016-09-17 10:45:46 +00:00
Jacques Le Roux c8ba932772 Fixes a "typo" in last commit for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
We used targetNamespace (should only be used in schema) instead of xsi:schemaLocation



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749634 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 05:58:26 +00:00
Jacques Le Roux 89212904bd Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
This is the 2nd step: puts back the original names, so it will be transparent for remaining references in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749489 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:37:47 +00:00
Jacques Le Roux 4931db1ed9 Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061 by replacing xsd files references in xml files by -ns.xsd files and removing the concerned xsd files
This is a 1st step, in a 2nd I will put back the original names, so it will be transparent for remaining reference in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749488 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:14:16 +00:00
Jacques Le Roux 901b1a4a06 Removes tooltip="${uiLabelMap.CommonRequired}" from fields, https://issues.apache.org/jira/browse/OFBIZ-6691
Instead of a quiet S/R action, this was an unexpected pain in the ass. A considerable number of forms:
    EmployeeForms.xml
    EmploymentForms.xml
    EmplPositionForms.xml
    GlobalHRSettingForms.xml
    RecruitmentForms.xml
    QuoteForms.xml
    PartyForms.xml
    StoreForms.xml
    ContactForms.xml
    FixedAssetForms.xml
    TaskForms.xml
    scrumForms.xml
    TaskForms.xml
contained a large number of fields with 
  tooltip="${uiLabelMap.CommonRequired}"
but no 
  required-field="true"


Of course display and display-entity should not be concerned, I spotted a number of them in the lot.

I also removed a bunch of harcoded * at end of labels (those followed by required-field="true"* and spotted a number of others }*"  who still need to be carefully reviewed to see if required=true is not missing there :/

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1709882 13f79535-47bb-0310-9956-ffa450edef68
2015-10-21 16:57:25 +00:00
Jacques Le Roux 7dc24b6902 A slightly modified patch from Taher Alkhateeb for <<replace widget-style="required" with required-field="true">> https://issues.apache.org/jira/browse/OFBIZ-6690
jleroux: after a cursory review, I simply did the chunk related to exampleName by hand, it needed more work. I also removed some trailing blanks.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1709872 13f79535-47bb-0310-9956-ffa450edef68
2015-10-21 16:00:02 +00:00
Nicolas Malin 895c9856b3 Cleaning forms code is needed after setting default-value in list-options and entity-options, patch related to OFBIZ-6524 and follows the resolution of OFBIZ-6490 and OFBIZ-6489. Thanks Gil Portenseigne for this effort
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1686674 13f79535-47bb-0310-9956-ffa450edef68
2015-06-20 21:58:05 +00:00
Christian Carlow 0fa16d6e3c JIRA OFBIZ-6387.patch
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1680155 13f79535-47bb-0310-9956-ffa450edef68
2015-05-19 03:15:43 +00:00
Jacques Le Roux 4a5346b230 A patch from Bob Morley "Creating New Employment Application (non secure)" https://issues.apache.org/jira/browse/OFBIZ-2894 - OFBIZ-2894
Removes the query string parms from the form action. The applicationId was already in the form but the partyId had to be added.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@933157 13f79535-47bb-0310-9956-ffa450edef68
2010-04-12 09:14:27 +00:00
Ashish Vijaywargiya 88a092d2f9 Applied patch from jira issue OFBIZ-3320 - improvement in Find screen.
Fix title of buttons to Find, for all the find screens to maintain consistency. 

Thanks Chandan for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@889084 13f79535-47bb-0310-9956-ffa450edef68
2009-12-10 04:29:19 +00:00
Jacques Le Roux b7a941d4f6 Revert r813307 on Adrian's request
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@813893 13f79535-47bb-0310-9956-ffa450edef68
2009-09-11 16:02:01 +00:00
Jacques Le Roux a7430a2fc2 A modified patch from Erwan de FERRIERES '"Automatic" sortable table headers" (https://issues.apache.org/jira/browse/OFBIZ-2921) - OFBIZ-2921
I was planning to wait longer, but I can't wait more. I have added a lot of small trivial changes in this patch and they are blocking me to go further on other issues...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@813307 13f79535-47bb-0310-9956-ffa450edef68
2009-09-10 08:41:19 +00:00
Scott Gray 12566c26b9 Wherever possible changed ELI queries to limit the result set to the actual rows required of the query, should improve time
and memory performance if a cursor isn't being used on large result sets quite a bit.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@808820 13f79535-47bb-0310-9956-ffa450edef68
2009-08-28 08:58:10 +00:00
Ashish Vijaywargiya 82e1b52445 Applied patch from jira issue OFBIZ-2205 (Implemented recruitment in HR module).
I am committing the recently uploaded patch.
As it looks lot better from the initial one.

It may happen that I have missed some small things(It was around 5th or 7th review from my side) ... although those can be handled as reported in future.

At the end thanks to Abhinav Vaid for his contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@776961 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 06:02:38 +00:00
Jacques Le Roux 999bd7c577 Fix following Chris Howe's message in dev ML
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@764195 13f79535-47bb-0310-9956-ffa450edef68
2009-04-11 13:00:24 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Jacques Le Roux 76f5ca6638 Secure URLs, we don't need to duplicate in from-field when param-name is the same
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@762215 13f79535-47bb-0310-9956-ffa450edef68
2009-04-06 06:25:24 +00:00
Jacques Le Roux 04eb726169 I think there were typos (&amp;&amp;) in
<hyperlink target="deleteEmploymentApp?applicationId=${applicationId}&amp;&amp;partyId=${partyId}&amp;&amp;referredByPartyId=${referredByPartyId}" description="${uiLabelMap.CommonDelete}" also-hidden="true"/>

else please explain me...



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759499 13f79535-47bb-0310-9956-ffa450edef68
2009-03-28 16:22:09 +00:00
Jacques Le Roux 10a5ee651a Replace tabs by 4 spaces in previous commit. I used 4 spaces instead of 2 because this was already used in this files
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759496 13f79535-47bb-0310-9956-ffa450edef68
2009-03-28 16:16:29 +00:00
Jacques Le Roux a30c0c9f3e 8th set of changes explained in https://issues.apache.org/jira/browse/OFBIZ-2243
In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759495 13f79535-47bb-0310-9956-ffa450edef68
2009-03-28 16:14:58 +00:00
Marco Risaliti eeb2b0c785 Artifact cleaning on humanres component after recent changes on xsd files (OFBIZ-2137)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@738249 13f79535-47bb-0310-9956-ffa450edef68
2009-01-27 21:25:52 +00:00
Jacques Le Roux 66ffa47fd6 This does not hurt and help
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@732677 13f79535-47bb-0310-9956-ffa450edef68
2009-01-08 10:36:01 +00:00
Jacques Le Roux 977174968a Fix a typo reported by Valentina Sirkova <vsirkova@iguanait.com> in user ML
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@663756 13f79535-47bb-0310-9956-ffa450edef68
2008-06-05 22:02:08 +00:00
Ashish Vijaywargiya dcaeb77523 Applied patch from JIRA issue OFBIZ-1659.
Few more improvements are included in this patch.
There were navigation problems in the tab's inside Employee header item.

Thanks Primal Gain for your patch.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@662162 13f79535-47bb-0310-9956-ffa450edef68
2008-06-01 07:46:13 +00:00
Ashish Vijaywargiya 4e1f4e636e Applied patch from JIRA issue OFBIZ-1659.
Following things are covered in this patch :-

Included LookUps at the required places and done improvements.
Added Employee Leave tab,Create Entity EmplLeave and crud operations by Parimal.

Thanks Harsha Chadhar and Parimal Gain for your work.




git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@661359 13f79535-47bb-0310-9956-ffa450edef68
2008-05-29 15:30:53 +00:00
Ashish Vijaywargiya 16a12b6140 Applied patch from JIRA issue OFBIZ-1659.
Following things are covered in this work :-

Restructured and organized the Screenc and Forms in the HR component.
Improved and Updated the naming conventions in the naming of Screens,Forms and requests. 

Thanks Harsha Chadhar for this work.
It was really very important for us to Manage the files before the component is used Extensively with other components.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@660980 13f79535-47bb-0310-9956-ffa450edef68
2008-05-28 15:25:38 +00:00