Commit Graph
58 Commits
Author SHA1 Message Date
Jacques Le Roux ec2b84341e Reverted: "Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)"
This reverts commit 17eb2e4cf7.

It does not work when using <<target="javascript:........>>
I could change those cases but it's easier and safer to simply revert back to
target-type!

Thanks: James for report
2020-12-18 11:08:32 +01:00
Jacques Le Roux 17eb2e4cf7 Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)
Same for sub-hyperlink
2020-12-11 16:52:04 +01:00
Aditya Sharma 1965e3a39a Improved: Activate / Finish EmplPositionType ValidResponsibilities
(OFBIZ-11045)
Most of code / form / screen already exist to manage EmpPositionType, except

1. menu item
2. screen menu fields
Fixed  wrong entity name in the entityCondition prepared in ListValidResponsibilities form

Thanks Olivier Heintz for reporting and providing the patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868911 13f79535-47bb-0310-9956-ffa450edef68
2019-10-25 08:51:03 +00:00
Paul Foxworthy 5fd7402240 Fixed: Find Employee Position does not allow "don't care" for boolean fields (OFBIZ-10158)
In the demo app, go to https://demo-stable.ofbiz.apache.org/humanres/control/FindEmplPositions, click on New Employee Position, and toggle one of the four flags, e.g. set Temporary Flag to N.

Now on the Find screen, there is no way to find all employee positions: it insists on a Yes or No for the flags. This patch allows a blank "don't care" option.

Thanks: Larissa Zanoni at Blockfreight for discovering this issue.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820949 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 06:50:17 +00:00
Deepak Dixit d09255c0b7 Reverted: Minilang code readability and consistency improvements done at r#1768222, this commit reversed key and description of drop-down in the code.
(OFBIZ-9114)

Thanks  Wei Zhang for reporting the issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772880 13f79535-47bb-0310-9956-ffa450edef68
2016-12-06 12:37:42 +00:00
Divesh Dutta 70eb7ff508 Improvement: Minilang code readability and consistency improvements.
(OFBIZ-8929) (OFBIZ-8930) (OFBIZ-8953) (OFBIZ-8965) (OFBIZ-8972) (OFBIZ-8986) (OFBIZ-8991) 

Thanks: Ankush Upadhyay, Anuj Jain, Abhijeet for your patches. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768222 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:34:00 +00:00
Divesh Dutta 738a12bec1 Improvement: Miniland code readability and consistency improvements
(OFBIZ-8744) (OFBIZ-8745) (OFBIZ-8746) (OFBIZ-8748) (OFBIZ-8829) (OFBIZ-8830) (OFBIZ-8907) (OFBIZ-8908) (OFBIZ-8924) (OFBIZ-8925) 

Thanks: Ankush Upadhyay , Sega patidar , Abhijeet Ashapure for your patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768219 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:14:04 +00:00
Pranay Pandey 769aa89ea8 Improved: HR List forms column alignment.
(OFBIZ-8456)

Thanks: Aditi Patidar for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765047 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 12:35:27 +00:00
Divesh Dutta 556279917d Improved:Display from date with default to now timestamp and also add asterisk sign to all the forms where it is part of primary key in all the components.
(OFBIZ-7650) (OFBIZ-7651) (OFBIZ-7653) (OFBIZ-7660) (OFBIZ-7662) (OFBIZ-7665) (OFBIZ-7666) (OFBIZ-8028)(OFBIZ-8029) (OFBIZ-8255)

Thanks: Anuj Jain and Ratnesh for the pathes and Swapnil Shah for reporting the issues.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761192 13f79535-47bb-0310-9956-ffa450edef68
2016-09-17 11:02:39 +00:00
Jacques Le Roux c8ba932772 Fixes a "typo" in last commit for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
We used targetNamespace (should only be used in schema) instead of xsi:schemaLocation



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749634 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 05:58:26 +00:00
Jacques Le Roux 89212904bd Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
This is the 2nd step: puts back the original names, so it will be transparent for remaining references in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749489 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:37:47 +00:00
Jacques Le Roux 4931db1ed9 Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061 by replacing xsd files references in xml files by -ns.xsd files and removing the concerned xsd files
This is a 1st step, in a 2nd I will put back the original names, so it will be transparent for remaining reference in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749488 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:14:16 +00:00
Nicolas Malin ce97afbf6b patch from Pierre Smits : Remove tooltip CommonNotModifRecreat from display fields (OFBIZ-6696), thanks for the screen clean Pierre
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1718970 13f79535-47bb-0310-9956-ffa450edef68
2015-12-09 21:24:44 +00:00
Jacques Le Roux 901b1a4a06 Removes tooltip="${uiLabelMap.CommonRequired}" from fields, https://issues.apache.org/jira/browse/OFBIZ-6691
Instead of a quiet S/R action, this was an unexpected pain in the ass. A considerable number of forms:
    EmployeeForms.xml
    EmploymentForms.xml
    EmplPositionForms.xml
    GlobalHRSettingForms.xml
    RecruitmentForms.xml
    QuoteForms.xml
    PartyForms.xml
    StoreForms.xml
    ContactForms.xml
    FixedAssetForms.xml
    TaskForms.xml
    scrumForms.xml
    TaskForms.xml
contained a large number of fields with 
  tooltip="${uiLabelMap.CommonRequired}"
but no 
  required-field="true"


Of course display and display-entity should not be concerned, I spotted a number of them in the lot.

I also removed a bunch of harcoded * at end of labels (those followed by required-field="true"* and spotted a number of others }*"  who still need to be carefully reviewed to see if required=true is not missing there :/

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1709882 13f79535-47bb-0310-9956-ffa450edef68
2015-10-21 16:57:25 +00:00
Nicolas Malin 895c9856b3 Cleaning forms code is needed after setting default-value in list-options and entity-options, patch related to OFBIZ-6524 and follows the resolution of OFBIZ-6490 and OFBIZ-6489. Thanks Gil Portenseigne for this effort
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1686674 13f79535-47bb-0310-9956-ffa450edef68
2015-06-20 21:58:05 +00:00
Jacques Le Roux 3ec515d897 A patch from Pierre Smits for "ListEmplPositionFulfillments links to wrong profile of employee" at https://issues.apache.org/jira/browse/OFBIZ-5708
Instead it should link to EmployeeProfile of the employee.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1617229 13f79535-47bb-0310-9956-ffa450edef68
2014-08-11 09:10:42 +00:00
Jacques Le Roux 8dd57be3c5 A patch from Christian Carlow for "ListReportedToEmplPositionReportingStructs displays no results" https://issues.apache.org/jira/browse/OFBIZ-5512
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1561311 13f79535-47bb-0310-9956-ffa450edef68
2014-01-25 13:49:33 +00:00
Jacques Le Roux c8df0c3e06 A (slightly enhanced) patch from Christian Carlow for "EditEmplPosition form widget missing Internal Org drop down and title incorrect" https://issues.apache.org/jira/browse/OFBIZ-5509
EditEmplPosition shows a partyId field as a text box instead of a <select> drop down that lists the internal orgs.  The field title should also be set to Internal Org instead of PartyId for consistency.

jleroux: while at it I added a tooltip


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1561286 13f79535-47bb-0310-9956-ffa450edef68
2014-01-25 11:58:09 +00:00
Jacques Le Roux 720578ecf3 Replaces all remaining title="${uiLabelMap.CommonEmptyHeader}" by title=" ", and specific case in ListPartyCommEvents
This closes the CommonEmptyHeader chapter

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343016 13f79535-47bb-0310-9956-ffa450edef68
2012-05-27 08:41:47 +00:00
Hans Bakker fa99376e69 only show employ positions in the HR tree which are active: status and from/thru dates
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1189692 13f79535-47bb-0310-9956-ffa450edef68
2011-10-27 09:46:18 +00:00
Hans Bakker 12575d54fe be able to move a position to another department/organization
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1179073 13f79535-47bb-0310-9956-ffa450edef68
2011-10-05 07:28:25 +00:00
Hans Bakker 68cccecf08 remove duplicated screens, now the tree is pointing to the existing screens to add leaves
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1176710 13f79535-47bb-0310-9956-ffa450edef68
2011-09-28 04:05:25 +00:00
Hans Bakker c4d270c294 be able to change the HR tree with the right mouse button adding orginazations, positions and employees, contribution of kookai
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1167042 13f79535-47bb-0310-9956-ffa450edef68
2011-09-09 08:37:21 +00:00
Adam Heath ac2299c50e Fix a bunch of no final newline issues.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@965918 13f79535-47bb-0310-9956-ffa450edef68
2010-07-20 17:15:21 +00:00
Ashish Vijaywargiya 88a092d2f9 Applied patch from jira issue OFBIZ-3320 - improvement in Find screen.
Fix title of buttons to Find, for all the find screens to maintain consistency. 

Thanks Chandan for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@889084 13f79535-47bb-0310-9956-ffa450edef68
2009-12-10 04:29:19 +00:00
Jacques Le Roux b7a941d4f6 Revert r813307 on Adrian's request
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@813893 13f79535-47bb-0310-9956-ffa450edef68
2009-09-11 16:02:01 +00:00
Jacques Le Roux a7430a2fc2 A modified patch from Erwan de FERRIERES '"Automatic" sortable table headers" (https://issues.apache.org/jira/browse/OFBIZ-2921) - OFBIZ-2921
I was planning to wait longer, but I can't wait more. I have added a lot of small trivial changes in this patch and they are blocking me to go further on other issues...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@813307 13f79535-47bb-0310-9956-ffa450edef68
2009-09-10 08:41:19 +00:00
Scott Gray 12566c26b9 Wherever possible changed ELI queries to limit the result set to the actual rows required of the query, should improve time
and memory performance if a cursor isn't being used on large result sets quite a bit.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@808820 13f79535-47bb-0310-9956-ffa450edef68
2009-08-28 08:58:10 +00:00
Jacques Le Roux 999bd7c577 Fix following Chris Howe's message in dev ML
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@764195 13f79535-47bb-0310-9956-ffa450edef68
2009-04-11 13:00:24 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Jacques Le Roux 76f5ca6638 Secure URLs, we don't need to duplicate in from-field when param-name is the same
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@762215 13f79535-47bb-0310-9956-ffa450edef68
2009-04-06 06:25:24 +00:00
Jacques Le Roux 77a2ff1d9f 21th set of changes explained in https://issues.apache.org/jira/browse/OFBIZ-2243
In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements

We are near the end...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759684 13f79535-47bb-0310-9956-ffa450edef68
2009-03-29 14:02:55 +00:00
Jacques Le Roux 40f5281303 20th set of changes explained in https://issues.apache.org/jira/browse/OFBIZ-2243
In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759680 13f79535-47bb-0310-9956-ffa450edef68
2009-03-29 13:33:53 +00:00
Jacques Le Roux 8c6d89fe75 18th set of changes explained in https://issues.apache.org/jira/browse/OFBIZ-2243
In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements

This one is huge, with some changes by hand, conversion from tabs to 4 spaces and some trailing spaces (I have activated it AnyEdit plugin following the changes I made in http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions but I wonder if I should not reverse all that - I mean my plugin setting and in wiki -, it's a nightmare!)

I did my best on this one, but I'm not sure some typos did not slip in. Anyway, alea jacta est


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759666 13f79535-47bb-0310-9956-ffa450edef68
2009-03-29 11:00:00 +00:00
Jacques Le Roux 10a5ee651a Replace tabs by 4 spaces in previous commit. I used 4 spaces instead of 2 because this was already used in this files
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759496 13f79535-47bb-0310-9956-ffa450edef68
2009-03-28 16:16:29 +00:00
Jacques Le Roux a30c0c9f3e 8th set of changes explained in https://issues.apache.org/jira/browse/OFBIZ-2243
In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759495 13f79535-47bb-0310-9956-ffa450edef68
2009-03-28 16:14:58 +00:00
Jacques Le Roux a70fb8275b 5th set of changes explained in https://issues.apache.org/jira/browse/OFBIZ-2243
In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759475 13f79535-47bb-0310-9956-ffa450edef68
2009-03-28 14:54:29 +00:00
Marco Risaliti fd032fc098 A lot of hardcoded labels cleaning and changes some wrong references
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@746654 13f79535-47bb-0310-9956-ffa450edef68
2009-02-22 10:45:15 +00:00
Marco Risaliti 201290e8db A lot of hardcoded labels cleaning and changes some wrong references
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@746341 13f79535-47bb-0310-9956-ffa450edef68
2009-02-20 19:11:06 +00:00
Marco Risaliti 8a3e5a7f52 A lot of hardcoded labels cleaning and changes some wrong references into humanres and marketing components
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@744509 13f79535-47bb-0310-9956-ffa450edef68
2009-02-14 15:54:35 +00:00
Hans Bakker ec47bc0b00 make hyperlink from empl position to type move paygrades to settings
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@738484 13f79535-47bb-0310-9956-ffa450edef68
2009-01-28 13:43:45 +00:00
Hans Bakker 8febab931e list employee positions on the employee profile
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@738430 13f79535-47bb-0310-9956-ffa450edef68
2009-01-28 10:40:35 +00:00
Marco Risaliti eeb2b0c785 Artifact cleaning on humanres component after recent changes on xsd files (OFBIZ-2137)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@738249 13f79535-47bb-0310-9956-ffa450edef68
2009-01-27 21:25:52 +00:00
Jacques Le Roux 66ffa47fd6 This does not hurt and help
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@732677 13f79535-47bb-0310-9956-ffa450edef68
2009-01-08 10:36:01 +00:00
Marco Risaliti 9b949f0c45 Some cleanup on humanres component (Part of issue OFBIZ-1982)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@701763 13f79535-47bb-0310-9956-ffa450edef68
2008-10-05 09:19:33 +00:00
Ashish Vijaywargiya d4e47f16c3 Patch from JIRA issue # https://issues.apache.org/jira/browse/OFBIZ-1839.
Container to Screenlet conversion is done on Human Resource component.

Thanks Harsha Chadhar for your patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@667014 13f79535-47bb-0310-9956-ffa450edef68
2008-06-12 09:36:32 +00:00
Ashish Vijaywargiya 16a12b6140 Applied patch from JIRA issue OFBIZ-1659.
Following things are covered in this work :-

Restructured and organized the Screenc and Forms in the HR component.
Improved and Updated the naming conventions in the naming of Screens,Forms and requests. 

Thanks Harsha Chadhar for this work.
It was really very important for us to Manage the files before the component is used Extensively with other components.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@660980 13f79535-47bb-0310-9956-ffa450edef68
2008-05-28 15:25:38 +00:00
Ashish Vijaywargiya a171bbd51c Applied patch from JIRA issue :- https://issues.apache.org/jira/browse/OFBIZ-1659
In this patch following things are cleaned up :

1) Employee Position Summary Section introduced
2) Improved the usability of Pay Grade,Termination Reason,UnEmployment Claim & Employment Application.

Thanks Parimal Gain for your patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@657019 13f79535-47bb-0310-9956-ffa450edef68
2008-05-16 11:16:38 +00:00
Ashish Vijaywargiya e8e527cf77 More clean up on the JIRA Issue :- https://issues.apache.org/jira/browse/OFBIZ-1760
Following points are covered in this work :-


1) created Find form for EmplPosition
2) created List form
3) prepare data for EmplPositionType
4) simple clean-up 

Thanks Parimal Gain for your patch.
Now this section(Employee Position) looks good.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@656233 13f79535-47bb-0310-9956-ffa450edef68
2008-05-14 10:53:56 +00:00
Vikas Mayur 596586e8ce continuing cleanups in HR module - patch from Harsha Chadhar & Parimal Gain
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@655778 13f79535-47bb-0310-9956-ffa450edef68
2008-05-13 08:27:14 +00:00