This reverts commit 17eb2e4cf7.
It does not work when using <<target="javascript:........>>
I could change those cases but it's easier and safer to simply revert back to
target-type!
Thanks: James for report
(OFBIZ-11045)
Most of code / form / screen already exist to manage EmpPositionType, except
1. menu item
2. screen menu fields
Fixed wrong entity name in the entityCondition prepared in ListValidResponsibilities form
Thanks Olivier Heintz for reporting and providing the patch
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868911 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-7650) (OFBIZ-7651) (OFBIZ-7653) (OFBIZ-7660) (OFBIZ-7662) (OFBIZ-7665) (OFBIZ-7666) (OFBIZ-8028)(OFBIZ-8029) (OFBIZ-8255)
Thanks: Anuj Jain and Ratnesh for the pathes and Swapnil Shah for reporting the issues.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761192 13f79535-47bb-0310-9956-ffa450edef68
This is the 2nd step: puts back the original names, so it will be transparent for remaining references in xml catalogs, Java code, etc.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749489 13f79535-47bb-0310-9956-ffa450edef68
This is a 1st step, in a 2nd I will put back the original names, so it will be transparent for remaining reference in xml catalogs, Java code, etc.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749488 13f79535-47bb-0310-9956-ffa450edef68
Instead of a quiet S/R action, this was an unexpected pain in the ass. A considerable number of forms:
EmployeeForms.xml
EmploymentForms.xml
EmplPositionForms.xml
GlobalHRSettingForms.xml
RecruitmentForms.xml
QuoteForms.xml
PartyForms.xml
StoreForms.xml
ContactForms.xml
FixedAssetForms.xml
TaskForms.xml
scrumForms.xml
TaskForms.xml
contained a large number of fields with
tooltip="${uiLabelMap.CommonRequired}"
but no
required-field="true"
Of course display and display-entity should not be concerned, I spotted a number of them in the lot.
I also removed a bunch of harcoded * at end of labels (those followed by required-field="true"* and spotted a number of others }*" who still need to be carefully reviewed to see if required=true is not missing there :/
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1709882 13f79535-47bb-0310-9956-ffa450edef68
EditEmplPosition shows a partyId field as a text box instead of a <select> drop down that lists the internal orgs. The field title should also be set to Internal Org instead of PartyId for consistency.
jleroux: while at it I added a tooltip
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1561286 13f79535-47bb-0310-9956-ffa450edef68
Fix title of buttons to Find, for all the find screens to maintain consistency.
Thanks Chandan for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@889084 13f79535-47bb-0310-9956-ffa450edef68
I was planning to wait longer, but I can't wait more. I have added a lot of small trivial changes in this patch and they are blocking me to go further on other issues...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@813307 13f79535-47bb-0310-9956-ffa450edef68
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)
Of course this effort to remove trailing spaces has no functional implications.
Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {
So these changes are also in this commit, should not be a problem anyway.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements
We are near the end...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759684 13f79535-47bb-0310-9956-ffa450edef68
In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements
This one is huge, with some changes by hand, conversion from tabs to 4 spaces and some trailing spaces (I have activated it AnyEdit plugin following the changes I made in http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions but I wonder if I should not reverse all that - I mean my plugin setting and in wiki -, it's a nightmare!)
I did my best on this one, but I'm not sure some typos did not slip in. Anyway, alea jacta est
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759666 13f79535-47bb-0310-9956-ffa450edef68
Container to Screenlet conversion is done on Human Resource component.
Thanks Harsha Chadhar for your patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@667014 13f79535-47bb-0310-9956-ffa450edef68
Following things are covered in this work :-
Restructured and organized the Screenc and Forms in the HR component.
Improved and Updated the naming conventions in the naming of Screens,Forms and requests.
Thanks Harsha Chadhar for this work.
It was really very important for us to Manage the files before the component is used Extensively with other components.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@660980 13f79535-47bb-0310-9956-ffa450edef68
In this patch following things are cleaned up :
1) Employee Position Summary Section introduced
2) Improved the usability of Pay Grade,Termination Reason,UnEmployment Claim & Employment Application.
Thanks Parimal Gain for your patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@657019 13f79535-47bb-0310-9956-ffa450edef68
Following points are covered in this work :-
1) created Find form for EmplPosition
2) created List form
3) prepare data for EmplPositionType
4) simple clean-up
Thanks Parimal Gain for your patch.
Now this section(Employee Position) looks good.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@656233 13f79535-47bb-0310-9956-ffa450edef68