Commit Graph
43 Commits
Author SHA1 Message Date
Jacques Le Roux ec2b84341e Reverted: "Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)"
This reverts commit 17eb2e4cf7.

It does not work when using <<target="javascript:........>>
I could change those cases but it's easier and safer to simply revert back to
target-type!

Thanks: James for report
2020-12-18 11:08:32 +01:00
Jacques Le Roux 17eb2e4cf7 Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)
Same for sub-hyperlink
2020-12-11 16:52:04 +01:00
Akash Jain da0f52d005 Improved: Status ID checkbox for FindEmploymentApps, FindPartyQuals and FindEmplLeaves forms (OFBIZ-11937) 2020-08-04 15:41:53 +05:30
Divesh Dutta 738a12bec1 Improvement: Miniland code readability and consistency improvements
(OFBIZ-8744) (OFBIZ-8745) (OFBIZ-8746) (OFBIZ-8748) (OFBIZ-8829) (OFBIZ-8830) (OFBIZ-8907) (OFBIZ-8908) (OFBIZ-8924) (OFBIZ-8925) 

Thanks: Ankush Upadhyay , Sega patidar , Abhijeet Ashapure for your patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768219 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:14:04 +00:00
Divesh Dutta 556279917d Improved:Display from date with default to now timestamp and also add asterisk sign to all the forms where it is part of primary key in all the components.
(OFBIZ-7650) (OFBIZ-7651) (OFBIZ-7653) (OFBIZ-7660) (OFBIZ-7662) (OFBIZ-7665) (OFBIZ-7666) (OFBIZ-8028)(OFBIZ-8029) (OFBIZ-8255)

Thanks: Anuj Jain and Ratnesh for the pathes and Swapnil Shah for reporting the issues.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761192 13f79535-47bb-0310-9956-ffa450edef68
2016-09-17 11:02:39 +00:00
Divesh Dutta ef0805ffb0 Improved:Convert search criteria on status into multi select pattern for project and HR component.
(OFBIZ-7549) (OFBIZ-7550)

Added Check box for status fields on Find Qualifications, Find Employment Applications, Find Leave in HR and in Find Tasks, Find TimeSheet in Project components.

Thanks: Mohammad Kathawala for the patch and Swapnil Shah for reporting the issues. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761186 13f79535-47bb-0310-9956-ffa450edef68
2016-09-17 10:45:46 +00:00
Pranay Pandey 11508ce7d5 [OFBIZ-7604] Added lookup for approver party at leave approval find form. Thanks Amardeep Singh Jhajj for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750447 13f79535-47bb-0310-9956-ffa450edef68
2016-06-28 06:18:07 +00:00
Jacques Le Roux c8ba932772 Fixes a "typo" in last commit for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
We used targetNamespace (should only be used in schema) instead of xsi:schemaLocation



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749634 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 05:58:26 +00:00
Jacques Le Roux 89212904bd Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
This is the 2nd step: puts back the original names, so it will be transparent for remaining references in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749489 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:37:47 +00:00
Jacques Le Roux 4931db1ed9 Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061 by replacing xsd files references in xml files by -ns.xsd files and removing the concerned xsd files
This is a 1st step, in a 2nd I will put back the original names, so it will be transparent for remaining reference in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749488 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:14:16 +00:00
Jacques Le Roux 901b1a4a06 Removes tooltip="${uiLabelMap.CommonRequired}" from fields, https://issues.apache.org/jira/browse/OFBIZ-6691
Instead of a quiet S/R action, this was an unexpected pain in the ass. A considerable number of forms:
    EmployeeForms.xml
    EmploymentForms.xml
    EmplPositionForms.xml
    GlobalHRSettingForms.xml
    RecruitmentForms.xml
    QuoteForms.xml
    PartyForms.xml
    StoreForms.xml
    ContactForms.xml
    FixedAssetForms.xml
    TaskForms.xml
    scrumForms.xml
    TaskForms.xml
contained a large number of fields with 
  tooltip="${uiLabelMap.CommonRequired}"
but no 
  required-field="true"


Of course display and display-entity should not be concerned, I spotted a number of them in the lot.

I also removed a bunch of harcoded * at end of labels (those followed by required-field="true"* and spotted a number of others }*"  who still need to be carefully reviewed to see if required=true is not missing there :/

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1709882 13f79535-47bb-0310-9956-ffa450edef68
2015-10-21 16:57:25 +00:00
Nicolas Malin 895c9856b3 Cleaning forms code is needed after setting default-value in list-options and entity-options, patch related to OFBIZ-6524 and follows the resolution of OFBIZ-6490 and OFBIZ-6489. Thanks Gil Portenseigne for this effort
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1686674 13f79535-47bb-0310-9956-ffa450edef68
2015-06-20 21:58:05 +00:00
Jacques Le Roux 4d9e447e11 Adds the conventional comment <!-- if this isn't there then with all fields empty no query will be done --> to "noConditionFind" fields. It's not quite obvious, so the more there are the better
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1576278 13f79535-47bb-0310-9956-ffa450edef68
2014-03-11 10:53:37 +00:00
Jacques Le Roux 5192aeea13 A patch from Tom Burns "Error is comming in HR's recruitment Tab " https://issues.apache.org/jira/browse/OFBIZ-5056
I am getting an error(null Pointer Exception) in HR module when i am testing some functionallities.
I followed some steps in my testing.
Step 1:-Cleck on Recruitment tab and also click on "New job Requisition".Fill the data and create the record.
Steps 2:-click on sub tap "Internal Job Posting" and then click on "New internal Job Posting" Button on find Internal job posting page. Create the record from require data
Step3:-Again click "Internal Job Posting" sub tab. and find the created Internal Job Posting record.
You find operastion give the Error Massage
:ERROR MESSAGE:
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen component://common/widget/CommonScreens.xml#FindScreenDecorator: java.lang.NullPointerException (null)
You also check Job Interview and Approve sub tab
I have sent this mail to jacopo Le but Issue is not resolve till date
Please solve this issuse. I Am waiting for ur responce APAS
Thanks
Dhiraj Gupta



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1400393 13f79535-47bb-0310-9956-ffa450edef68
2012-10-20 08:59:40 +00:00
Erwan de Ferrieres 9fb25ce2ac Entitylabels for EmplLeaveReasonType
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1232509 13f79535-47bb-0310-9956-ffa450edef68
2012-01-17 17:57:31 +00:00
Erwan de Ferrieres d0e308b918 Reformating, just tabulations not right
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1232379 13f79535-47bb-0310-9956-ffa450edef68
2012-01-17 10:22:23 +00:00
Erwan de Ferrieres f968df3a27 Creating entityLabels in humanres component, and adding some for EmplLeaveType
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1232373 13f79535-47bb-0310-9956-ffa450edef68
2012-01-17 09:55:47 +00:00
Erwan de Ferrieres 9b03a5022b Improvements on the EmplLeave entity. Adding entityLabels for the leaveStatus field
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1232158 13f79535-47bb-0310-9956-ffa450edef68
2012-01-16 20:51:18 +00:00
Adam Heath ac2299c50e Fix a bunch of no final newline issues.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@965918 13f79535-47bb-0310-9956-ffa450edef68
2010-07-20 17:15:21 +00:00
Erwan de Ferrieres 522b06d9e8 Corrected a NPE error in ListLeaveApprovals
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@915271 13f79535-47bb-0310-9956-ffa450edef68
2010-02-23 10:30:52 +00:00
Erwan de Ferrieres 9a060b67d1 Removed some trailing spaces
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@915270 13f79535-47bb-0310-9956-ffa450edef68
2010-02-23 10:29:19 +00:00
Erwan de Ferrieres 4f99c06d02 Timestamps in EditEmplLeave were creating strange records in the database, so I change them to date
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@915263 13f79535-47bb-0310-9956-ffa450edef68
2010-02-23 09:57:07 +00:00
Erwan de Ferrieres 35457c1801 Corrected OFBIZ-3488 NPE in humanres when searching for leaves (https://issues.apache.org/jira/browse/OFBIZ-3488)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@915045 13f79535-47bb-0310-9956-ffa450edef68
2010-02-22 20:12:54 +00:00
Erwan de Ferrieres 6e3478bca9 Remove some hardcoded labels
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@911785 13f79535-47bb-0310-9956-ffa450edef68
2010-02-19 11:08:35 +00:00
Erwan de Ferrieres 4dcd8b03af Updates on menus and uilabels in the leave management screens (HumanRes)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@901119 13f79535-47bb-0310-9956-ffa450edef68
2010-01-20 10:08:45 +00:00
Marco Risaliti e91b2aff57 Convert some tabs to 4 spaces
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@890985 13f79535-47bb-0310-9956-ffa450edef68
2009-12-15 20:58:21 +00:00
Ashish Vijaywargiya 88a092d2f9 Applied patch from jira issue OFBIZ-3320 - improvement in Find screen.
Fix title of buttons to Find, for all the find screens to maintain consistency. 

Thanks Chandan for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@889084 13f79535-47bb-0310-9956-ffa450edef68
2009-12-10 04:29:19 +00:00
Jacques Le Roux ef2c935618 A patch from Pradeep Ruhil "HR Leave Enhancement ." (https://issues.apache.org/jira/browse/OFBIZ-2938) - OFBIZ-2938
In this patch we are doing enhancement in HumanResource Leave Module. 
Initially we can only create new leave application for a partyId. 
But there was not functionality available for approval of leave. 
So in this patch we have given functionality for Leave approval as well as leave creation. 
+ A better French label


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@831249 13f79535-47bb-0310-9956-ffa450edef68
2009-10-30 10:07:09 +00:00
Jacques Le Roux 835ab9c7c1 Revert r826429, the work at https://issues.apache.org/jira/browse/OFBIZ-2938 was not good enough to be committed. Notably issues with data model changes as noticed by Scott.
See http://markmail.org/thread/vzcj3oaevvxyvek7 for more

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@826964 13f79535-47bb-0310-9956-ffa450edef68
2009-10-20 05:56:47 +00:00
Jacques Le Roux c28b2bf0ca A patch from Pradeep Ruhil "HR Leave Enhancement " (https://issues.apache.org/jira/browse/OFBIZ-2938) - OFBIZ-2938
In this patch we are doing enhancement in HumanResource Leave Module. Initially we can only create new leave application for a partyId. But there was not functionality available for approval of leave. So in this patch we have given functionality for Leave approval as well as leave creation. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@826429 13f79535-47bb-0310-9956-ffa450edef68
2009-10-18 13:15:59 +00:00
Jacques Le Roux b7a941d4f6 Revert r813307 on Adrian's request
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@813893 13f79535-47bb-0310-9956-ffa450edef68
2009-09-11 16:02:01 +00:00
Jacques Le Roux a7430a2fc2 A modified patch from Erwan de FERRIERES '"Automatic" sortable table headers" (https://issues.apache.org/jira/browse/OFBIZ-2921) - OFBIZ-2921
I was planning to wait longer, but I can't wait more. I have added a lot of small trivial changes in this patch and they are blocking me to go further on other issues...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@813307 13f79535-47bb-0310-9956-ffa450edef68
2009-09-10 08:41:19 +00:00
Scott Gray 12566c26b9 Wherever possible changed ELI queries to limit the result set to the actual rows required of the query, should improve time
and memory performance if a cursor isn't being used on large result sets quite a bit.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@808820 13f79535-47bb-0310-9956-ffa450edef68
2009-08-28 08:58:10 +00:00
Jacques Le Roux 999bd7c577 Fix following Chris Howe's message in dev ML
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@764195 13f79535-47bb-0310-9956-ffa450edef68
2009-04-11 13:00:24 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Jacques Le Roux 76f5ca6638 Secure URLs, we don't need to duplicate in from-field when param-name is the same
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@762215 13f79535-47bb-0310-9956-ffa450edef68
2009-04-06 06:25:24 +00:00
Jacques Le Roux 8c6d89fe75 18th set of changes explained in https://issues.apache.org/jira/browse/OFBIZ-2243
In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements

This one is huge, with some changes by hand, conversion from tabs to 4 spaces and some trailing spaces (I have activated it AnyEdit plugin following the changes I made in http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions but I wonder if I should not reverse all that - I mean my plugin setting and in wiki -, it's a nightmare!)

I did my best on this one, but I'm not sure some typos did not slip in. Anyway, alea jacta est


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759666 13f79535-47bb-0310-9956-ffa450edef68
2009-03-29 11:00:00 +00:00
Marco Risaliti eeb2b0c785 Artifact cleaning on humanres component after recent changes on xsd files (OFBIZ-2137)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@738249 13f79535-47bb-0310-9956-ffa450edef68
2009-01-27 21:25:52 +00:00
Jacques Le Roux 66ffa47fd6 This does not hurt and help
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@732677 13f79535-47bb-0310-9956-ffa450edef68
2009-01-08 10:36:01 +00:00
Jacques Le Roux b7366559b7 Some adjustments in HumanRes UI (i18n)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@728529 13f79535-47bb-0310-9956-ffa450edef68
2008-12-21 22:16:35 +00:00
Ashish Vijaywargiya d4e47f16c3 Patch from JIRA issue # https://issues.apache.org/jira/browse/OFBIZ-1839.
Container to Screenlet conversion is done on Human Resource component.

Thanks Harsha Chadhar for your patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@667014 13f79535-47bb-0310-9956-ffa450edef68
2008-06-12 09:36:32 +00:00
Ashish Vijaywargiya dcaeb77523 Applied patch from JIRA issue OFBIZ-1659.
Few more improvements are included in this patch.
There were navigation problems in the tab's inside Employee header item.

Thanks Primal Gain for your patch.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@662162 13f79535-47bb-0310-9956-ffa450edef68
2008-06-01 07:46:13 +00:00
Ashish Vijaywargiya 4e1f4e636e Applied patch from JIRA issue OFBIZ-1659.
Following things are covered in this patch :-

Included LookUps at the required places and done improvements.
Added Employee Leave tab,Create Entity EmplLeave and crud operations by Parimal.

Thanks Harsha Chadhar and Parimal Gain for your work.




git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@661359 13f79535-47bb-0310-9956-ffa450edef68
2008-05-29 15:30:53 +00:00