Commit Graph
647 Commits
Author SHA1 Message Date
Jacques Le Roux a2dac5482c Improved: Default ordering of webapps titles in main menu (OFBIZ-12166)
[...] having more important apps in 1st places would be better [...]
the feature should be easily changed by custom projects [...]
documentation for that would be enough.

This 1st step sorts the applications and webtools. I believe webtools should not
be secondary but that needs to be discussed with other options.
2021-02-14 21:11:58 +01:00
Nicolas Malin 7165768251 Implemented: Add a framework method to get main webapp menu with the webapp name
(OFBIZ-10601)

To improve theme management and provide better tools for new themes, we implement a method to obtain the main menu of a webapp.
Instead of just managing a menu, we extend the functionality by offering a method to expose a summary of the webapp, to simplify the navigation.

For this we add a new attribute on webapp definition app-shortcut-screen :

    <webapp name="mywebapp"
            ...
            app-shortcut-screen="component://mycomponent/widget/CommonScreens.xml#ShortcutApp"
            ...
    />

The idea is to define a new purpose screen *Shortcut* that contains what defines a webapp when an action or navigation has been requested. With this screen you can load a menu, a search, a complex description and use all screen powerfulness to resolve what displaying and support by theming

    <screen name="ShortcutApp">
        <section>
            <actions>
                <property-map resource="CommonUiLabels" map-name="uiLabelMap" global="true"/>
            </actions>
            <widgets>
                <decorator-screen name="ShortcutDecorator" location="component://common/widget/CommonScreens.xml">
                    <decorator-section name="body">
                        <include-menu name="MyShortcutAppBar" location="component://mycomponent/widget/CommonMenus.xml"/>
                    </decorator-section>
                </decorator-screen>
            </widgets>
        </section>
    </screen>

Each component are self-sufficient to define what shortcuts to display without framework change or knowledge about other component.
Each theme can implement and customize the display rendering at will.

To illustrate an example of implementation we set sub menu for each webapp defined on applications and exploit it on bluelight theme.

Thanks for Dennis Balkir, Jacques Leroux, Leila Mekika and Julien Nicolas for their involvement
2021-01-15 08:56:23 +01:00
Jacques Le Roux ec2b84341e Reverted: "Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)"
This reverts commit 17eb2e4cf7.

It does not work when using <<target="javascript:........>>
I could change those cases but it's easier and safer to simply revert back to
target-type!

Thanks: James for report
2020-12-18 11:08:32 +01:00
Jacques Le Roux 17eb2e4cf7 Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)
Same for sub-hyperlink
2020-12-11 16:52:04 +01:00
holivier c2c1eae612 Documented: migrated Wiki Glossary to glossary asciidoc files (OFBIZ-12060)
- Accounting Glossary,
  - declare it as glossary
  - re-order existing items
  - add a comment at beginning about importance of order items
  - correction for some ID: change space to _
  - add some items coming from wiki glossary
- Facility
  - add glossary directly in facility.adoc
- Human Resource Glossary
  - re-order existing items
  - add a comment at beginning about importance of order items
  - move some items to Party Glossary or global Glossary
- HR appendix: add link to wiki OFBiz related book for Data Model Reference Book
- Add Party Glossary and included it in party.adoc
  - add some items coming from wiki glossary and HR glossary
- General Glossary
  - add a comment at beginning about importance of order items
  - add some items coming from wiki glossary and HR glossary
2020-11-18 17:19:39 +01:00
holivier 5e6f537708 Documented: HR Doc drive by process (OFBIZ-11026)
- Re-organize sub-chapter to have a process vision of HR component
- Add hr-data-model sub-chapter
- Add hr-appendix which list some bug or WIP development
2020-11-17 14:27:08 +01:00
holivier c21892609b Documented: Add a Global Glossary for user-documentation (OFBIZ-10303) 2020-11-14 17:12:14 +01:00
holivier 4a41f0fde5 Documented: migration to help system using asciidoc files (OFBIZ-11587)
commit correction for <Remove all related help docbook files>
* reAdd a contentDocData for main contentId and portletCategory
* remove from ofbiz-component of each application line about helpData which are removed
2020-10-27 11:20:09 +01:00
holivier 302bc0eb15 Documented: migration to help system using asciidoc files (OFBIZ-11587)
Remove all related help docbook files
2020-10-26 17:34:03 +01:00
Suraj Khurana b3fcbeedba Improved: Make data members of class as private and added accessor methods for the same, also corrected occurences of the same in applications component.
(OFBIZ-11963)
Also made some related checkstyle code enhancements. Thanks Jacques for review.
2020-09-12 12:09:03 +05:30
James Yong 1f9c300027 Improved: Move page-specific script links to html template (OFBIZ-11799)
Use importLibrary js function to load jstree and cookie js in ContentNav.ftl and CategoryTree.ftl.
Tested on
/content/control/navigateContent
/humanres/control/main
2020-08-22 21:11:20 +08:00
Akash Jain da0f52d005 Improved: Status ID checkbox for FindEmploymentApps, FindPartyQuals and FindEmplLeaves forms (OFBIZ-11937) 2020-08-04 15:41:53 +05:30
Suraj Khurana c6399ef668 Improved: Corrected some line is longer than 150 characters checkstyle issues in applications component. Also fixed some extra spaces and naming conventions related checkstyle issues.
(OFBIZ-11921)
2020-08-03 10:14:20 +05:30
Jacques Le Roux 2d7c533e34 Improved: Use Error.ftl everywhere it's not yet used (OFBIZ-11890)
Removes all error*.jsp reference, no longer used
2020-07-20 19:27:00 +02:00
Suraj Khurana 0524945bda Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in applications component.
(OFBIZ-11887)
2020-07-18 12:15:16 +05:30
holivier b36943d56f Documented: Check all docbook file in each applications-component
documents directory
(OFBIZ-11587)

remove all files
2020-07-14 16:55:05 +02:00
Suraj Khurana 2d01d722e6 Improved: Corrected all checkstyle formatting issues: Line has trailing spaces in applications component.
(OFBIZ-11880)
Thanks Jacques for review.
2020-07-13 14:15:34 +05:30
Suraj Khurana bdc8c73fd8 Improved: Corrected checkstyle formatting issues, 'is preceded/not preceded with whitespace' for applications component.
(OFBIZ-11874)
This fixes following checkstyle issues:
'{' is not preceded with whitespace.
'{' is not followed by whitespace.
'}' is not followed by whitespace.
'}' is not preceded with whitespace.
'typecast' is not followed by whitespace.
'try' is not followed by whitespace.
';' is preceded with whitespace.
2020-07-11 14:29:35 +05:30
Suraj Khurana 82ce4304ae Improved: Corrected all checkstyle issues related to succeeding space for comma in applications directory.
(OFBIZ-11805)
Thanks Jacques and Ritesh Kumar for review.
2020-07-09 11:59:51 +05:30
Suraj Khurana bfe3adeae9 Improved: Corrected all 'if is not followed by whitespace' checkstyle errors. Also corrected few ', is not followed by whitespace' checkstyle errors in applications component.
(OFBIZ-11805)
Thanks Jacques Le Roux and Ritesh Kumar for review.
2020-07-06 15:34:00 +05:30
lodhiravi 32a0cb865e Fixed: Added employee lookup to search/select employee(person) while creating new employment. This will also fixed the issue of party groups being selected as a employee. (OFBIZ-11697) (#210) 2020-07-04 23:11:58 +05:30
holivier 21077ac056 Documented: remove docbook help files for humanres (OFBIZ-11587)
All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files

In the global Help Docbook index tree, remove all points about
humanres and add a short page with a link to the new help
2020-06-19 17:23:29 +02:00
James Yong c0e527efb2 Improved: Headerize external script in multi-block html template (OFBIZ-11741)
Allow external scripts within the multi-block html template, to be rendered
within the html head tag, when a new attribute data-import is set to “head”

Thanks: Jacques for review
2020-05-30 12:00:21 +08:00
Suraj Khurana 5e7193f5a8 Improved: Changed resources with proper naming convention in all application components.
(OFBIZ-11739)
Also, made MODULE as private data member of class instead of public. This will reduce checkstlye issues. Thanks Jacques for review.
2020-05-29 13:19:05 +05:30
Pierre Smits 52732c8807 Fixed: organisation tree in humanres doesn't show person names (OFBIZ-11677) (#121)
* Fixed: Tree on main page of the humanres component doesn't show names of persons

(OFBIZ-11677)

When parties are assigned to employee positions their names aren't shown in the tree
fixed: the function that retrieves the person record of the assigned party was using
	the wrong variable in the query, resulting in a null being returned. Corrected the variable
added/improved: retrieval of the middleName value of the person record, added it to the title
improved: ordering of the names making up the title.
improved: applying proper case to variable names

* Fixed: Tree on main page of the humanres component doesn't show names of persons

(OFBIZ-11677)

invoking PartyHelper.getPartyName instead of custom code
code clean-up

Thanks to Pawan Verma for the review and the suggestion
2020-05-25 19:42:16 +05:30
Suraj Khurana a178b79107 Improved: Added UI labels for success/error messages for humanres, marketing, order component.
(OFBIZ-7696)
Thanks Deepak Nigam for reporting and Sourabh Punyani for the patch.
2020-05-24 13:03:03 +05:30
Suraj Khurana 59d465bfd8 Improved: All the service level error messages for missing required field for humanares component.
(OFBIZ-8716)
Thanks Jagpreet for reporting and Prasheel for providing the initial patch
2020-05-23 17:06:18 +05:30
James Yong f443ace724 Improved: Apply multi-block attr to each application (OFBIZ-11706)
Revert multi-block attr on RemoveInternalOrg.ftl, to fix
regression for HR tree.
There is no inline script causing CSP issue in the 1st place.

Thanks: Olivier for reporting
2020-05-18 20:26:39 +08:00
James Yong 2c62637752 Improved: Apply multi-block attr to each application (OFBIZ-11706)
For Accounting, Content, HR, Manufacturing.
2020-05-15 17:43:38 +08:00
Suraj Khurana c3cda28099 Improved: Converted all EmplLeave related CRUD services from simple to entity-auto (#97)
(OFBIZ-11630)
Also, added comments for similar types entity-auto services and clubbed them for better visibility.
2020-05-04 14:12:59 +05:30
Suraj Khurana 71d9040923 Improved: Converted all SalaryStep related CRUD services from simple to entity-auto (#98)
Improved: Converted all SalaryStep related CRUD services from simple to entity-auto
(OFBIZ-11631)
2020-05-03 11:26:36 +05:30
Jacques Le Roux ddb8f4273a Improved: replaces module by MODULE everywhere 2020-04-05 19:46:34 +02:00
Pierre Smits 321e51602a Improved: unify style application
(OFBIZ-11458)

replace 'align-float' with 'align-text'
2020-04-04 15:49:42 +02:00
Jacques Le Roux 6c49411ee7 Improved: "auth" should be true for all the request url used for Application
components

(OFBIZ-4956)

Currently there are some URLs present in application components with
auth="false". So anyone can hit these URLs and access these resources without
authorization.
I think all the URLs should be secure with auth="true"

jleroux: I have also fixed the dataResourceId="GZ-DIG"

Thanks: Amardeep Singh Jhajj for report and initial fix
2020-04-04 15:25:51 +02:00
Jacques Le Roux 7240b2642b Fixed: Ensure that the SameSite attribute is set to 'strict' for all cookies.
(OFBIZ-11470)

As reported by OWASP ZAP:
A cookie has been set without the SameSite attribute, which means that the
cookie can be sent as a result of a 'cross-site' request. The SameSite attribute
is an effective counter measure to cross-site request forgery, cross-site script
inclusion, and timing attacks.

The solution was not obvious in OFBiz for 2 reasons:

1. There is no HttpServletResponse::setHeader. So we need to use a filter
  (SameSiteFilter) and even that is not enough because of 2:
2. To prevent session fixation we force Tomcat to generates a new jsessionId,
ultimately put in cookie, in LoginWorker::login. So we need to add a call to
SameSiteFilter::addSameSiteCookieAttribute in
UtilHttp::setResponseBrowserDefaultSecurityHeaders.
2020-03-21 11:31:56 +01:00
Pierre Smits f5f2d459ad Improved: Cleanup HumanRes labels
(OFBIZ-9367)

Removing unused HumanRes labels
2020-03-21 11:31:43 +01:00
Michael Brohl 2f7e675ad6 Fixed: hr-glossary.adoc: line 22: id assigned to block already in use:
ANNUAL_REVENUE

(OFBIZ-11419)

Thanks Olivier Heintz for providing the patch.
2020-03-21 11:31:42 +01:00
holivier e9a0d113cf Documented: revert remove docbook help files for humanres
(OFBIZ-11420)

Removing Help files in docbook format break the current online help
2020-03-21 11:31:41 +01:00
Jacques Le Roux c34491892a Improved:
Implemented:
Documented:
Completed:
Reverted:
Fixed:
Improved: no functional change
(OFBIZ-)
Explanation
Thanks:
2020-02-27 14:36:26 +01:00
holivier 13abd8298c Documented : just remove trailing space
(OFBIZ-10251)
2020-02-25 21:28:03 +01:00
holivier f0e4db047d Documented : Migrate Training Howto Help to asciidoc and include in
hr-training.adoc
(OFBIZ-10268)

Included the Howto as a sub-chapter
File in docbook format is deleted
2020-02-25 21:28:03 +01:00
holivier 97d15cbcb0 Documented : Migrate Employee-position Help to asciidoc and include in
hr-employee-positions.adoc
(OFBIZ-10259)

Included all Help about Employee-position screen in a dedicated
sub-chapter "Employee Position management in UI"
Related Help file in docbook format is deleted
2020-02-25 21:28:03 +01:00
holivier 3d4d999e6a Documented : Migrate Employment Help to asciidoc and include in
hr-employment.adoc
(OFBIZ-10261)

Included all Help about Employment screen in a dedicated sub-chapter
"Employment management in UI"
Related Help file in docbook format is deleted
2020-02-25 21:28:03 +01:00
holivier eddb5a7b41 Documented : Migrate Employee Help to asciidoc and include in
hr-employees.adoc
(OFBIZ-10260)

Included all Help about Employee screen in a dedicated sub-chapter
"Employee management in UI"
Related Help file in docbook format is deleted
2020-02-25 21:28:03 +01:00
holivier 8d80909c90 Documented : Migrate Help to asciidoc and include in hr-intro.adoc
(OFBIZ-10256)

remove all related Help file in docbook format
2020-02-25 21:28:03 +01:00
Michael Brohl e4335b66c2 Improvement: German translation improvements in HumanResUiLabels
(OFBIZ-11134)

Thanks Ulrich Heidfeld for reporting and providing the patch.
2020-02-01 14:09:14 +01:00
Jacques Le Roux a609900105 Fixed: POC for CSRF Token
(OFBIZ-11306)

While reviewing I found this non related fix (FindPayGrade should be plural)
Better to commit it apart
2020-01-03 09:23:10 +01:00
Mathieu Lirzin aae1c8a8f5 Reverted: "Improved: Use ‘depends-on’ attribute instead of “component-load.xml”"
(OFBIZ-11296)

This reverts commit eeabe69813.
2019-12-18 12:09:20 +01:00
Samuel Trégouët 62c617eeec Fixed: Add XML declaration in “web.xml” files
(OFBIZ-6993)

These declarations avoid SAXParseException traceback when parsing web.xml
the first time in WebappUtil.parseWebXmlFile
2019-12-07 22:58:29 +01:00
Mathieu Lirzin 3b14e7afa9 Reverted: "Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)"
This reverts commit a93b1fcb78.
2019-11-27 21:42:33 +01:00