Commit Graph
42 Commits
Author SHA1 Message Date
Jacques Le Roux 54ab93ff2a Improved: Field 'govAgencyPartyId' shows all parties, not just Government Agencies (OFBIZ-10863)
The field govAgencyPartyId in the AddFixedAssetRegistration form shows all
parties through the lookup target-form-name="LookupPartyName function.

This should be limited to those parties that qualify with the constraint.

Thanks: Pierre Smits for report Priya Sharma for the fix
2021-02-21 14:22:00 +01:00
Michael Brohl 662a3f9d1c Improved: Remove Compdoc functionality from content manager
(OFBIZ-10476)
2021-02-13 17:33:05 +01:00
Jacques Le Roux e7b3169d03 Improved: Rename some connoted words like blacklist and whitelist (OFBIZ-12168)
Renames respectively blacklist and whitelist to denylist and allowlist in
several places.

There are still a lot of master word which can be replaced by main, but not in
contexts where slave is also used. I'll discuss that on dev ML again...

Provides the migrateOldOrderBlacklistAndOldOrderBlacklistType service to migrate
records from OrderBlacklist and OrderBlacklistType entities to new OrderDenylist
and OrderDenylistType entities
2021-02-09 09:55:39 +01:00
Jacques Le Roux fdeedf23ee Improved: Adds the HTML <input> accept Attribute in form widgets and Freemaker templates (OFBIZ-12049)
As explained at
https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/accept
this is only an help for the users (ie not a security feature), but an
appreciable one easy to implement.

Here we start with website/WebSiteCMSContent.ftl
Also add some missing file extensions
2020-12-07 18:45:25 +01:00
Jacques Le Roux 4481f373ca Fixed: Secure the uploads (OFBIZ-12080)
Handles audio and video formats supported by Tika.

Adds few new audio and video formats in seed data.

AFAIK there are no ways to embed a webshell in an audio or video file. So I did
not sophisticate the validation, just rely on Tika.

I have also fixed bugs in SecuredUpload: in isValidSvgFile and
isValidImageIncludingSvgFile
2020-12-07 18:45:24 +01:00
Jacques Le Roux e73616caf1 Fixed: Secure the uploads (OFBIZ-12080)
2020/08/10 the OFBiz security team received a security report by Harshit Shukla
<harshit.shukz@gmail.com>, roughly it was (quoting part of it to simplify):

<<I have identified a Remote Code Execution (RCE) Vulnerability. The reason
behind this RCE is lack of file extension check at
catalog/control/UploadCategoryImage?productCategoryId=CATALOG1_BEST_SELL&pload_file_type=category>>

Using this post-auth RCE in OFBiz demos, Harshit was able to get some AWS
credentials by uploading a webshell (based on [0]).
By security, it was then decided by the Infra and OFBiz security teams to shut
down the demos.

After discussing the elements reported with Mark J Cox (VP of ASF security team)
we in common decided that no CVE was necessary.
2020-12-01 10:16:04 +01:00
Suraj Khurana d7408de03f Fixed: Incorrect data issue for InvoiceItemTypeMap and ReturnItemTypeMap.
(OFBIZ-11971)
As we have returnItemTypeId as RET_MISC_ADJ, same should be used in ReturnItemTypeMap and corresponding InvoiceItemTypeMap.
Thanks Amit Gadaley for reporting and providing the patch.
2020-09-26 18:16:31 +05:30
Priya SharmaandPriya Sharma 9e7df96921 Improved: Move 'SecurityPermission' data to seed data files (OFBIZ-10575) (#225)
Co-authored-by: Priya Sharma <priya.sharma@hotwaxsystems.com>
2020-08-11 16:01:18 +02:00
Pierre Smits a58d78a79e Improved: Accounting seed data (OFBIZ-11652) (#116)
* Improved: Accounting Component - improve seed data

(OFBIZ-11652)
Adding role type records relating to budget entities

* Improved: Accounting Component - improve seed data

(OFBIZ-11652)
Adding role type records relating to budget entities
2020-05-06 13:47:10 +02:00
Pierre Smits a7328da044 Improved: Accounting Component - improve seed data
(OFBIZ-11652)
Adding role type records relating to budget entities
2020-05-06 12:53:22 +02:00
Daniel Watford bbd570ad22 Improved: Add 2020 version of Incoterms
(OFBIZ-11437)

Alter the parent type and descriptions of existing Incoterm TermTypes to
indicate the version of Incoterms they relate to.

Added new Incoterm TermTypes and descriptions correspoding to the
Incoterms 2020 set.
2020-03-03 17:59:56 +00:00
Jacques Le Roux 4ee663356e Improved: no functional change
In r1868022 I added the POS_SALES_CHANNEL was suggested in OFBIZ-10965. Actually
that was wrong. Tt's already in PosTypeData.xml though with a wrong sequenceId

This fixes it


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868023 13f79535-47bb-0310-9956-ffa450edef68
2019-10-05 14:23:17 +00:00
Jacques Le Roux 37672315c1 Improved: no functional change
Adds the POS_SALES_CHANNEL was suggested in OFBIZ-10965 and could be useful


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868022 13f79535-47bb-0310-9956-ffa450edef68
2019-10-05 14:18:33 +00:00
Jacques Le Roux be4555020c Fixed: In Product Image Management Uploading file fails due to missing
StatusValidChange
(OFBIZ-11148)
The error is
java.lang.Exception: Error in Service [updateContent]: Error: 
status change from [CTNT_IN_PROGRESS] to [IM_PENDING] is not allowed.

The issue does not exist in R16. So I guess it's because of OFBIZ-9907.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1864721 13f79535-47bb-0310-9956-ffa450edef68
2019-08-08 15:52:04 +00:00
Suraj Khurana 56d7903400 Improved: ContactMechPurposeType entity should be extended with generic type entity fields.
(OFBIZ-11008)
Thanks Jacques for reviewing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859913 13f79535-47bb-0310-9956-ffa450edef68
2019-05-25 06:40:54 +00:00
Jacques Le Roux a8f3480de4 Fixed: no functional changes
Fixes typos


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859055 13f79535-47bb-0310-9956-ffa450edef68
2019-05-10 05:15:28 +00:00
Suraj Khurana 443bac5d8f Improved: Added support for Inventory (Supply) Allocation Planning.
(OFBIZ-10518)
Thanks Deepak Nigam for initiating this feature and providng the patches, Arun Patidar for review and Swapnil Shah for design discussions.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1858270 13f79535-47bb-0310-9956-ffa450edef68
2019-04-27 13:05:30 +00:00
Suraj Khurana 8436ca3a25 Improved: Marital Status not managed properly in Person entity.
(OFBIZ-10921)
Thanks Paul, Jacques, Pierre and Nicolas for you suggestions and discussions.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1858261 13f79535-47bb-0310-9956-ffa450edef68
2019-04-27 10:11:09 +00:00
Suraj Khurana 755b835c8c Improved: Extended ReturnType entity with parentTypeId and hasTable fields to make it consistent with other type entities.
(OFBIZ-10868)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1856592 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 04:39:13 +00:00
Nicolas Malin 78e67432e7 Fixed: Update and clean deprecated code after release 18.12 creation
(OFBIZ-10761)
Remove deprecated entity fields deprecated for more 10 years and without impact with source code
Add since deprecate release on comment for PartyAcctgPreference definition and demo data to help the next analyse

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1850182 13f79535-47bb-0310-9956-ffa450edef68
2019-01-02 17:58:36 +00:00
Arun Patidar 136991d438 Added: Demo Data based on the proposed design to support replenishment planning through any inter-company facility.
(OFBIZ-7357)
For high level design and requirement details, please refer ticket (OFBIZ-6964)
Thanks Swapnil and Yashwant for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1849547 13f79535-47bb-0310-9956-ffa450edef68
2018-12-22 12:19:19 +00:00
Jacques Le Roux 3190e0ff2e Improved: Create patch for removal of IDEAL code in framework
(OFBIZ-5444)

Removes all iDEAL specifics from the framework (actually only applications)

Thanks: Pierre Smits

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1846227 13f79535-47bb-0310-9956-ffa450edef68
2018-11-09 10:20:10 +00:00
Suraj Khurana 9c2127b257 Improved: Added support to calculate deposit price as well while creating shopping cart item.
(OFBIZ-7482)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1838320 13f79535-47bb-0310-9956-ffa450edef68
2018-08-18 08:34:18 +00:00
Deepak Dixit 397628ba7d Improved: Remove use of deprecated language attribute from script tag
(OFBIZ-10491)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1836545 13f79535-47bb-0310-9956-ffa450edef68
2018-07-24 11:26:23 +00:00
Gil Portenseigne 9fbb3765e4 Implemented : File transfer management with communicationEvent and new contactMech FTP_ADDRESS
(OFBIZ-10245)

This commit introduce a new way to manage file transfer in OFBiz.
Inspired by mailing communication event management, a new communicationEventTypeId is created ('FILE_TRANSFER_COMM').

Such commEvent with classics : partyIdFrom/partyIdTo/contactMechIdTo/entryDate etc. are analysed by a job (like sendEmailDated), to send associated contents to a configured FTP/SFTP/FTPS server. If failure happens, it is catched and stored in communicationEvent, waiting for a new try.

For this purpose :

A new contactMechTypeId is introduced (FtpAddress), with its corresponding table. This contactMech store needed information for basic user/password authentication (server url and protocol, port, username, password, etc.)
A new service sendFileTransferDated that will look for pending file transfer and call following service.
A new service sendCommEventAsFtp that take a selected commEvent, check its structure and manage its status after trying the associated content file transfers.
A new service sendContentToFtp, that take a content and transfer it to a given FtpAddress.
A seca createCommEventFromFtpTransfer on sendContentToFtp to manage plural content file transfer, creating children communicationEvent to follow each content transfer separately (only for several content transfers).
A new Interface FtpClientInterface, with the 3 implementations of FTP, FTPS (To Implement), SFTP clients to manage Ftp connection and transfer.
A new property file to enable and manage redirection for testing purpose.

With this implementation, creating a communicationEvent, with a FtpAddress contactMechIdTo, and sendFileTransferDated job planned, the file is transfered to the ftp : communication event status set to COM_COMPLETE, if error occured the communication event status is set to COM_BOUNCED with error message on communicationEvent note.

Thanks Rishi for your feedbacks

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831867 13f79535-47bb-0310-9956-ffa450edef68
2018-05-18 15:53:35 +00:00
Rishi Solanki cfef87d6f1 Improved: Remove empty field values from xml data files so that it will not override existing data with empty values. Removed all empty data fields from data files.
(OFBIZ-10282)
Thanks to Arun Patidar for reporting and review.
Thanks to Suraj Khurana for providing patch for the improvement.
Thanks to Jacques for discussion and finalizing the work.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830545 13f79535-47bb-0310-9956-ffa450edef68
2018-04-30 10:52:55 +00:00
Akash Jain f0dc1e14b7 Improved: Invoice in status approved - cancel, applied patch from jira issue with minor changes (OFBIZ-10189)
Thanks, Ingo Wolfmayr for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830449 13f79535-47bb-0310-9956-ffa450edef68
2018-04-28 12:33:44 +00:00
Rishi Solanki ced30c8dc3 Improved: Move all data in applications to the datamodel component. Move the PortalPortlet, PortletPortletCategory and PortletCategory data to party, workeffort and content components from datamodel.
(OFBIZ-9501)
Thanks to Taher for reporting.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1828817 13f79535-47bb-0310-9956-ffa450edef68
2018-04-10 13:36:51 +00:00
Nicolas Malin 8aa723a98a Implemented: Add PartyPrefDocTypeTpl entity to link official template document to organisational party (OFBIZ-10186)
With this entity we can link a customScreen with an organisational party for a document type like salesinvoice, product quote and so on.
I added screen, form and menu to manage them on the organisation party configuration page accounting/control/ListCompanies
Currently this isn't useful alone but needed for issues OFBIZ-10215, OFBIZ-10216, OFBIZ-10217 that will be completed soon

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1824436 13f79535-47bb-0310-9956-ffa450edef68
2018-02-16 09:04:06 +00:00
Jacques Le Roux 7d15b3030a Improved: Add seqId to GlAccountClass table to support the sorting of GLAccount
sub classes
(OFBIZ-10209)
Arun:
Most "liquid" assets should be first (i.e Bank/Cash before Inventory) so need 
to provide support to sort GLAccount classes.
Add seqId to GlAccountClass entity to support the sorting of GLAccount sub 
classes.
Suraj:
Also rearranged GlAccountClass data in a logical grouping for better readability

Jacques:
I counted 35 lines GlAccountClass moved, did not check each line

Thanks: Arun Patidar for report and Suraj Khurana for the patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1823737 13f79535-47bb-0310-9956-ffa450edef68
2018-02-10 09:18:34 +00:00
Jacques Le Roux 35ee954560 Completed: Remove applet concept in OFBiz
(OFBIZ-10094)

Following discussion at http://markmail.org/message/dlp4zoo3xxuiefpn :

While reviewing http://svn.apache.org/viewvc?view=revision&revision=1811438 
I stumbled upon the usage of Java Applets

It's still possible to use Java Applets in browsers but most of the time it's 
not OOTB https://www.digitalcitizen.life/how-enable-java-all-major-web-browsers

And Java 9 deprecates it https://www.java.com/en/download/faq/jdk9_plugin.xml


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818646 13f79535-47bb-0310-9956-ffa450edef68
2017-12-19 10:33:15 +00:00
Rishi Solanki 613a605a3f Improved: Move all data in applications to the datamodel component. Moved seed data from commonext component. Left the protlet, security and help data.
(OFBIZ-9501)
Thanks to Jacques and Taher for your help and finalizing the directions.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818385 13f79535-47bb-0310-9956-ffa450edef68
2017-12-16 11:39:52 +00:00
Rishi Solanki 319d7292d2 Improved: Move all data in applications to the datamodel component. Moved seed data from humanres, marketing and order component. Left the protlet, security and help data for these components.
(OFBIZ-9501)
Thanks to Jacques and Taher for your help and finalizing the directions.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817915 13f79535-47bb-0310-9956-ffa450edef68
2017-12-12 13:57:04 +00:00
Rishi Solanki e83ab9ee03 Improved: Move all data in applications to the datamodel component. Move the help data back to the origin component from where moved to datamodel as discussed on ticket.
(OFBIZ-9501)
Thanks to Taher and Jacques for finalizing the direction.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817151 13f79535-47bb-0310-9956-ffa450edef68
2017-12-05 04:14:38 +00:00
Rishi Solanki be307fbade Improved: Move all data in applications to the datamodel component.
(OFBIZ-9501)
Move selected seed data for Product, Accounting and Manufacturing component. Thanks to Taher and Jacques for finalizing the data set.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816948 13f79535-47bb-0310-9956-ffa450edef68
2017-12-02 13:18:01 +00:00
Rishi Solanki a102c955fc Improved: Move all data in applications to the datamodel component. Remove unused files and added additional files to maintain all component data.
(OFBIZ-9501)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1813725 13f79535-47bb-0310-9956-ffa450edef68
2017-10-30 05:51:08 +00:00
Rishi Solanki 42cc28f78e Improved: Move all data in applications to the datamodel component. Moved seed and seed-initial data from party, content, security ext and work effort component. Left with few data changes which can be moved to some plugins or confusing. Will share the data over community and proceed accordingly once base effort is complete. Thanks Sourabh Jain, Saurabh Dixit and Prakhar Kumar for your contribution.
(OFBIZ-9501)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1813724 13f79535-47bb-0310-9956-ffa450edef68
2017-10-30 05:33:32 +00:00
Rishi Solanki 3b90303a43 Improvement: Move all data in applications to the datamodel component. (OFBIZ-9501)
Move parent type to data model component and childs back to workeffort as it seems to be related to project plugin. This will fix the issue of data loading.
Thanks Aditya Sharma for reporting the problem.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806279 13f79535-47bb-0310-9956-ffa450edef68
2017-08-26 09:27:33 +00:00
Rishi Solanki d5eb2cee42 Improvement: Move all data in applications to the datamodel component. (OFBIZ-9501)
Moved the data which belongs to product with seed reader.
Thanks Saurabh Jain for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806267 13f79535-47bb-0310-9956-ffa450edef68
2017-08-26 07:39:19 +00:00
Rishi Solanki 63852a97ae Improvement: Move all data in applications to the datamodel component. (OFBIZ-9501)
Moved the data which belongs to workeffot with seed reader.
Thanks Prakhar Kumar for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806265 13f79535-47bb-0310-9956-ffa450edef68
2017-08-26 07:33:06 +00:00
Rishi Solanki b0651cbe4d Improvement: Move all data in applications to the datamodel component. (OFBIZ-9501)
Moved the data which belongs to content with seed reader.
Thanks Saurabh Dixit for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806258 13f79535-47bb-0310-9956-ffa450edef68
2017-08-26 05:54:15 +00:00
Taher A. Alkhateeb 13994d0f22 Implemeted: Move all data in applications to the datamodel component
(OFBIZ-9501)

This is the first of many more commits to move all data from applications
to the datamodel component to centralize both entity definitions and the data
supporting it.

This commit partially moves data from PartyTypeData.xml file to the newly
created central file PartySeedData. All tests pass

Thank you: Swapnil Mane for your review and feedback


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802603 13f79535-47bb-0310-9956-ffa450edef68
2017-07-21 14:46:36 +00:00