Commit Graph
161 Commits
Author SHA1 Message Date
Jacques Le Roux 54ab93ff2a Improved: Field 'govAgencyPartyId' shows all parties, not just Government Agencies (OFBIZ-10863)
The field govAgencyPartyId in the AddFixedAssetRegistration form shows all
parties through the lookup target-form-name="LookupPartyName function.

This should be limited to those parties that qualify with the constraint.

Thanks: Pierre Smits for report Priya Sharma for the fix
2021-02-21 14:22:00 +01:00
Michael Brohl 662a3f9d1c Improved: Remove Compdoc functionality from content manager
(OFBIZ-10476)
2021-02-13 17:33:05 +01:00
Jacques Le Roux 0044d288a6 Improved: Rename some connoted words like blacklist and whitelist (OFBIZ-12168)
Updates DATAMODEL_CHANGES.adoc
2021-02-12 12:41:52 +01:00
Jacques Le Roux 49a1438806 Improved: Rename some connoted words like blacklist and whitelist (OFBIZ-12168)
The fk-name for OrderDenylist entity needs to be different from the one of
OldOrderBlacklist

Thanks to Deepak Dixit for spotting it
2021-02-12 12:34:09 +01:00
Jacques Le Roux e7b3169d03 Improved: Rename some connoted words like blacklist and whitelist (OFBIZ-12168)
Renames respectively blacklist and whitelist to denylist and allowlist in
several places.

There are still a lot of master word which can be replaced by main, but not in
contexts where slave is also used. I'll discuss that on dev ML again...

Provides the migrateOldOrderBlacklistAndOldOrderBlacklistType service to migrate
records from OrderBlacklist and OrderBlacklistType entities to new OrderDenylist
and OrderDenylistType entities
2021-02-09 09:55:39 +01:00
Jacques Le Roux fdeedf23ee Improved: Adds the HTML <input> accept Attribute in form widgets and Freemaker templates (OFBIZ-12049)
As explained at
https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/accept
this is only an help for the users (ie not a security feature), but an
appreciable one easy to implement.

Here we start with website/WebSiteCMSContent.ftl
Also add some missing file extensions
2020-12-07 18:45:25 +01:00
Jacques Le Roux 4481f373ca Fixed: Secure the uploads (OFBIZ-12080)
Handles audio and video formats supported by Tika.

Adds few new audio and video formats in seed data.

AFAIK there are no ways to embed a webshell in an audio or video file. So I did
not sophisticate the validation, just rely on Tika.

I have also fixed bugs in SecuredUpload: in isValidSvgFile and
isValidImageIncludingSvgFile
2020-12-07 18:45:24 +01:00
Jacques Le Roux e73616caf1 Fixed: Secure the uploads (OFBIZ-12080)
2020/08/10 the OFBiz security team received a security report by Harshit Shukla
<harshit.shukz@gmail.com>, roughly it was (quoting part of it to simplify):

<<I have identified a Remote Code Execution (RCE) Vulnerability. The reason
behind this RCE is lack of file extension check at
catalog/control/UploadCategoryImage?productCategoryId=CATALOG1_BEST_SELL&pload_file_type=category>>

Using this post-auth RCE in OFBiz demos, Harshit was able to get some AWS
credentials by uploading a webshell (based on [0]).
By security, it was then decided by the Infra and OFBiz security teams to shut
down the demos.

After discussing the elements reported with Mark J Cox (VP of ASF security team)
we in common decided that no CVE was necessary.
2020-12-01 10:16:04 +01:00
Jacques Le Roux a8b252f7dd Reverted: "description" and "comment" datatypes unnecessarily limited to 255 char (OFBIZ-12021)
This reverts commit 8736162c74.

We have test integration issues to fix

Due to TortoiseGIt, something weird happened, confused me to revert the revert :/
2020-10-03 13:41:41 +02:00
Jacques Le Roux 8736162c74 Reverted: "description" and "comment" datatypes unnecessarily limited to 255 char (OFBIZ-12021)
This reverts commit 686f01c8cf.

We have test integration issues to fix
2020-10-03 13:30:15 +02:00
Jacques Le Roux 8ef3b54c22 Reverted: "description" and "comment" datatypes unnecessarily limited to 255 char (OFBIZ-12021)
This reverts commit 686f01c8cf.

We have test integration issues to fix
2020-10-03 13:28:10 +02:00
Jacques Le Roux 686f01c8cf Improved: "description" and "comment" datatypes unnecessarily limited to 255 char (OFBIZ-12021)
"Description" and "comment" fields are restricted to 255 char.

However after some research I found that all the supported databases support
longer then 255 char
I would expect users to want to write more then 255 char in a comment
(I know I personally can).

A discussion has been started on dev ML:
https://markmail.org/message/7utrgejc2c44i37u

Also adds a note in DATAMODEL_CHANGES.adoc

Thanks: ddev
2020-10-03 11:26:27 +02:00
Suraj Khurana d7408de03f Fixed: Incorrect data issue for InvoiceItemTypeMap and ReturnItemTypeMap.
(OFBIZ-11971)
As we have returnItemTypeId as RET_MISC_ADJ, same should be used in ReturnItemTypeMap and corresponding InvoiceItemTypeMap.
Thanks Amit Gadaley for reporting and providing the patch.
2020-09-26 18:16:31 +05:30
Jacques Le Roux 2d033df446 Improved: Update information in README.md files from removed pages in wiki 2020-08-29 17:37:18 +02:00
Priya SharmaandPriya Sharma 9e7df96921 Improved: Move 'SecurityPermission' data to seed data files (OFBIZ-10575) (#225)
Co-authored-by: Priya Sharma <priya.sharma@hotwaxsystems.com>
2020-08-11 16:01:18 +02:00
holivier 192059e3da Improvement: Help link using asciidoc files via generated html
(OFBIZ-11693)

Change release for all asciidoc files, now there area 3 publish site,
one per release
* site/trunk
* site/next   currently for the 18.12
* site/stable currently for the 17.12
2020-06-04 17:56:54 +02:00
Pierre Smits 96c428d1cf Improved: instructions to upgrade due to datamodel changes (OFBIZ-11719) (#162) 2020-05-26 17:21:05 +05:30
Aditya Sharmaandholivier a82c3032ad Documented: datamodel markdown migration to asciidoc (OFBIZ-11574)
* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

- DATAMODEL_CHANGE migration to asciidoc and add a included in
developer_manual
- Readme migration to asciidoc

* Documented: theme/README.md change theme/README.adoc but with very
simple content
(OFBIZ-11574)

README.md  has been migrated to asciidoc as doc/themes.adoc previously
but remove README.md has been forgot.
In this commit README.md is removed and a new README.adoc is created
with only a brief component definition and link to the theme
documentation (and developer-manual which included theme.adoc)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

Added new field parentGlXbrlClassId taking reference from DATAMODEL_CHANGES.md which was added with OFBIZ-10613 and missing in adoc file

Co-authored-by: holivier <holivier@apache.org>
2020-05-25 19:46:04 +05:30
Suraj Khurana 44c374a644 Removed: Deprecated entity captureBillingAccountPayments since release 17.12. (#131)
(OFBIZ-11435)
Also, added deprecated since tag in some old entities and fields. This is done as per current policy to deprecate entities/services.
Thanks Pierre for reporting and Jacques for review.
2020-05-15 12:07:35 +05:30
Pierre SmitsandPawan Verma e1ab3b1e99 Improved: Enhance entity "GlXbrlClass" and use (OFBIZ-10613) (#41)
* Improved: Enhance entity "GlXbrlClass" and use

(OFBIZ-10613)

Adding field parent of the GlXbrlClassId
Application of field in appropriate forms

* Improved: Added new field parentGlXbrlClassId into DATAMODEL_CHANGES.md
(OFBIZ-10613)

Co-authored-by: Pawan Verma <pawan.verma@hotwaxsystems.com>
2020-05-08 16:34:40 +05:30
Pierre Smits a58d78a79e Improved: Accounting seed data (OFBIZ-11652) (#116)
* Improved: Accounting Component - improve seed data

(OFBIZ-11652)
Adding role type records relating to budget entities

* Improved: Accounting Component - improve seed data

(OFBIZ-11652)
Adding role type records relating to budget entities
2020-05-06 13:47:10 +02:00
Pierre Smits a7328da044 Improved: Accounting Component - improve seed data
(OFBIZ-11652)
Adding role type records relating to budget entities
2020-05-06 12:53:22 +02:00
Pierre Smits 10060c8eea Improved: Tax Authority Data for China
(OFBIZ-11628)

added party and tax authority data for China
2020-05-05 15:55:33 +02:00
Pierre Smits 451d78b1c7 Improved: move demo data from optional plugin to base application
(OFBIZ-6110)

Moved: marketing component related data in ecommerce plugin
2020-05-05 15:51:12 +02:00
Pierre Smits e675694d0b Improved: demo data regarding rental assets
(OFBIZ-10862)

Updating fixed asset 'RentalShip'
2020-05-05 13:43:19 +02:00
Pierre Smits df66cca3ff Improved: Marketing/SFA demo data (OFBIZ-11043) (#107)
* Improved: Marketing/SFA demo data

(OFBIZ-11043)

modified: UserLoginSecurityGroup for DemoLeadOwner
modified: UserLoginSecurityGroup for DemoLeadOwner1
modified: roleTypeId for DemoLeadOwnerGroup
modified: PartyRelationship between DemoLeadOwnerGroup and DemoLeadOwner
modified: PartyRelationship between DemoLeadOwnerGroup and DemoLeadOwner1

* Improved: Marketing/SFA demo data

(OFBIZ-11043)

removed: related comments
2020-05-04 21:45:07 +02:00
Suraj Khurana 13ea2ba726 Improved: View entity definition for MarketingCampaignAndVisit and made relational optional as false.
(OFBIZ-9909)

This will generate the report with positive visits only in both the cases (with/without date filter) while running marketing campaign reports.

Thanks Rubia for reporting and Ankit Joshi for providing the patch.
2020-04-26 20:10:08 +05:30
Pawan Verma 3b86754e14 Improved: Added new data model changes done under OFBIZ-5426 in DataModel changes file. (#55)
(OFBIZ-5426)

Thanks, Deepak Dixit for the report.
2020-03-30 23:21:43 +05:30
Pierre Smits dc68ac089f Fixed: DataModel - correct foreign key (#51)
(OFBIZ-11474)

Renaming foreign key to PROD_PRCDE_OPCD
2020-03-24 14:45:58 +05:30
Pawan Verma 91673f1b41 Fixed: Specified key was too long; max key length is 767 bytes for ProductPromoCodeEmail entity.(OFBIZ-5426) (#44)
* Fixed: Specified key was too long; max key length is 767 bytes for ProductPromoCodeEmail entity.
(OFBIZ-5426)

The problem is in the entity model. An email address should not be used in the primary key - mainly because an email address is case-insensitive. A better design would be to use the email address contact mechanism ID in the primary key.

Done Following:
1. Changed Entity Name from ProductPromoCodeEmail to ProductPromoCodeContMech
2. Related Changes for the entity name change
3. Migration service to migrate old data

Thanks, Leon for the report and Adrian Crum, Jacques Le Roux, Ingo Wolfmayr, Deepak Dixit, Pierre Smits and Gil Portenseigne for the discussion and review.

* Improved: Added new line in service definition file and lincence in MigrationServices file.
(OFBIZ-5426)

Thanks, Jacopo for the review.
2020-03-23 17:08:58 +05:30
Jacques Le Roux 67531d8bb2 Improved: "auth" should be true for all the request url used for Application
components

(OFBIZ-4956)

Currently there are some URLs present in application components with
auth="false". So anyone can hit these URLs and access these resources without
authorization.
I think all the URLs should be secure with auth="true"

jleroux: I have also fixed the dataResourceId="GZ-DIG"

Thanks: Amardeep Singh Jhajj for report and initial fix
2020-03-14 08:51:23 +01:00
Daniel Watford bbd570ad22 Improved: Add 2020 version of Incoterms
(OFBIZ-11437)

Alter the parent type and descriptions of existing Incoterm TermTypes to
indicate the version of Incoterms they relate to.

Added new Incoterm TermTypes and descriptions correspoding to the
Incoterms 2020 set.
2020-03-03 17:59:56 +00:00
Suraj Khurana d98d9ccbfa Fixed: Picklist is in Input status even after order is completed.
(OFBIZ-10883)

Thanks Rashi Dhagat for reporting, Shikha Jaiswal for the patch and Pawan Verma for review.
2020-02-26 19:22:49 +05:30
Jacopo Cappellato f9607c0298 Fixed: Extend the thru date of the demo financial period (and simplify
some related demo data for easier future maintenance) in order to fix
some tests that are failing in the new year.
2020-01-03 13:46:04 +01:00
Jacques Le Roux 4ee663356e Improved: no functional change
In r1868022 I added the POS_SALES_CHANNEL was suggested in OFBIZ-10965. Actually
that was wrong. Tt's already in PosTypeData.xml though with a wrong sequenceId

This fixes it


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868023 13f79535-47bb-0310-9956-ffa450edef68
2019-10-05 14:23:17 +00:00
Jacques Le Roux 37672315c1 Improved: no functional change
Adds the POS_SALES_CHANNEL was suggested in OFBIZ-10965 and could be useful


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868022 13f79535-47bb-0310-9956-ffa450edef68
2019-10-05 14:18:33 +00:00
Jacques Le Roux b76d95d72a Improved: Unit test case for service - testSendOrderChangeNotification
(OFBIZ-8811)(OFBIZ-9647)(OFBIZ-9671)

While working on this I stumbled upon an issue related with 
webSiteId="OrderEntry" well related by Ratnesh Upadhyay in OFBIZ-9647.

Unlike him I decided not to remove the webSiteId="OrderEntry" entries but to
replace them by webSiteId="WebStore"

Tests pass!


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1867889 13f79535-47bb-0310-9956-ffa450edef68
2019-10-02 14:46:00 +00:00
Jacques Le Roux c8155d86da Improved: Foreign Key relation is missing for dataSourceId in SalesOpportunity
entity
(OFBIZ-11218)

I see no reason to no have it as it's in all other cases. 

Thanks: reported by Rajesh Mallah, improved with a patch from Devanshu Vyas.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1867665 13f79535-47bb-0310-9956-ffa450edef68
2019-09-28 12:08:11 +00:00
Nicolas Malin c16dad812f Implemented: Convert Picklist related CRUD services from simple to entity-auto
(OFBIZ-10636)

services converted: 
 * createPicklist
 * updatePicklist
 * deletePicklist
 * createPicklistBin
 * deletePicklistBin
 * createPicklistItem
 * updatePicklistItem
 * updatePicklistItem
 * deletePicklistItem
 * createPicklistRole
 * deletePicklistRole

Entity Picklist received to new field createdDate and lastModifiedDate
that needed to support automatic setting of createdByUserLogin natevily
by entity auto engine 

Thanks to Pallavi Goyal for this issue and Suraj Khurana for the remind.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1866561 13f79535-47bb-0310-9956-ffa450edef68
2019-09-07 17:48:50 +00:00
Nicolas Malin 1e5c621420 Improved: PicklistStatusHistory doesn't follow history entity status pattern
(OFBIZ-11182)
The entity PicklistStatusHistory record each status change realized on picklist.

It can't be convert to entity-auto easily because PicklistStatusHistory's fields pattern
doesn't follow same entities like ShipmentStatus and PartyStatus.

To solve this issue, I deprecate PicklistStatusHistory and move it to OldPicklistStatusHistory
and replace it by new entity PicklistStatus that can use natively with entityauto.

I added a new migration service migrateOldPicklistStatusHistoryToPickListStatus to forward all 
picklist status history to new entity.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1866558 13f79535-47bb-0310-9956-ffa450edef68
2019-09-07 15:51:06 +00:00
Jacques Le Roux 15a9563e07 Fixed: In Product Image Management Uploading file fails due to missing
StatusValidChange
(OFBIZ-11148)

With last commit I introduced a dependency from ProductSeedData to 
ContentSeedData. The loadAll tasks failed because of that, this fixes it.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1864891 13f79535-47bb-0310-9956-ffa450edef68
2019-08-10 17:02:12 +00:00
Jacques Le Roux be4555020c Fixed: In Product Image Management Uploading file fails due to missing
StatusValidChange
(OFBIZ-11148)
The error is
java.lang.Exception: Error in Service [updateContent]: Error: 
status change from [CTNT_IN_PROGRESS] to [IM_PENDING] is not allowed.

The issue does not exist in R16. So I guess it's because of OFBIZ-9907.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1864721 13f79535-47bb-0310-9956-ffa450edef68
2019-08-08 15:52:04 +00:00
Jacques Le Roux 71f0cad57c fixed: supplierProductId Should Have Consistent Types Across Entities.
(OFBIZ-10150)

During some data migration I hit an issue where my data for supplierProductId 
was too long. So I looked up the fields and noticed that the order item entity 
had a different type for the field than the supplier product entity.

jleroux: we should do it for all cases
 

Thanks: jesse thomas for report and Rohit Hukkeri for the fix

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1862271 13f79535-47bb-0310-9956-ffa450edef68
2019-06-28 09:39:44 +00:00
Suraj Khurana 56d7903400 Improved: ContactMechPurposeType entity should be extended with generic type entity fields.
(OFBIZ-11008)
Thanks Jacques for reviewing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859913 13f79535-47bb-0310-9956-ffa450edef68
2019-05-25 06:40:54 +00:00
Jacques Le Roux ddb43a6493 Fixed: field emplFromDate is forgot in PayHistory entity
(OFBIZ-11028)

Arpit Mor: steps to regenerate:
    Login to the URL: https://demo-trunk.ofbiz.apache.org/humanres/control/main
    Click on Employments
    Click on New Employments
    Click on Create
Actual: Error message is displayed.

Olivier Heintz: employment is associated with PayHistory, and there is a problem 
in PayHistory entity definition in OFBiz,
In PayHistory, the field fromDate from Employment is confused with fromDate 
about the current record.
A Employment can have multiple PayHistories and should have multiple
because PayHistory should show history of Pay  for a employment  !
It's necessary to have a field emplFromDate (to have the complete employment 
primaryKey).
When modifying a PayRecord the current should be expire and a new one should 
be created.

Thanks: Arpit Mor for report at OFBIZ-10969 and Olivier Heintz for the fix

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859571 13f79535-47bb-0310-9956-ffa450edef68
2019-05-20 17:14:43 +00:00
Jacques Le Roux 2a2d1c25a8 Improved: Have an Auditor party with associated AUDITOR SecurityGroup
permissions in all DEMO instances
(OFBIZ-10899)

Adds auditor party and user login with only VIEW_ADMIN permission, ie only view 
permissions on the UI elements (screens/menu-items/forms and templates).

Other improvements could also occur (e.g. create buttons visible to 'VIEW' only 
permission holders) but are not part of this issue.

Thanks: Pierre Smits

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859535 13f79535-47bb-0310-9956-ffa450edef68
2019-05-20 08:17:36 +00:00
Jacques Le Roux a8f3480de4 Fixed: no functional changes
Fixes typos


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859055 13f79535-47bb-0310-9956-ffa450edef68
2019-05-10 05:15:28 +00:00
Arun Patidar d9fd6ba83d Improved: Having ability to make Configurable options date controlled
(OFBiz-10950)

Thanks: Pritam Kute for reporting and Mohammed Rehan Khan for providing patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1858305 13f79535-47bb-0310-9956-ffa450edef68
2019-04-28 06:15:46 +00:00
Suraj Khurana 443bac5d8f Improved: Added support for Inventory (Supply) Allocation Planning.
(OFBIZ-10518)
Thanks Deepak Nigam for initiating this feature and providng the patches, Arun Patidar for review and Swapnil Shah for design discussions.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1858270 13f79535-47bb-0310-9956-ffa450edef68
2019-04-27 13:05:30 +00:00
Suraj Khurana 8436ca3a25 Improved: Marital Status not managed properly in Person entity.
(OFBIZ-10921)
Thanks Paul, Jacques, Pierre and Nicolas for you suggestions and discussions.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1858261 13f79535-47bb-0310-9956-ffa450edef68
2019-04-27 10:11:09 +00:00