The field govAgencyPartyId in the AddFixedAssetRegistration form shows all
parties through the lookup target-form-name="LookupPartyName function.
This should be limited to those parties that qualify with the constraint.
Thanks: Pierre Smits for report Priya Sharma for the fix
Renames respectively blacklist and whitelist to denylist and allowlist in
several places.
There are still a lot of master word which can be replaced by main, but not in
contexts where slave is also used. I'll discuss that on dev ML again...
Provides the migrateOldOrderBlacklistAndOldOrderBlacklistType service to migrate
records from OrderBlacklist and OrderBlacklistType entities to new OrderDenylist
and OrderDenylistType entities
As explained at
https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/accept
this is only an help for the users (ie not a security feature), but an
appreciable one easy to implement.
Here we start with website/WebSiteCMSContent.ftl
Also add some missing file extensions
Handles audio and video formats supported by Tika.
Adds few new audio and video formats in seed data.
AFAIK there are no ways to embed a webshell in an audio or video file. So I did
not sophisticate the validation, just rely on Tika.
I have also fixed bugs in SecuredUpload: in isValidSvgFile and
isValidImageIncludingSvgFile
2020/08/10 the OFBiz security team received a security report by Harshit Shukla
<harshit.shukz@gmail.com>, roughly it was (quoting part of it to simplify):
<<I have identified a Remote Code Execution (RCE) Vulnerability. The reason
behind this RCE is lack of file extension check at
catalog/control/UploadCategoryImage?productCategoryId=CATALOG1_BEST_SELL&pload_file_type=category>>
Using this post-auth RCE in OFBiz demos, Harshit was able to get some AWS
credentials by uploading a webshell (based on [0]).
By security, it was then decided by the Infra and OFBiz security teams to shut
down the demos.
After discussing the elements reported with Mark J Cox (VP of ASF security team)
we in common decided that no CVE was necessary.
This reverts commit 8736162c74.
We have test integration issues to fix
Due to TortoiseGIt, something weird happened, confused me to revert the revert :/
"Description" and "comment" fields are restricted to 255 char.
However after some research I found that all the supported databases support
longer then 255 char
I would expect users to want to write more then 255 char in a comment
(I know I personally can).
A discussion has been started on dev ML:
https://markmail.org/message/7utrgejc2c44i37u
Also adds a note in DATAMODEL_CHANGES.adoc
Thanks: ddev
(OFBIZ-11971)
As we have returnItemTypeId as RET_MISC_ADJ, same should be used in ReturnItemTypeMap and corresponding InvoiceItemTypeMap.
Thanks Amit Gadaley for reporting and providing the patch.
(OFBIZ-11693)
Change release for all asciidoc files, now there area 3 publish site,
one per release
* site/trunk
* site/next currently for the 18.12
* site/stable currently for the 17.12
* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)
- DATAMODEL_CHANGE migration to asciidoc and add a included in
developer_manual
- Readme migration to asciidoc
* Documented: theme/README.md change theme/README.adoc but with very
simple content
(OFBIZ-11574)
README.md has been migrated to asciidoc as doc/themes.adoc previously
but remove README.md has been forgot.
In this commit README.md is removed and a new README.adoc is created
with only a brief component definition and link to the theme
documentation (and developer-manual which included theme.adoc)
* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)
Added new field parentGlXbrlClassId taking reference from DATAMODEL_CHANGES.md which was added with OFBIZ-10613 and missing in adoc file
Co-authored-by: holivier <holivier@apache.org>
(OFBIZ-11435)
Also, added deprecated since tag in some old entities and fields. This is done as per current policy to deprecate entities/services.
Thanks Pierre for reporting and Jacques for review.
* Improved: Enhance entity "GlXbrlClass" and use
(OFBIZ-10613)
Adding field parent of the GlXbrlClassId
Application of field in appropriate forms
* Improved: Added new field parentGlXbrlClassId into DATAMODEL_CHANGES.md
(OFBIZ-10613)
Co-authored-by: Pawan Verma <pawan.verma@hotwaxsystems.com>
* Improved: Accounting Component - improve seed data
(OFBIZ-11652)
Adding role type records relating to budget entities
* Improved: Accounting Component - improve seed data
(OFBIZ-11652)
Adding role type records relating to budget entities
* Improved: Marketing/SFA demo data
(OFBIZ-11043)
modified: UserLoginSecurityGroup for DemoLeadOwner
modified: UserLoginSecurityGroup for DemoLeadOwner1
modified: roleTypeId for DemoLeadOwnerGroup
modified: PartyRelationship between DemoLeadOwnerGroup and DemoLeadOwner
modified: PartyRelationship between DemoLeadOwnerGroup and DemoLeadOwner1
* Improved: Marketing/SFA demo data
(OFBIZ-11043)
removed: related comments
(OFBIZ-9909)
This will generate the report with positive visits only in both the cases (with/without date filter) while running marketing campaign reports.
Thanks Rubia for reporting and Ankit Joshi for providing the patch.
* Fixed: Specified key was too long; max key length is 767 bytes for ProductPromoCodeEmail entity.
(OFBIZ-5426)
The problem is in the entity model. An email address should not be used in the primary key - mainly because an email address is case-insensitive. A better design would be to use the email address contact mechanism ID in the primary key.
Done Following:
1. Changed Entity Name from ProductPromoCodeEmail to ProductPromoCodeContMech
2. Related Changes for the entity name change
3. Migration service to migrate old data
Thanks, Leon for the report and Adrian Crum, Jacques Le Roux, Ingo Wolfmayr, Deepak Dixit, Pierre Smits and Gil Portenseigne for the discussion and review.
* Improved: Added new line in service definition file and lincence in MigrationServices file.
(OFBIZ-5426)
Thanks, Jacopo for the review.
components
(OFBIZ-4956)
Currently there are some URLs present in application components with
auth="false". So anyone can hit these URLs and access these resources without
authorization.
I think all the URLs should be secure with auth="true"
jleroux: I have also fixed the dataResourceId="GZ-DIG"
Thanks: Amardeep Singh Jhajj for report and initial fix
(OFBIZ-11437)
Alter the parent type and descriptions of existing Incoterm TermTypes to
indicate the version of Incoterms they relate to.
Added new Incoterm TermTypes and descriptions correspoding to the
Incoterms 2020 set.
In r1868022 I added the POS_SALES_CHANNEL was suggested in OFBIZ-10965. Actually
that was wrong. Tt's already in PosTypeData.xml though with a wrong sequenceId
This fixes it
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1868023 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8811)(OFBIZ-9647)(OFBIZ-9671)
While working on this I stumbled upon an issue related with
webSiteId="OrderEntry" well related by Ratnesh Upadhyay in OFBIZ-9647.
Unlike him I decided not to remove the webSiteId="OrderEntry" entries but to
replace them by webSiteId="WebStore"
Tests pass!
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1867889 13f79535-47bb-0310-9956-ffa450edef68
entity
(OFBIZ-11218)
I see no reason to no have it as it's in all other cases.
Thanks: reported by Rajesh Mallah, improved with a patch from Devanshu Vyas.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1867665 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10636)
services converted:
* createPicklist
* updatePicklist
* deletePicklist
* createPicklistBin
* deletePicklistBin
* createPicklistItem
* updatePicklistItem
* updatePicklistItem
* deletePicklistItem
* createPicklistRole
* deletePicklistRole
Entity Picklist received to new field createdDate and lastModifiedDate
that needed to support automatic setting of createdByUserLogin natevily
by entity auto engine
Thanks to Pallavi Goyal for this issue and Suraj Khurana for the remind.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1866561 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-11182)
The entity PicklistStatusHistory record each status change realized on picklist.
It can't be convert to entity-auto easily because PicklistStatusHistory's fields pattern
doesn't follow same entities like ShipmentStatus and PartyStatus.
To solve this issue, I deprecate PicklistStatusHistory and move it to OldPicklistStatusHistory
and replace it by new entity PicklistStatus that can use natively with entityauto.
I added a new migration service migrateOldPicklistStatusHistoryToPickListStatus to forward all
picklist status history to new entity.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1866558 13f79535-47bb-0310-9956-ffa450edef68
StatusValidChange
(OFBIZ-11148)
With last commit I introduced a dependency from ProductSeedData to
ContentSeedData. The loadAll tasks failed because of that, this fixes it.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1864891 13f79535-47bb-0310-9956-ffa450edef68
StatusValidChange
(OFBIZ-11148)
The error is
java.lang.Exception: Error in Service [updateContent]: Error:
status change from [CTNT_IN_PROGRESS] to [IM_PENDING] is not allowed.
The issue does not exist in R16. So I guess it's because of OFBIZ-9907.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1864721 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10150)
During some data migration I hit an issue where my data for supplierProductId
was too long. So I looked up the fields and noticed that the order item entity
had a different type for the field than the supplier product entity.
jleroux: we should do it for all cases
Thanks: jesse thomas for report and Rohit Hukkeri for the fix
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1862271 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-11028)
Arpit Mor: steps to regenerate:
Login to the URL: https://demo-trunk.ofbiz.apache.org/humanres/control/main
Click on Employments
Click on New Employments
Click on Create
Actual: Error message is displayed.
Olivier Heintz: employment is associated with PayHistory, and there is a problem
in PayHistory entity definition in OFBiz,
In PayHistory, the field fromDate from Employment is confused with fromDate
about the current record.
A Employment can have multiple PayHistories and should have multiple
because PayHistory should show history of Pay for a employment !
It's necessary to have a field emplFromDate (to have the complete employment
primaryKey).
When modifying a PayRecord the current should be expire and a new one should
be created.
Thanks: Arpit Mor for report at OFBIZ-10969 and Olivier Heintz for the fix
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859571 13f79535-47bb-0310-9956-ffa450edef68
permissions in all DEMO instances
(OFBIZ-10899)
Adds auditor party and user login with only VIEW_ADMIN permission, ie only view
permissions on the UI elements (screens/menu-items/forms and templates).
Other improvements could also occur (e.g. create buttons visible to 'VIEW' only
permission holders) but are not part of this issue.
Thanks: Pierre Smits
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859535 13f79535-47bb-0310-9956-ffa450edef68