Commit Graph
46 Commits
Author SHA1 Message Date
Jacques Le Roux ec2b84341e Reverted: "Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)"
This reverts commit 17eb2e4cf7.

It does not work when using <<target="javascript:........>>
I could change those cases but it's easier and safer to simply revert back to
target-type!

Thanks: James for report
2020-12-18 11:08:32 +01:00
Jacques Le Roux 17eb2e4cf7 Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)
Same for sub-hyperlink
2020-12-11 16:52:04 +01:00
Jacques Le Roux 4d646ce052 Improved: Use "Create" instead of "Create New" on the various screens of all
components
(OFBIZ-9905)

As the title says + removes now useless labels

Thanks: Aayush Jain for report, Sourabh Jain for the fix, Pierre Smits and 
Rishi Solanki for comments

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1858291 13f79535-47bb-0310-9956-ffa450edef68
2019-04-27 17:56:44 +00:00
Jacques Le Roux 8cdb6010a1 Fixed: Fix references where Mime type is displayed in HTML encoded pattern
(OFBIZ-9644)

I found various instances where the mimeTypeId is displayed in HTML 
encoded pattern over UI.

jleroux: this also removes 2 duplicated fields in AddLayout form

Thanks: Ankit Joshi

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806951 13f79535-47bb-0310-9956-ffa450edef68
2017-09-01 12:49:04 +00:00
Jacques Le Roux 83d0294118 Reverts revision: 1806947, changes in UserEvents.xml inadvertently slipped in
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806948 13f79535-47bb-0310-9956-ffa450edef68
2017-09-01 12:42:11 +00:00
Jacques Le Roux 7be7ad6179 Fixed: Fix references where Mime type is displayed in HTML encoded pattern
(OFBIZ-9644)

I found various instances where the mimeTypeId is displayed in HTML 
encoded pattern over UI.

jleroux: this also removes 2 duplicated fields in AddLayout form

Thanks: Ankit Joshi

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806947 13f79535-47bb-0310-9956-ffa450edef68
2017-09-01 12:38:47 +00:00
Nicolas Malin 40fdd2ca73 Implemented: Continue the common-theme upload (OFBIZ-9138 Create a common theme)
Five step 
#9 Change all set screen and script that call widget.properties values replaced by call to modelTheme

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806150 13f79535-47bb-0310-9956-ffa450edef68
2017-08-25 10:02:34 +00:00
Deepak Dixit d09255c0b7 Reverted: Minilang code readability and consistency improvements done at r#1768222, this commit reversed key and description of drop-down in the code.
(OFBIZ-9114)

Thanks  Wei Zhang for reporting the issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772880 13f79535-47bb-0310-9956-ffa450edef68
2016-12-06 12:37:42 +00:00
Deepak Dixit d415614fbf Improved: Consitent menu bar in following screens decorator:
- Feature Category
- Product Store  
- DataResource
- Template
- CMS Content

(OFBIZ-8187)(OFBIZ-8186)(OFBIZ-8185)(OFBIZ-8184)(OFBIZ-8183)

Thanks Avnindra Sharma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768267 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 18:26:40 +00:00
Divesh Dutta 70eb7ff508 Improvement: Minilang code readability and consistency improvements.
(OFBIZ-8929) (OFBIZ-8930) (OFBIZ-8953) (OFBIZ-8965) (OFBIZ-8972) (OFBIZ-8986) (OFBIZ-8991) 

Thanks: Ankush Upadhyay, Anuj Jain, Abhijeet for your patches. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768222 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:34:00 +00:00
Divesh Dutta 738a12bec1 Improvement: Miniland code readability and consistency improvements
(OFBIZ-8744) (OFBIZ-8745) (OFBIZ-8746) (OFBIZ-8748) (OFBIZ-8829) (OFBIZ-8830) (OFBIZ-8907) (OFBIZ-8908) (OFBIZ-8924) (OFBIZ-8925) 

Thanks: Ankush Upadhyay , Sega patidar , Abhijeet Ashapure for your patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768219 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:14:04 +00:00
Michael Brohl 6c8a33ff2c Improved: Content: Consistent form name.
(OFBIZ-8046)

Change all form names to upper camel case for consistency.

Thanks: Tanmay Muley for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761079 13f79535-47bb-0310-9956-ffa450edef68
2016-09-16 20:37:43 +00:00
Jacques Le Roux c8ba932772 Fixes a "typo" in last commit for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
We used targetNamespace (should only be used in schema) instead of xsi:schemaLocation



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749634 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 05:58:26 +00:00
Jacques Le Roux 89212904bd Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
This is the 2nd step: puts back the original names, so it will be transparent for remaining references in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749489 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:37:47 +00:00
Jacques Le Roux 4931db1ed9 Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061 by replacing xsd files references in xml files by -ns.xsd files and removing the concerned xsd files
This is a 1st step, in a 2nd I will put back the original names, so it will be transparent for remaining reference in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749488 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:14:16 +00:00
Deepak Dixit 25b56a03ea (OFBIZ-7223) Relocate .groovy files in the content component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747756 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 17:21:10 +00:00
Deepak Dixit 84ad66589e (OFBIZ-7021) Renamed content component ftl file name from lower case to upper case pattern.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1742457 13f79535-47bb-0310-9956-ffa450edef68
2016-05-05 18:11:54 +00:00
Deepak Dixit cee0263cef (OFBIZ-6815) relocate .ftl files in the content component
Thanks Pierre for your contribution.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1740446 13f79535-47bb-0310-9956-ffa450edef68
2016-04-22 06:12:08 +00:00
Nicolas Malin 895c9856b3 Cleaning forms code is needed after setting default-value in list-options and entity-options, patch related to OFBIZ-6524 and follows the resolution of OFBIZ-6490 and OFBIZ-6489. Thanks Gil Portenseigne for this effort
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1686674 13f79535-47bb-0310-9956-ffa450edef68
2015-06-20 21:58:05 +00:00
Jacques Le Roux 9bfe114d10 Fixes a bug, there is no LookupParty only LookupPerson and LookupPartyGroup. anyway I believe here we should rather use LookupUserLoginAndPartyDetails because no reasons to exclude a PartyGroup or a Person
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1653934 13f79535-47bb-0310-9956-ffa450edef68
2015-01-22 16:28:14 +00:00
Jacques Le Roux 53ccd2ceb7 Fixes "Overview of routings does not paginate" https://issues.apache.org/jira/browse/OFBIZ-5322 and more
Actually it does paginate but the value is not dependent on widget property widget.form.defaultViewSize which default value is 20. It uses a default value of 50 which is defined by

<set field="viewSize" from-field="parameters.VIEW_SIZE" type="Integer" default-value="3"/>

You can easily test it using https://localhost:8443/manufacturing/control/FindRouting?VIEW_SIZE=3

This is legacy from pre Apache era. I found 143 cases where a default-value is defined in screens for VIEW_SIZE.

I did not look into details for the 143 cases but I believe most are also legacy.
There are few default values: 10, 20, 30, 50, 500 and even an extreme case of 10000 for InventoryItemTotalsExport!
There is only one comment for LookupBulkAddProducts which is also legacy: <!-- 10 rows seems more appropriate given screen size, etc. -->

I suggest to OOTB replace all those by the widget.form.defaultViewSize value.
Things will then be consistent and easily changeable on a global scale using the widget property.
Or if really needed forcing the default-value as it's done now.

So this would be applied on the 143 cases (I checked, viewSizeDefaultValue does not exist in any screen)

<property-to-field resource="widget" property="widget.form.defaultViewSize" field="viewSizeDefaultValue"/>
<set field="viewSize" from-field="parameters.VIEW_SIZE" type="Integer" default-value="${viewSizeDefaultValue}"/>

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1526387 13f79535-47bb-0310-9956-ffa450edef68
2013-09-26 05:55:32 +00:00
Jacques Le Roux 3369dca046 Replaces title="${uiLabelMap.CommonEmptyHeader}" by title=" " where it's known to not be a problem. Here with links styled by widget-style="buttontext"
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1340373 13f79535-47bb-0310-9956-ffa450edef68
2012-05-19 08:45:18 +00:00
Hans Bakker 80fc19704c more forms files which were emptied with the recent renaming attempt
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1160971 13f79535-47bb-0310-9956-ffa450edef68
2011-08-24 03:34:18 +00:00
Vikas Mayur 153203cd03 Moved form widgets from webapp to widget folder. Contribution from Deepak Dixit.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1160233 13f79535-47bb-0310-9956-ffa450edef68
2011-08-22 12:14:25 +00:00
Vikas Mayur a9372fbb65 Reverted r1160209 & r1160213 as the files aren't moved correctly.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1160226 13f79535-47bb-0310-9956-ffa450edef68
2011-08-22 12:03:21 +00:00
Vikas Mayur d6f433a5e1 Moved form widgets from webapp to widget folder. Contribution from Deepak Dixit.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1160209 13f79535-47bb-0310-9956-ffa450edef68
2011-08-22 11:30:31 +00:00
Adam Heath ac2299c50e Fix a bunch of no final newline issues.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@965918 13f79535-47bb-0310-9956-ffa450edef68
2010-07-20 17:15:21 +00:00
Bruno Busco 1e39c7bd92 Part of OFBIZ-3067 - Menus and form widget files location
Content component
Moved menus from webapp to widget folder


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@828872 13f79535-47bb-0310-9956-ffa450edef68
2009-10-22 22:18:00 +00:00
Bruno Busco c30c24b95c Changed <container style="screenlet"> pattern to <screenlet...>.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@826269 13f79535-47bb-0310-9956-ffa450edef68
2009-10-17 15:11:32 +00:00
Jacopo Cappellato 05261bc552 Fix to make the "Clone Layout" button to work again after recent security refactoring.
NB: the error was caused by the wrong way in which the link with parameters (that are now rendered as forms to post the parameters in a secure way) was implemented in the content application: it was a field of a form causing a nested <form> element in html. Unfortunately this pattern is used in other screens in the content application and sooner or later we will have to fix them in a similar way.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@783000 13f79535-47bb-0310-9956-ffa450edef68
2009-06-09 13:52:30 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Jacques Le Roux ef0137f95b Securing URLs, link element in screens and menus : 26th set + tabs to 4 spaces
We continue to approach the end... But for some exceptions, more than the 2 I found before. I will write a compilation on dev ML at end

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@761261 13f79535-47bb-0310-9956-ffa450edef68
2009-04-02 12:14:18 +00:00
Jacques Le Roux 2ac0493ee6 Securing URLs, link element in screens and menus : 20th set + tabs to 4 spaces
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@761205 13f79535-47bb-0310-9956-ffa450edef68
2009-04-02 08:39:10 +00:00
Marco Risaliti a68519cc0b Artifact cleaning on content component after recent changes on xsd files (OFBIZ-2137)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739777 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 15:16:33 +00:00
Jacques Le Roux 290534059d <entity-one entity-name=(.*)value-name => <entity-one entity-name=$1value-field
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739732 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 10:27:43 +00:00
Jacques Le Roux f09724ea75 An enhancing patch from Bruno Busco "Using screenlets in Content Application" (https://issues.apache.org/jira/browse/OFBIZ-1881) - OFBIZ-1881
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@680088 13f79535-47bb-0310-9956-ffa450edef68
2008-07-27 10:41:47 +00:00
Marco Risaliti bf65b1ad7a Converted some content bsh scripts to groovy (Part of issue OFBIZ-1801)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@667666 13f79535-47bb-0310-9956-ffa450edef68
2008-06-13 22:02:46 +00:00
Adrian Crum 68c1dbbaf9 Second sweep through the maincss.css style sheet. Changed the head1, head2, and head3 style names to h1, h2, and h3. Updated affected styles in ftl and xml files.
The ecommerce component is excluded from this commit.

These changes shouldn't break any layout. If you spot something wrong, let me know and I'll fix it.

I won't make any more maincss.css changes for a little while. I'll let the dust settle from these two commits, then I'll go through the file and physically remove the deprecated styles.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@627051 13f79535-47bb-0310-9956-ffa450edef68
2008-02-12 19:30:09 +00:00
Marco Risaliti 3c764b0f22 CMS/Content Setup/Data Setup/Layout/CompDoc/Data Resouces forms (ftl/widgets screen) has now the same look and feel (Part of issue OFBIZ-1601)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@617713 13f79535-47bb-0310-9956-ffa450edef68
2008-02-01 23:56:39 +00:00
David E. Jones 7d70c41c12 Did a big search/replace to change all xsd file refs from www.ofbiz.org to ofbiz.apache.org
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@539504 13f79535-47bb-0310-9956-ffa450edef68
2007-05-18 15:47:14 +00:00
Jacques Le Roux dad67935f7 A (large) patch from Scott Gray "Update ASL header" (https://issues.apache.org/jira/browse/OFBIZ-637).
I put also some svn:ignore for shark build and lib diretories and assetmaint/build 

I did some by hand lately, too much to remember. They were files with old header but without copyright. A 1st attempt I suppose, will have to check this after this commit.

I add some problems to commit this patch in one piece because it's so huge (specially with Eclipse I had to turn to Tortoise) !

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@499486 13f79535-47bb-0310-9956-ffa450edef68
2007-01-24 17:15:54 +00:00
Jacopo Cappellato 669220064e Fixed content permission errors: OFBIZ-526
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@484960 13f79535-47bb-0310-9956-ffa450edef68
2006-12-09 10:04:29 +00:00
Jacopo Cappellato 90cf9dc17e Converted the lasr JPublish pages... now JPublish is completely gone!
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@479154 13f79535-47bb-0310-9956-ffa450edef68
2006-11-25 17:52:10 +00:00
Jacopo Cappellato 1aac5b5b1b A bunch of cleanups for the Content component and one more JPublish page converted to screen widget.
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@479140 13f79535-47bb-0310-9956-ffa450edef68
2006-11-25 16:17:54 +00:00
Jacopo Cappellato a4b55df77f Removed other unused content's resources.
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@472496 13f79535-47bb-0310-9956-ffa450edef68
2006-11-08 13:55:12 +00:00
Jacopo Cappellato c762436af5 New Files needed by the new screens.
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@471378 13f79535-47bb-0310-9956-ffa450edef68
2006-11-05 08:28:19 +00:00