Commit Graph
89 Commits
Author SHA1 Message Date
Jacques Le Roux 432c7bde98 Fixed: Use from-field pattern instead of value=${***} pattern in 'set' element (OFBIZ-9607)
Fixes a syntax issue spotted while testing FreeMarker 2.3.31
2021-02-13 18:12:00 +01:00
Michael Brohl e4e32a1a64 Improved: Styles some clickable fields of backend tables as buttons.
(OFBIZ-11309)

Thanks Ulrich Heidfeld for reporting and providing the patch, James Yong
for additional review.
2020-03-18 08:05:00 +01:00
Jacopo Cappellato 9b5aad637c [Fixed]: Added permission checks to three blog/forum services; improved the
configuration for the "add article forum" form (the source tab is not needed in 
the ecommerce application).

Fixes CVE-2019-10073

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1858432 13f79535-47bb-0310-9956-ffa450edef68
2019-04-30 14:25:13 +00:00
Jacques Le Roux 67bb8465e8 Fixed: Content - Able to add empty Forum Group
(OFBIZ-10615)

Steps to Regenerate issue:
 # Login to demo-trunk or demo-stable instance with details:
URL - [https://demo-trunk.ofbiz.apache.org/content/control/findForumGroups] 
admin/ ofbiz  OR
URl - [https://demo-stable.ofbiz.apache.org/content/control/createForumGroup]
admin/ ofbiz
 # Go to Content > Forum and try to create new forum group.
 # do not enter Forum Group Name and Description.
 # Click on the Submit button.

Actual - System allowed the user to enter an empty forum group. 
This issue is occurring at demo-trunk and demo-stable instance. 

Expected - Empty Forum group should not be added. If the user tries to do this
s/he should not be allowed and proper validation error message should display.

Thanks: Sanjay Yadav

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1846214 13f79535-47bb-0310-9956-ffa450edef68
2018-11-09 08:11:46 +00:00
Deepak Dixit 29461cdc47 Fixed: Found some more vlaue=dollor pattern in set element.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806329 13f79535-47bb-0310-9956-ffa450edef68
2017-08-26 20:33:37 +00:00
Deepak Dixit 1a7aee6685 Improved:Use from-field pattern instead of value=dollor pattern in 'set' element
Apply slightly modified patch from jira issue, fixed some typo (OFBIZ-9607)
Thanks Suraj Khurana and Rohit Rai for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806326 13f79535-47bb-0310-9956-ffa450edef68
2017-08-26 20:23:40 +00:00
Jacques Le Roux 68c8bcd028 Implemented: Special characters displays in From Date UI label field in forum
screen
Improved:
(OFBIZ-7850)

1. Go to Find Forum group list page 
    https://localhost:8443/content/control/findForumGroups
2. Select one of the Forum from the available forum list.
3. On this Forum Group page, In Add Forum and List Forums section, the UI label 
	From Date Time displayed "From Date & Time", it should be corrected to 
	display From Date Time.

jleroux: patch obsolete, I had to change things by hand

Thanks: Gopal Yadav

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1791473 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 08:52:59 +00:00
Deepak Dixit d09255c0b7 Reverted: Minilang code readability and consistency improvements done at r#1768222, this commit reversed key and description of drop-down in the code.
(OFBIZ-9114)

Thanks  Wei Zhang for reporting the issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772880 13f79535-47bb-0310-9956-ffa450edef68
2016-12-06 12:37:42 +00:00
Divesh Dutta 70eb7ff508 Improvement: Minilang code readability and consistency improvements.
(OFBIZ-8929) (OFBIZ-8930) (OFBIZ-8953) (OFBIZ-8965) (OFBIZ-8972) (OFBIZ-8986) (OFBIZ-8991) 

Thanks: Ankush Upadhyay, Anuj Jain, Abhijeet for your patches. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768222 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:34:00 +00:00
Divesh Dutta 738a12bec1 Improvement: Miniland code readability and consistency improvements
(OFBIZ-8744) (OFBIZ-8745) (OFBIZ-8746) (OFBIZ-8748) (OFBIZ-8829) (OFBIZ-8830) (OFBIZ-8907) (OFBIZ-8908) (OFBIZ-8924) (OFBIZ-8925) 

Thanks: Ankush Upadhyay , Sega patidar , Abhijeet Ashapure for your patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768219 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:14:04 +00:00
Divesh Dutta 556279917d Improved:Display from date with default to now timestamp and also add asterisk sign to all the forms where it is part of primary key in all the components.
(OFBIZ-7650) (OFBIZ-7651) (OFBIZ-7653) (OFBIZ-7660) (OFBIZ-7662) (OFBIZ-7665) (OFBIZ-7666) (OFBIZ-8028)(OFBIZ-8029) (OFBIZ-8255)

Thanks: Anuj Jain and Ratnesh for the pathes and Swapnil Shah for reporting the issues.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761192 13f79535-47bb-0310-9956-ffa450edef68
2016-09-17 11:02:39 +00:00
Pranay Pandey 97b5e976dc [OFBIZ-7554] Fixed issues with Forum Screens Delete and Update buttons.
Issues fixed are:
- Forum list on Forum Group View
-- Delete button is not showing up and working.
-- Update button is not working.
- Forum Group Roles
-- Delete button is not showing up and working.
- Messages for Forum View
-- Delete button is not showing up and working.
-- Update button is not working.

Thanks Mohammed Rehan Khan for reporting the issue and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750624 13f79535-47bb-0310-9956-ffa450edef68
2016-06-29 12:34:35 +00:00
Jacques Le Roux c8ba932772 Fixes a "typo" in last commit for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
We used targetNamespace (should only be used in schema) instead of xsi:schemaLocation



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749634 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 05:58:26 +00:00
Jacques Le Roux 89212904bd Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
This is the 2nd step: puts back the original names, so it will be transparent for remaining references in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749489 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:37:47 +00:00
Jacques Le Roux 4931db1ed9 Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061 by replacing xsd files references in xml files by -ns.xsd files and removing the concerned xsd files
This is a 1st step, in a 2nd I will put back the original names, so it will be transparent for remaining reference in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749488 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:14:16 +00:00
Nicolas Malin 895c9856b3 Cleaning forms code is needed after setting default-value in list-options and entity-options, patch related to OFBIZ-6524 and follows the resolution of OFBIZ-6490 and OFBIZ-6489. Thanks Gil Portenseigne for this effort
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1686674 13f79535-47bb-0310-9956-ffa450edef68
2015-06-20 21:58:05 +00:00
Jacques Le Roux 5c7f0b1fcb This closes "Replace bsh code with Groovy code" https://issues.apache.org/jira/browse/OFBIZ-6332 with all its subtasks and more.
jleroux: I suspected it was only a matter of replacing "${bsh" by "${groovy" in *.xml. But I had not the guts to get into 11(!) sub tasks. 
So, in Eclipse, I simply did a S/R in *.xml and compared parts of my changes with some Pierre's most "complex" patches respectively product, ebaystore, projectmgr and scrum. 
They were totally similar (just revisions number changed) so here is the whole. 

I will later improve these changes by removing HTML entities when possible, this is a bit more delicate because in some cases the XML schema are not complete (or/and for other still obscure to me reasons) and if you simply replace HTML entities by simple code (eg &Amp; by &) you get issues in logs when the XML parser cross them...

Note: only menus, screen and forms are changed here.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1682118 13f79535-47bb-0310-9956-ffa450edef68
2015-05-27 20:39:43 +00:00
Adrian Crum 888b7c08cc Fix for rev 1649090. In that rev I removed the hard-coded Content default entity, but that broke trees that didn't specify Content as their default entity. This commit specifies the Content entity in the Content tree definitions.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1649222 13f79535-47bb-0310-9956-ffa450edef68
2015-01-03 17:30:50 +00:00
Jacopo Cappellato 47cc76394c OFBIZ-4908 Added missing target attribute from form definition that was preventing the update to work: thanks to Harsha Chadhar for the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1461551 13f79535-47bb-0310-9956-ffa450edef68
2013-03-27 12:48:45 +00:00
Jacques Le Roux 3e7b774156 Adrian suggested to removes all default-tooltip-style="tabletext": <<That style was removed from the stylesheet in 2007. All references to it should be removed.>>
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1340387 13f79535-47bb-0310-9956-ffa450edef68
2012-05-19 09:37:35 +00:00
Jacques Le Roux 9ee7384202 Adrian suggested to removes all widget-style="tabletext": <<That style was removed from the stylesheet in 2007. All references to it should be removed.>>
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1340385 13f79535-47bb-0310-9956-ffa450edef68
2012-05-19 09:32:48 +00:00
Hans Bakker 3420b210a6 move blog labels from ecommerce to content and use them from there.....
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1190180 13f79535-47bb-0310-9956-ffa450edef68
2011-10-28 07:17:34 +00:00
Scott Gray 0a3eee807a Remove position attributes from FindForumMessages form, gets the layout back to normal
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1137315 13f79535-47bb-0310-9956-ffa450edef68
2011-06-19 09:03:53 +00:00
Jacques Le Roux 24fe5ff37e Merges the jQuery branch back to the trunk
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1044503 13f79535-47bb-0310-9956-ffa450edef68
2010-12-10 20:40:08 +00:00
Hans Bakker 46d74a9789 replacing an empty blog summary with text did not work and moving labels from ecommerce to content because used in both components
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1036332 13f79535-47bb-0310-9956-ffa450edef68
2010-11-18 07:28:45 +00:00
Hans Bakker 73344a5802 blog summary could not be updated, in the same process move the editarticle form from ecommerce to content because also used there.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1036329 13f79535-47bb-0310-9956-ffa450edef68
2010-11-18 06:29:25 +00:00
Hans Bakker f04c360b32 article not showing in summary, corrected misplaced pagetitle
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1027370 13f79535-47bb-0310-9956-ffa450edef68
2010-10-26 05:57:28 +00:00
Adam Heath ac2299c50e Fix a bunch of no final newline issues.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@965918 13f79535-47bb-0310-9956-ffa450edef68
2010-07-20 17:15:21 +00:00
Bruno Busco 964588402b Content and Humanres component
Moved TabBar Menus from the "body" decorator-section to the "pre-body" decorator section.
This makes better the rendering of themes such as Dropping Crumbs.

Removed several redundant <section><widget> tags also

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883769 13f79535-47bb-0310-9956-ffa450edef68
2009-11-24 16:30:31 +00:00
Bruno Busco c30c24b95c Changed <container style="screenlet"> pattern to <screenlet...>.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@826269 13f79535-47bb-0310-9956-ffa450edef68
2009-10-17 15:11:32 +00:00
Jacques Le Roux b7a941d4f6 Revert r813307 on Adrian's request
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@813893 13f79535-47bb-0310-9956-ffa450edef68
2009-09-11 16:02:01 +00:00
Jacques Le Roux a7430a2fc2 A modified patch from Erwan de FERRIERES '"Automatic" sortable table headers" (https://issues.apache.org/jira/browse/OFBIZ-2921) - OFBIZ-2921
I was planning to wait longer, but I can't wait more. I have added a lot of small trivial changes in this patch and they are blocking me to go further on other issues...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@813307 13f79535-47bb-0310-9956-ffa450edef68
2009-09-10 08:41:19 +00:00
Jacques Le Roux 999bd7c577 Fix following Chris Howe's message in dev ML
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@764195 13f79535-47bb-0310-9956-ffa450edef68
2009-04-11 13:00:24 +00:00
Jacques Le Roux c1e68e9eda A patch from Divesh Dutta "Some errors and bugs coming on console" https://issues.apache.org/jira/browse/OFBIZ-2280
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763195 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 11:48:42 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Jacques Le Roux 32afd66679 I'm a bit fussy about details, but this has already proven to be useful, weird formating never...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@762853 13f79535-47bb-0310-9956-ffa450edef68
2009-04-07 17:03:35 +00:00
Vikas Mayur 82578372ef Fixed error in accessing Label Manager as elements in menu file were not placed correctly.
Applied patch from jira issue OFBIZ-2277 (https://issues.apache.org/jira/browse/OFBIZ-2277)
Thanks Arun Patidar for reporting and Divesh Dutta for the fix.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@762790 13f79535-47bb-0310-9956-ffa450edef68
2009-04-07 14:27:31 +00:00
Jacques Le Roux a5042291f7 1st part of an effort to remove trailing spaces
" +/> => "/>
Should be easier when dealing with Eclipse S/R regexp

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@762648 13f79535-47bb-0310-9956-ffa450edef68
2009-04-07 08:27:15 +00:00
Jacques Le Roux 76f5ca6638 Secure URLs, we don't need to duplicate in from-field when param-name is the same
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@762215 13f79535-47bb-0310-9956-ffa450edef68
2009-04-06 06:25:24 +00:00
Jacques Le Roux bc1afdfb39 Securing URLs, link element in screens and menus : 25th set + tabs to 4 spaces
We are near the end...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@761240 13f79535-47bb-0310-9956-ffa450edef68
2009-04-02 10:31:49 +00:00
Jacques Le Roux 76352e305a Securing URLs, link element in screens and menus : 24th set + tabs to 4 spaces
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@761238 13f79535-47bb-0310-9956-ffa450edef68
2009-04-02 10:27:18 +00:00
Jacques Le Roux ca876f93ce Securing URLs, link element in screens and menus : 11th set + tabs to 4 spaces
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@760789 13f79535-47bb-0310-9956-ffa450edef68
2009-04-01 06:16:07 +00:00
Jacques Le Roux 40f5281303 20th set of changes explained in https://issues.apache.org/jira/browse/OFBIZ-2243
In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759680 13f79535-47bb-0310-9956-ffa450edef68
2009-03-29 13:33:53 +00:00
Jacques Le Roux bb2d8d5bad 19th set of changes explained in https://issues.apache.org/jira/browse/OFBIZ-2243
In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759667 13f79535-47bb-0310-9956-ffa450edef68
2009-03-29 11:14:57 +00:00
Jacques Le Roux 8c6d89fe75 18th set of changes explained in https://issues.apache.org/jira/browse/OFBIZ-2243
In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements

This one is huge, with some changes by hand, conversion from tabs to 4 spaces and some trailing spaces (I have activated it AnyEdit plugin following the changes I made in http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions but I wonder if I should not reverse all that - I mean my plugin setting and in wiki -, it's a nightmare!)

I did my best on this one, but I'm not sure some typos did not slip in. Anyway, alea jacta est


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759666 13f79535-47bb-0310-9956-ffa450edef68
2009-03-29 11:00:00 +00:00
Jacques Le Roux c2bc362e09 A last bunch of typos
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759612 13f79535-47bb-0310-9956-ffa450edef68
2009-03-28 22:52:07 +00:00
Jacques Le Roux b1766aaa8c Fix some bad changes in previous commit (hyperlinks related)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759605 13f79535-47bb-0310-9956-ffa450edef68
2009-03-28 22:06:23 +00:00
Jacques Le Roux 3fe66ef254 tabs to 4 spaces
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759574 13f79535-47bb-0310-9956-ffa450edef68
2009-03-28 20:13:03 +00:00
Jacques Le Roux e75524ac5b Fix some bad changes in previous commit
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759572 13f79535-47bb-0310-9956-ffa450edef68
2009-03-28 20:11:02 +00:00
Jacques Le Roux 0a55248195 14th set of changes explained in https://issues.apache.org/jira/browse/OFBIZ-2243
In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759565 13f79535-47bb-0310-9956-ffa450edef68
2009-03-28 20:01:04 +00:00