This reverts commit 17eb2e4cf7.
It does not work when using <<target="javascript:........>>
I could change those cases but it's easier and safer to simply revert back to
target-type!
Thanks: James for report
(OFBIZ-11376)
I could not find any references for this service in the code base, i.e. this
service has not been used anywhere, do we still want to keep it?
Thanks: Devanshu Vyas for report, Priya Sharma for the proposition and the fix
(OFBIZ-9644)
I found various instances where the mimeTypeId is displayed in HTML
encoded pattern over UI.
jleroux: this also removes 2 duplicated fields in AddLayout form
Thanks: Ankit Joshi
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806951 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9644)
I found various instances where the mimeTypeId is displayed in HTML
encoded pattern over UI.
jleroux: this also removes 2 duplicated fields in AddLayout form
Thanks: Ankit Joshi
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806947 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8046)
Change all form names to upper camel case for consistency.
Thanks: Tanmay Muley for reporting and providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761079 13f79535-47bb-0310-9956-ffa450edef68
This is the 2nd step: puts back the original names, so it will be transparent for remaining references in xml catalogs, Java code, etc.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749489 13f79535-47bb-0310-9956-ffa450edef68
This is a 1st step, in a 2nd I will put back the original names, so it will be transparent for remaining reference in xml catalogs, Java code, etc.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749488 13f79535-47bb-0310-9956-ffa450edef68
In this way it will be easier to compare the ootb Lucene integration with custom ones (based on Lucene/Solr/etc...) and to switch between them.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1518925 13f79535-47bb-0310-9956-ffa450edef68
Sascha: There are some more issues in the groovy file
In entity field [ContentAssoc.fromDate] set the value passed in [java.lang.String] is not compatible with the Java type of the field [java.sql.Timestamp]
I'm not quite sure why this is going wrong. Maybe we have to explicitly create an Timestamp here.
DataResourceWorker.getDataResourceTextCache(dataResource, "text/html", Locale.getDefault(), templateRoot, delegator);
should be replaced with
DataResourceWorker.getDataResourceText(dataResource, "text/html", Locale.getDefault(), templateRoot, delegator, true);
JLR: this patch allows now to create a content from CMSContentFind but I'm not quire sure all is resolved. I jave also set the fromDate field in the calling screen as Timestamp type, not sure it's needed but it can't hurt. Nevertheless I think there are still some issues. But at least now it does not break
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1060744 13f79535-47bb-0310-9956-ffa450edef68
OFBIZ-3611 - XHTML validation errors (content)
XHTML validation errors
- Unclosed INPUT
- attributes without values (checked, selected, disabled, etc)
- attribute values without "
- Uppercase tags or attributes.
- Unencoded ampersands in urls.
Other errors:
AdminSearch.ftl (this template has several markup errors and it should be reviewed)
Wrong markup at line 32. Duplicated TR
<tr>
Wrong markup at line 49. Table directly inside tr, needs td. Also wrong attribute name wdith should be width.
<table border="0" wdith="100%">
Wrong markup at line 112. Unclosed previous table and td
<td width="20%" align="right">
CMSSites.ftl
Wrong attribute name at lines 42,66, 154, 211. mode should be method
mode="POST"
Lacks needed type attribute at lines 19, 265.
<SCRIPT language="javascript">
UserPermissions.ftl
Wrong attribute name at lines 60, 81. mode should be method
mode="POST"
Lacks needed type attribute at lines 19 .
<SCRIPT language="javascript">
Wrong markup at lines 115 to 120. Those closing tags have no matching open tags.
</td>
</tr>
</table>
</td>
</tr>
</table>
CMSMenus.xml
Duplicated id value "dflt" at lines 32,38,43
<link id="dflt"
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@929257 13f79535-47bb-0310-9956-ffa450edef68
This allows themes to style these buttons with additional "+" icons or whatever.
The idea is to add a "functional" class wherever needed so that the button-bar can be styled better by the theme.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@899899 13f79535-47bb-0310-9956-ffa450edef68
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)
Of course this effort to remove trailing spaces has no functional implications.
Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {
So these changes are also in this commit, should not be a problem anyway.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68