Commit Graph
68 Commits
Author SHA1 Message Date
Jacques Le Roux ec2b84341e Reverted: "Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)"
This reverts commit 17eb2e4cf7.

It does not work when using <<target="javascript:........>>
I could change those cases but it's easier and safer to simply revert back to
target-type!

Thanks: James for report
2020-12-18 11:08:32 +01:00
Jacques Le Roux 17eb2e4cf7 Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)
Same for sub-hyperlink
2020-12-11 16:52:04 +01:00
James Yong 2c62637752 Improved: Apply multi-block attr to each application (OFBIZ-11706)
For Accounting, Content, HR, Manufacturing.
2020-05-15 17:43:38 +08:00
Michael Brohl e4e32a1a64 Improved: Styles some clickable fields of backend tables as buttons.
(OFBIZ-11309)

Thanks Ulrich Heidfeld for reporting and providing the patch, James Yong
for additional review.
2020-03-18 08:05:00 +01:00
Jacques Le Roux d003807154 Improved: Remove createTopic service (unused)
(OFBIZ-11376)

I could not find any references for this service in the code base, i.e. this
service has not been used anywhere, do we still want to keep it?

Thanks: Devanshu Vyas for report, Priya Sharma for the proposition and the fix
2020-02-26 10:00:33 +01:00
Deepak Dixit 49fadbf68b Improved: Standardise Layout throughout Applications
(OFBIZ-10242)
This fix the content and marketing component layout
Thanks Dennis Balkir for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1828917 13f79535-47bb-0310-9956-ffa450edef68
2018-04-11 18:15:02 +00:00
Jacques Le Roux 8cdb6010a1 Fixed: Fix references where Mime type is displayed in HTML encoded pattern
(OFBIZ-9644)

I found various instances where the mimeTypeId is displayed in HTML 
encoded pattern over UI.

jleroux: this also removes 2 duplicated fields in AddLayout form

Thanks: Ankit Joshi

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806951 13f79535-47bb-0310-9956-ffa450edef68
2017-09-01 12:49:04 +00:00
Jacques Le Roux 83d0294118 Reverts revision: 1806947, changes in UserEvents.xml inadvertently slipped in
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806948 13f79535-47bb-0310-9956-ffa450edef68
2017-09-01 12:42:11 +00:00
Jacques Le Roux 7be7ad6179 Fixed: Fix references where Mime type is displayed in HTML encoded pattern
(OFBIZ-9644)

I found various instances where the mimeTypeId is displayed in HTML 
encoded pattern over UI.

jleroux: this also removes 2 duplicated fields in AddLayout form

Thanks: Ankit Joshi

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806947 13f79535-47bb-0310-9956-ffa450edef68
2017-09-01 12:38:47 +00:00
Deepak Dixit d09255c0b7 Reverted: Minilang code readability and consistency improvements done at r#1768222, this commit reversed key and description of drop-down in the code.
(OFBIZ-9114)

Thanks  Wei Zhang for reporting the issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772880 13f79535-47bb-0310-9956-ffa450edef68
2016-12-06 12:37:42 +00:00
Deepak Dixit d415614fbf Improved: Consitent menu bar in following screens decorator:
- Feature Category
- Product Store  
- DataResource
- Template
- CMS Content

(OFBIZ-8187)(OFBIZ-8186)(OFBIZ-8185)(OFBIZ-8184)(OFBIZ-8183)

Thanks Avnindra Sharma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768267 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 18:26:40 +00:00
Divesh Dutta 70eb7ff508 Improvement: Minilang code readability and consistency improvements.
(OFBIZ-8929) (OFBIZ-8930) (OFBIZ-8953) (OFBIZ-8965) (OFBIZ-8972) (OFBIZ-8986) (OFBIZ-8991) 

Thanks: Ankush Upadhyay, Anuj Jain, Abhijeet for your patches. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768222 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:34:00 +00:00
Divesh Dutta 738a12bec1 Improvement: Miniland code readability and consistency improvements
(OFBIZ-8744) (OFBIZ-8745) (OFBIZ-8746) (OFBIZ-8748) (OFBIZ-8829) (OFBIZ-8830) (OFBIZ-8907) (OFBIZ-8908) (OFBIZ-8924) (OFBIZ-8925) 

Thanks: Ankush Upadhyay , Sega patidar , Abhijeet Ashapure for your patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768219 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:14:04 +00:00
Divesh Dutta 85ce444748 Improvement: Minilang code readibility and conistency improvements
(OFBIZ-8445) (OFBIZ-8447) (OFBIZ-8448) (OFBIZ-8450) ( OFBIZ-8451) (OFBIZ-8653) (OFBIZ-8740) (OFBIZ-8741) (OFBIZ-8742) (OFBIZ-8743)

Thanks: Devanshu Vyas, Anuj Jain, Sega Patidar, Abhijeet Ashapure for your patches

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768209 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 12:41:35 +00:00
Michael Brohl 6c8a33ff2c Improved: Content: Consistent form name.
(OFBIZ-8046)

Change all form names to upper camel case for consistency.

Thanks: Tanmay Muley for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761079 13f79535-47bb-0310-9956-ffa450edef68
2016-09-16 20:37:43 +00:00
Jacques Le Roux c8ba932772 Fixes a "typo" in last commit for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
We used targetNamespace (should only be used in schema) instead of xsi:schemaLocation



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749634 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 05:58:26 +00:00
Jacques Le Roux 89212904bd Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
This is the 2nd step: puts back the original names, so it will be transparent for remaining references in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749489 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:37:47 +00:00
Jacques Le Roux 4931db1ed9 Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061 by replacing xsd files references in xml files by -ns.xsd files and removing the concerned xsd files
This is a 1st step, in a 2nd I will put back the original names, so it will be transparent for remaining reference in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749488 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:14:16 +00:00
Deepak Dixit 25b56a03ea (OFBIZ-7223) Relocate .groovy files in the content component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747756 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 17:21:10 +00:00
Deepak Dixit 84ad66589e (OFBIZ-7021) Renamed content component ftl file name from lower case to upper case pattern.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1742457 13f79535-47bb-0310-9956-ffa450edef68
2016-05-05 18:11:54 +00:00
Deepak Dixit cee0263cef (OFBIZ-6815) relocate .ftl files in the content component
Thanks Pierre for your contribution.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1740446 13f79535-47bb-0310-9956-ffa450edef68
2016-04-22 06:12:08 +00:00
Nicolas Malin 895c9856b3 Cleaning forms code is needed after setting default-value in list-options and entity-options, patch related to OFBIZ-6524 and follows the resolution of OFBIZ-6490 and OFBIZ-6489. Thanks Gil Portenseigne for this effort
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1686674 13f79535-47bb-0310-9956-ffa450edef68
2015-06-20 21:58:05 +00:00
Ashish Vijaywargiya ed26dd4dc4 Applied patch from jira issue OFBIZ-4946 - Getting error when uploading a file after creating a data resource.
Thanks Ashish Ambulkar for creating the issue. Thanks Arun, Jacques for providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1646984 13f79535-47bb-0310-9956-ffa450edef68
2014-12-20 14:22:50 +00:00
Ashish Vijaywargiya b889daf058 Applied patch from jira issue - OFBIZ-4362 - MapKey for CMS content cannot be updated.
Thanks Manuela for reporting the bug, Thanks Deepak for providing the patch for this issue. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1639867 13f79535-47bb-0310-9956-ffa450edef68
2014-11-15 12:19:44 +00:00
Jacopo Cappellato 6071e8d8e0 Extracted from the OFBiz content component the dependencies on Lucene and created a new specialpurpose/lucene component in order to simplify the integration of components based on Lucene/Solr and to simplify the management of conflicts caused by different versions of Solr/Lucene jars.
In this way it will be easier to compare the ootb Lucene integration with custom ones (based on Lucene/Solr/etc...) and to switch between them.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1518925 13f79535-47bb-0310-9956-ffa450edef68
2013-08-30 09:45:33 +00:00
Jacques Le Roux 720578ecf3 Replaces all remaining title="${uiLabelMap.CommonEmptyHeader}" by title=" ", and specific case in ListPartyCommEvents
This closes the CommonEmptyHeader chapter

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1343016 13f79535-47bb-0310-9956-ffa450edef68
2012-05-27 08:41:47 +00:00
Jacques Le Roux b4cc50a2ac Adrian suggested to removes all style="tabletext": <<That style was removed from the stylesheet in 2007. All references to it should be removed.>>
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1340389 13f79535-47bb-0310-9956-ffa450edef68
2012-05-19 09:39:47 +00:00
Jacques Le Roux 3369dca046 Replaces title="${uiLabelMap.CommonEmptyHeader}" by title=" " where it's known to not be a problem. Here with links styled by widget-style="buttontext"
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1340373 13f79535-47bb-0310-9956-ffa450edef68
2012-05-19 08:45:18 +00:00
Erwan de Ferrieres a7eaf555b8 moving GetMenuContext.groovy to its right location with the other groovy scripts
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1327181 13f79535-47bb-0310-9956-ffa450edef68
2012-04-17 17:00:59 +00:00
Hans Bakker 80fc19704c more forms files which were emptied with the recent renaming attempt
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1160971 13f79535-47bb-0310-9956-ffa450edef68
2011-08-24 03:34:18 +00:00
Vikas Mayur 153203cd03 Moved form widgets from webapp to widget folder. Contribution from Deepak Dixit.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1160233 13f79535-47bb-0310-9956-ffa450edef68
2011-08-22 12:14:25 +00:00
Vikas Mayur a9372fbb65 Reverted r1160209 & r1160213 as the files aren't moved correctly.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1160226 13f79535-47bb-0310-9956-ffa450edef68
2011-08-22 12:03:21 +00:00
Vikas Mayur d6f433a5e1 Moved form widgets from webapp to widget folder. Contribution from Deepak Dixit.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1160209 13f79535-47bb-0310-9956-ffa450edef68
2011-08-22 11:30:31 +00:00
Jacques Le Roux 07bebdaea7 A slightly modified patch from Sascha "In Content Manager's CMS sub-module CMSContentFind page doesn't show the content list." (https://issues.apache.org/jira/browse/OFBIZ-2746) - OFBIZ-2746
Sascha: There are some more issues in the groovy file
In entity field [ContentAssoc.fromDate] set the value passed in [java.lang.String] is not compatible with the Java type of the field [java.sql.Timestamp]
I'm not quite sure why this is going wrong. Maybe we have to explicitly create an Timestamp here.
DataResourceWorker.getDataResourceTextCache(dataResource, "text/html", Locale.getDefault(), templateRoot, delegator);
should be replaced with
DataResourceWorker.getDataResourceText(dataResource, "text/html", Locale.getDefault(), templateRoot, delegator, true);

JLR: this patch allows now to create a content from CMSContentFind but I'm not quire sure all is resolved. I jave also set the fromDate field in the calling screen as Timestamp type, not sure it's needed but it can't hurt. Nevertheless I think there are still some issues. But at least now it does not break



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1060744 13f79535-47bb-0310-9956-ffa450edef68
2011-01-19 10:28:01 +00:00
Bruno Busco 8c3b694494 A patch from Blas Rodriguez Somoza
OFBIZ-3611 - XHTML validation errors (content)
XHTML validation errors
- Unclosed INPUT
- attributes without values (checked, selected, disabled, etc)
- attribute values without "
- Uppercase tags or attributes.
- Unencoded ampersands in urls.

Other errors:

AdminSearch.ftl (this template has several markup errors and it should be reviewed)
Wrong markup at line 32. Duplicated TR
<tr>
Wrong markup at line 49. Table directly inside tr, needs td. Also wrong attribute name wdith should be width.
<table border="0" wdith="100%">
Wrong markup at line 112. Unclosed previous table and td
<td width="20%" align="right">

CMSSites.ftl
Wrong attribute name at lines 42,66, 154, 211. mode should be method
mode="POST"
Lacks needed type attribute at lines 19, 265.
<SCRIPT language="javascript">

UserPermissions.ftl
Wrong attribute name at lines 60, 81. mode should be method
mode="POST"
Lacks needed type attribute at lines 19 .
<SCRIPT language="javascript">
Wrong markup at lines 115 to 120. Those closing tags have no matching open tags.
</td>
</tr>
</table>
</td>
</tr>
</table>

CMSMenus.xml
Duplicated id value "dflt" at lines 32,38,43
<link id="dflt"

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@929257 13f79535-47bb-0310-9956-ffa450edef68
2010-03-30 20:28:48 +00:00
Bruno Busco 11c1256111 Added a "create" class to the buttontext for buttons that represents "Create New" operations.
This allows themes to style these buttons with additional "+" icons or whatever.
The idea is to add a "functional" class wherever needed so that the button-bar can be styled better by the theme.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@899899 13f79535-47bb-0310-9956-ffa450edef68
2010-01-16 08:19:35 +00:00
Bruno Busco 1e39c7bd92 Part of OFBIZ-3067 - Menus and form widget files location
Content component
Moved menus from webapp to widget folder


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@828872 13f79535-47bb-0310-9956-ffa450edef68
2009-10-22 22:18:00 +00:00
Bruno Busco c30c24b95c Changed <container style="screenlet"> pattern to <screenlet...>.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@826269 13f79535-47bb-0310-9956-ffa450edef68
2009-10-17 15:11:32 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Jacques Le Roux a5042291f7 1st part of an effort to remove trailing spaces
" +/> => "/>
Should be easier when dealing with Eclipse S/R regexp

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@762648 13f79535-47bb-0310-9956-ffa450edef68
2009-04-07 08:27:15 +00:00
Marco Risaliti 7712182402 A lot of hardcoded labels cleaning and changes some wrong references
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@746406 13f79535-47bb-0310-9956-ffa450edef68
2009-02-20 22:53:32 +00:00
Marco Risaliti 54e0334ca2 A lot of hardcoded labels cleaning and changes some wrong references
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@742770 13f79535-47bb-0310-9956-ffa450edef68
2009-02-09 22:13:57 +00:00
Jacques Le Roux 5d9fd471dc <field-map(.*)env-name => <field-map$1from-field
<service(.*)result-map-name => <service$1result-map

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739764 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 13:54:08 +00:00
Jacques Le Roux 290534059d <entity-one entity-name=(.*)value-name => <entity-one entity-name=$1value-field
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739732 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 10:27:43 +00:00
Marco Risaliti 774a0ba9af A lot of cleaning into Content labels (Part of OFBIZ-1780)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@731189 13f79535-47bb-0310-9956-ffa450edef68
2009-01-04 07:43:52 +00:00
Marco Risaliti cfeb2a6745 Some cleanup on content component (Part of issue OFBIZ-1982)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@701855 13f79535-47bb-0310-9956-ffa450edef68
2008-10-05 19:14:33 +00:00
Jacques Le Roux f09724ea75 An enhancing patch from Bruno Busco "Using screenlets in Content Application" (https://issues.apache.org/jira/browse/OFBIZ-1881) - OFBIZ-1881
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@680088 13f79535-47bb-0310-9956-ffa450edef68
2008-07-27 10:41:47 +00:00
Marco Risaliti ff503b24e9 Converted some content bsh scripts to groovy (Part of issue OFBIZ-1801)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@667961 13f79535-47bb-0310-9956-ffa450edef68
2008-06-15 13:49:12 +00:00
Marco Risaliti 65e731867a Converted some content bsh scripts to groovy (Part of issue OFBIZ-1801)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@667668 13f79535-47bb-0310-9956-ffa450edef68
2008-06-13 22:11:00 +00:00
David E. Jones 0d6a10e5b8 More cleanups of now deprecated constructors and what what
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@660843 13f79535-47bb-0310-9956-ffa450edef68
2008-05-28 07:22:59 +00:00