Commit Graph
206 Commits
Author SHA1 Message Date
Michael Brohl 662a3f9d1c Improved: Remove Compdoc functionality from content manager
(OFBIZ-10476)
2021-02-13 17:33:05 +01:00
Benjamin Jugl f5788b2a81 Improved: Converts DataServices.xml to Groovy. (OFBIZ-11469) 2021-02-01 17:08:46 +01:00
Nicolas Malin 12162a2a9c Fixed: Create a blog article failed to link each contents
(OFBIZ-12075)

When you create a blog article with screen https://localhost:8443/content/control/EditBlogArticle?blogContentId=${blogId} by default you can create an article with a summary, an image and a long text.

After the creation all content related to this article was created by impossible to display this article correctly. The problem come from the contentAssoc of each relation where the mapKey isn't populate.

The root come from the conversion to entity-auto for the service createContent, where some seca are present and use some field to create some relation with attribute not present on a content (like the field mapKey)

To correct this I the simple way is to authorize these fields, and think for the future how do better.
2020-11-30 09:17:21 +01:00
Jacques Le Roux 2fe76bead8 Improved: Misc trivial changes done while working on others issues 2020-11-11 20:43:59 +01:00
Pawan Verma 271e3c9bd5 Improved: Convert createCommEventContentAssoc service from mini-lang to groovy DSL(OFBIZ-11380)
Thanks, Devanshu for report, rushikesh and priya for the patch and Suraj and jacques for the review.
2020-08-22 19:09:44 +05:30
Pawan Verma 568fa2c173 Improved: Convert updateSingleContentPurpose service from mini-lang to groovy DSL(OFBIZ-11367)
Thanks: Devanshu for report and Sourabh for the patch.
2020-08-22 10:44:02 +05:30
Pawan Verma 7799673fa3 Improved: Convert createEmailContent service from mini-lang to groovy DSL(OFBIZ-11370)
Thanks, Devanshu for the report and Rohit for initial patch and Nicolas for updated patch and review.
2020-07-18 22:25:55 +05:30
Pawan Verma 904491ede1 Improved: Convert indexContentKeywords and forceIndexContentKeywords services from miniland to groovy(OFBIZ-11390)(OFBIZ-11392)
Thanks, Devanshu for report and Sourabh and Aishwary for the patch.
2020-07-18 22:11:32 +05:30
Pawan Verma 22bb77ebc6 Improved: Convert updateCommContentDataResource service from mini-lang to groovy DSL(OFBIZ-11379)
Thanks, Devanshu for the report, Sourabh for the initial patch and Nicolas for the updated patch.
2020-07-18 14:21:33 +05:30
Suraj Khurana ad586a1c14 Improved: Converted deleteContentKeywords service from mini-lang to groovy DSL.
(OFBIZ-11391)
Thanks Devanshu Vyas for reporting and Yogesh Naroliya for the patch.
2020-07-04 15:12:14 +05:30
Suraj Khurana 9223d40204 Improved: Converted createContentFromDataResource service from mini-lang to groovy DSL.
(OFBIZ-11377)
Thanks Devanshu Vyas for reporting and Anushi Gupta for the patch.
2020-07-04 14:53:12 +05:30
Suraj Khurana 84f82a44d1 Improved: Converted getContentAndDataResource service from mini-lang to groovy DSL.
(OFBIZ-11382)
Thanks Devanshu Vyas for reporting and Ravi Lodhi for the patch.
2020-07-04 14:44:29 +05:30
Pawan Verma 9e97730288 Improved: Convert getDataResource service from mini-lang to groovy DSL(OFBIZ-11381)
Thanks: Devanshu for report and Kirti for the patch.
2020-07-01 16:02:33 +05:30
Suraj Khurana 7aa3db4c45 Improved: Converted createDownloadContent,updateDownloadContent services from mini-lang to groovy.
(OFBIZ-11372)(OFBIZ-11373)
Thanks Devanshu Vyas for reporting, Harman Kaur and Rahul for initial patch, Pawan for review.
2020-05-25 13:37:16 +05:30
Mridul Pathak f9a05c8e30 Improved: Convert setContentStatus service from mini-lang to groovy DSL(OFBIZ-11365). Thanks Devanshu Vyas for the contribution. 2020-05-23 18:12:13 +05:30
Jacques Le Roux 11905d82f5 Improved: Convert deactivateAllContentRoles service from mini-lang to groovy DSL
(OFBIZ-11366)

jleroux: I had to slightly rewrite the patch, mostly the Groovy part (see
comment in Jira)

Thanks: Devanshu Vyas for the initial patch
2020-05-18 13:25:35 +02:00
Priya SharmaandPriya Sharma 6495dc7a91 Improved: Convert createArticleContent service from mini-lang to groovy (#140)
Deleted the old mini-lang service file
Updated the service definitions with the new groovy methods
Added the groovy implementation (with minor enhancement)

(OFBIZ-11383)

Co-authored-by: Priya Sharma <priya.sharma@example.com>
2020-05-17 10:54:16 +02:00
Suraj Khurana e3124a6856 Improved: Converted remaining ElectronicText related CRUD services from simple to entity-auto (#120)
(OFBIZ-11664)
2020-05-13 10:46:55 +05:30
Pawan Verma e9664e94c4 Improved: Convert updateEmailContent service from mini-lang to groovy DSL
(OFBIZ-11371)

Thanks: Devanshu Vyas for report and Anushi Gupta for the patch.
2020-05-04 15:45:33 +05:30
Jacques Le Roux 200c0e85fc Implemented: Convert createContentAlternativeUrl service from mini-lang to Groovy
(OFBIZ-11389)

Thanks:  Priya Sharma for patch and  Pawan Verma for review
2020-04-19 09:48:24 +02:00
Nicolas Malin 27aa23833c Improved: Convert createTextAndUploadedContent service from mini-lang to groovy DSL
(OFBIZ-11368)

Thanks to Rohit Hukkeri for providing the patch
2020-03-06 14:58:15 +01:00
Jacques Le Roux a3bcdc4cc3 Improved: Removes getSubContentWithPermCheck and getSubSubContentWithPermCheck
unused services
(OFBIZ-11393)(OFBIZ-11394)

They were introduced by Al Byers in 2007 and, like some other stuff done then
by Al, were never used. We can safely close the 2 related issues as won't do
after removing the 2 services and all the references to them.

Thanks: Priya Sharma
2020-03-04 14:35:18 +01:00
Jacques Le Roux d003807154 Improved: Remove createTopic service (unused)
(OFBIZ-11376)

I could not find any references for this service in the code base, i.e. this
service has not been used anywhere, do we still want to keep it?

Thanks: Devanshu Vyas for report, Priya Sharma for the proposition and the fix
2020-02-26 10:00:33 +01:00
Michael Brohl c332322017 Fixed: CMS add content not working.
(OFBIZ-10833)

This fixes the missing content association and wrong update of the
parent content reported by Ingo Wolfmayr. Thanks Sebastian Berg for
providing the patch.
2020-02-18 21:28:14 +01:00
Jacques Le Roux 8aea160e04 Fixed: Getting policy error while editing html text data using cms
(OFBIZ-11265)

Service parameter with allow-html="safe" does not check the OWASP sanitizer flag
ie. enabled or not and perform sanitization which causing policy error while
editing text data

getting following exception error:
"In field [textData] by our input policy, your input has not been accepted for
security reason. Please check and modify accordingly, thanks."

Thanks: Pradeep Choudhary for report and suggestion
2019-11-07 15:46:05 +01:00
Jacques Le Roux 2dadaacac8 Fixed: Services allow arbitrary HTML for parameters with allow-html set to "safe"
(OFBIZ-5254)

This was reopened after discussion at 
https://markmail.org/message/jnaitmwahjcjmdn5

This is a new solution which follows the work done with OFBIZ-6669 and OFBIZ-10187
Roughly said, it uses org.owasp.html.PolicyFactory and org.owasp.html.Sanitizers

Thanks: Christoph Neuroth for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859877 13f79535-47bb-0310-9956-ffa450edef68
2019-05-24 13:47:08 +00:00
Jacopo Cappellato 1b0ae5999f Improved: Replaced permission-service with required-permissions in order to
perform permission checks in a way that is more consistent with the screen 
permissions set in the ecommerce blog/forum screens.

Fixes CVE-2019-10073



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1858539 13f79535-47bb-0310-9956-ffa450edef68
2019-05-02 13:41:24 +00:00
Jacopo Cappellato 9b5aad637c [Fixed]: Added permission checks to three blog/forum services; improved the
configuration for the "add article forum" form (the source tab is not needed in 
the ecommerce application).

Fixes CVE-2019-10073

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1858432 13f79535-47bb-0310-9956-ffa450edef68
2019-04-30 14:25:13 +00:00
Suraj Khurana f79f6fd797 Fixed: Forum Group update not working, throwing an error.
(OFBIZ-10744)
It was due to missing default entity name in service definition while using entity-auto.
Thanks Ayushi Rathod for reporting the issue and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1849740 13f79535-47bb-0310-9956-ffa450edef68
2018-12-26 07:55:09 +00:00
Deepak Dixit 55d6c0011d Improved: Convert updateContent and removeContent service to entity-auto
(OFBIZ-10625)
Thanks Aditya Sharma for reporting the issue. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1849025 13f79535-47bb-0310-9956-ffa450edef68
2018-12-16 12:29:49 +00:00
Gil Portenseigne 9fbb3765e4 Implemented : File transfer management with communicationEvent and new contactMech FTP_ADDRESS
(OFBIZ-10245)

This commit introduce a new way to manage file transfer in OFBiz.
Inspired by mailing communication event management, a new communicationEventTypeId is created ('FILE_TRANSFER_COMM').

Such commEvent with classics : partyIdFrom/partyIdTo/contactMechIdTo/entryDate etc. are analysed by a job (like sendEmailDated), to send associated contents to a configured FTP/SFTP/FTPS server. If failure happens, it is catched and stored in communicationEvent, waiting for a new try.

For this purpose :

A new contactMechTypeId is introduced (FtpAddress), with its corresponding table. This contactMech store needed information for basic user/password authentication (server url and protocol, port, username, password, etc.)
A new service sendFileTransferDated that will look for pending file transfer and call following service.
A new service sendCommEventAsFtp that take a selected commEvent, check its structure and manage its status after trying the associated content file transfers.
A new service sendContentToFtp, that take a content and transfer it to a given FtpAddress.
A seca createCommEventFromFtpTransfer on sendContentToFtp to manage plural content file transfer, creating children communicationEvent to follow each content transfer separately (only for several content transfers).
A new Interface FtpClientInterface, with the 3 implementations of FTP, FTPS (To Implement), SFTP clients to manage Ftp connection and transfer.
A new property file to enable and manage redirection for testing purpose.

With this implementation, creating a communicationEvent, with a FtpAddress contactMechIdTo, and sendFileTransferDated job planned, the file is transfered to the ftp : communication event status set to COM_COMPLETE, if error occured the communication event status is set to COM_BOUNCED with error message on communicationEvent note.

Thanks Rishi for your feedbacks

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831867 13f79535-47bb-0310-9956-ffa450edef68
2018-05-18 15:53:35 +00:00
Jacques Le Roux f1676f1aec Improved: Migrate createContent service from Minilang to Entity Auto
(OFBIZ-10401)

Like Suraj did for createRequirement, this uses 
  <override name="statusId" default-value="CTNT_IN_PROGRESS"/>
to replace the only thing specific in the Minilang implementation

Improves 2 related French labels


Thanks: Deepak for discussion and Suraj for initial idea

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831511 13f79535-47bb-0310-9956-ffa450edef68
2018-05-13 10:09:06 +00:00
Deepak Dixit 645e6e1c47 Fixed: Fix typo 'paramters' => 'parameters'
(OFBIZ-10394)
Thanks Mathieu Lirzin for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830936 13f79535-47bb-0310-9956-ffa450edef68
2018-05-04 19:34:07 +00:00
Deepak Dixit 616f180e6e Fixed: service:updateTextContent fails (OFBIZ-10112)
Thanks Wai for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819120 13f79535-47bb-0310-9956-ffa450edef68
2017-12-23 08:40:56 +00:00
Deepak Dixit 87b230b5b5 Fixed: service:createContent fails to create proper entity:ContentAssoc entry (OFBIZ-10098)
Thanks Wai for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818693 13f79535-47bb-0310-9956-ffa450edef68
2017-12-19 17:55:49 +00:00
Deepak Dixit 80ae23f5ef Fixed xml validation error found while console read
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818244 13f79535-47bb-0310-9956-ffa450edef68
2017-12-15 08:46:55 +00:00
Jacques Le Roux 57bdcb3db3 Improved: Remove unused service checkContentAssocIds and its usage
(OFBIZ-9999)

All cases were not handled if contentAssocTypeId is also passed while creating 
a content.

Thanks: Suraj Khurana

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816637 13f79535-47bb-0310-9956-ffa450edef68
2017-11-29 15:38:57 +00:00
Akash Jain f48f17b96b Improved: Remove unused service checkContentAssocIds and its usage, applied patch from jira issue (OFBIZ-9999)
Thanks, Suraj Khurana for reporting the issue and Sonal Patwari for providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816266 13f79535-47bb-0310-9956-ffa450edef68
2017-11-25 08:21:21 +00:00
Arun Patidar 8a2ec7ddd4 IMPROVED: Replace ContentAssoc related CRUD services with entity-auto. (OFBIZ-9907)
Thanks Mr. Khurana for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1813623 13f79535-47bb-0310-9956-ffa450edef68
2017-10-28 12:56:17 +00:00
Arun Patidar 98d5d599f9 Fixed typo of entity name and invoke attribute in service defination.(OFBIZ-8834)
Thanks Devanshu for reporting.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802883 13f79535-47bb-0310-9956-ffa450edef68
2017-07-25 05:57:23 +00:00
Arun Patidar e8b73fbc18 Improvements in CommEventContentAssoc entity definition and services. (OFBIZ-8843)
Applied improved patch. thanks Devanshu for  your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802772 13f79535-47bb-0310-9956-ffa450edef68
2017-07-24 09:24:15 +00:00
Ashish Vijaywargiya 1ce72c550d Improved: OFBIZ-7471: Improve all the service level error messages for missing required field for content component.(OFBIZ-8713)
Thanks Jagpreet and Shikha for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802667 13f79535-47bb-0310-9956-ffa450edef68
2017-07-22 09:59:31 +00:00
Arun Patidar 1623fadf00 Improvements in CommEventContentAssoc entity definition and services. (OFBIZ-8843)
Thanks Rishi Solanki for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802656 13f79535-47bb-0310-9956-ffa450edef68
2017-07-22 05:43:28 +00:00
Jacques Le Roux 371ebe2913 Fixed: Create new blog article entry error.
(OFBIZ-9373)

After using plain text for the field [articleData], when I post the form, 
I get the following error message:
 The following required parameter is missing: [IN] 
 [createElectronicText.dataResourceId]]
 
jleroux: it was a bug introduced with r1765319 while refactoring to use 
entity-auto

Thanks: Daniel Coric who find the reason and Yao who initially reported and 
helped to find a solution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1799088 13f79535-47bb-0310-9956-ffa450edef68
2017-06-18 14:32:36 +00:00
Jacques Le Roux 25e965cb2e Implemented: New implementation of Birt. Easier user possibility of
report creation
(OFBIZ-6919)

This are a non functional changes not yet used OOTB. 
They are only intended to ease the sync between the svn trunk repo and 
the github branch (using a fork)

So still a WIP...


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777586 13f79535-47bb-0310-9956-ffa450edef68
2017-01-06 10:54:20 +00:00
Deepak Dixit 333d8e65ce Fixed: Set required parameter as option false at service definition level.
(OFBIZ-8358)
Thanks Avnindra Sharma and Pawan Verma for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768256 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 17:33:42 +00:00
Deepak Dixit 3eca8d6aad Improved: Added generic permission service for following
- facility
- marketting
- return
- entitysync
Also moved  the permission check from implementation level to service defination level

(OFBIZ-8673)(OFBIZ-8673)(OFBIZ-8674)(OFBIZ-8739)(OFBIZ-8823)(OFBIZ-8825)(OFBIZ-8827)(OFBIZ-8850)(OFBIZ-8876)(OFBIZ-8875)(OFBIZ-8824)(OFBIZ-8826)(OFBIZ-8851)

Thanks Nameet Jain for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768188 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 11:10:57 +00:00
Arun Patidar 3584666dbc Implemented: Added CRUD services for ProdConfItemContentType, ProductAssocType, UserPrefGroupType, WebPreferenceType, WorkEffortAssocAttribute, WorkEffortAssocType, WorkEffortAssocTypeAttr, WorkEffortBilling, WorkEffortContentType, WorkEffortGoodStandardType, WorkEffortPurposeType, WorkEffortType, WorkEffortTypeAttr, WorkReqFulfType, UomType, UomGroup, ProductPricePurpose, ProductPriceType, ProductStoreGroupRole and ProductStoreGroupRollup entities.
(OFBIZ-8729)(OFBIZ-8730)(OFBIZ-8792)(OFBIZ-8793)(OFBIZ-8794)(OFBIZ-8795)(OFBIZ-8796)(OFBIZ-8797)(OFBIZ-8798)(OFBIZ-8799)(OFBIZ-8800)(OFBIZ-8801)(OFBIZ-8802)(OFBIZ-8803)(OFBIZ-8788)(OFBIZ-8789)(OFBIZ-8767)
(OFBIZ-8768)(OFBIZ-8769)(OFBIZ-8770)

Thanks: Chinmay Patidar, Amit Gadaley and Rishi Solanki for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767965 13f79535-47bb-0310-9956-ffa450edef68
2016-11-03 20:30:52 +00:00
Jacques Le Roux d2aa6aa9ee Fixed: Updating Party Content Image does not work
(OFBIZ-8458) (OFBIZ-8347)

Actually it was a regression introduced by r1765499 for a ticket which did not
exist.

This also fixes OFBIZ-8347 for a typo (UPDATE permission instead of DELETE)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1766183 13f79535-47bb-0310-9956-ffa450edef68
2016-10-22 11:19:28 +00:00
Deepak Dixit 5b853bae42 Improved: Converted some CRUD services from simple to entity-auto.
(OFBIZ-8384)(OFBIZ-8388)(OFBIZ-8295)(OFBIZ-8294)(OFBIZ-8389)(OFBIZ-8390)(OFBIZ-8391)(OFBIZ-8392)(OFBIZ-8393)(OFBIZ-8407)

Thanks Pawan Verma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765500 13f79535-47bb-0310-9956-ffa450edef68
2016-10-18 19:33:49 +00:00