* [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug
- Replaced the debug.log methods with the respective groovy utility method
- Enhanced the GroovyBaseScript to entertain the fetch the current class name as the module name for logging
- Overloaded the logError method to entertain throwbale object for better logging
- Removed unused import statements and module variables.
(OFBIZ-11762)
* [Removed]: Extra line spaces. (OFBIZ-11762)
* [Revert]: Unwanted changes. (OFBIZ-11762)
* [Added] Same changes to these files. (OFBIZ-11762)
Co-authored-by: Priya Sharma <priya.sharma@example.com>
* [Fixed] Create Payment service throws exception when receiving payment on order
- Since the MODULE variable could not be found, the service was throwing error
- Instead used the groovy method directly to print the log instead, which has access to the module variable implicitly.
- Removed the unused import as Debug class is not longer needed here.
(OFBIZ-11754)
* [Improved] The content groovy services to avoid the error in case we try to log a detail, since the module variable is not found. (OFBIZ-11754)
* Update ContentServices.groovy
* [Improved] Added error logs instead of info logs for service excpetions logging. (OFBIZ-11754)
Co-authored-by: Priya Sharma <priya.sharma@example.com>
Co-authored-by: Suraj Khurana <64310724+surajkhurana@users.noreply.github.com>
Deleted the old mini-lang service file
Updated the service definitions with the new groovy methods
Added the groovy implementation (with minor enhancement)
(OFBIZ-11383)
Co-authored-by: Priya Sharma <priya.sharma@example.com>
(OFBIZ-9830)
Steps to recreate:
1. Go to ContentManager.
2. Go to Template.
3. Click Find, then click LEFTBAR in the search result.
4. Click Edit, then we get a error page.
Thanks: fumiyoshi.to
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811559 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-9385)
This is an improvement only because no cases were reported. But obviously in
case of unlucky exception after the EntityListIterator creation and before it's
closed the EntityListIterator remains in memory.
It should be closed in EntityListIterator.finalize() but the less happens there
the better.
I noticed Groovy has no try-with-ressources statement. I put a comment in
the description of OFBIZ-9296 "Update Gradle to 2.4.10" Maybe a solution would
be to use streams but really WTF! It seems Gradle 2.5 has autocloseable...
This contains also some refactoring and code cleaning
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1797373 13f79535-47bb-0310-9956-ffa450edef68
Michael suggested in dev ML that we don't show the error in UI because VIEW_SIZE
is only technical, which I agree with. The log is enough.
Actually it was already the case because I missed to move the
if (errMsgList) {
request.setAttribute("_ERROR_MESSAGE_LIST_", errMsgList)
}
block below the now caught NumberFormatException
So I just need to remove the 2nd line in the catch, done.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1789736 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8341)
While working on OFBIZ-7759, I stumbled upon this by chance.
It's unlikely that this NumberFormatException is ever caught, but not a reason
to swallow it.
I checked there are no other swallowed exceptions in Groovy files.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1789710 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-7000)
If you get to
content/control/EditLayout?drDataResourceId=NOCONTENTFOUND&contentId=NOCONTENTFOUND
When trying to editing you get an error
Mohammed Rehan Khan explored the issue and found that there is a condition in
DataResourceWorker method to render content of 'text' mime type only, for others
it returns exception.
We can fix this by setting up mimeTypeID as null in request param
Question: Why setting up mimeTypeTypeId as 'null' is fixing this issue?
Answer: As we don't have image specific worker method for rendering these type
of contents, so we are using DataResourceWorker.renderDataResourceAsText()
to render image type content as well. Due to following condition,
targetMimeTypeId is setting up as "text/html" if sent null and hence not
throwing the exception reported in the ticket.
Thanks: Mohammed Rehan Khan for the patch
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765094 13f79535-47bb-0310-9956-ffa450edef68