Commit Graph
78 Commits
Author SHA1 Message Date
Jacques Le Roux ec2b84341e Reverted: "Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)"
This reverts commit 17eb2e4cf7.

It does not work when using <<target="javascript:........>>
I could change those cases but it's easier and safer to simply revert back to
target-type!

Thanks: James for report
2020-12-18 11:08:32 +01:00
Jacques Le Roux 17eb2e4cf7 Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)
Same for sub-hyperlink
2020-12-11 16:52:04 +01:00
Suraj Khurana 10598672b6 Fixed: Update Contact Mech ID with Billing Account not working.
(OFBIZ-10315)
Thanks Shikha Jaiswal for providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1847360 13f79535-47bb-0310-9956-ffa450edef68
2018-11-24 12:42:23 +00:00
Jacques Le Roux 66e82b1d75 Fixed: UI Issue with Account Limit at Find Billing Account(s)
(OFBIZ-9899)

Steps:
1. Open https://demo-trunk.ofbiz.apache.org/accounting/control/FindBillingAccount
2. Navigate to Find Billing account
3. Check for Search Results
Actual: At Account Limit section, symbol is been displayed
Expected: Currency Symbols should be displayed

Actual issue in the code is, Billing Account rendering logic is using browser's 
locale(Due to Null BillingAccount object passed) to render currency symbol but 
the code should use BillingAcccount.accountCurrencyUomId that get's set by User 
on BillingAccount creation.
Fixed the logic to use accountCurrencyUomId as currency to render currency symbol.

Thanks: Aayush jain for report, Ankush Upadhyay for patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816369 13f79535-47bb-0310-9956-ffa450edef68
2017-11-26 08:12:04 +00:00
Arun Patidar 4a28d14ac6 FIXED:Request handler exception in create billing account from suppliers profile page. (OFBIZ-9751)
Thanks Mr. Khurana for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1813626 13f79535-47bb-0310-9956-ffa450edef68
2017-10-28 13:11:17 +00:00
Jacques Le Roux 117ac9ce96 Improved: refactor list related forms in BillingAccount widgets
(OFBIZ-9215)

Refactoring various list forms into grids
Refactoring various list form references in screen widgets

Thanks: Pierre Smits

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1786915 13f79535-47bb-0310-9956-ffa450edef68
2017-03-14 15:47:52 +00:00
Michael Brohl fbcff9ffdc Improved: Client side validation required in Add Billing Accounts Role.
(OFBIZ-7429)

Thanks: Padmavati Rawat for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774798 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 20:12:53 +00:00
Divesh Dutta 738a12bec1 Improvement: Miniland code readability and consistency improvements
(OFBIZ-8744) (OFBIZ-8745) (OFBIZ-8746) (OFBIZ-8748) (OFBIZ-8829) (OFBIZ-8830) (OFBIZ-8907) (OFBIZ-8908) (OFBIZ-8924) (OFBIZ-8925) 

Thanks: Ankush Upadhyay , Sega patidar , Abhijeet Ashapure for your patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768219 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:14:04 +00:00
Pranay Pandey 3b6417f6d1 Improved: Accounting list forms column title alignment.
(OFBIZ-8278)

Thanks: Aditi Patidar for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765011 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 05:41:01 +00:00
Divesh Dutta 556279917d Improved:Display from date with default to now timestamp and also add asterisk sign to all the forms where it is part of primary key in all the components.
(OFBIZ-7650) (OFBIZ-7651) (OFBIZ-7653) (OFBIZ-7660) (OFBIZ-7662) (OFBIZ-7665) (OFBIZ-7666) (OFBIZ-8028)(OFBIZ-8029) (OFBIZ-8255)

Thanks: Anuj Jain and Ratnesh for the pathes and Swapnil Shah for reporting the issues.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761192 13f79535-47bb-0310-9956-ffa450edef68
2016-09-17 11:02:39 +00:00
Pranay Pandey 75fb73e348 [OFBIZ-7858] Adding paginate target on 'BillingAccountForms', 'CostForms' and 'AP/AR-InvoiceForms'.
Thanks Amardeep Singh Jhajj for reporting the issue and Chandan Khandelwal for providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1752933 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 12:02:36 +00:00
Deepak Dixit 834691742b (OFBIZ-6274) Renamed OFBiz artefacts from org.ofbiz.* to org.apache.ofbiz.*.Thanks to Taher for working on it.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1752920 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 10:30:49 +00:00
Jacques Le Roux c8ba932772 Fixes a "typo" in last commit for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
We used targetNamespace (should only be used in schema) instead of xsi:schemaLocation



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749634 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 05:58:26 +00:00
Jacques Le Roux 89212904bd Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
This is the 2nd step: puts back the original names, so it will be transparent for remaining references in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749489 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:37:47 +00:00
Jacques Le Roux 4931db1ed9 Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061 by replacing xsd files references in xml files by -ns.xsd files and removing the concerned xsd files
This is a 1st step, in a 2nd I will put back the original names, so it will be transparent for remaining reference in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749488 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:14:16 +00:00
Nicolas Malin ce97afbf6b patch from Pierre Smits : Remove tooltip CommonNotModifRecreat from display fields (OFBIZ-6696), thanks for the screen clean Pierre
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1718970 13f79535-47bb-0310-9956-ffa450edef68
2015-12-09 21:24:44 +00:00
Nicolas Malin 895c9856b3 Cleaning forms code is needed after setting default-value in list-options and entity-options, patch related to OFBIZ-6524 and follows the resolution of OFBIZ-6490 and OFBIZ-6489. Thanks Gil Portenseigne for this effort
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1686674 13f79535-47bb-0310-9956-ffa450edef68
2015-06-20 21:58:05 +00:00
Nicolas Malin ddc01156ab Convert old simple CRUD service on BillingAccount to entity-auto (OFBIZ-5963).
Clean service definition with using auto-fields-entity and clean editBillingAccount screen :
    display correctly the customer billing party
    hidden billingAccountId and contactMechId on create process
    add new service createBillingAccountAndRole (the screen present the partyId field but didn't propage the value on billingAccountRole)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1651912 13f79535-47bb-0310-9956-ffa450edef68
2015-01-15 00:37:06 +00:00
Jacopo Cappellato ecfc14a6bc ${bsh: to ${groovy: scriptlet conversions.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1613432 13f79535-47bb-0310-9956-ffa450edef68
2014-07-25 13:28:20 +00:00
Jacopo Cappellato 52c7659c23 Moved two util methods for billing accounts from the "accounting" to the "order" component and removed duplicated code from the order component that was there to avoid a cyclic dependency between the two components.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1582774 13f79535-47bb-0310-9956-ffa450edef68
2014-03-28 15:05:23 +00:00
Jacques Le Roux 3369dca046 Replaces title="${uiLabelMap.CommonEmptyHeader}" by title=" " where it's known to not be a problem. Here with links styled by widget-style="buttontext"
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1340373 13f79535-47bb-0310-9956-ffa450edef68
2012-05-19 08:45:18 +00:00
Adam Heath 619509092b Applied patch from OFBIZ-3358, form ListBillingAccountInvoices had an
error when calculating whether paidInvoice was true; namely, BigDecimal
wasn't imported or fully specified, so bsh complained that it couldn't
find the class or variable.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@891378 13f79535-47bb-0310-9956-ffa450edef68
2009-12-16 18:54:51 +00:00
Ashish Vijaywargiya 45f5e3d794 Applied patch from jira issue OFBIZ-3339 - Enhance Find Billing Account Screen to follow standard Find/List screen pattern.
Thanks Surya & Ratnesh for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@890792 13f79535-47bb-0310-9956-ffa450edef68
2009-12-15 13:29:13 +00:00
Vikas Mayur 5ac53da722 Update button was displayed on the create billing account screen but it should be Create. Applied patch from Brajesh Patel,
part of jira issue OFBIZ-3041 (https://issues.apache.org/jira/browse/OFBIZ-3041)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@825135 13f79535-47bb-0310-9956-ffa450edef68
2009-10-14 13:47:15 +00:00
Jacques Le Roux b7a941d4f6 Revert r813307 on Adrian's request
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@813893 13f79535-47bb-0310-9956-ffa450edef68
2009-09-11 16:02:01 +00:00
Jacques Le Roux a7430a2fc2 A modified patch from Erwan de FERRIERES '"Automatic" sortable table headers" (https://issues.apache.org/jira/browse/OFBIZ-2921) - OFBIZ-2921
I was planning to wait longer, but I can't wait more. I have added a lot of small trivial changes in this patch and they are blocking me to go further on other issues...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@813307 13f79535-47bb-0310-9956-ffa450edef68
2009-09-10 08:41:19 +00:00
Anil Patel 0f1f62b2f0 Adding more localization of screen labels. Thanks Arpit, Rishi and Hans for quick reminder.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@800414 13f79535-47bb-0310-9956-ffa450edef68
2009-08-03 15:09:23 +00:00
Hans Bakker fe146772e2 take the default currency as set in the commonext component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@795474 13f79535-47bb-0310-9956-ffa450edef68
2009-07-19 03:54:22 +00:00
Hans Bakker 7e815c48c7 sort currency by country and not by abbreviation in form dropdowns
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@794619 13f79535-47bb-0310-9956-ffa450edef68
2009-07-16 10:40:07 +00:00
Vikas Mayur 0739e1b39a Sort the existing Billing Account on accounting.
Patch from Vivek Mishra, part of OFBIZ-2465 (https://issues.apache.org/jira/browse/OFBIZ-2465)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@775104 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 12:27:26 +00:00
Jacques Le Roux 999bd7c577 Fix following Chris Howe's message in dev ML
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@764195 13f79535-47bb-0310-9956-ffa450edef68
2009-04-11 13:00:24 +00:00
Jacques Le Roux a5042291f7 1st part of an effort to remove trailing spaces
" +/> => "/>
Should be easier when dealing with Eclipse S/R regexp

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@762648 13f79535-47bb-0310-9956-ffa450edef68
2009-04-07 08:27:15 +00:00
Jacques Le Roux 76f5ca6638 Secure URLs, we don't need to duplicate in from-field when param-name is the same
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@762215 13f79535-47bb-0310-9956-ffa450edef68
2009-04-06 06:25:24 +00:00
Jacques Le Roux 67a602c3ed Securing URLs, link element in screens and menus : 28th set + tabs to 4 spaces
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@761972 13f79535-47bb-0310-9956-ffa450edef68
2009-04-04 17:36:48 +00:00
Jacques Le Roux 77a2ff1d9f 21th set of changes explained in https://issues.apache.org/jira/browse/OFBIZ-2243
In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements

We are near the end...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759684 13f79535-47bb-0310-9956-ffa450edef68
2009-03-29 14:02:55 +00:00
Jacques Le Roux 8c6d89fe75 18th set of changes explained in https://issues.apache.org/jira/browse/OFBIZ-2243
In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements

This one is huge, with some changes by hand, conversion from tabs to 4 spaces and some trailing spaces (I have activated it AnyEdit plugin following the changes I made in http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions but I wonder if I should not reverse all that - I mean my plugin setting and in wiki -, it's a nightmare!)

I did my best on this one, but I'm not sure some typos did not slip in. Anyway, alea jacta est


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759666 13f79535-47bb-0310-9956-ffa450edef68
2009-03-29 11:00:00 +00:00
Jacques Le Roux 3fe66ef254 tabs to 4 spaces
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759574 13f79535-47bb-0310-9956-ffa450edef68
2009-03-28 20:13:03 +00:00
Jacques Le Roux 2f9c37bd22 13th set of changes explained in https://issues.apache.org/jira/browse/OFBIZ-2243
In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759564 13f79535-47bb-0310-9956-ffa450edef68
2009-03-28 19:56:49 +00:00
Jacques Le Roux e3f730799b 12th set of changes explained in https://issues.apache.org/jira/browse/OFBIZ-2243
In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759562 13f79535-47bb-0310-9956-ffa450edef68
2009-03-28 19:45:05 +00:00
Marco Risaliti 8ed72242d9 Artifact cleaning on accounting component after recent changes on xsd files (OFBIZ-2137)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@737563 13f79535-47bb-0310-9956-ffa450edef68
2009-01-25 18:33:55 +00:00
David E. Jones 874f02e9da Manual merge of typecheckcleanup200810 branch as of rev 731346 in that branch, resolved all conflicts; with this BigDecimal is not the native type for many entity fields and is used for many calculations; some work is still needed in certain areas of the project but this covers the most critical ones; thanks especially to Scott for his work on this
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@731851 13f79535-47bb-0310-9956-ffa450edef68
2009-01-06 07:13:36 +00:00
Jacques Le Roux 10a97260af Revert 728176, should better be done in typecheckcleanup200810 branch (David's advice)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@728247 13f79535-47bb-0310-9956-ffa450edef68
2008-12-20 08:16:36 +00:00
Jacques Le Roux cc616c4ea2 Some BigDecimals in xml files
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@728176 13f79535-47bb-0310-9956-ffa450edef68
2008-12-19 22:25:35 +00:00
David E. Jones 3269e7602c Various cleanups dones while reviewing functionality including formatting, refactoring, better descriptions and consistent defaults. In general no functionality change, though did add a default of N for the require return receive setting on the ProductStore
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@725022 13f79535-47bb-0310-9956-ffa450edef68
2008-12-10 07:31:39 +00:00
Scott Gray b08bfae6e3 Fix an NPE, some typos and a label
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@670108 13f79535-47bb-0310-9956-ffa450edef68
2008-06-21 00:53:09 +00:00
Ashish Vijaywargiya 55b888849e Patch from JIRA issue # OFBIZ-1839.
Container to Screenlet conversion for Accounting component.

For now followed the CamelCase pattern starting with the First letter as capital one.
Thanks Awdesh Singh Parihar for your patch and Ratnesh Upadhyay for your Support.

Special thanks to Vikas Mayur and Adrian Crum for their useful comments.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@666968 13f79535-47bb-0310-9956-ffa450edef68
2008-06-12 06:09:10 +00:00
Jacopo Cappellato 3fabe825fe Applied patch from Sumit Porwal, with some changes I did, (OFBIZ-1632 "Refactor the getGlAccountFromAccountType minilang method so that all the entity-one calls are replaced by calls to minilang (inline) methods.") and patch from Rashko Rejmer (OFBIZ-1631, "Replace all the code that directly retrieves from the db a PartyAcctgPreference for an organizationPartyId with a call to the service implemented in OFBIZ-1630"); misc cleanups to gl forms and screens; implemented new service to manually run the mappings for acctg trans entries (useful also to test the gl setup for automatic transactions).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@646697 13f79535-47bb-0310-9956-ffa450edef68
2008-04-10 08:58:40 +00:00
Marco Risaliti 17db1c5623 Agreement/Billing Account/Lookup forms (ftl/widgets screen) has now the same look and feel (Part of issue OFBIZ-1603)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@616013 13f79535-47bb-0310-9956-ffa450edef68
2008-01-28 19:50:02 +00:00
Anil Patel 81193dd284 Shortcut for all Unpaid Invoices on a BillingAccount,
Pankaj, thanks for your contribution. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@599737 13f79535-47bb-0310-9956-ffa450edef68
2007-11-30 08:37:27 +00:00
Jacopo Cappellato 9684945ab3 Removing the default-map attribute will allow the field availableBalance to get the omonimous value created in the <actions> section.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@590619 13f79535-47bb-0310-9956-ffa450edef68
2007-10-31 10:53:59 +00:00