Commit Graph
43 Commits
Author SHA1 Message Date
Jacques Le Roux ec2b84341e Reverted: "Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)"
This reverts commit 17eb2e4cf7.

It does not work when using <<target="javascript:........>>
I could change those cases but it's easier and safer to simply revert back to
target-type!

Thanks: James for report
2020-12-18 11:08:32 +01:00
Jacques Le Roux 17eb2e4cf7 Improved: Hyperlink target-type attribute is deprecated and should be replaced by url-mode (OFBIZ-12091)
Same for sub-hyperlink
2020-12-11 16:52:04 +01:00
Pawan Verma 932e28d444 Improved: UI/UX issues found with Find Agreements screen(OFBIZ-10373)
Thanks, Aayush for the report and Pritam for the patch and Pierre for the review.
2020-07-11 10:22:08 +05:30
Deepak Dixit 244d7505fa Fixed: Moved groovy file GetPartyNameForDate.groovy form WEB-INF/actions to groovyScripts folder added in r#1751109
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801362 13f79535-47bb-0310-9956-ffa450edef68
2017-07-09 09:56:44 +00:00
Jacques Le Roux ba2b13754e Improved: refactor list related forms in Agreeement widgets
(OFBIZ-9186)

Refactoring various list forms into grids
Refactoring various list form references in screens

Thanks: Pierre Smits

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782562 13f79535-47bb-0310-9956-ffa450edef68
2017-02-11 09:25:52 +00:00
Michael Brohl 9d3ffe77d6 Improved: Proper Form validation should be added while creating new agreement product.
(OFBIZ-7441)

Thanks: Ankit Joshi for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774790 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 16:22:43 +00:00
Michael Brohl 3da2380660 Improved: Proper form validation should be there while creating Agreement Item Party.
(OFBIZ-7458)

Thanks: Ankit Joshi for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774788 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 16:18:58 +00:00
Michael Brohl 0615bf828f Improved: Proper form validation should be there while creating Agreement Item Facility.
(OFBIZ-7461)

Thanks: Ankit Joshi for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774786 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 16:15:10 +00:00
Michael Brohl d196677a16 Improved: Proper form validation should be there while creating Agreement Roles.
(OFBIZ-7511)

Thanks: Ankit Joshi for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774785 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 16:09:55 +00:00
Deepak Dixit d09255c0b7 Reverted: Minilang code readability and consistency improvements done at r#1768222, this commit reversed key and description of drop-down in the code.
(OFBIZ-9114)

Thanks  Wei Zhang for reporting the issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772880 13f79535-47bb-0310-9956-ffa450edef68
2016-12-06 12:37:42 +00:00
Divesh Dutta 70eb7ff508 Improvement: Minilang code readability and consistency improvements.
(OFBIZ-8929) (OFBIZ-8930) (OFBIZ-8953) (OFBIZ-8965) (OFBIZ-8972) (OFBIZ-8986) (OFBIZ-8991) 

Thanks: Ankush Upadhyay, Anuj Jain, Abhijeet for your patches. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768222 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:34:00 +00:00
Divesh Dutta 738a12bec1 Improvement: Miniland code readability and consistency improvements
(OFBIZ-8744) (OFBIZ-8745) (OFBIZ-8746) (OFBIZ-8748) (OFBIZ-8829) (OFBIZ-8830) (OFBIZ-8907) (OFBIZ-8908) (OFBIZ-8924) (OFBIZ-8925) 

Thanks: Ankush Upadhyay , Sega patidar , Abhijeet Ashapure for your patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768219 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:14:04 +00:00
Divesh Dutta 85ce444748 Improvement: Minilang code readibility and conistency improvements
(OFBIZ-8445) (OFBIZ-8447) (OFBIZ-8448) (OFBIZ-8450) ( OFBIZ-8451) (OFBIZ-8653) (OFBIZ-8740) (OFBIZ-8741) (OFBIZ-8742) (OFBIZ-8743)

Thanks: Devanshu Vyas, Anuj Jain, Sega Patidar, Abhijeet Ashapure for your patches

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768209 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 12:41:35 +00:00
Deepak Dixit ecefd18ce2 Improved: Added agreementItemSeqId in AgreementContent entity, now content can be uploaded for item level as well (OFBIZ-7969)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1766266 13f79535-47bb-0310-9956-ffa450edef68
2016-10-23 11:26:02 +00:00
Divesh Dutta 556279917d Improved:Display from date with default to now timestamp and also add asterisk sign to all the forms where it is part of primary key in all the components.
(OFBIZ-7650) (OFBIZ-7651) (OFBIZ-7653) (OFBIZ-7660) (OFBIZ-7662) (OFBIZ-7665) (OFBIZ-7666) (OFBIZ-8028)(OFBIZ-8029) (OFBIZ-8255)

Thanks: Anuj Jain and Ratnesh for the pathes and Swapnil Shah for reporting the issues.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761192 13f79535-47bb-0310-9956-ffa450edef68
2016-09-17 11:02:39 +00:00
Deepak Dixit d51014bf71 (OFBIZ-7969) Set hyperlink type to anchor for stream request, that is used to render attached agreement content
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1759129 13f79535-47bb-0310-9956-ffa450edef68
2016-09-03 19:32:48 +00:00
Deepak Dixit e99052cf12 (OFBIZ-7969) Applied slightly modified patch from jira issue.
=================================
Enable adding a content to an agreement
=================================
Thanks Leila Mekika for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1759127 13f79535-47bb-0310-9956-ffa450edef68
2016-09-03 19:24:00 +00:00
Deepak Dixit 834691742b (OFBIZ-6274) Renamed OFBiz artefacts from org.ofbiz.* to org.apache.ofbiz.*.Thanks to Taher for working on it.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1752920 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 10:30:49 +00:00
Ashish Vijaywargiya 6502865b55 Applied patch from jira issue - OFBIZ-7143 - Error on cancelling agreement.
Thanks Ravi for the contribution. Thanks Montalbano for the discussion. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751109 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 05:16:56 +00:00
Jacques Le Roux c8ba932772 Fixes a "typo" in last commit for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
We used targetNamespace (should only be used in schema) instead of xsi:schemaLocation



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749634 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 05:58:26 +00:00
Jacques Le Roux 89212904bd Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
This is the 2nd step: puts back the original names, so it will be transparent for remaining references in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749489 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:37:47 +00:00
Jacques Le Roux 4931db1ed9 Completes and finish "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061 by replacing xsd files references in xml files by -ns.xsd files and removing the concerned xsd files
This is a 1st step, in a 2nd I will put back the original names, so it will be transparent for remaining reference in xml catalogs, Java code, etc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749488 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 11:14:16 +00:00
Pranay Pandey 79dc7983c6 [OFBIZ-7349] Fixed error on adding new term to an agreement after updating any existing term or adding new one. The reason of the error was hidden parameter for agreementTermId which already found set from parameters.
Thanks Amardeep Singh Jhajj for the contribution.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1748559 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 11:23:32 +00:00
Jacques Le Roux e586f71289 A patch from Ingo Wolfmayr for "Agreement Search List requires partyIdFrom/partyIdTo or fails" - https://issues.apache.org/jira/browse/OFBIZ-7030
How tot test!
Create a new agreement and fill the following fields:

    partyTo (for ex. DemoCustomer)
    Role Type Id From (for ex. Client)
    Role Type Id To(for ex. Bill-to customer)
    Agreement Type ID (for ex. Sales)
    Description: test

error: Error in form [ListAgreements] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId]java.lang.IllegalArgumentException: Error in form [ListAgreements] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId]

I create a generic agreement (from company to all customers with no specific agreements) - I could not access it after creation.

This more a workaround than a fix but it works and is better than an error message. Missing fields will be set to empty field. Service will be called and return nothing.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1741960 13f79535-47bb-0310-9956-ffa450edef68
2016-05-02 11:02:36 +00:00
Jacques Le Roux b3d642f68b Revert r1741925 It was not a correct solution:
======================================================================================================================================================
A patch from Ingo Wolfmayr for "Agreement Search List requires partyIdFrom/partyIdTo or fails" - https://issues.apache.org/jira/browse/OFBIZ-7030

How tot test!
Create a new agreement and fill the following fields:

    partyTo (for ex. DemoCustomer)
    Role Type Id From (for ex. Client)
    Role Type Id To(for ex. Bill-to customer)
    Agreement Type ID (for ex. Sales)
    Description: test

error: Error in form [ListAgreements] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId]java.lang.IllegalArgumentException: Error in form [ListAgreements] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId]

I create a generic agreement (from company to all customers with no specific agreements) - I could not access it after creation.

I added a not-empty check.
======================================================================================================================================================

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1741930 13f79535-47bb-0310-9956-ffa450edef68
2016-05-02 08:24:48 +00:00
Jacques Le Roux 717278a82f A patch from Ingo Wolfmayr for "Agreement Search List requires partyIdFrom/partyIdTo or fails" - https://issues.apache.org/jira/browse/OFBIZ-7030
How tot test!
Create a new agreement and fill the following fields:

    partyTo (for ex. DemoCustomer)
    Role Type Id From (for ex. Client)
    Role Type Id To(for ex. Bill-to customer)
    Agreement Type ID (for ex. Sales)
    Description: test

error: Error in form [ListAgreements] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId]java.lang.IllegalArgumentException: Error in form [ListAgreements] calling service with name [getPartyNameForDate]: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [getPartyNameForDate.partyId]

I create a generic agreement (from company to all customers with no specific agreements) - I could not access it after creation.

I added a not-empty check.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1741925 13f79535-47bb-0310-9956-ffa450edef68
2016-05-02 07:35:38 +00:00
Nicolas Malin ce97afbf6b patch from Pierre Smits : Remove tooltip CommonNotModifRecreat from display fields (OFBIZ-6696), thanks for the screen clean Pierre
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1718970 13f79535-47bb-0310-9956-ffa450edef68
2015-12-09 21:24:44 +00:00
Nicolas Malin 895c9856b3 Cleaning forms code is needed after setting default-value in list-options and entity-options, patch related to OFBIZ-6524 and follows the resolution of OFBIZ-6490 and OFBIZ-6489. Thanks Gil Portenseigne for this effort
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1686674 13f79535-47bb-0310-9956-ffa450edef68
2015-06-20 21:58:05 +00:00
Jacques Le Roux 51d95c4023 A patch from Willem Janssen for "Show party names in Agreement list" https://issues.apache.org/jira/browse/OFBIZ-5593
In the findAgreement screen partyIdFrom and partyIdTo columns show only the ID's, not the names.
Attached to this issue a small patch that implements to show the names in the search result screen in the same way as in the findInvoices screen.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1581063 13f79535-47bb-0310-9956-ffa450edef68
2014-03-24 21:02:41 +00:00
Adam Heath 12934702ec Add AgreementFacilityAppl entity and screens. There is no code that
deals with the data yet, however.  This is modeled after
AgreementProductAppl minus the price.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1413810 13f79535-47bb-0310-9956-ffa450edef68
2012-11-26 20:09:17 +00:00
Jacques Le Roux b3ac428f69 A patch from Tom Burns "Pagination Fails in Form ListAgreementTerms " https://issues.apache.org/jira/browse/OFBIZ-5013
As mentionned by Tom, ListAgreementRoles pagination also failed: paginate-target FindAgreementRoles does not exist. I replaced by EditAgreementRoles, works


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1388832 13f79535-47bb-0310-9956-ffa450edef68
2012-09-22 16:24:26 +00:00
Jacques Le Roux 3369dca046 Replaces title="${uiLabelMap.CommonEmptyHeader}" by title=" " where it's known to not be a problem. Here with links styled by widget-style="buttontext"
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1340373 13f79535-47bb-0310-9956-ffa450edef68
2012-05-19 08:45:18 +00:00
Erwan de Ferrieres f39fb4f019 OFBIZ-4232 A patch from Deepak Dixit : Agreement item product price should be display as per the currencyUomId set for respective agreement item.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1092197 13f79535-47bb-0310-9956-ffa450edef68
2011-04-14 12:45:58 +00:00
Jacques Le Roux fda988d301 Closes "Allow to open a layer lookup from a layer lookup recursively" (https://issues.apache.org/jira/browse/OFBIZ-3693) - OFBIZ-3693
This commit removes all remaining <presentation="window">

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@946073 13f79535-47bb-0310-9956-ffa450edef68
2010-05-19 07:36:02 +00:00
Jacques Le Roux 62976e36fb We still have a problem with the find button in recursive cases (ie LookupWorkEffort and LookupContent).
It's not related to previous patches committed but an issue which is remaining and we have to face now.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@944647 13f79535-47bb-0310-9956-ffa450edef68
2010-05-15 14:13:03 +00:00
Jacques Le Roux 578662ae4c Now that we have fixed the layered lookup inside layered lookup issue and the recursive call case we can get rid of all the useless remaining presentation="window".
I keep the example and beware LookupTimeDuration is a special case

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@944623 13f79535-47bb-0310-9956-ffa450edef68
2010-05-15 12:13:00 +00:00
Hans Bakker df0f8b78f2 sort dropdowm in agreemenet terms
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@942009 13f79535-47bb-0310-9956-ffa450edef68
2010-05-07 06:19:47 +00:00
Jacques Le Roux df40275120 A completed patch from Sascha Rodekamp "Lookup Layer Search of a Varient Product" (https://issues.apache.org/jira/browse/OFBIZ-3746) - OFBIZ-3746
Fix the variant issue in product lookups
Remove the temporary window presentation workaround (done at r939232)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@940410 13f79535-47bb-0310-9956-ffa450edef68
2010-05-03 10:37:33 +00:00
Jacques Le Roux 8f11d470b9 Some other issues with layered lookups, bypassed for now using popups
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@939999 13f79535-47bb-0310-9956-ffa450edef68
2010-05-01 12:43:34 +00:00
Jacques Le Roux 92699050d0 A temporary workaround for the problem reported by Sam Hamilton at https://issues.apache.org/jira/browse/OFBIZ-3746: "Lookup Layer Search of a Variants Product"
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@939232 13f79535-47bb-0310-9956-ffa450edef68
2010-04-29 08:47:57 +00:00
Bilgin Ismet Ibryam 0765552fef Hide agreementItemSeqId field while creating agreement items. Reported by Babu Sreekanth in https://issues.apache.org/jira/browse/OFBIZ-3484
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@916206 13f79535-47bb-0310-9956-ffa450edef68
2010-02-25 09:44:07 +00:00
Bilgin Ismet Ibryam 9190cdeb89 Renamed AgreementWorkEffortAppl entity to AgreementWorkEffortApplic in order to change relation types so that assigning WorkEfforts to Agreements is possible w/o specifying an agreementItemSeqId.
Added a migrateAgreementWorkEffortAppl service to migrate existing data to the new entity.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883140 13f79535-47bb-0310-9956-ffa450edef68
2009-11-22 20:17:38 +00:00
Bruno Busco 4740d3a616 Part of OFBIZ-3067 - Menus and form widget files location
Accounting component
Moved forms from webapp to widget folder


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@828868 13f79535-47bb-0310-9956-ffa450edef68
2009-10-22 21:57:30 +00:00