Commit Graph
483 Commits
Author SHA1 Message Date
SebastianEcomify 8a96462538 Improved: Convert CostService.xml minilang to groovy
(OFBIZ-11595)

Thanks: Sebastian Berg for implementation
2021-02-21 11:38:21 +00:00
Jacques Le Roux 4ff22b46dc Improved: Convert getInvoicePaymentInfoListByDueDateOffset service from mini-lang to groovy DSL (OFBIZ-11486)
Thanks: Devanshu Vyas for report, Nitish Mishra for the patch
2020-08-09 20:14:10 +02:00
Jacques Le Roux cc61673198 Improved: Convert cancelCheckRunPayments service from mini-lang to groovy DSL (OFBIZ-11494)
Thanks: Devanshu Vyas for report, Yogesh Naroliya for the patch
2020-08-09 20:07:51 +02:00
Jacques Le Roux 2b04118690 Revert "Improved: Convert voidPayment service from mini-lang to groovy DSL (OFBIZ-11487)"
This reverts commit faa59b325f.

It introduced 3 errors in testIntegration, in:
testGlPostingOnCancelCheckRun
testGlPostingsOnVoidPayment
testVoidPayment
2020-07-25 16:06:34 +02:00
Jacques Le Roux faa59b325f Improved: Convert voidPayment service from mini-lang to groovy DSL (OFBIZ-11487)
Thanks: Sourabh Punyani
2020-07-25 10:33:17 +02:00
Jacques Le Roux 7c4a117448 Improved: Convert getPaymentGroupReconciliationId service from mini-lang to groovy DSL (OFBIZ-11496)
Thanks: Devanshu Vyas for report and Rohit Koushal for the patch

Improved: Convert createPaymentAndApplication service from mini-lang to groovy DSL (OFBIZ-11484)
Thanks: Devanshu Vyas for report and Anushi Gupta for the patch

Sorry due to a bad handling there are 2 commits in one (squashed)
2020-07-09 14:18:05 +02:00
Priya Sharma 18b21c1e94 [Improved] Convert getInvoicePaymentInfoList service from mini-lang to groovy DSL (#148)
(OFBIZ-11485)

Done following:
- removed the mini-lang implementation of the service
- updated the service definition to point the groovy service
- added the groovy implementation of the service
2020-07-04 14:57:53 +05:30
Pawan Verma 6de4b73074 Improved: Convert getPayments service from mini-lang to groovy DSL(OFBIZ-11495)
Thanks: Devanshu for the report and Yogesh for the patch.
2020-07-01 16:13:33 +05:30
Pawan Verma 20ba868b7d Improved: Convert cancelPaymentBatch service from mini-lang to groovy DSL(OFBIZ-11489)
Thanks: Devanshu for report, Kirti for patch and Jacques for the review.
2020-07-01 15:48:49 +05:30
Jacques Le Roux 5880859c7c Implemented: Convert voidPayment service from mini-lang to groovy DSL (OFBIZ-11487)
Thanks: Devanshu Vyas for report and Sourabh Punyani for implementation
2020-07-01 12:05:22 +02:00
Jacques Le Roux 8fc41cb9ae Improved: Convert createFinAccoutnTransFromPayment service from mini-lang to groovy DSL (OFBIZ-11492)
Fixes previous commit, I used a 1st patch and did not see it was wrong

Thanks: Anushi Gupta for the 2nd patch
2020-06-27 12:17:16 +02:00
Jacques Le Roux f421af33a3 Improved: Convert createFinAccoutnTransFromPayment service from mini-lang to groovy DSL (OFBIZ-11492)
Thanks: Devanshu Vyas  for report, Anushi Gupta for the patch
2020-06-27 12:06:46 +02:00
Suraj Khurana 15bcc92dd1 Improved: Converted updatePayment service from mini-lang to groovy.
(OFBIZ-11480)
Thanks Devanshu Vyas for reporting and Priya Sharma for the patch.
2020-05-23 17:48:54 +05:30
Suraj Khurana 9e194b0e9a Improved: Converted createPaymentAndApplicationForParty service from mini-lang to groovy
(OFBIZ-11491)
Thanks Devanshu Vyas for reporting and Sourabh Punyani for providing the patch.
2020-05-23 15:57:21 +05:30
Suraj Khurana 21a8bfaef7 Improved: Converted massChangePaymentStatus service from mini-lang to groovy.
(OFBIZ-11498)
Thanks Devanshu Vyas for reporting and Rushikesh Mawal for initial patch.
2020-05-23 15:23:13 +05:30
Suraj Khurana c21683e30b Improved: Converted createPaymentContent, updatePaymentContent services from mini-lang to groovy. (#155)
(OFBIZ-11501)(OFBIZ-11502)
Thanks Devanshu Vyas for reporting and Sourabh Punyani for providing the patch.
2020-05-23 12:38:07 +05:30
Suraj Khurana 89016fa71e Improved: Converted getPaymentRunningTotal service from mini-lang to groovy DSL
(OFBIZ-11488)
Thanks Nitish Mishra for the patch and Devanshu Vyas for reporting and review.
2020-05-23 10:27:50 +05:30
Suraj Khurana 44c374a644 Removed: Deprecated entity captureBillingAccountPayments since release 17.12. (#131)
(OFBIZ-11435)
Also, added deprecated since tag in some old entities and fields. This is done as per current policy to deprecate entities/services.
Thanks Pierre for reporting and Jacques for review.
2020-05-15 12:07:35 +05:30
Suraj Khurana 2b0166410d Improved: Converted all GlReconciliationEntry related CRUD services from simple to entity-auto (#129)
* Improved: Converted all GlReconciliationEntry related CRUD services from simple to entity-auto
(OFBIZ-11662)
2020-05-13 17:17:20 +05:30
Suraj Khurana 10a8f7a093 Improved: Converted all AcctgTrans related CRUD services from simple to entity-auto (#103)
* Improved: Converted all AcctgTrans related CRUD services from simple to entity-auto
(OFBIZ-11640)
2020-05-10 16:05:54 +05:30
Suraj Khurana c7e0f909ea Improved: Converted all GlReconciliation related CRUD services from simple to entity-auto (#110)
(OFBIZ-11642)
2020-05-09 12:31:23 +05:30
Suraj Khurana 3c3147d745 Improved: Converted all FixedAssetMeter services from simple to entity-auto. (#82)
* Improved: Converted all FixedAssetMeter services from simple to entity-auto.
* Improved: Added seca rule for creating maints from meter reading, earlier it was called inline while creating or updating FixedAssetMeter record.

(OFBIZ-11611)
2020-05-01 14:15:49 +05:30
Suraj Khurana f527bf4dc0 Improved: Converted cancelFixedAssetStdCost service from simple to entity-auto. (#80)
* Improved: Converted cancelFixedAssetStdCost service from simple to entity-auto.
(OFBIZ-11612)
2020-04-29 18:47:34 +05:30
Jacques Le Roux b8848355d1 Implemented: Convert createPayment service from mini-lang to groovy DSL
(OFBIZ-11479)

jleroux: I have only changed the MODULE name (and uppercased it)

Thanks: Priya Sharma
2020-04-09 11:13:09 +02:00
Pawan Verma 36a94d70df Fixed: Issue in which Agreement Item can't be removed from Agreement
(OFBIZ-11410)

Reason for the issue was incorrect use of service IN parameters for entity-auto delete invoke.

Thanks, Pierre Smits for the report.
2020-02-24 19:04:16 +05:30
Jacques Le Roux 2dadaacac8 Fixed: Services allow arbitrary HTML for parameters with allow-html set to "safe"
(OFBIZ-5254)

This was reopened after discussion at 
https://markmail.org/message/jnaitmwahjcjmdn5

This is a new solution which follows the work done with OFBIZ-6669 and OFBIZ-10187
Roughly said, it uses org.owasp.html.PolicyFactory and org.owasp.html.Sanitizers

Thanks: Christoph Neuroth for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859877 13f79535-47bb-0310-9956-ffa450edef68
2019-05-24 13:47:08 +00:00
Suraj Khurana 2cecce8a22 Improved: OrderId should be set in FinAccountTrans while gift card redemption and creation.
(OFBIZ-10867)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1856602 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 05:53:42 +00:00
Nicolas Malin 02afdb671a Fixed: Update and clean deprecated code after release 18.12 creation
(OFBIZ-10761)
Move deprecated comment for service captureBillingAccountPayment to service definition

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1850178 13f79535-47bb-0310-9956-ffa450edef68
2019-01-02 17:19:24 +00:00
Nicolas Malin acbd42387c Fixed: Update and clean deprecated code after release 18.12 creation
(OFBIZ-10761)
et all deprecated since='Upcoming Release' to since='Release 18.12'

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1850177 13f79535-47bb-0310-9956-ffa450edef68
2019-01-02 16:48:18 +00:00
Deepak Dixit 42d0e01cbc Improved: Convert createBudget service to entity-auto
(OFBIZ-10715)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1849024 13f79535-47bb-0310-9956-ffa450edef68
2018-12-16 12:21:52 +00:00
Jacques Le Roux 3190e0ff2e Improved: Create patch for removal of IDEAL code in framework
(OFBIZ-5444)

Removes all iDEAL specifics from the framework (actually only applications)

Thanks: Pierre Smits

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1846227 13f79535-47bb-0310-9956-ffa450edef68
2018-11-09 10:20:10 +00:00
Suraj Khurana 3e7df1be6d Improved: Consistency and Readability improvements for condition tag.
(OFBIZ-8991)
Thanks Ankush Upadhyay for reporting and Devanshu Vyas for providing the updated patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1845074 13f79535-47bb-0310-9956-ffa450edef68
2018-10-29 06:29:17 +00:00
Nicolas Malin acfe87067e Improved: Convert InvoiceServices.xml mini lang to groovy
(OFBIZ-9986)
Convert services getNextInvoiceId, invoiceSequenceEnforced and invoiceSequenceRestart from minilang to groovy.
This is a subtask of OFBIZ-9350 Deprecate Mini Lang

Thanks to Leila Mekika for this issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1839778 13f79535-47bb-0310-9956-ffa450edef68
2018-08-31 17:29:55 +00:00
Nicolas Malin 1a7e890f0d Fixed: correct field name partyId on the service createPartyPrefDocTypeTpl
(OFBIZ-10186)
Thanks to Aditya Sharma for the corective patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1827892 13f79535-47bb-0310-9956-ffa450edef68
2018-03-28 07:04:03 +00:00
Nicolas Malin 8aa723a98a Implemented: Add PartyPrefDocTypeTpl entity to link official template document to organisational party (OFBIZ-10186)
With this entity we can link a customScreen with an organisational party for a document type like salesinvoice, product quote and so on.
I added screen, form and menu to manage them on the organisation party configuration page accounting/control/ListCompanies
Currently this isn't useful alone but needed for issues OFBIZ-10215, OFBIZ-10216, OFBIZ-10217 that will be completed soon

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1824436 13f79535-47bb-0310-9956-ffa450edef68
2018-02-16 09:04:06 +00:00
Nicolas Malin 904c3d1fd9 Improved: Convert BudgetServices.xml mini lang to groovy (OFBIZ-9985)
Just migrate BudgetServices.xml to groovy file version related to OFBIZ-9350 Deprecate Mini Lang
Thanks to Leila Mekika for resolve this issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816482 13f79535-47bb-0310-9956-ffa450edef68
2017-11-27 18:04:08 +00:00
Deepak Dixit 1a93abaa07 Removed unused SECA rule, as we have new group service createBillingAccountAndRole for this purpose. This seca rule will never get trigger.
Thanks Suraj Khurana for reporting the issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1813391 13f79535-47bb-0310-9956-ffa450edef68
2017-10-26 11:50:19 +00:00
Nicolas Malin 8b96173d79 Fixed: For service getRateAmount move the periodTypeId default value from groovy to service definition,
Thans Scott for this remark

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802666 13f79535-47bb-0310-9956-ffa450edef68
2017-07-22 09:46:47 +00:00
Deepak Dixit a3f7437a09 Improved: Remove cancelAgreement service and added expireAgreement entity-auto service. (OFBIZ-9480)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801355 13f79535-47bb-0310-9956-ffa450edef68
2017-07-09 08:57:20 +00:00
Arun Patidar abbece0f9f Improved: Convert AgreementServices.xml mini-lang to groovyDSL. (OFBIZ-9460)
Thanks Rishi Solanki for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801342 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 23:45:10 +00:00
Nicolas Malin 987feeb2a8 Improved: Convert RateServices.xml mini-lang to groovyDSL (OFBIZ-9381)
finish the service conversion : getRateAmount, getRatesAmountsFromWorkEffortId, getRatesAmountsFromPartyId, getRatesAmountsFromEmplPositionTypeId and filterRateAmountList
I create a generic groovy function getRateAmoutForm to remove duplicate code and refactoring the filterRateAmount for simplicity

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1800245 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 07:46:02 +00:00
Michael Brohl 59ed752fe4 Fixed: Cannot create a new GL Account
(OFBIZ-9429)

This changes the service definition of createGLAccount to use the pk
attributes as OUT instead of INOUT so that the glAccountId will be 
generated by OFBiz instead of being provided to the service.

Thanks Sharan Foga for reporting.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1799793 13f79535-47bb-0310-9956-ffa450edef68
2017-06-25 10:37:48 +00:00
Nicolas Malin a1b7e5a23d Improved: Convert RateServices.xml mini-lang to groovyDSL (OFBIZ-9381)
With service rate minilang conversion to groovy, I renamed deleteRateAmount and deletePartyRate to expireRateAmount and expirePartyRate for more coherence between the service process and the name. The previous service naming have been kept to set them as deprecated

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1799252 13f79535-47bb-0310-9956-ffa450edef68
2017-06-19 18:27:14 +00:00
Gil Portenseigne f2fac1a18f Fixed: Convert AcctgAdminServices.xml mini-lang to groovyDSL (OFBIZ-9372)
Related to task OFBIZ-9350 Deprecate Mini Lang, convert services createPartyAcctgPreference, getPartyAccountingPreferences, setAcctgCompany, updateFXConversion and getFXConversion from mini-lang to groovyDSL
Commited slightly modified patch from Leila, implementing Jacques and Deepak recommendations.

Thanks to Jacques and Deepak for the review, Leila for the provided patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1796731 13f79535-47bb-0310-9956-ffa450edef68
2017-05-30 07:14:27 +00:00
Nicolas Malin 0185345b7a Fixed: Convert RateServices.xml mini-lang to groovyDSL (OFBIZ-9381)
related to task OFBIZ-9350 Deprecate Mini Lang, convert service updateRateAmount, deleteRateAmount updatePartyRate and deletePartyRate from mini-ang to groovyDSL
Thanks to Deepak for the review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1796428 13f79535-47bb-0310-9956-ffa450edef68
2017-05-27 16:23:31 +00:00
Deepak Dixit a40e9e194c Improved: Removed old data migration services. (OFBIZ-9327)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1792788 13f79535-47bb-0310-9956-ffa450edef68
2017-04-26 18:15:26 +00:00
Deepak Dixit 7fb5c14fe3 Improved: Removed deprecated entity related migration service, also removed some more deprecated entities that are located in entitymodel.xml instead entitymodel_old.xm (OFBIZ-9327)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1792182 13f79535-47bb-0310-9956-ffa450edef68
2017-04-21 11:21:32 +00:00
Deepak Dixit d09255c0b7 Reverted: Minilang code readability and consistency improvements done at r#1768222, this commit reversed key and description of drop-down in the code.
(OFBIZ-9114)

Thanks  Wei Zhang for reporting the issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772880 13f79535-47bb-0310-9956-ffa450edef68
2016-12-06 12:37:42 +00:00
Jacopo Cappellato f6bcc33e69 Fixed: Removed duplicated service declarations.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772081 13f79535-47bb-0310-9956-ffa450edef68
2016-11-30 16:31:23 +00:00
Deepak Dixit f0758527a6 Improved: Converted createInvoiceContactMech service from simple to entity auto, and fixed service definition for same, removed unused out parameter contactMechId from service definition, I don't understand purpose of this out parameter, and this service is used only in 3 places and not SECA rule define on it. So I think we can modify service definition.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1769755 13f79535-47bb-0310-9956-ffa450edef68
2016-11-15 08:41:09 +00:00