Commit Graph
14 Commits
Author SHA1 Message Date
Pawan Verma 034e03abf4 Improved: Inconsistent String Comparisons(OFBIZ-9254)
There are some inconsistencies in the code for string comparison statusId.equals(PRUN_COMPLETED) whereas it should be written as PRUN_COMPLETED.equals(statusId) cause the former can throw NullPointerException if the variable found to be NULL.

Thanks: Devanshu for your contribution.
2020-07-30 17:01:54 +05:30
Jacques Le Roux 28e119027c Improved: Use Groovy Truth instead of UtilValidate Class in Groovy
(OFBIZ-11064)

As we all know, Groovy is a powerful language with great built-in functions. 
Groovy Truth[1] is one of them, which is not used properly in our code base. 
We have used UtilValidate Class to validate arguments for Empty or NotEmpty, 
which can easily be done in groovy with built-in functionality[1].
 
Current Code: if (UtilValidate.isNotEmpty(locations)) { ... }
Groovy Built-in Code: if (locations) { ... }
 
[1] - http://groovy-lang.org/semantics.html#Groovy-Truth
 
We need to careful for some points while we change this:
Like:
maxRetry = 0
if (!maxRetry)
{  // Not set, use a default  maxRetry = -1 }

Because groovy evaluates zero to be false, it wouldn't be possible to set
maxRetry to zero.  So it's best not to use groovy truth for null-checks on
numbers in some cases. 
 
Thanks: Pawan Verma

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1860051 13f79535-47bb-0310-9956-ffa450edef68
2019-05-26 10:36:16 +00:00
Deepak Dixit 7e19de9966 Improved: Replace all delegator findByAnd and findOne method calling by EntityQuery methods (OFBIZ-10029)
Applied slightly modified patch, rearrange import properly, 
Thanks Suraj Khurana for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818003 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 12:03:17 +00:00
Deepak Dixit 63258e90f8 Reverted r#1817989, workign fine locally, reverted for now will check and commit again
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817998 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 10:42:32 +00:00
Deepak Dixit d1f85a7e5d Improved: Replace all delegator findByAnd and findOne method calling by EntityQuery methods (OFBIZ-10029)
Applied slightly modified patch, rearrange import properly, 
Thanks Suraj Khurana for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817989 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 09:21:33 +00:00
Arun Patidar 35b93c82a1 Added missing file those of part of 1801320, also updated the path in screens. (OFBIZ-6774)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801359 13f79535-47bb-0310-9956-ffa450edef68
2017-07-09 09:28:35 +00:00
Jacques Le Roux 1ac56553bd Fixed: report GL Account Trial Balance
(OFBIZ-9216)


Go to Accouting --> Organization GL Settings -->Accounting button – >> 
reports --> GL Account Trial Balance
this report the give me an error 

Thanks: Moatasim Al Masri for report, Pierre Smits for patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1783202 13f79535-47bb-0310-9956-ffa450edef68
2017-02-16 13:32:00 +00:00
Arun Patidar 2bfc816e9b Improved: Removed semicolon from all Groovy files of all components.
(OFBIZ-8652)

Thanks: Rohit Koushal, Jacques Le Roux and Rishi Solanki for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767764 13f79535-47bb-0310-9956-ffa450edef68
2016-11-02 19:09:13 +00:00
Mridul Pathak 9b2643d9be Improved: Removed unused imports from groovy files in accounting component.
(OFBIZ-8484)

Thanks: Suraj Khurana for contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765057 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 13:11:46 +00:00
Ashish Vijaywargiya 7402cda35d Applied patch from jira issue - OFBIZ-8069 - Clean up commented out code in Groovy for Accounting. Thanks Aman for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1759145 13f79535-47bb-0310-9956-ffa450edef68
2016-09-04 06:33:32 +00:00
Deepak Dixit 834691742b (OFBIZ-6274) Renamed OFBiz artefacts from org.ofbiz.* to org.apache.ofbiz.*.Thanks to Taher for working on it.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1752920 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 10:30:49 +00:00
Arun Patidar 9596b03661 Applied patch from jira issue - OFBIZ-7515 - Balance Sheet PDF export fails. Thanks Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750940 13f79535-47bb-0310-9956-ffa450edef68
2016-07-01 14:06:51 +00:00
Arun Patidar 5e34274b47 Applied patch from jira issue - OFBIZ-7514 - Income Statement PDF export fails. Thanks Rohit Koushal for your contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750925 13f79535-47bb-0310-9956-ffa450edef68
2016-07-01 13:28:42 +00:00
Deepak Dixit 87601f6aca (OFBIZ-7219) Relocate .groovy files in the accounting component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747746 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 16:54:38 +00:00