Commit Graph
15 Commits
Author SHA1 Message Date
Deepak Dixit a4da06cb56 Fixed: Not able to delete PartyRate
(OFBIZ-10483)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835964 13f79535-47bb-0310-9956-ffa450edef68
2018-07-15 10:47:55 +00:00
Akash Jain b792635558 Fixed: Not able to expire the rate amount and an error is displayed in Workeffort (OFBIZ-10114)
Thanks, Rubia Elza Joshep and Chandrashekhar Dhakad for your contibution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835887 13f79535-47bb-0310-9956-ffa450edef68
2018-07-14 09:02:51 +00:00
Akash Jain b18fdf7f7d Fixed: Issue while removing RateAmount Record, applied patch from jira issue (OFBIZ-9904)
Thanks, Parakh Maheshwari and Suraj Khurana for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1813608 13f79535-47bb-0310-9956-ffa450edef68
2017-10-28 11:11:19 +00:00
Jacques Le Roux a115d37998 Fixes a test issue introduced with r1802668
See https://ci.apache.org/builders/ofbiz-trunk-framework-plugins?numbuilds=30

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1803406 13f79535-47bb-0310-9956-ffa450edef68
2017-07-30 08:36:35 +00:00
Nicolas Malin c8fd7699e4 Fixed: remove uneeded makeValidContext call with Groovy DSL improvement on run service at revision 1802798
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802811 13f79535-47bb-0310-9956-ffa450edef68
2017-07-24 13:07:52 +00:00
Deepak Dixit acbf92baff Improved: Used ModelService.IN_PARAM instead of hard coded "IN" in groovy file.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802753 13f79535-47bb-0310-9956-ffa450edef68
2017-07-24 06:13:11 +00:00
Deepak Dixit cd94155947 Fixed: Fixed typo done at r#1802668, Corrected service name from filteredRatesList to filterRateAmountList
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802752 13f79535-47bb-0310-9956-ffa450edef68
2017-07-24 06:01:41 +00:00
Nicolas Malin 0c9a81f118 Improved: With new groovy DSL for query one, simplify groovy rate amount services
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802712 13f79535-47bb-0310-9956-ffa450edef68
2017-07-22 22:42:56 +00:00
Nicolas Malin d74177348b Fixed: For service getRateAmount align the level variable on 'rateTypeId' by default and correct name workEffort to workEffortId for more coherence with other.
This escape a potential failure on groovy instanciation if the service found a rateList without dedicate service, Thanks Scott for this remark

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802670 13f79535-47bb-0310-9956-ffa450edef68
2017-07-22 10:37:56 +00:00
Nicolas Malin 0e96e6daad Fixed: For service getRateAmount don't use parameters map to propage variable to ensure the isolation,
Thans Scott for this remark

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802668 13f79535-47bb-0310-9956-ffa450edef68
2017-07-22 10:26:15 +00:00
Nicolas Malin 8b96173d79 Fixed: For service getRateAmount move the periodTypeId default value from groovy to service definition,
Thans Scott for this remark

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802666 13f79535-47bb-0310-9956-ffa450edef68
2017-07-22 09:46:47 +00:00
Nicolas Malin 3cce62448a Fixed: Remove unnecessary UtilValidate.is(Not)Empty used in RateAmount groovy service,
Thans Scott for this remark

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802665 13f79535-47bb-0310-9956-ffa450edef68
2017-07-22 09:42:08 +00:00
Nicolas Malin 987feeb2a8 Improved: Convert RateServices.xml mini-lang to groovyDSL (OFBIZ-9381)
finish the service conversion : getRateAmount, getRatesAmountsFromWorkEffortId, getRatesAmountsFromPartyId, getRatesAmountsFromEmplPositionTypeId and filterRateAmountList
I create a generic groovy function getRateAmoutForm to remove duplicate code and refactoring the filterRateAmount for simplicity

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1800245 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 07:46:02 +00:00
Nicolas Malin a1b7e5a23d Improved: Convert RateServices.xml mini-lang to groovyDSL (OFBIZ-9381)
With service rate minilang conversion to groovy, I renamed deleteRateAmount and deletePartyRate to expireRateAmount and expirePartyRate for more coherence between the service process and the name. The previous service naming have been kept to set them as deprecated

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1799252 13f79535-47bb-0310-9956-ffa450edef68
2017-06-19 18:27:14 +00:00
Nicolas Malin 0185345b7a Fixed: Convert RateServices.xml mini-lang to groovyDSL (OFBIZ-9381)
related to task OFBIZ-9350 Deprecate Mini Lang, convert service updateRateAmount, deleteRateAmount updatePartyRate and deletePartyRate from mini-ang to groovyDSL
Thanks to Deepak for the review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1796428 13f79535-47bb-0310-9956-ffa450edef68
2017-05-27 16:23:31 +00:00