Commit Graph
26 Commits
Author SHA1 Message Date
Jacques Le Roux bee1b11831 Fixed: Terms are not shown correctly on the Invoice overview (OFBIZ-12139)
When we have multiple Payment (Net Days) terms on the invoice say
20% in 15Days (FIN_PAY_NETDAYS_1)
80% in 30Days (FIN_PAY_NETDAYS_2)

The terms section shows incorrect term data as shown in the screenshot.

Thanks: Nameet Jain for report and fix, Jacopo for confirmation
2021-01-18 20:19:21 +01:00
Jacques Le Roux 4ff22b46dc Improved: Convert getInvoicePaymentInfoListByDueDateOffset service from mini-lang to groovy DSL (OFBIZ-11486)
Thanks: Devanshu Vyas for report, Nitish Mishra for the patch
2020-08-09 20:14:10 +02:00
Jacques Le Roux cc61673198 Improved: Convert cancelCheckRunPayments service from mini-lang to groovy DSL (OFBIZ-11494)
Thanks: Devanshu Vyas for report, Yogesh Naroliya for the patch
2020-08-09 20:07:51 +02:00
Jacques Le Roux 2b04118690 Revert "Improved: Convert voidPayment service from mini-lang to groovy DSL (OFBIZ-11487)"
This reverts commit faa59b325f.

It introduced 3 errors in testIntegration, in:
testGlPostingOnCancelCheckRun
testGlPostingsOnVoidPayment
testVoidPayment
2020-07-25 16:06:34 +02:00
Jacques Le Roux faa59b325f Improved: Convert voidPayment service from mini-lang to groovy DSL (OFBIZ-11487)
Thanks: Sourabh Punyani
2020-07-25 10:33:17 +02:00
Jacques Le Roux 7c4a117448 Improved: Convert getPaymentGroupReconciliationId service from mini-lang to groovy DSL (OFBIZ-11496)
Thanks: Devanshu Vyas for report and Rohit Koushal for the patch

Improved: Convert createPaymentAndApplication service from mini-lang to groovy DSL (OFBIZ-11484)
Thanks: Devanshu Vyas for report and Anushi Gupta for the patch

Sorry due to a bad handling there are 2 commits in one (squashed)
2020-07-09 14:18:05 +02:00
Priya Sharma 18b21c1e94 [Improved] Convert getInvoicePaymentInfoList service from mini-lang to groovy DSL (#148)
(OFBIZ-11485)

Done following:
- removed the mini-lang implementation of the service
- updated the service definition to point the groovy service
- added the groovy implementation of the service
2020-07-04 14:57:53 +05:30
Pawan Verma 6de4b73074 Improved: Convert getPayments service from mini-lang to groovy DSL(OFBIZ-11495)
Thanks: Devanshu for the report and Yogesh for the patch.
2020-07-01 16:13:33 +05:30
Pawan Verma 20ba868b7d Improved: Convert cancelPaymentBatch service from mini-lang to groovy DSL(OFBIZ-11489)
Thanks: Devanshu for report, Kirti for patch and Jacques for the review.
2020-07-01 15:48:49 +05:30
Jacques Le Roux 5880859c7c Implemented: Convert voidPayment service from mini-lang to groovy DSL (OFBIZ-11487)
Thanks: Devanshu Vyas for report and Sourabh Punyani for implementation
2020-07-01 12:05:22 +02:00
Priya SharmaandPriya Sharma 5a144c0bed Improved: Use GroovyBaseScript's makeValue utility methods in each Groovy files (OFBIZ-11779)
Co-authored-by: Priya Sharma <priya.sharma@hotwaxsystems.com>
2020-06-28 01:24:32 +05:30
Jacques Le Roux f421af33a3 Improved: Convert createFinAccoutnTransFromPayment service from mini-lang to groovy DSL (OFBIZ-11492)
Thanks: Devanshu Vyas  for report, Anushi Gupta for the patch
2020-06-27 12:06:46 +02:00
c8a7c7dd23 Fixed: Create Payment service throws an exception when receiving payment on order (OFBIZ-11754) (#166)
* [Fixed] Create Payment service throws exception when receiving payment on order
- Since the MODULE variable could not be found, the service was throwing error
- Instead used the groovy method directly to print the log instead, which has access to the module variable implicitly.
- Removed the unused import as Debug class is not longer needed here.

(OFBIZ-11754)

* [Improved] The content groovy services to avoid the error in case we try to log a detail, since the module variable is not found. (OFBIZ-11754)

* Update ContentServices.groovy

* [Improved] Added error logs instead of info logs for service excpetions logging. (OFBIZ-11754)

Co-authored-by: Priya Sharma <priya.sharma@example.com>
Co-authored-by: Suraj Khurana <64310724+surajkhurana@users.noreply.github.com>
2020-05-30 11:53:53 +02:00
Suraj Khurana 15bcc92dd1 Improved: Converted updatePayment service from mini-lang to groovy.
(OFBIZ-11480)
Thanks Devanshu Vyas for reporting and Priya Sharma for the patch.
2020-05-23 17:48:54 +05:30
Suraj Khurana 9e194b0e9a Improved: Converted createPaymentAndApplicationForParty service from mini-lang to groovy
(OFBIZ-11491)
Thanks Devanshu Vyas for reporting and Sourabh Punyani for providing the patch.
2020-05-23 15:57:21 +05:30
Suraj Khurana 21a8bfaef7 Improved: Converted massChangePaymentStatus service from mini-lang to groovy.
(OFBIZ-11498)
Thanks Devanshu Vyas for reporting and Rushikesh Mawal for initial patch.
2020-05-23 15:23:13 +05:30
Suraj Khurana c21683e30b Improved: Converted createPaymentContent, updatePaymentContent services from mini-lang to groovy. (#155)
(OFBIZ-11501)(OFBIZ-11502)
Thanks Devanshu Vyas for reporting and Sourabh Punyani for providing the patch.
2020-05-23 12:38:07 +05:30
Suraj Khurana 89016fa71e Improved: Converted getPaymentRunningTotal service from mini-lang to groovy DSL
(OFBIZ-11488)
Thanks Nitish Mishra for the patch and Devanshu Vyas for reporting and review.
2020-05-23 10:27:50 +05:30
Jacques Le Roux aef9382a9c Implemented: Convert createPayment service from mini-lang to groovy DSL
(OFBIZ-11479)

Better code with Groovy truth

Thanks: Pawan Verma
2020-04-09 14:27:16 +02:00
Jacques Le Roux b8848355d1 Implemented: Convert createPayment service from mini-lang to groovy DSL
(OFBIZ-11479)

jleroux: I have only changed the MODULE name (and uppercased it)

Thanks: Priya Sharma
2020-04-09 11:13:09 +02:00
Jacques Le Roux 28e119027c Improved: Use Groovy Truth instead of UtilValidate Class in Groovy
(OFBIZ-11064)

As we all know, Groovy is a powerful language with great built-in functions. 
Groovy Truth[1] is one of them, which is not used properly in our code base. 
We have used UtilValidate Class to validate arguments for Empty or NotEmpty, 
which can easily be done in groovy with built-in functionality[1].
 
Current Code: if (UtilValidate.isNotEmpty(locations)) { ... }
Groovy Built-in Code: if (locations) { ... }
 
[1] - http://groovy-lang.org/semantics.html#Groovy-Truth
 
We need to careful for some points while we change this:
Like:
maxRetry = 0
if (!maxRetry)
{  // Not set, use a default  maxRetry = -1 }

Because groovy evaluates zero to be false, it wouldn't be possible to set
maxRetry to zero.  So it's best not to use groovy truth for null-checks on
numbers in some cases. 
 
Thanks: Pawan Verma

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1860051 13f79535-47bb-0310-9956-ffa450edef68
2019-05-26 10:36:16 +00:00
Deepak Dixit acbf92baff Improved: Used ModelService.IN_PARAM instead of hard coded "IN" in groovy file.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1802753 13f79535-47bb-0310-9956-ffa450edef68
2017-07-24 06:13:11 +00:00
Arun Patidar 2bfc816e9b Improved: Removed semicolon from all Groovy files of all components.
(OFBIZ-8652)

Thanks: Rohit Koushal, Jacques Le Roux and Rishi Solanki for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767764 13f79535-47bb-0310-9956-ffa450edef68
2016-11-02 19:09:13 +00:00
Mridul Pathak 9b2643d9be Improved: Removed unused imports from groovy files in accounting component.
(OFBIZ-8484)

Thanks: Suraj Khurana for contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765057 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 13:11:46 +00:00
Deepak Dixit 834691742b (OFBIZ-6274) Renamed OFBiz artefacts from org.ofbiz.* to org.apache.ofbiz.*.Thanks to Taher for working on it.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1752920 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 10:30:49 +00:00
Deepak Dixit 87601f6aca (OFBIZ-7219) Relocate .groovy files in the accounting component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747746 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 16:54:38 +00:00