Commit Graph
14503 Commits
Author SHA1 Message Date
Sebastian Berg bcb76eb607 Improved: Convert ImageManagementServices.xml minilang to groovy (OFBIZ-11604) 2021-02-26 18:53:22 +01:00
Sebastian Berg 1047003b92 Fixed: Remove CommunicationContent not working as expected (OFBIZ-12172) 2021-02-26 18:49:58 +01:00
Jacques Le Roux 07054fdaf5 Fixed: Error while running MRP (OFBIZ-12187)
I tried running MRP for Sales Forecast option and it returned the following error.

Error running the initMrpEvents service: Service [initMrpEvents] target threw
an unexpected exception (java.sql.Timestamp cannot be cast to java.sql.Date)

Thanks: Nameet Jain
2021-02-23 12:59:46 +01:00
Jacques Le Roux 54ab93ff2a Improved: Field 'govAgencyPartyId' shows all parties, not just Government Agencies (OFBIZ-10863)
The field govAgencyPartyId in the AddFixedAssetRegistration form shows all
parties through the lookup target-form-name="LookupPartyName function.

This should be limited to those parties that qualify with the constraint.

Thanks: Pierre Smits for report Priya Sharma for the fix
2021-02-21 14:22:00 +01:00
Jacques Le Roux d5c336ed3a Fixed: Error on quick ship complete order (OFBIZ-12185)
When we try to quick ship entire order from the Order Manager, the following
error is thrown (in some cases, specifically when we have added a telecom number
for the customer

This was broken by OFBIZ-11462

Thanks: Priya Sharma
2021-02-21 14:14:38 +01:00
SebastianEcomify 8a96462538 Improved: Convert CostService.xml minilang to groovy
(OFBIZ-11595)

Thanks: Sebastian Berg for implementation
2021-02-21 11:38:21 +00:00
Jacques Le Roux 7fb64ba5b5 Fixed: Wrong heading on creating quote under order component (OFBIZ-11221)
Steps to re-generate :

1. Login with the username and password.
2. Go to order component order.
3. Click on Quotes
4. Click on new quotes

Error: Edit quote is shown on the place of New quote.
Actual: New quote should be shown on the place of edit quote on UI.

Thanks: jai kumar raghuwanshi for report, Pradyum Dharwa  for 1st patch,
Ratnesh Upadhyay for better suggestion and Ankit Joshi for the patch
2021-02-20 13:28:06 +01:00
Jacques Le Roux e259170b77 Improved: Improvement on Find BOM screen (OFBIZ-12179)
While exploring the manufacturing code I observed on the find screen BOM type is
set hardcoded. We can improve it by using the entity-option tag to allow all
ProductAssocType with parentTypeId equals "PRODUCT_COMPONENT".

Thanks: Nameet Jain
2021-02-18 11:57:35 +01:00
Wiebke Pätzold 785be8abe4 Fixed: Financial account transaction (OFBIZ-10308)
Fixes the direction of some accounting transactions.

Thanks Ingo Wolfmayr for the patch
2021-02-15 19:47:21 +01:00
Sebastian Berg 18b83b91c2 Fixed: Unable to add product (of ASSET_USAGE type) in order OFBIZ-10791
Thanks Priya for providing the patch
2021-02-15 17:56:35 +01:00
Michael Brohl 69c62f5f00 Merge changes for PR #267 due to conflicting changes in trunk (OFBIZ-12169) 2021-02-15 17:15:18 +01:00
Jacques Le Roux a2dac5482c Improved: Default ordering of webapps titles in main menu (OFBIZ-12166)
[...] having more important apps in 1st places would be better [...]
the feature should be easily changed by custom projects [...]
documentation for that would be enough.

This 1st step sorts the applications and webtools. I believe webtools should not
be secondary but that needs to be discussed with other options.
2021-02-14 21:11:58 +01:00
Jacques Le Roux da134243f7 Fixed: issue put in with r1160964 (9 years, 5 months ago)
Fixes a syntax issue spotted while testing FreeMarker 2.3.31
2021-02-13 18:12:00 +01:00
Jacques Le Roux 432c7bde98 Fixed: Use from-field pattern instead of value=${***} pattern in 'set' element (OFBIZ-9607)
Fixes a syntax issue spotted while testing FreeMarker 2.3.31
2021-02-13 18:12:00 +01:00
Michael Brohl 662a3f9d1c Improved: Remove Compdoc functionality from content manager
(OFBIZ-10476)
2021-02-13 17:33:05 +01:00
Michael Brohl 29bf0a040a Merge branch 'trunk' into OFBIZ-12169_Handle_remaining_checkstyle_errors 2021-02-13 11:26:01 +01:00
Jacques Le Roux 0044d288a6 Improved: Rename some connoted words like blacklist and whitelist (OFBIZ-12168)
Updates DATAMODEL_CHANGES.adoc
2021-02-12 12:41:52 +01:00
Jacques Le Roux 49a1438806 Improved: Rename some connoted words like blacklist and whitelist (OFBIZ-12168)
The fk-name for OrderDenylist entity needs to be different from the one of
OldOrderBlacklist

Thanks to Deepak Dixit for spotting it
2021-02-12 12:34:09 +01:00
Deepak Dixit 3273793842 Fixed: Incorrect mapping for Lookup Purchase Order (#272)
(OFBIZ-12143)

This issue was due to common form is being used for LookupPurchaseOrderHeaderAndShipInfo and LookupOrderHeaderAndShipInfo screen. Passed the paginateTargetUrl from screen to make sure pagination works properly
Thanks Rajesh Kumar for reporting the issue
2021-02-12 16:05:27 +05:30
Suraj Khurana cbec4d7b7c Fixed: ViewQuoteProfit shows fields in wrong order.
(OFBIZ-11680)
Thanks Pierre for reporting and Lalit Dashora for providing the patch.
2021-02-12 10:59:11 +05:30
Benjamin Jugl ce5397dbc6 Fixed: Prevents NPE in Party/My Communications (OFBIZ-12164) 2021-02-11 21:36:04 +01:00
Wiebke Pätzold fab0783722 Improved: Used uppercase 'L' as suggested by checkstyle (OFBIZ-12169) 2021-02-10 12:44:44 +01:00
Wiebke Pätzold 780e00866f Improved: Changed line break so line doesnt't start with ( (OFBIZ-12169) 2021-02-10 11:35:03 +01:00
Wiebke Pätzold 783a987e5a Improved: Multiblock indentations as shown by checkstyle (OFBIZ-12169) 2021-02-10 11:23:53 +01:00
Jacques Le Roux a608fa4b56 Improved: puts dates in migration services to be able to remove them later 2021-02-10 11:02:59 +01:00
Wiebke Pätzold 74f224f88c Improved: Removed trailing spaces (OFBIZ-12169) 2021-02-09 14:16:08 +01:00
Wiebke Pätzold 384572401d Improved: Fixed indentation level (OFBIZ-12169) 2021-02-09 14:12:15 +01:00
Wiebke Pätzold 636c5e393e Improved: max line length is 150 characters (OFBIZ-12169) 2021-02-09 14:10:36 +01:00
Wiebke Pätzold 2e6399c20c Improved: Simplified expression (OFBIZ-12169) 2021-02-09 14:09:55 +01:00
Wiebke Pätzold 03960053a8 Improved: Replaced '.*' import form (OFBIZ-12169) 2021-02-09 11:30:18 +01:00
Wiebke Pätzold 5d52bcf2e1 Improved: Replaced tab character (OFBIZ-12169) 2021-02-09 10:32:26 +01:00
Jacques Le Roux e7b3169d03 Improved: Rename some connoted words like blacklist and whitelist (OFBIZ-12168)
Renames respectively blacklist and whitelist to denylist and allowlist in
several places.

There are still a lot of master word which can be replaced by main, but not in
contexts where slave is also used. I'll discuss that on dev ML again...

Provides the migrateOldOrderBlacklistAndOldOrderBlacklistType service to migrate
records from OrderBlacklist and OrderBlacklistType entities to new OrderDenylist
and OrderDenylistType entities
2021-02-09 09:55:39 +01:00
Wiebke Pätzold b65be41fc7 Improved: if else construct must use parentheses (OFBIZ-12169) 2021-02-09 09:11:48 +01:00
Wiebke Pätzold 95d37d2189 Removes and adds whitespaces as suggested by checkstyle (OFBIZ-12169) 2021-02-09 08:46:20 +01:00
Wiebke Pätzold 2fe5e15a83 Improved: Adds newline at the end of file (OFBIZ-12169) 2021-02-08 16:31:13 +01:00
Michael Brohl 0dc7e562c9 Improved: Remove unused imports (OFBIZ-12169) 2021-02-05 18:14:51 +01:00
Sebastian Berg 11634ae08c Improved: Converted OrderDeliveryServices.xml minilang to groovy
(OFBIZ-11461)
2021-02-04 17:46:55 +01:00
Benjamin Jugl f5788b2a81 Improved: Converts DataServices.xml to Groovy. (OFBIZ-11469) 2021-02-01 17:08:46 +01:00
Sebastian Berg 10f1f5a546 Improved: Update German UiLabel in relation with entity QuantityBreak (OFBIZ-12146)
changed german translations from using "Sprung" to "Staffelung"
2021-01-25 18:08:07 +01:00
Jacques Le Roux 49dbd2afcb Improved: Create 'New Request' button should be removed from create new request screen in Order the component. (OFBIZ-12121)
Thanks: Shubham Choudhary
2021-01-24 18:14:30 +01:00
Daniel Watford edd7960e4b Fixed: Use data url scheme for logo in CompanyHeader
(OFBIZ-7327)

Use a data URL rather than a regular URL for company logos when a
logo has been specified as a Party Content item. This works around the
problem of Apache FOP failing to retrieve content from HTTPS URLs.

Thanks: Deepak Dixit for the review and suggestions
2021-01-24 16:26:34 +00:00
Jacques Le Roux bee1b11831 Fixed: Terms are not shown correctly on the Invoice overview (OFBIZ-12139)
When we have multiple Payment (Net Days) terms on the invoice say
20% in 15Days (FIN_PAY_NETDAYS_1)
80% in 30Days (FIN_PAY_NETDAYS_2)

The terms section shows incorrect term data as shown in the screenshot.

Thanks: Nameet Jain for report and fix, Jacopo for confirmation
2021-01-18 20:19:21 +01:00
Nicolas Malin 7165768251 Implemented: Add a framework method to get main webapp menu with the webapp name
(OFBIZ-10601)

To improve theme management and provide better tools for new themes, we implement a method to obtain the main menu of a webapp.
Instead of just managing a menu, we extend the functionality by offering a method to expose a summary of the webapp, to simplify the navigation.

For this we add a new attribute on webapp definition app-shortcut-screen :

    <webapp name="mywebapp"
            ...
            app-shortcut-screen="component://mycomponent/widget/CommonScreens.xml#ShortcutApp"
            ...
    />

The idea is to define a new purpose screen *Shortcut* that contains what defines a webapp when an action or navigation has been requested. With this screen you can load a menu, a search, a complex description and use all screen powerfulness to resolve what displaying and support by theming

    <screen name="ShortcutApp">
        <section>
            <actions>
                <property-map resource="CommonUiLabels" map-name="uiLabelMap" global="true"/>
            </actions>
            <widgets>
                <decorator-screen name="ShortcutDecorator" location="component://common/widget/CommonScreens.xml">
                    <decorator-section name="body">
                        <include-menu name="MyShortcutAppBar" location="component://mycomponent/widget/CommonMenus.xml"/>
                    </decorator-section>
                </decorator-screen>
            </widgets>
        </section>
    </screen>

Each component are self-sufficient to define what shortcuts to display without framework change or knowledge about other component.
Each theme can implement and customize the display rendering at will.

To illustrate an example of implementation we set sub menu for each webapp defined on applications and exploit it on bluelight theme.

Thanks for Dennis Balkir, Jacques Leroux, Leila Mekika and Julien Nicolas for their involvement
2021-01-15 08:56:23 +01:00
Daniel Watford 3795727ea2 Improved: MacroFormRenderer refactoring of label, display and text
fields

(OFBIZ-11900)

New RenderableFtl elements to represent pre-rendered FTL strings and FTL
macro calls. RenderableFtl elements are able to render themselves to
strings which are processed as an FTL template by the FtlWriter class.

For labels, display fields and text fields, MacroFormRenderer no longer
generates FTL to write to a template itself, but instead calls
RenderableFtlFormElementsBuilder to create corresponding RenderableFtl
elements which are then processed by FtlWriter. This is a WIP to reduce
complexity in MacroFormRenderer.
2021-01-12 10:40:58 +00:00
James Yong ba5536fe57 Improved: Apply CSS Grid to Find Orders (OFBIZ-12116)
Improve naming
2021-01-03 11:13:13 +08:00
James Yong 6f3c7cb4c2 Improved: Apply CSS Grid to Find Orders (OFBIZ-12116)
Apply CSS Grid Layout on the form.
Keep related fields together
2021-01-02 12:46:44 +08:00
Jacques Le Roux 66decd89f7 Improved: Create 'New Communication' button should be removed from create new communication screen. (OFBIZ-12027)
Steps to replicate the issue :
Go to Party application.
On the 'find communications' screen clicks on the 'New communications' button.
The system will navigate you to create/edit communications screen.
On create/edit communications screen you will see the 'New communications' button.

Providing the 'New communications' button on the 'create new communication
screen' does not make any sense over so it should be removed from here.

Thanks: Shubham Choudhary
2020-12-29 11:28:16 +01:00
James Yong 816a2a6ac1 Reverted: apply buttontext class for links inside screenlet title bar (OFBIZ-12112)
Links not showing correctly for themes like Bluelight, Tomahawk.
This reverts commit 9d0e5313
2020-12-27 15:29:03 +08:00
James Yong 9d0e5313bc Improved: apply buttontext class for links inside screenlet title bar (OFBIZ-12112)
For Order application
2020-12-26 20:25:47 +08:00
Jacques Le Roux 0fc14af687 Improved: Remove hardcoded product category on CategoryWorker.getCatalogTopCategory (OFBIZ-12078)
When you call the java function
org.apache.ofbiz.product.category.CategoryWorker.getCatalogTopCategory()
the catalog returned if the system failed found it is hardcoded and don't use an
existing property : catalog->top.category.default

Thanks: Nicolas
2020-12-25 17:02:52 +01:00