Commit Graph
23691 Commits
Author SHA1 Message Date
Mridul Pathak 9b2643d9be Improved: Removed unused imports from groovy files in accounting component.
(OFBIZ-8484)

Thanks: Suraj Khurana for contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765057 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 13:11:46 +00:00
Jacques Le Roux 28113b2523 Fixed: popup calendar fails for ecomseo et ecommerce
(OFBIZ-8345)

go to https://localhost:8443/ecomseo/editShoppingList
create a new shopping list
make changes to "Shopping List Reorder" pane by clicking on date icon.
nothing happens

This was due to a regression introduced with r1721092

Fixed by reverting and removing useless input of type="text

Thanks: Wai for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765055 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 13:05:47 +00:00
Mridul Pathak 3cae9578a3 Improved: Removed unused imports from groovy files in example component.
(OFBIZ-8483)

Thanks: Gopal Yadav for contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765054 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 13:00:53 +00:00
Mridul Pathak 174530f001 Improved: Removed unused imports from groovy files in ebaystore component.
(OFBIZ-8485)

Thanks: Ankit Joshi for contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765052 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 12:51:31 +00:00
Mridul Pathak 83a0ed643c Fixed: Entity ECA rules throws NPE in case of remove operation.
(OFBIZ-8001)

Thanks: Suraj Khurana for contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765048 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 12:36:30 +00:00
Pranay Pandey 769aa89ea8 Improved: HR List forms column alignment.
(OFBIZ-8456)

Thanks: Aditi Patidar for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765047 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 12:35:27 +00:00
Pranay Pandey 85d4a75383 Reverted: Commit r1765030. Integration test failing, will look into it to correct it and checkin again.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765045 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 12:31:48 +00:00
Pranay Pandey aa3e81070e Improved: Facility List forms column alignment.
(OFBIZ-8480)

Thanks: Aditi Patidar for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765043 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 12:14:15 +00:00
Mridul Pathak abfbb66daf Improved: Removed unused imports from groovy files in birt component.
(OFBIZ-8482)

Thanks: Ankit Joshi for contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765042 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 12:11:11 +00:00
Pranay Pandey 109c494d38 Improved: Manufacturing List form column alignment.
(OFBIZ-8467)

Thanks: Aditi Patidar for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765041 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 12:10:22 +00:00
Pranay Pandey c5d8a8b349 Fixed: Pagination error in Accounting TaxAuthorityForms.
(OFBIZ-8475)

Thanks:  Chandan Khandelwal for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765038 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 11:59:25 +00:00
Mridul Pathak 12abe0fccb Improved: Removed unused imports from groovy files in BI component.
(OFBIZ-8474)

Thanks: Gopal Yadav for contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765037 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 11:46:51 +00:00
Mridul Pathak 2c2cb96eff Improved: Removed unused imports from groovy files in party component.
(OFBIZ-8465)

Thanks: Gopal Yadav for contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765036 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 11:40:23 +00:00
Mridul Pathak b9cec0ba53 Improved: Entity auto services doesn't returns success message.
(OFBIZ-7597)

Thanks: Suraj Khurana for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765035 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 11:28:59 +00:00
Mridul Pathak 06dff16010 Improved: Product based promotion calculation.
(OFBIZ-7359)

In case of a promotion where X% discount has to be applied on a product, when more than one quantity of the product is added to order, respective multiple item adjustments are created. Improved the code to create a single adjustment for the total discount.

Thanks: Arvind Singh Tomar for contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765034 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 11:12:11 +00:00
Arun Patidar 6a28dcc541 Improved: Services of 'entity' component moved to 'entityext' and services of 'datamodel' component moved to more relevant place. component.
Thanks: Jacopo and Pierre for reviewing and providing suggestion.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765032 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 10:07:53 +00:00
Pranay Pandey 6607bba731 Fixed: InventoryItemStatus logging for reserved serialized inventory item.
(OFBIZ-8459)

InventoryItemStatus will now be logged as: INV_PROMISED when a serialized inventory item is reserved for an order. 

Thanks:  Vaibhav Jain for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765030 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 09:50:06 +00:00
Pranay Pandey 0d7bf0d87b Improved: Accounting-AR List form column alignment.
(OFBIZ-8449)

Thanks: Aditi Patidar for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765029 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 09:34:48 +00:00
Mridul Pathak f119cd6b7e Improved: WebPos - Remove unused imports from groovy files for code optimization.
(OFBIZ-8442)

Thanks: Gopal Yadav for contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765022 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 08:03:10 +00:00
Pranay Pandey f5865d78b9 Fixed: Pagination error in Accounting PaymentGroupForms.
(OFBIZ-8446)

Thanks: Chandan Khandelwal for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765017 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 06:53:16 +00:00
Pranay Pandey 49da7855c3 Improved: QuoteId field visibility in Create and Update Quote process.
(OFBIZ-7777)

When creating a new quote, the field quoteId is displayed even though its value is "null". Fixed the behavior adding a use-when condition to display the field when the quote already exists and to hide the field when the quote is being created.

Thanks: Montalbano Florian for the contribution and Chandan Khandelwal for reviewing and providing the updated patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765012 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 05:56:30 +00:00
Pranay Pandey 3b6417f6d1 Improved: Accounting list forms column title alignment.
(OFBIZ-8278)

Thanks: Aditi Patidar for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765011 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 05:41:01 +00:00
Jacques Le Roux 379e0100f0 Fixed: "Labels and properties caches clearing no longer work" and
"Shortlist the needed resources to start OFBiz in the sourcesets block in 
Gradle"
(OFBIZ-8321)(OFBIZ-7937)

While working on OFBIZ-7798 I noticed an issue with labels cache clearing. 
It still worked correctly in R15.12 and pre-Gradle version 

To test it, load a page with a label, change the label in file, clear all caches
 in webtools, the new label value should appear, it does not.

The same issue exists for properties.

This fixes both and while at it fixes also OFBIZ-7937 "Shortlist the needed 
resources to start OFBiz in the sourcesets block in  Gradle"

I also removed the DTDs from the resources, they seems useless there.

There area also some trailing blanks removed, my Eclipse is set like that.

Thanks: Taher for OFBIZ-7937 description of the issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1764280 13f79535-47bb-0310-9956-ffa450edef68
2016-10-11 16:03:02 +00:00
Jacques Le Roux 9b235bc113 No functional change, renames files:
DefaultMessagesLabels to DefaultMessagesLabels.xml
Was wrong in r1764261

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1764268 13f79535-47bb-0310-9956-ffa450edef68
2016-10-11 15:23:17 +00:00
Jacques Le Roux 7e5a0db5df No functional change, renames files:
conditional.xml to conditionalLabels.xml
DefaultMessages.xml to DefaultMessagesLabels.xml
EmailPassword.xml to EmailPasswordLabels.xml
Found while working on OFBIZ-8321

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1764261 13f79535-47bb-0310-9956-ffa450edef68
2016-10-11 14:56:49 +00:00
Jacques Le Roux 630befc82f No functional change: removes unused ControlApplet.java, found while working on
OFBIZ-8321

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1764253 13f79535-47bb-0310-9956-ffa450edef68
2016-10-11 14:18:36 +00:00
Jacques Le Roux 02203f4c01 No functional change: removes unused UtilCache.createLineInfo() method, found
while working on OFBIZ-8321

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1764222 13f79535-47bb-0310-9956-ffa450edef68
2016-10-11 10:37:27 +00:00
Jacques Le Roux 0177715de3 Fixed: deleteCustomerTaxAuthInfo page called from /ecommerce/control/viewprofile
(OFBIZ-4106)

Completes previous commits at r1764158/76: removes createCustomerTaxAuthInfo and
 updateCustomerTaxAuthInfo requests which are now useless



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1764178 13f79535-47bb-0310-9956-ffa450edef68
2016-10-10 20:26:56 +00:00
Jacques Le Roux e2415807c0 Fixed: deleteCustomerTaxAuthInfo page called from /ecommerce/control/viewprofile
(OFBIZ-4106)

Completes previous commit at r1764158: moves deleteCustomerTaxAuthInfo request 
from ecommerce to order where it's only used


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1764176 13f79535-47bb-0310-9956-ffa450edef68
2016-10-10 20:16:46 +00:00
Jacques Le Roux 9990ebd79f Fixed: deleteCustomerTaxAuthInfo page called from /ecommerce/control/viewprofile
(OFBIZ-4106)

As explained on dev ML, I prefers to remove the possibility of creating "Tax 
Identifications and Exemptions". Because users would actually need to have the 
ACCOUNTING_CREATE or ACCOUNTING_ADMIN permissions to do so (or higher admin 
permissions) and opening the accounting (or total) admin right to a customer 
seems not secure to me.

Moreover the same exists in party and it needs admin rights in both places, 
so does not make sense in ecommerce IMO. 

Sharan : The only case I can think of is that a customer may want to manage 
their own tax info. For example if I know my VAT number or Tax number 
- do I add it to my profile, or do I have to wait for it be verified and 
completed by the accounting administrator?
Generally I think companies would want an accounting administrator to take 
control of this type of tax and exemption information (rather than leave it up 
to the customer themselves) as they will need to be responsible for it 
and report on it to their tax authorities so they need to make sure it is correct.

Thanks: Michał Cukierman for report and Sharan for functional confirmation

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1764158 13f79535-47bb-0310-9956-ffa450edef68
2016-10-10 17:57:38 +00:00
Jacques Le Roux efee2bc4b5 No functional change: removes annoying superfluous spaces in labels.
Can't be found when searching from HTML source, HTML removes it. 
There are no others but in ALv2 headers. 
I have asked why on dev@community.apache.org out of curiosity.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1764064 13f79535-47bb-0310-9956-ffa450edef68
2016-10-10 11:43:46 +00:00
Jacques Le Roux 59025dde56 No functional change: removed an annoying superfluous space, when searching:
can't be found when searching from HTML source, HTML removes it

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1764058 13f79535-47bb-0310-9956-ffa450edef68
2016-10-10 11:09:29 +00:00
Jacques Le Roux 2bbfd1f933 No functional change. This has never been implemented, better to remove it as
mentioned on dev ML few days ago

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1764057 13f79535-47bb-0310-9956-ffa450edef68
2016-10-10 11:07:34 +00:00
Jacques Le Roux 0e90db4da3 No functional change: makes a comment easier to read
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1763878 13f79535-47bb-0310-9956-ffa450edef68
2016-10-08 09:11:26 +00:00
Jacques Le Roux 4866953c20 Fixed: cannot edit shopping list for ecommerce and ecomseo
(OFBIZ-8348)

This was previously fixed with r1763686 by Pawan Verma which was correct.
But Scott reported on dev ML that he was surprised by this bare solution. 
We could have kept it because it's js and works, but since we use jQuery and 
for consistencey reason Amardeep suggested to rather 
$('#selectShoppingList').submit()

This reverts r1763686 and applies Amardeep's solution.

It also removes pending work related with OFBIZ-4106. I have asked a question 
about it yesterday and forgot to remove the related change in this unrelated 
commit.

Thanks: Scott for report, Amardeep for patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1763754 13f79535-47bb-0310-9956-ffa450edef68
2016-10-07 12:17:50 +00:00
Jacques Le Roux d4a0d90bd1 Fixed: The entity description labels are considered not used by the Label Manager
(OFBIZ-8154)

More used or useful labels

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1763701 13f79535-47bb-0310-9956-ffa450edef68
2016-10-07 08:57:47 +00:00
Jacques Le Roux 18e4c59f7a Fixed: The entity description labels are considered not used by the Label Manager
(OFBIZ-8154)

The languages Ids and buildEbayConfig.* are used. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1763695 13f79535-47bb-0310-9956-ffa450edef68
2016-10-07 08:40:01 +00:00
Jacques Le Roux 7b28a7f664 Fixed: cannot edit shopping list for ecommerce and ecomseo
(OFBIZ-8348)

go to https://localhost:8443/ecomseo
login as DemoCustomer
go to https://localhost:8443/ecomseo/editShoppingList
create 2 shopping lists
ofbiz shows the 2 shopping list. but you cannot select the first shopping list 
for editing

Thanks: Wai for report, Pawan Verma for patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1763686 13f79535-47bb-0310-9956-ffa450edef68
2016-10-07 07:29:58 +00:00
Jacques Le Roux ff9aed0854 No functional change: only a consensual tsvn:logtemplatecommit
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1763560 13f79535-47bb-0310-9956-ffa450edef68
2016-10-06 11:39:07 +00:00
Jacopo Cappellato 2fe42574f4 Implemented: removed the specialpurpose/oagis component; a reference to it is in
the Attic page.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1763454 13f79535-47bb-0310-9956-ffa450edef68
2016-10-05 14:10:54 +00:00
Jacopo Cappellato 32f4e6bc9c Improved: made the entity delegator test less noisy by disabling the error log
level during the execution of these tests.

Thanks: Jacques Le Roux for requesting the improvement.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1763453 13f79535-47bb-0310-9956-ffa450edef68
2016-10-05 14:00:46 +00:00
Arun Patidar 9a8236688d Implemented: Added CRUD services for ReturnItemType, ReturnItemTypeMap, ReturnReason, ReturnType, RoleType, RoleTypeAttr and SaleType entities.
(OFBIZ-8329) (OFBIZ-8330) (OFBIZ-8331) (OFBIZ-8332) (OFBIZ-8333) (OFBIZ-8334) (OFBIZ-8335)

Thanks: Amit Gadaley for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1763315 13f79535-47bb-0310-9956-ffa450edef68
2016-10-04 17:58:45 +00:00
Arun Patidar 815afa131e Implemented: Added CRUD services for QuoteTypeAttr, RejectionReason, ReorderGuideline, RequirementAttribute, RequirementBudgetAllocation, RequirementType, RequirementTypeAttr, RespondingParty, ReturnAdjustmentType and ReturnHeaderType entities.
(OFBIZ-8306) (OFBIZ-8308) (OFBIZ-8309) (OFBIZ-8310) (OFBIZ-8311) (OFBIZ-8314) (OFBIZ-8325) (OFBIZ-8326) (OFBIZ-8327) (OFBIZ-8328)

Thanks: Amit Gadaley for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1763306 13f79535-47bb-0310-9956-ffa450edef68
2016-10-04 17:24:12 +00:00
Jacques Le Roux 688c3b21c1 Improves: No functional change, just a comment to remember to change the version
number in FreeMarkerWorker class when upgrading in build.gradle


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1763304 13f79535-47bb-0310-9956-ffa450edef68
2016-10-04 17:01:23 +00:00
Arun Patidar 82921a982f Implemented: Added CRUD services for InvoiceTypeAttr, MrpEventType, OrderAdjustmentAttribute, OrderAdjustmentType, OrderAttribute, OrderBlacklist, OrderBlacklistType, QuantityBreakType, QuoteTermAttribute and QuoteType entities.
(OFBIZ-8271) (OFBIZ-8277) (OFBIZ-8281) (OFBIZ-8283) (OFBIZ-8285) (OFBIZ-8286) (OFBIZ-8287) (OFBIZ-8303) (OFBIZ-8304) (OFBIZ-8305)

Thanks: Amit Gadaley for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1763298 13f79535-47bb-0310-9956-ffa450edef68
2016-10-04 16:42:10 +00:00
Divesh Dutta c9479c8beb Fixed: Payment section was breaking up when in Party profile page when Party does not have Check account.
(OFBIZ-6899) 

Thanks: Japreet for the fix.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1763281 13f79535-47bb-0310-9956-ffa450edef68
2016-10-04 14:21:17 +00:00
Jacopo Cappellato b49bc16f1e Fixed: Null Pointer Exception in the ecommerce webapp when accessed with
multitenant mode on, caused by the recent refactoring to ContextFilter.
(OFBIZ-8338)

Thanks: Ingo Wolfmayr for the bug report.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1763251 13f79535-47bb-0310-9956-ffa450edef68
2016-10-04 09:04:42 +00:00
Jacques Le Roux aa577e6e39 Improves: Add WebSocket support in OFBiz
(OFBIZ-7073)

With last Amardeep Singh Jhajj's patch we introduced a slow down when starting.

The simple trick is to check if we want to use websocket or not. 
By default (webSocket=false in catalina.properties) we don't and I gain 17 sec 
on my machine (13 instead of 30). Not a big deal but the log is also cleaner. 
And I guess not everybody needs websockets.

This should be documented in the wiki page to come with OFBIZ-7538. Then the 
comment for webSocket in catalina.properties should be changed accordingly

If we want to always have webSocket available, then we should start from 
Tomcat StandardJarScanFilter class and adapt it to our needs.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1763241 13f79535-47bb-0310-9956-ffa450edef68
2016-10-04 08:09:00 +00:00
Jacques Le Roux 9fe4260342 Improves: After r1761181 some useful comments were removed. This readds them
Also some comments were not removed but should have been, this removes them
No functional changes



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1763154 13f79535-47bb-0310-9956-ffa450edef68
2016-10-03 11:12:48 +00:00
Jacques Le Roux 93c65e871a Fixes: Net Before Overhead Report is not working
(OFBIZ-7317)

Here is the patch that removes the NBO(Net Before Overhead) report from the 
trunk. In the patch I have also removed the Demo data which is required by this 
report only.

Note : Please remove below data from existing database to avoid any data 
related problem in OrderPortletData.xml

<PortalPortlet portalPortletId="NBO_Report"
   portletName="Net Before Overhead Report"
   screenName="NetBeforeOverheadReport"
   screenLocation="component://birt/widget/order/OrderScreens.xml"
   description=""/>
<PortletPortletCategory portalPortletId="NBO_Report" portletCategoryId="REPORT"/>
<PortalPagePortlet portalPageId="OrderReportPage" portalPortletId="NBO_Report" 
portletSeqId="00001" columnSeqId="00002" sequenceNum="11"/>


Thanks: Rohit Koushal

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1763132 13f79535-47bb-0310-9956-ffa450edef68
2016-10-03 08:59:10 +00:00